Main Koha release repository https://koha-community.org
Find a file
Joonas Kylmälä a69b5e6ee9
Bug 28012: Creating numbering pattern: mark mandatory fields required
If any of these fields were missing, notably the Numbering formula
then saving the new numbering pattern silently failed, it didn't give
any error but it didn't save any new pattern either.

Note that there is a plan to make description field optional, so even
if it currently is mandatory on the DB level we leave it optional
here (and due to people using production DB's in non-strict mode which
allows this to be optional).

To test:
  1) After applying this patch make sure all the 3 fields must be
  filled in
  /cgi-bin/koha/serials/subscription-numberpatterns.pl?op=new
  page and it cannot be saved without those.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2023-12-27 19:06:07 +01:00
acqui Bug 34708: Add ability to modify orderline to increase quantity 2023-11-09 10:15:05 -03:00
admin Bug 35460: Fix add and edit of hold rules in circulation rules table 2023-12-11 19:41:26 +01:00
api Bug 35574: Correct api permission for listing biblio specific bookings 2023-12-18 15:21:05 +01:00
authorities
basket
bin
bookings Bug 35574: Bookings tab from biblio details should only require manage_bookings permission 2023-12-18 15:21:04 +01:00
C4 Bug 35491: Add logging to RevertWaitingStatus 2023-12-19 13:42:13 +01:00
catalogue Bug 26468: Add damaged as a searchable status in item search 2023-11-08 17:52:46 -03:00
cataloguing Bug 35414: Silence warn related to number_of_copies 2023-12-11 19:41:24 +01:00
circ Bug 35216: Rename error to issuingimpossible 2023-12-19 13:42:09 +01:00
clubs
course_reserves
debian Bug 35174: update control files for koha-l10n dependency package 2023-11-16 11:31:55 +01:00
docs 23.11.00: Update history.txt 2023-11-30 14:58:48 -03:00
erm
errors
etc Bug 35455: Remove = in ICU for indexing/searching 2023-12-20 15:13:46 +01:00
ill
installer Bug 31297: DBRev 23.12.00.002 2023-12-27 19:06:05 +01:00
Koha Bug 31297: DBIC schema 2023-12-27 19:06:06 +01:00
koha-tmpl Bug 28012: Creating numbering pattern: mark mandatory fields required 2023-12-27 19:06:07 +01:00
labels
lib/CGI/Session/Serialize
members Bug 30287: Conditionally render notice preview 2023-12-19 13:42:10 +01:00
misc Bug 34091: Fix typo log-modules in help for cleanupdatabase.pl 2023-12-11 19:41:27 +01:00
offline_circ
opac Bug 35496: (QA follow-up): tidy up code 2023-12-14 16:29:22 +01:00
patron_lists Bug 34977: (QA follow-up) Tidy code 2023-11-08 11:41:33 -03:00
patroncards
plugins
pos
preservation
recalls
reports
reserve Bug 34519: Add a template plugin for fetch searchable patron attributes 2023-11-08 17:52:37 -03:00
reviews
rotating_collections
serials Bug 28012: Use definedness test instead of bool when checking whether to null fields 2023-12-27 19:06:06 +01:00
services
skel
suggestion Bug 35276: Remove authentication params from suggestion hash 2023-11-14 10:32:38 -03:00
svc
t Bug 35491: Add logging to RevertWaitingStatus 2023-12-19 13:42:13 +01:00
tags
tools Bug 35291: (QA follow-up) Tidying script for QA test tools 2023-11-24 16:43:25 -03:00
virtualshelves Bug 35547: Show public "staff only" lists in addbybiblionumber.pl 2023-12-27 19:06:03 +01:00
xt
.editorconfig
.eslintrc.json
.gitignore Bug 35174: Add misc/translator/po to .gitignore 2023-11-16 08:56:36 +01:00
.htaccess
.mailmap 23.11.00: Update mailmap 2023-11-30 14:58:47 -03:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.proverc.dist
.stylelintrc.json
about.pl Bug 35174: Add a warning to the about page 2023-11-16 08:56:36 +01:00
app.psgi
build-resources.PL
changelanguage.pl
cpanfile
cypress.config.ts
fix-perl-path.PL
gulpfile.js Bug 35428: Remove temporary files for gulp po tasks 2023-12-12 15:04:54 +01:00
help.pl
INSTALL
Koha.pm Bug 31297: DBRev 23.12.00.002 2023-12-27 19:06:05 +01:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 29002: Update Makefile 2023-11-03 12:04:27 -03:00
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo