Owen Leonard
f2be2cedc5
This patch restores the inclusion of the jsdiff JS library on the guided reports page when displaying saved SQL reports. This fixes a JS error in the browser console when the user tries to use our automatic update on SQL reports which use an older syntax. The patch also corrects a problem with svc/convert_report which was causing an error when trying to display the diff information. To test, apply the patch and restart services. - Go to Reports -> Create from SQL. - Add a report which is based on an older db structure. The example I found was: SELECT biblionumber, ExtractValue(marcxml,'//datafield/@tag/text()[substring(.,1,1) = "5"]') as 'notes' FROM biblioitems HAVING notes <> '' - Save the report and go to the list of saved reports. There should be an "Update" column in the table, with a message about your newly-added report: "This report seems obsolete, it uses biblioitems.marcxml field." - Clicking the "Update SQL" button should trigger a modal window that shows the before an after versions of the report. There should be no error in the browser console. Unfortunately the diff will not display because of a separate bug in svc/convert_report Signed.off-by: Jessie Zairo <jzairo@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
||
---|---|---|
.. | ||
csv | ||
acquisitions_stats.tt | ||
bor_issues_top.tt | ||
borrowers_out.tt | ||
borrowers_stats.tt | ||
cash_register_stats.tt | ||
cat_issues_top.tt | ||
catalogue_out.tt | ||
catalogue_stats.tt | ||
convert_report.tt | ||
dictionary.tt | ||
guided_reports_start.tt | ||
issues_avg_stats.tt | ||
issues_stats.tt | ||
itemslost.tt | ||
itemtypes.tt | ||
orders_by_budget.tt | ||
reports-home.tt | ||
reserves_stats.tt | ||
serials_stats.tt |