Julian Maurice 2cbc47a871 Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved ... If IndependentBranches is ON, patrons are not allowed to place hold requests on items whose owning library is different from the patron's home library, *unless* the canreservefromotherbranches system preference is also ON. The patch implements the intended behavior; without it, IndependentBranches and canreservefromotherbranches were not consulted during the item holdability check. To test: [1] Have IndependentBranches ON and canreservefromotherbranches OFF. Make sure that the circulation rules are set up to permit patrons to place hold requests in general. [2] In the OPAC, log in as a patron from library A, and try placing a hold on an item from library B. The patron will be able to place the request. [3] Cancel the request. [4] Apply the patch. [5] Try placing the same hold request. This time, the request should be forbidden. [6] Turn on canreservefromotherbranches. [7] Try placing the hold request. This time, it should go through. [8] Cancel the request. [9] Turn off IndependentBranches. [10] Try placing the hold request and verify that it is permitted. [10] Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>		2013-08-09 17:55:32 +00:00
..
AuthoritiesMarc	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
Barcodes	Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm	2012-09-20 12:01:36 +02:00
ClassSortRoutine	Bug 9770: fix sorting of Dewey call numbers that contain prefixes	2013-07-15 16:12:47 +00:00
Creators
External
Form	Talking Tech Support - Phase I - Followup - Fix Messaging Preferences	2012-06-10 17:46:58 +02:00
Heading	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
ILSDI	Bug 9394: Use reserve_id where possible	2013-07-24 05:04:55 +00:00
Installer	bug 6281: add Library::CallNumber::LC as a required Perl dependency	2013-06-10 07:56:53 -07:00
Labels	bug 9370: improve splitting of LC call numbers for labels	2013-06-12 07:44:10 -07:00
Linker	Bug 8447: Make sure we have enough subfields for broader_headings	2012-09-14 14:56:48 +02:00
Members	Bug 7919: Fix unit test (Members_AttributeTypes.t)	2012-12-07 18:26:37 -05:00
OAI
Output	Fix FSF address in directory C4/	2010-03-16 20:17:56 -04:00
Patroncards
Reports
Search
SIP
Utils
VirtualShelves
Accounts.pm
Acquisition.pm	Bug 10504: Remove the unused C4::Acq::ModOrderItem routine	2013-07-15 16:06:19 +00:00
Auth.pm
Auth_cas_servers.yaml.orig	Bug 5630 CAS improvements	2011-10-13 10:49:49 +13:00
Auth_with_cas.pm	Bug 10029 - CAS authentication fails in OPAC reserve	2013-07-02 07:13:05 -07:00
Auth_with_ldap.pm
AuthoritiesMarc.pm
BackgroundJob.pm
Barcodes.pm	Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm	2012-09-20 12:01:36 +02:00
Biblio.pm
Bookseller.pm	Bug 10557: remove unused branch parameter from GetBooksellersWithLateOrders	2013-07-22 19:01:09 +00:00
Boolean.pm	Bug 10080 - Change system pref IndependantBranches to IndependentBranches	2013-05-22 07:58:23 -07:00
Branch.pm
Breeding.pm	Bug 10462: (follow-up) remove some undefined variable warning noise	2013-07-24 16:55:52 +00:00
Budgets.pm
Calendar.pm	Bug 7351 : feature that allows to delete a range of dates	2012-09-28 12:19:45 +02:00
Category.pm	Bug 7919: FIX the "all" categories method	2013-01-02 16:50:52 -05:00
Charset.pm
Circulation.pm	Bug 9362: fix query that finds upcoming due loans	2013-07-17 15:45:47 +00:00
ClassSortRoutine.pm
ClassSource.pm
Context.pm	Revert "Bug 6554 - make Koha internally utf-8 clean"	2013-04-29 15:12:32 -07:00
Contract.pm	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
CourseReserves.pm
Creators.pm	Bug 8315 - remove use C4::* version	2012-07-13 14:17:20 +02:00
Csv.pm	Bug 7986: Export issues for patron	2012-09-13 17:58:30 +02:00
Dates.pm	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
Debug.pm	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
Heading.pm	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
HoldsQueue.pm	Bug 10311 - Holds queue ignores item-level holds where only one items exists	2013-06-10 09:08:16 -07:00
HTML5Media.pm	Bug 8377: Followup move style in a css file and do not pass template to a pm	2012-12-27 09:28:00 -05:00
Images.pm
ImportBatch.pm	Bug 10230: Don't limit valid matches to bibs	2013-05-19 08:40:13 -04:00
ImportExportFramework.pm	Bug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm	2012-09-20 12:00:55 +02:00
Input.pm	Bug 7919 : Display of values depending on the connexion library	2012-12-05 10:10:57 -05:00
Installer.pm	Bug 9752: Set marcflavour to NORMARC when NORMARC is chosen	2013-03-30 22:51:17 -04:00
ItemCirculationAlertPreference.pm	Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/ItemCirculationAlertPreference.pm	2012-09-20 12:01:39 +02:00
Items.pm	Bug 10080 - Change system pref IndependantBranches to IndependentBranches	2013-05-22 07:58:23 -07:00
ItemType.pm	Revert "Bug 6554 - make Koha internally utf-8 clean"	2013-04-29 15:12:32 -07:00
Koha.pm
Labels.pm	Bug 8315 - remove use C4::* version	2012-07-13 14:17:20 +02:00
Languages.pm	Bug 8954: Make languages list in advanced search translatable (revision 1)	2012-11-20 14:39:56 -05:00
Letters.pm	Bug 10621: use correct from-address for subscription alert emails	2013-07-25 13:54:41 +00:00
Linker.pm	Bug 7284: Fix unit test broken by erroneous POD	2012-03-08 15:24:18 +01:00
Log.pm	Bug 7067 - OPAC Borrower Self Registration	2012-12-14 08:08:59 -05:00
Maintainance.pm
Matcher.pm	Bug 10230: no need to use SimpleSearch for matching auths	2013-05-19 08:40:13 -04:00
Members.pm
Message.pm	Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm	2012-09-20 12:01:39 +02:00
NewsChannels.pm	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
Output.pm	Complete revert of 6554	2013-05-03 07:58:50 -07:00
Overdues.pm
Patroncards.pm	Bug 8315 - remove use C4::* version	2012-07-13 14:17:20 +02:00
Print.pm	Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm	2012-09-20 12:17:43 +02:00
Ratings.pm	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
Record.pm
Reports.pm
Reserves.pm
Review.pm
Ris.pm	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
RotatingCollections.pm	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
Scheduler.pm
Scrubber.pm
Search.pm	Bug 9961: Add truncation support to QP driver	2013-05-08 09:44:23 -04:00
Serials.pm
Service.pm
ShelfBrowser.pm
SMS.pm
SocialData.pm
SQLHelper.pm	Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm	2012-09-20 12:01:38 +02:00
Stats.pm
Suggestions.pm
Tags.pm
Templates.pm
TmplToken.pm	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
TmplTokenType.pm	Revert "Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm"	2012-09-20 13:29:59 +02:00
TTParser.pm
UploadedFile.pm	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
Utils.pm	Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Utils.pm	2012-09-20 12:01:39 +02:00
VirtualShelves.pm	Bug 10386: improvements to VirtualShelves.t	2013-06-28 05:19:49 -07:00
XISBN.pm	Bug 9728: XISBN unit test update	2013-06-18 09:46:37 -07:00
XSLT.pm	bug 10292: improve fallback logic for picking XSLT	2013-05-29 07:39:41 -07:00