Main Koha release repository https://koha-community.org
Find a file
Fridolin Somers affd0caea5 Bug 26669: Last Run if report not always updated
The last run of a report is updated only if method execute_query() is
called with report_id.
This whas missing for :
- when report is run publicly
- when report is sent by email
- when report is exported

Patch changes the method signature to use a hash of params, in order to
easily avoid some params.

Test plan :

1) Create a report.
2) Run report.
3) Check the report listing.  Confirm that the last run info on the report is updated.
4) Make report public.
5) Run report via public url.
6) Check the report listing.  Confirm that the last run info on the report IS NOT updated.
7) Schedule the report to run at a given time and e-mailed to an address.
8) After the report runs at the scheduled time, check the report listing.  Confirm that the last run info on the report IS NOT updated.
9) Run report.
10) Export results.
11) Check the report listing.  Confirm that the last run info on the report IS NOT updated AT THE TIME OF THE EXPORT.

Questionable (I don't know if this is addressed):
12) Run report on backend through a cron job and send results via e-mail.
13) Check the report listing.  Confirm that the last run info on the report IS NOT updated.

14) Apply patch.
15) Rerun steps 2-13.  Confirm that steps 3, 6, 8, 11, and 13 DO UPDATE the last run info.

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2022-04-04 16:23:46 +02:00
acqui Bug 30055: Use /acquisitions/baskets/managers for basket's manager 2022-04-04 09:46:58 +02:00
admin Bug 13952: (follow-up) JS translatability, clean warns, other 2022-04-04 16:23:46 +02:00
api Bug 30408: Make API and OpenAPI versions strings in spec 2022-04-04 16:23:46 +02:00
authorities
basket
bin
C4 Bug 26669: Last Run if report not always updated 2022-04-04 16:23:46 +02:00
catalogue Bug 17748: Show due date and availability in item search results 2022-03-24 14:22:10 -10:00
cataloguing Bug 29788: (follow-up) Make Koha::Item->safe_to_delete use Koha::Result::Boolean 2022-03-23 10:50:51 -10:00
circ Bug 30063: Remove occurrences of C4::Utils::DataTables::Members 2022-04-04 09:47:01 +02:00
clubs Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
course_reserves
debian Bug 26685: Move starman out of debian/control.in and into cpanfile 2022-03-22 10:17:34 -10:00
docs
errors
etc
ill Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
installer Bug 30063: Sort by "Name" firstname,surname 2022-04-04 09:47:02 +02:00
Koha Bug 30394: Add x-koha-request-id handling in controllers 2022-04-04 16:23:46 +02:00
koha-tmpl Bug 30394: Make datatables.js aware of x-koha-request-id 2022-04-04 16:23:46 +02:00
labels Bug 25616: (QA follow-up) Catch a case in labels/label-item-search.pl 2022-02-24 14:35:36 -10:00
lib/CGI/Session/Serialize
members Bug 30063: Restore back behaviour 2022-04-04 09:47:02 +02:00
misc Bug 26669: Last Run if report not always updated 2022-04-04 16:23:46 +02:00
offline_circ
opac Bug 26669: Last Run if report not always updated 2022-04-04 16:23:46 +02:00
patron_lists
patroncards Bug 30055: Use /patrons for patron's cards 2022-04-04 09:46:57 +02:00
plugins Bug 29931: Check cookie status before continuing 2022-03-15 22:30:50 -10:00
pos Bug 28481: (RM follow-up) formatting 2021-12-16 12:13:51 -10:00
recalls Bug 19532: (RM follow-up) Fix recalls.old is default 0 2022-03-15 00:31:32 -10:00
reports Bug 26669: Last Run if report not always updated 2022-04-04 16:23:46 +02:00
reserve Bug 30093: Make patron search from request.pl use the REST API 2022-04-04 09:47:00 +02:00
reviews
rotating_collections
serials Bug 30377: Fix two CGI::param called in list context-warnings 2022-04-04 16:23:46 +02:00
services
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 30055: Use /api/v1/suggestions/managers to list managers or suggestions 2022-04-04 09:46:57 +02:00
svc Bug 26669: Last Run if report not always updated 2022-04-04 16:23:46 +02:00
t Bug 26669: Last Run if report not always updated 2022-04-04 16:23:46 +02:00
tags
tmp/modified_authorities
tools Bug 6815: Capture member photo via webcam 2022-03-24 14:22:10 -10:00
virtualshelves
xt Bug 30194: (follow-up) Fix xt/api.t 2022-03-29 17:14:50 +02:00
.editorconfig
.eslintrc.json
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap 21.11.00 - Update .mailmap 2021-11-26 12:26:22 +01:00
.perlcriticrc
.proverc.dist
.scss-lint.yml
about.pl
app.psgi
changelanguage.pl
cpanfile Bug 28610: Elasticsearch 7 - hits.total is now an object 2022-04-04 16:23:46 +02:00
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 24221: DBRev 21.12.00.020 2022-03-25 11:01:04 -10:00
koha_perl_deps.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl
Makefile.PL Bug 19532: Database and installer stuff 2022-03-14 22:45:50 -10:00
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo