Koha/C4
Jonathan Druart b140b8cc08 Bug 12409: Fix fields order on exporting to bibtex
The C4::Record::marc2bibtex subroutine supposes hashref keys are sorted
which is wrong with perl 5.18

Note that the t/db_dependent/Record.t fails without this patch.

Test plan (for perl >= 5.18 only):
1/ prove t/db_dependent/Record.t should return green
2/ Try to export a record to bibtex and verify the order is correct
(should be author, title, year, published, etc.).

http://bugs.koha-community.org/show_bug.cgi?id=12409

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Wrong Bug number on heading.
Work as described, test pass, no koha-qa errors.

The problem is to think that a hash returns
keys in a particular order, that's not true
and no matter which perl version.

Code as was left is... misleading.
Comments talks about a hash, which is no more.
On array asignment "a => b" is equivalent to "a, b",
but the former is usually used on hashes, so a
replacement of '=>' by ',' could clarify what are we storing.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixing the comments in a follow-up patch.
Tests pass now without problems and records export ok.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2014-07-07 10:13:02 -03:00
..
AuthoritiesMarc
Barcodes Bug 11539: removing 2 unused files 2014-01-14 20:55:28 +00:00
ClassSortRoutine
Creators Bug 8375: (follow-up) adjust StrWidth to account for TTF fonts 2014-05-06 18:52:12 +00:00
External Bug 12041 - improve Koha::Cache 2014-06-19 13:05:04 -03:00
Form Bug 12100: ensure that messaging preferences displays saved Days in Advance 2014-04-28 21:35:18 +00:00
Heading
ILSDI Bug 8918: Fix reserve priority in ILS-DI 2014-03-10 17:31:05 +00:00
Installer Bug 12393 - Depend on SSL module for LWP, for OverDrive 2014-06-22 20:35:46 -03:00
Labels Bug 8375: (follow-up) fix font code and alignment 2014-05-05 21:55:16 +00:00
Linker
Members Bug 12100: (follow-up) fix regression 2014-04-28 21:36:25 +00:00
OAI
Output
Patroncards
Reports Bug 12214: (follow-up) correct POD of C4::Reports::Guided::execute_query() 2014-05-09 14:40:06 +00:00
Search Bug 10807: (follow-up) use 24-hour time when storing search times to session 2014-05-05 02:55:41 +00:00
Serials Bug 7688: (follow-up) update license statements 2013-10-30 02:56:32 +00:00
SIP Bug 12462: Fix some POD errors 2014-06-22 19:56:37 -03:00
Utils Bug 9811: Cardnumber could be alphanumeric 2014-07-01 09:59:20 -03:00
VirtualShelves Bug 8262: (follow-up) correct comment 2014-04-20 22:57:55 +00:00
Accounts.pm Bug 6273: (follow-up) fix various issues 2014-04-30 17:11:58 +00:00
Acquisition.pm Bug 11169: Display acquisition details in the OPAC 2014-06-15 11:12:24 -03:00
Auth.pm Bug 11715: Update POD for get_template_and_user 2014-06-25 12:27:24 -03:00
Auth_cas_servers.yaml.orig
Auth_with_cas.pm Bug 11048: Fix logout redirection for CAS authentication 2014-05-05 05:20:26 +00:00
Auth_with_ldap.pm BUG 12304: LDAP auto-provisioning set default messaging preferences 2014-07-02 15:17:35 -03:00
AuthoritiesMarc.pm Bug 10330 - Rename system preference authoritysep to AuthoritySeperator 2014-05-23 13:26:48 +00:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm Bug 12343: QA follow-up 2014-06-15 11:27:20 -03:00
Bookseller.pm Bug 7965: Silence warns in staff log 2014-01-10 15:42:09 +00:00
Boolean.pm
Branch.pm Bug 11051: remove unneccessary SQL queries in GetBranches 2014-01-10 16:02:39 +00:00
Breeding.pm Bug 12112: remove disused routine C4::Breeding::ImportBreeding() 2014-04-25 15:07:52 +00:00
Budgets.pm Bug 12482: removing the use of the module C4::SQLHelper.pm, it is replaced by DBIx::Class 2014-07-03 14:24:58 -03:00
Calendar.pm
Category.pm
Charset.pm Bug 12462: Fix some POD errors 2014-06-22 19:56:37 -03:00
Circulation.pm Bug 11629: (follow-up) Add message for librarian that status was updated 2014-05-26 03:23:37 +00:00
ClassSortRoutine.pm
ClassSource.pm
Context.pm Bug 9612: (follow-up) restore elementSetName in Context.pm 2014-05-19 16:46:57 +00:00
Contract.pm
CourseReserves.pm
Creators.pm
Csv.pm
Dates.pm
Debug.pm
Heading.pm
HoldsQueue.pm Bug 11258: fix another case where holds queue made transfer requests that contradict the library holds policy 2014-04-18 15:23:23 +00:00
HTML5Media.pm
Images.pm
ImportBatch.pm Bug 11254: make reservoir search normalize ISBNs 2014-04-19 21:44:30 +00:00
ImportExportFramework.pm Bug 11666: remove SQL as an option for MARC framework exports and imports 2014-02-05 19:48:27 +00:00
Input.pm Bug 766: remove disused routine buildCGISort 2014-05-04 23:03:24 +00:00
InstallAuth.pm Bug 12023 - move InstallAuth.pm to be in C4 2014-05-23 13:19:42 +00:00
Installer.pm Bug 10523: Remove two obsolete routines from Installer.pm 2013-10-31 16:51:47 +00:00
ItemCirculationAlertPreference.pm
Items.pm Bug 12428 - "OPAC info" is not displayed in the OPAC 2014-06-23 15:44:05 -03:00
ItemType.pm
Koha.pm Bug 12288: (follow-up) test for defined values 2014-05-19 20:03:30 +00:00
Labels.pm
Languages.pm Bug 7841: quell warnings in C4::Languages 2014-05-19 16:41:50 +00:00
Letters.pm Bug 11742: FIX the code parameter was not take into account 2014-06-23 15:19:56 -03:00
Linker.pm
Log.pm
MarcModificationTemplates.pm Bug 11479: Remove experimental given/when keywords 2014-02-20 15:55:21 +00:00
Matcher.pm Bug 10500: (follow-up) disable AggressiveMatchOnISBN if UseQueryParser is on 2014-05-05 19:31:00 +00:00
Members.pm Bug 9811: Patron search improvement 2014-07-01 09:57:09 -03:00
Message.pm
NewsChannels.pm Bug 7567: (follow-up) construct values clause in SQL statement more idiomatically 2014-04-07 18:14:21 +00:00
Output.pm Bug 10016: force zero browser-side caching of SCO pages 2013-10-21 18:05:12 +00:00
Overdues.pm Bug 11696: ensure that print overdue notices use the print template 2014-05-02 20:29:21 +00:00
Patroncards.pm
Print.pm
Ratings.pm
Record.pm Bug 12409: Fix fields order on exporting to bibtex 2014-07-07 10:13:02 -03:00
Reports.pm
Reserves.pm Bug 12086 - Hold priorities incorrect, when waiting status was reversed 2014-06-23 15:07:11 -03:00
Review.pm
Ris.pm Bug 11066: make RIS and Bibtex exports RDA compatible 2014-01-03 15:54:38 +00:00
RotatingCollections.pm Bug 11384: rename the collections_tracking.ctId column 2013-12-23 16:14:57 +00:00
Scheduler.pm
Scrubber.pm
Search.pm Bug 12419: Not for loan items are not listed 2014-06-30 15:57:23 -03:00
Serials.pm Bug 12338: Remove smartmatch operator from C4/Serials.pm 2014-06-16 15:07:01 -03:00
Service.pm
ShelfBrowser.pm
SMS.pm
SocialData.pm
SQLHelper.pm Bug 11221: ensure that SQLHelper uses NULL rather than 0000-00-00 as default date value 2013-11-19 15:29:08 +00:00
Stats.pm
Suggestions.pm Bug 10277 - Add C4::Context->IsSuperLibrarian() 2013-12-30 15:47:23 +00:00
Tags.pm
Templates.pm Bug 12237: Remove the "horrible hack" in C4::Templates 2014-07-03 10:34:11 -03:00
TmplToken.pm Bug 12131: Remove unused dependency on Exporter 2014-04-25 15:24:39 +00:00
TmplTokenType.pm
TTParser.pm Bug 12207: fix TTparser's handling of TT directives that contain "]" 2014-05-23 15:23:20 +00:00
UploadedFile.pm
VirtualShelves.pm Bug 8262: explicitly warn that database admin account cannot create lists 2014-04-20 22:55:22 +00:00
XISBN.pm Bug 11096: support the retrieval of large MARCXML records 2014-02-28 19:50:09 +00:00
XSLT.pm Bug 12237: Remove the "horrible hack" in C4::Templates 2014-07-03 10:34:11 -03:00