Main Koha release repository https://koha-community.org
Find a file
Nick Clemens b32756a5d7 Bug 22052: Refactor DeleteExpiredOpacReigstrations
This patch changes the sub to use Koha::Objects and updates the tests.
Previously the sub would die on borrowers with checkouts and would
delete borrowers if they had fines

To test:
 1 - prove -v t/db_dependent/
 2 - Set your selfreg preferences:
    PatronSelfRegistration: Allow
    PatronSelfRegistrationDefaultCategory: SELFREG (or of your choice)
    PatronSelfRegistrationExpireTemporaryAccountsDelay: 30
 3 - Register a patron into SELFREG or how you set above
 4 - Set their date enrolled to two months ago
 5 - Checkout an item to the patron
 6 - Issue a fine to that patron
 7 - perl misc/cronjobs/cleanup_database.pl --del-exp-selfreg -v
 8 - The job should die with an error
 9 - Check in the item
10 - run the corn again - patron is deleted, oops
11 - Apply patch
12 - Create another patron in the same way
13 - Checkout and fine the patron
14 - run the cron
15 - they are not deleted, and no error
16 - checkin the item
17 - run the cron
18 - they are not deleted and no error
19 - clear the fine
20 - run the cron
21 - patron is deleted, huzzah

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-01-08 14:02:43 +00:00
acqui Bug 21853: (follow-up) to solve printpdf error 2018-11-21 11:08:23 +00:00
admin Bug 21605: (follow-up) Simple ternary boolean to number conversion 2019-01-08 13:58:10 +00:00
api/v1 Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
authorities Bug 21986: Do not escape quotation marks when cataloguing 2018-12-14 13:33:28 +00:00
basket Bug 21874: Fix encoding of cart and list email subjects 2018-11-26 12:38:56 +00:00
C4 Bug 22052: Refactor DeleteExpiredOpacReigstrations 2019-01-08 14:02:43 +00:00
catalogue Bug 22034: Handle default framework for MARC view with framework 2019-01-02 20:52:53 +00:00
cataloguing Bug 21986: Do not escape quotation marks when cataloguing 2018-12-14 13:33:28 +00:00
circ Bug 21928: (bug 18789 follow-up) Fix CircAutoPrintQuickSlip=clear 2019-01-02 20:36:49 +00:00
clubs
course_reserves Bug 21501: Remove dead code from course reserves module 2018-11-02 10:37:45 +00:00
debian Bug 21897: Typo in postinst 2018-11-29 17:58:27 +00:00
docs Bug 7143: Update about page for Nazlı 2018-11-29 18:45:01 +00:00
errors
etc Bug 20078: (follow-up) Prevent conflict from attribute duplication 2018-11-06 12:22:53 +00:00
ill Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
installer Bug 22030: DBRev 18.12.00.005 2019-01-08 14:01:45 +00:00
Koha Bug 22059: Fix exception params in Koha::Patron->set_password 2019-01-08 13:48:14 +00:00
koha-tmpl Bug 22030: Use preference to determine username sent to overdrive 2019-01-08 13:59:46 +00:00
labels Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
members Bug 21986: Do not escape quotation marks when cataloguing 2018-12-14 13:33:28 +00:00
misc Bug 21908: (QA follow-up) Remove useless parentheses in query 2018-12-11 19:19:47 +00:00
offline_circ Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl 2018-09-14 17:27:29 +00:00
opac Bug 22030: Use preference to determine username sent to overdrive 2019-01-08 13:59:46 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patron_lists
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins
reports Bug 21984: Pass param_name in pagination URL 2018-12-19 16:32:00 +00:00
reserve Bug 21608: Disable dropdown for found holds - add button to revert 2018-12-11 19:13:30 +00:00
reviews
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 21467: Display a summary line per parent_ordernumber 2018-11-13 19:31:11 +00:00
services
skel
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-08 20:58:23 +00:00
svc Bug 15836: Remove debug statement 2018-11-13 15:18:24 +00:00
t Bug 22052: Unit tests 2019-01-08 14:02:42 +00:00
tags
test
tmp/modified_authorities
tools Bug 21695: Clean up access files template 2018-12-26 20:47:04 +00:00
virtualshelves Bug 21874: (QA follow-up) Fix intranet sendshelf 2018-11-26 12:38:56 +00:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
.mailmap
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL
gulpfile.js Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
INSTALL
install-CPAN.pl
Koha.pm Bug 22030: DBRev 18.12.00.005 2019-01-08 14:01:45 +00:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 17698: Do not send pending_checkout_notes from all circ scripts 2018-07-23 15:23:44 +00:00
Makefile.PL Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
MANIFEST.SKIP
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
README
README.md
README.robots
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo