Main Koha release repository https://koha-community.org
Find a file
Nick Clemens bbeab36789
Bug 34678: Allow new entries to overwrite hold_fill_targets
When using background jobs, there is a possibility of a race condition where two jobs will be updating the holds queue for the same biblio. We should try to minimize those cases (see bug 34596)

In the meantime though, we should prevent jobs possibly dying, and allow the most recent update to succeed.

There is a possibility two updates wil assign different items to the same reserve, and that a reserve could end up in the queue twice, however, whichever one is filled first will delete both entries. as filling the hold deletes by reserve id (see bug 24359)

This patch adds a transaction to delete and then inset the new row

To test:
1 - prove -v t/db_dependent/Reserves.t
2 - It fails
3 - Apply patch
4 - t/db_dependent/Reserves.t
5 - It succeeds!

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
2023-10-27 16:44:24 -03:00
acqui Bug 34908: Sort item types alphabetically by description when adding a new empty record as an order to a basket 2023-10-25 12:09:54 -03:00
admin Bug 27153: Adjust mappings to add title without punctuation 2023-10-24 15:44:34 -03:00
api Bug 29523: (follow-up) Adding documentation to swagger.yaml 2023-10-27 16:40:47 -03:00
authorities Bug 33406: (QA follow-up) Adjust tests and tidy 2023-09-15 15:50:43 -03:00
basket Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
bin
C4 Bug 34678: Allow new entries to overwrite hold_fill_targets 2023-10-27 16:44:24 -03:00
catalogue Bug 35099: (bug 26314 follow-up) Fix detail view for records with invalid MARCXML 2023-10-20 11:02:52 -03:00
cataloguing Bug 34171: Use barcodedecode when attaching items to another record 2023-10-20 11:43:03 -03:00
circ Bug 34547: Add transfer reason to checkedintable on returns.tt 2023-10-20 11:43:02 -03:00
clubs Bug 25079: Show club enrollment question answers in staff client 2023-06-23 11:00:54 -03:00
course_reserves Bug 20256: Use new methods 2023-02-02 11:59:26 -03:00
debian Bug 33547: Add print slip 2023-10-23 11:33:51 -03:00
docs Bug 34800: Adding openhub links for Koha contributors 2023-10-17 14:45:28 -03:00
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors
etc Bug 30708: Add apache RewriteRule 2023-10-18 15:41:42 -03:00
ill Bug 30719: ILL Batches 2023-10-17 14:45:15 -03:00
installer Bug 33887: DBRev 23.06.00.054 2023-10-25 12:09:54 -03:00
Koha Bug 35167: Make 'effective_not_for_loan_status' fallback to 0 if itype has it undef 2023-10-27 16:44:05 -03:00
koha-tmpl Bug 35119: Add back classes used for selenium tests 2023-10-27 16:42:50 -03:00
labels Bug 10762: (QA follow-up) Perltidy 2023-10-25 10:35:31 -03:00
lib/CGI/Session/Serialize
members Bug 35127: Fix 'Search type' for patron search 2023-10-25 10:35:26 -03:00
misc Bug 35148: before_send_messages plugin hook does not pass the --where option 2023-10-25 11:08:03 -03:00
offline_circ Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm 2023-09-22 10:52:39 -03:00
opac Bug 31503: Make opac-patron-consent more generic 2023-10-25 10:35:20 -03:00
patron_lists
patroncards
plugins Bug 30367: (follow-up) Same adjustment for gitlab 2023-05-05 10:18:57 -03:00
pos Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
preservation Bug 34030: Add a "print slips" action links to print in batch 2023-10-23 11:33:55 -03:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-06-23 10:01:04 -03:00
reports Bug 23059: reserve_stats.pl: Simplify reservestatus 2023-10-20 14:44:06 -03:00
reserve Bug 31692: Tidy and rebase fix 2023-10-10 09:58:59 -03:00
reviews
rotating_collections
serials Bug 31846: Add syspref for serials search results limit 2023-10-25 10:35:27 -03:00
services
skel
suggestion Bug 26994: List names in alphabetical order in Suggestion filter 2023-10-20 16:31:14 -03:00
svc Bug 25393: (QA follow-up) Tidy 2023-10-20 16:31:24 -03:00
t Bug 34678: Unit test 2023-10-27 16:44:24 -03:00
tags
tools Bug 31383: (QA follow-up) Tidy 2023-10-20 14:44:03 -03:00
virtualshelves Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
xt Bug 34911: Test files from HEAD instead of 'master' 2023-10-04 09:15:35 -04:00
.editorconfig
.eslintrc.json
.gitignore Bug 33710: Ignore how-to related files 2023-05-12 17:50:01 -03:00
.htaccess
.mailmap Update .mailmap 2023-06-12 11:52:05 -03:00
.perlcriticrc
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.proverc.dist
.stylelintrc.json
about.pl Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set 2023-09-19 16:34:19 -03:00
app.psgi
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl
cpanfile Bug 34064: Add SQL::Translator dependency to cpanfile 2023-10-10 10:54:04 -03:00
cypress.config.ts Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
fix-perl-path.PL
gulpfile.js Bug 35024: Do not wrap translations 2023-10-19 16:00:47 -03:00
help.pl
INSTALL
Koha.pm Bug 33887: DBRev 23.06.00.054 2023-10-25 12:09:54 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 35019: Add a CSRF token when deleting news 2023-10-20 17:22:02 -03:00
Makefile.PL Bug 30708: Add 'preservation' to Makefile.PL 2023-10-20 08:33:34 -03:00
MANIFEST.SKIP
package.json Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 30708: Vue app 2023-10-18 15:41:40 -03:00
yarn.lock Bug 34319: Update yarn.lock 2023-09-05 11:52:25 -03:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo