Main Koha release repository https://koha-community.org
Find a file
Agustin Moyano bcf9b259c5 Bug 19889: Make it possible to exclude items and categories from local holds priority
This patch adds the ability to exclude patrons (by category) from local
holds, and items, by editing the item itself or by batch item
modification tool.

To test:
1. apply patches
2. updatedatabase
3. Enable LocalHoldsPriority preference, and leave
   LocalHoldsPriorityPatronControl in pickup library, and
LocalHoldsPriorityItemControl in holding library.
4. Search for a biblio with one item.
5. Place a hold with a patron (patron1) and set pickup location to a different
   library of the item's home library
6. Place another hold with another patron (patron2) and set pickup location to be
   the same as the item's home library
7. ./misc/cronjobs/holds/build_holds_queue.pl
8. Go to circulation -> holds queue
9. Search by the item's home library
CHECK => only the hold for patron2 (with the pickup location the same as the
item's home library) appears in the table
10. Go back to the biblio details page and click on "Items" tab
CHECK => There is a new section in the item's details between "Statuses"
and "History" called "Priority"
11. Set exclude to "Yes" and update
12. repeat steps 7 to 9
SUCCESS => only the hold for patron1 now appears, even the other hold had local
hold priority
13. Repeat step 10 and 11 but this time set exclude to "No"
14. repeat steps 7 to 9
CHECK => the hold for patron2 is back
15. Edit patron2's category and set exclude from local holds priority to
    "Yes"
16. Repeat steps 7 to 9
SUCCESS => the hold for patron1 is back
17. Go to tools -> Batch item modification and in barcode list place
    several (existing) barcodes and press continue
CHECK => There is a new section in the bottom called "Priority"
18. Set exclude to "Yes" and save
SUCCESS => all items in the list now have exclude setted to "Yes"
19. Try to checkout the first item to a patron3
SUCCESS => Alert message appears saying that patron1 has a hold on that
item
20. Click on Yes and then checkin that item
SUCCESS => There is a modal window saying that a hold was found for
patron1
21. prove t/db_dependent/HoldsQueue.t t/db_dependent/Holds/LocalHoldsPriority.t
22. Sign off

Sponsored-by: Cooperative Information Network (CIN)

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-08-31 16:17:58 +02:00
acqui Bug 25033: Display both local and all pending suggestions counts if the numbers differ 2020-08-25 11:31:40 +02:00
admin Bug 19889: Make it possible to exclude items and categories from local holds priority 2020-08-31 16:17:58 +02:00
api Bug 26015: Terminology: Fix tons more staff clients to staff interfaces 2020-08-31 16:10:25 +02:00
authorities Bug 25728: Create AV when cataloguing an authority record 2020-08-24 11:19:03 +02:00
basket Bug 17842: Simplify the code 2020-06-12 10:32:35 +02:00
C4 Bug 19889: Make it possible to exclude items and categories from local holds priority 2020-08-31 16:17:58 +02:00
catalogue Bug 19889: Make it possible to exclude items and categories from local holds priority 2020-08-31 16:17:58 +02:00
cataloguing Bug 25728: Create AV when adding a new item 2020-08-24 11:19:03 +02:00
circ Bug 25534: Add reason to pendingreserves.pl 2020-08-25 15:07:27 +02:00
clubs Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
course_reserves Bug 25606: Remove all reserve items button 2020-08-07 16:54:40 +02:00
debian Bug 26015: Terminology: Fix tons more staff clients to staff interfaces 2020-08-31 16:10:25 +02:00
docs Bug 26179: Add Timothy Alexis Vass to contributors 2020-08-13 08:09:10 +02:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 26253: (bug 22857 follow-up) Remove duplicated mana_config in etc/koha-conf.xml 2020-08-24 10:12:39 +02:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 19889: Add exclude_from_local_holds_priority columns to item, deleteditems and categories tables 2020-08-31 16:10:26 +02:00
Koha Bug 19889: set exclude_from_local_holds_priority columns as boolean in schema 2020-08-31 16:17:40 +02:00
koha-tmpl Bug 19889: Make it possible to exclude items and categories from local holds priority 2020-08-31 16:17:58 +02:00
labels Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
members Bug 26076: (QA Follow up) Prevent error by using a fresh resultset 2020-08-24 10:12:49 +02:00
misc Bug 26015: Terminology: Fix tons more staff clients to staff interfaces 2020-08-31 16:10:25 +02:00
offline_circ Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
opac Bug 20057: System preference for auto approval of patron profile changes 2020-08-31 14:41:08 +02:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
plugins Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
pos Bug 26023: Properly secure the cashup and refund actions 2020-08-24 10:12:42 +02:00
reports Bug 25605: Replace NULL values with '' when downloading a report as a tab separated text 2020-08-19 09:29:40 +02:00
reserve Bug 22789: (follow-up) Fix atomic update, GUI and more than one hold 2020-08-31 16:10:25 +02:00
reviews
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 25081: Fix wrong comment 2020-04-08 11:53:37 +01:00
services
skel
suggestion Bug 25033: (follow-up) Don't limit suggestions to branches if displaying by branch 2020-08-25 11:31:42 +02:00
svc Bug 25728: Use a svc script instead of the REST API endpoint 2020-08-24 11:19:03 +02:00
t Bug 19889: Add tests 2020-08-31 16:17:58 +02:00
tags Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
tmp/modified_authorities
tools Bug 19889: Make it possible to exclude items and categories from local holds priority 2020-08-31 16:17:58 +02:00
virtualshelves Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
xt Bug 26265: add a plan for tests 2020-08-25 15:14:30 +02:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
.mailmap
.perlcriticrc Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 25826: Add a warning to the about page 2020-08-07 09:55:50 +02:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
cpanfile Bug 25723: Drop DateTime::Set from cpanfile 2020-07-20 17:45:31 +02:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js Bug 26228: Update gulpfile to work with Node.js v12 2020-08-18 14:47:44 +02:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
INSTALL
Koha.pm Bug 22789: DBRev 20.06.00.031 2020-08-31 16:10:25 +02:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl
LICENSE
mainpage.pl Bug 25033: Display both local and all pending suggestions counts if the numbers differ 2020-08-25 11:31:40 +02:00
Makefile.PL Bug 26265: Add missing xt dir 2020-08-24 12:30:53 +02:00
MANIFEST.SKIP
package.json Bug 26228: Update gulpfile to work with Node.js v12 2020-08-18 14:47:44 +02:00
README
README.md
README.robots
rewrite-config.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-07-21 14:34:25 +02:00
yarn.lock Bug 26228: Update gulpfile to work with Node.js v12 2020-08-18 14:47:44 +02:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo