Koha/cataloguing/value_builder
Bernardo Gonzalez Kriegel 2d9f5fc69e Bug 9457: [ENH] Ordering branches should be case independent (2)
This patch replace use of CGI::scroll_list() to show list of branches.

In two files, marc21_linking_section.pl and unimarc_field_4XX.pl,
the scrolling list is created but not used in the template file,
so the code is removed.

Also minor renaming/normalizing of variables.

To test:
1) Install with some branches, records and patrons

2.1) Select a record, click 'Place hold', select user,
     there is a library pull-down next to 'Pickup at:',
     list is ordered case sensitive
2.2) Go to Reports > Average loan time,
     next to Library is a pull-down,
     list without order
2.3) Go to Reports > Catalog by item type,
     next to 'Select a library' is a pull-down,
     list is ordered case sensitive
2.4) This is tricky, go to Reports home,
     change last part of URL 'reports-home.pl' with
     'manager.pl?report_name=issues_by_borrower_category'
     (can't find a direct link), next to 'Select a library'
     is a library pull-down,
     list without order
2.5) Edit/Add a patron, on section 'Library management'
     there is a library pull-down, case sensitive
2.6) OPAC, as logged user, make a suggestion or hold,
     there is library pull-down, correct order

3) Apply the patch

4.1) Repeat 2.1), correctly ordered list
4.2) Repeat 2.2), correctly ordered list
4.3) Repeat 2.3), correctly ordered list
4.4) Repeat 2.4), correctly ordered list
4.5) This is a bit more work
     There are 3 possible situations to test:
     A) No branches, must show a message that are no
        libraries defined
     B) New patron, must show a correctly ordered
        list of branches, current branch selected
     C) Edit patron, must show a correctly ordered
        list of branches, patron branch selected
4.6) Small changes on variable names, so retest 2.6)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2013-03-20 15:35:58 -04:00
..
barcode.pl Bug 8524: Followup FIX an undeclared variable $query 2012-08-31 17:42:46 +02:00
barcode_manual.pl Bug 8524 follow-up: fix Javascript syntax error 2012-08-31 17:42:48 +02:00
callnumber-KU.pl bug_7458: Correct existing existing call numbers retrieval 2012-03-12 18:20:22 +01:00
callnumber.pl Bug #6139 Automatic incrementation of call number does not work if prefix contains ' 2011-08-14 20:27:17 +12:00
dateaccessioned.pl Bug 6125: repairs dateaccessioned plugin 2012-03-22 16:18:38 +01:00
labs_theses.pl Fix for Bug 2947, value_builder scripts using authnotrequired 2010-10-06 08:20:23 -04:00
macles.pl Bug 6679 : Tidying changed parts of file 2011-11-06 18:19:19 +01:00
marc21_field_003.pl Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
marc21_field_005.pl Bug 5374 (update transaction date when saving biblio) RESENT with small fix 2011-01-05 08:42:47 +13:00
marc21_field_006.pl Bug 6167 - can't use 008 or 006 plugin in cataloging 2011-04-12 09:12:09 +12:00
marc21_field_007.pl Bug 5385: POD Cleanups (part 2) 2010-11-12 10:06:56 +13:00
marc21_field_008.pl Bug 7601 - Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") 2012-06-10 10:53:14 +02:00
marc21_field_008_authorities.pl 8627 Followup for removing tabs 2012-09-18 12:29:37 +02:00
marc21_field_040c.pl
marc21_field_040d.pl Bug 5385: POD Cleanups (part 2) 2010-11-12 10:06:56 +13:00
marc21_field_245h.pl Bug 5385: POD Cleanups (part 2) 2010-11-12 10:06:56 +13:00
marc21_leader.pl Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
marc21_leader_authorities.pl Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
marc21_leader_book.pl Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
marc21_leader_computerfile.pl Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
marc21_leader_video.pl Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
marc21_linking_section.pl Bug 9457: [ENH] Ordering branches should be case independent (2) 2013-03-20 15:35:58 -04:00
normarc_field_007.pl Bug 3644 Add support for NORMARC 2011-03-30 10:13:37 +02:00
normarc_field_008.pl Bug 7601 - Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") 2012-06-10 10:53:14 +02:00
normarc_leader.pl Bug 3644 Add support for NORMARC 2011-03-30 10:13:37 +02:00
stocknumber.pl Bug 6679: fix missing use strict 2011-12-09 09:49:22 +01:00
stocknumberam123.pl Bug 5385: POD Cleanups (part 2) 2010-11-12 10:06:56 +13:00
stocknumberAV.pl Bug 7992: New plugin stocknumberAV 2012-10-02 17:19:55 +02:00
unimarc_field_4XX.pl Bug 9457: [ENH] Ordering branches should be case independent (2) 2013-03-20 15:35:58 -04:00
unimarc_field_010.pl BZ5719: unimarc plugin fixes 2011-08-01 12:23:55 +12:00
unimarc_field_100.pl Bug 8347 - Koha forces UNIMARC 100 field code language to 'fre' 2013-02-20 09:06:09 -05:00
unimarc_field_105.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_106.pl Bug 5385: POD Cleanups (part 2) 2010-11-12 10:06:56 +13:00
unimarc_field_110.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_115a.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_115b.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_116.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_117.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_120.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_121a.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_121b.pl Bug 5385: POD Cleanups (part 2) 2010-11-12 10:06:56 +13:00
unimarc_field_122.pl Bug 5385: POD Cleanups (part 2) 2010-11-12 10:06:56 +13:00
unimarc_field_123a.pl Bug 5385: POD Cleanups (part 2) 2010-11-12 10:06:56 +13:00
unimarc_field_123d.pl Bug 5385: POD Cleanups (part 2) 2010-11-12 10:06:56 +13:00
unimarc_field_123e.pl Bug 5385: POD Cleanups (part 2) 2010-11-12 10:06:56 +13:00
unimarc_field_123f.pl Bug 5385: POD Cleanups (part 2) 2010-11-12 10:06:56 +13:00
unimarc_field_123g.pl Bug 5385: POD Cleanups (part 2) 2010-11-12 10:06:56 +13:00
unimarc_field_123i.pl
unimarc_field_123j.pl
unimarc_field_124.pl
unimarc_field_124a.pl
unimarc_field_124b.pl
unimarc_field_124c.pl
unimarc_field_124d.pl
unimarc_field_124e.pl
unimarc_field_124f.pl
unimarc_field_124g.pl
unimarc_field_125.pl
unimarc_field_125a.pl
unimarc_field_125b.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_126.pl
unimarc_field_126a.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_126b.pl
unimarc_field_127.pl
unimarc_field_128a.pl
unimarc_field_128b.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_128c.pl
unimarc_field_130.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_135a.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_140.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00
unimarc_field_141.pl
unimarc_field_210c.pl Bug 6679: fix missing use strict 2011-12-09 09:49:22 +01:00
unimarc_field_210c_bis.pl Bug 5692 : Adds an alternative cataloguing plugin for 210$c 2011-04-13 15:48:42 +12:00
unimarc_field_225a.pl BZ5719: unimarc plugin fixes 2011-08-01 12:23:55 +12:00
unimarc_field_686a.pl
unimarc_field_700-4.pl
unimarc_leader.pl Bug 6465 - Errors in UNIMARC plugins for fixed length fields (for | and space) (T::T issue) 2011-09-26 14:32:32 +13:00