Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/admin
History
Jonathan Druart a844a2211f Bug 28567: Fix 0 vs "" vs undef on the admin library form 
There are two things here:
* Branches.pickup_location has a default = 1 in DB, we should not set to undef if 0
or it will be set to 1 when stored.
* The other fields are all text (varchar, mediumtext or longtext) and
can be NULL. They are correct set to NULL when a new library is created
but set to an empty string when the library is modified. That's not
consistent

Test plan:
0. Don't apply the patch
1. Create a new library, set pickup location to "No"
2. Save
=> Pickup location is set to YES
=> In DB notice that the different values you didn't fill in are set to
NULL
3. Edit the library
4. Save
=> In DB notice that the different values you didn't fill in are now set
to an empty string
5. Apply the patch, restart_all
6. Run the updatedatabase script
=> In DB all the empty string values are set to NULL
7. Repeat 1 to 4 and confirm that everything is now working as expected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-08-06 08:14:52 -04:00
..
searchengine/elasticsearch Bug 26051: Add sort=1 on cn-sort in mappings.yaml 2021-02-23 13:12:56 +01:00
add_user_search.pl Bug 23271: Replace search_limited with search_with_library_limits 2021-04-21 15:25:07 +02:00
additional-fields.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
admin-home.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
adveditorshortcuts.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
aqbudgetperiods.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
aqbudgets.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
aqcontract.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
aqplan.pl Bug 27486: (QA follow-up) Fix occurence in aqplan.pl 2021-01-29 09:03:45 +01:00
audio_alerts.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
auth_subfields_structure.pl Bug 8976: Use existing Koha::Authority::Subfield[s] 2021-03-03 11:57:51 +01:00
auth_tag_structure.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
authorised_values.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
authtypes.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
background_jobs.pl Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
biblio_framework.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
branch_transfer_limits.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
branches.pl Bug 28567: Fix 0 vs "" vs undef on the admin library form 2021-08-06 08:14:52 -04:00
cash_registers.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
categories.pl Bug 23271: Use Koha::Object::Limit::Library for Koha::Patron::Categories 2021-04-21 15:25:07 +02:00
check_budget_parent.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
check_parent_total.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
checkmarc.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cities.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
classsources.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
clone-rules.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
columns_settings.pl Bug 27673: Replace YAML with YAML::XS 2021-02-16 14:54:50 +01:00
columns_settings.yml Bug 28408: Add new column to the table settings config 2021-07-30 10:29:39 -04:00
credit_types.pl Bug 26721: Fix permission check on debit and credit type admin pages 2020-11-03 10:57:35 +01:00
currency.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
debit_types.pl Bug 26721: Fix permission check on debit and credit type admin pages 2020-11-03 10:57:35 +01:00
desks.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
didyoumean.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
edi_accounts.pl Bug 26908: (follow-up) Alter template check 2020-11-05 15:24:20 +01:00
edi_ean_accounts.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
import_export_framework.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
item_circulation_alerts.pl Bug 23271: Replace search_limited with search_with_library_limits 2021-04-21 15:25:07 +02:00
items_search_field.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
items_search_fields.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
itemtypes.pl Bug 23207: Add automatic checkin feature 2021-04-22 11:11:05 +02:00
koha2marclinks.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
library_groups.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
localization.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
marc_subfields_structure.pl Bug 8976: Code cleaning 2021-03-01 15:14:22 +01:00
marctagstructure.pl Bug 28207: Fix biblio_framework.frameworktext isn't in GROUP BY 2021-04-30 17:07:32 +02:00
matching-rules.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
oai_set_mappings.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
oai_sets.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
overdrive.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
patron-attr-types.pl Bug 23271: (follow-up) Fix typo 'limlits' 2021-04-23 13:55:09 +02:00
preferences.pl Bug 27805: Use input type "email" for email preferences 2021-04-06 15:56:30 +02:00
share_content.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
smart-rules.pl Bug 24083: Delete the new rule when needed 2020-11-11 16:09:58 +01:00
sms_providers.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
smtp_servers.pl Bug 22343: (follow-up) Correctly handle password on editing 2020-11-20 08:16:38 +01:00
sru_modmapping.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
systempreferences.pl Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
transfer_limits.pl Bug 26633: Fix indirect object notation 2021-03-16 16:08:30 +01:00
transport-cost-matrix.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
usage_statistics.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
z3950servers.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00