Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/C4
History
Jonathan Druart e66d69fa3e Bug 26734: Rename activethemes with availablethemes 
There was an existing call to $self->activethemes that behave as setter:
   85     $self->activethemes($activethemes);

I am not sure what are the side-effects but it does not look good.

It caused warning in the logs:

Use of uninitialized value $interface in string eq at /kohadevbox/koha/C4/Templates.pm line 279.
Use of uninitialized value $interface in string eq at /kohadevbox/koha/C4/Templates.pm line 280.
Use of uninitialized value $interface in string eq at /kohadevbox/koha/C4/Templates.pm line 282.
Use of uninitialized value $lang in concatenation (.) or string at /kohadevbox/koha/C4/Templates.pm line 296.
Use of uninitialized value $lang in concatenation (.) or string at /kohadevbox/koha/C4/Templates.pm line 296.
Use of uninitialized value $lang in concatenation (.) or string at /kohadevbox/koha/C4/Templates.pm line 296

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-05-27 15:07:36 +02:00
..
AuthoritiesMarc
Barcodes Bug 26673: Fix perlcritic complains 2020-11-02 08:42:20 +01:00
ClassSortRoutine
ClassSplitRoutine Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Creators Bug 25852: Improve C4::Creators::Lib reliability under plack 2020-07-31 10:03:26 +02:00
External
Form
Heading Bug 18017: Add subdivisions to UNIMARC authorities zebra configuration 2021-04-16 15:12:45 +02:00
ILSDI Bug 17229: Check if patron is expired in CanItemBeReserved 2021-01-19 15:45:11 +01:00
Installer
Labels Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Linker Bug 25189: Don't create authority if results found 2020-06-24 14:31:37 +02:00
Members Bug 24447: Changing 'DUE' to example in database that exists. 2021-01-22 13:46:41 +01:00
OAI Bug 25460: Update OAI sets when adding/editing/deleting item records 2020-10-15 12:56:30 +02:00
Output
Patroncards Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Reports Bug 24695: Move to Koha::Report->is_sql_valid 2021-04-12 15:27:50 +02:00
Search
Serials
SIP Bug 28320: Add DB connection check to the SIP SC status message 2021-05-17 12:34:33 +02:00
Utils Bug 28069: (bug 27715 follow-up) Fix sort for lists 2021-04-16 16:20:50 +02:00
Accounts.pm Bug 22394: Remove C4::Accounts::manualinvoice 2020-11-04 12:59:33 +01:00
Acquisition.pm Bug 27203: Calculate tax based on ecost if unitprice not set 2021-05-11 15:09:13 +02:00
Auth.pm Bug 28317: Use the default CGI::Session serializer 2021-05-19 14:45:32 +02:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm Bug 20854: (QA follow-up) Improve readability 2021-04-21 10:51:29 +02:00
Auth_with_ldap.pm Bug 28385: Use ldapserver only if exists 2021-05-25 10:34:51 +02:00
Auth_with_shibboleth.pm Bug 28367: (follow-up) Fix plack condition in C4/Auth_with_shibboleth.pm 2021-05-18 11:26:27 +02:00
AuthoritiesMarc.pm Bug 21958: Fix bibliographic record field comparison with authority 2021-04-01 17:13:56 +02:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm Bug 27837: Always pass permanent location from items editor if it was defined 2021-05-19 15:06:42 +02:00
Breeding.pm Bug 26528: Z39.50/SRU ignore invalid replies 2021-04-16 16:20:42 +02:00
Budgets.pm Bug 23195: Always count shipping costs as 'spent' 2021-04-22 14:50:11 +02:00
Calendar.pm Bug 25723: (QA follow-up) Handle holiday and exception on same day 2020-07-20 17:45:31 +02:00
Charset.pm
Circulation.pm Bug 17202: Don't report an item in a collection if the collection doesn't exist 2021-04-28 11:07:06 +02:00
ClassSortRoutine.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
ClassSource.pm
ClassSplitRoutine.pm
Context.pm Bug 28317: Use the default CGI::Session serializer 2021-05-19 14:45:32 +02:00
Contract.pm
CourseReserves.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Creators.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Debug.pm
Heading.pm Bug 21958: Fix bibliographic record field comparison with authority 2021-04-01 17:13:56 +02:00
HoldsQueue.pm Bug 27069: Adapt uses of holdallowed 2021-04-07 16:08:04 +02:00
HTML5Media.pm Bug 27422: YouTube videos are HTTPS only 2021-02-08 17:09:34 +01:00
ImportBatch.pm Bug 24469: Move the new queries to a dedicated ImportBatch subroutine 2021-02-18 11:52:59 +01:00
ImportExportFramework.pm Bug 27968: Fix framework import if isurl has an incorrect value 2021-04-23 10:03:30 +02:00
InstallAuth.pm Bug 28317: Use the default CGI::Session serializer 2021-05-19 14:45:32 +02:00
Installer.pm Bug 28281: Remove double decoding when importing installation data 2021-05-07 14:44:00 +02:00
ItemCirculationAlertPreference.pm Bug 23271: Replace search_limited with search_with_library_limits 2021-04-21 15:25:07 +02:00
Items.pm Bug 27837: (follow-up) Do not check subfield unless tag defined 2021-05-19 15:06:42 +02:00
Koha.pm Bug 27746: prevent regexp undefined warning when checking subfield contents ($oclc) 2021-04-14 15:25:26 +02:00
Labels.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Languages.pm Bug 27491: Rename system preference opaclanguages to OPACLanguages 2021-01-22 14:59:27 +01:00
Letters.pm Bug 26734: Rename activethemes with availablethemes 2021-05-27 15:07:36 +02:00
Linker.pm
Log.pm Bug 23632: Remove C4::Logs::GetLogs 2020-08-18 15:45:48 +02:00
MarcModificationTemplates.pm
Matcher.pm Bug 26199: Include LDR for match check/match point 2021-03-09 17:20:47 +01:00
Members.pm Bug 28001: (bug 27050 follow-up) Fix delete_patrons if no category passed 2021-04-16 12:28:17 +02:00
Message.pm Bug 28230: Store C4::Message->{metadata} as Perl string always 2021-04-28 11:07:06 +02:00
NewsChannels.pm Bug 21066: Rename publicationdate with published_on 2020-09-02 15:35:08 +02:00
Output.pm Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml 2020-06-24 14:31:37 +02:00
Overdues.pm Bug 28144: Check if issue_id defined 2021-04-27 16:23:49 +02:00
Patroncards.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Record.pm Bug 27673: Fix encoding issues 2021-02-16 14:54:50 +01:00
Reports.pm Bug 27486: Rename system preference delimiter to CSVDelimiter 2021-01-29 09:03:45 +01:00
Reserves.pm Bug 16787: 'Too many holds' message appears inappropriately and is missing data 2021-04-22 14:37:14 +02:00
Ris.pm Bug 27673: Fix encoding issues 2021-02-16 14:54:50 +01:00
RotatingCollections.pm Bug 17202: Don't report an item in a collection if the collection doesn't exist 2021-04-28 11:07:06 +02:00
Scheduler.pm
Scrubber.pm
Search.pm Bug 18989: Allow displaying biblios with all items hidden by OpacHiddenItems 2021-05-12 14:12:07 +02:00
Serials.pm Bug 27842: Update serial.biblionumber when a subscription is linked with another record 2021-04-28 11:07:06 +02:00
Service.pm Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
ShelfBrowser.pm Bug 26673: Remove shebangs from Perl modules 2020-10-26 00:14:42 +01:00
SMS.pm Bug 27673: Replace YAML with YAML::XS 2021-02-16 14:54:50 +01:00
SocialData.pm
Stats.pm Bug 24151: Copy info to the pseudonymized table when a transaction is done 2020-07-20 15:17:42 +02:00
Suggestions.pm Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-01 11:16:42 +01:00
Tags.pm
Templates.pm Bug 26734: Rename activethemes with availablethemes 2021-05-27 15:07:36 +02:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm Bug 26673: Remove #!/usr/bin/env perl from .pm modules too 2020-10-26 00:14:42 +01:00
UsageStats.pm Bug 28108: Fix filtering 2021-05-10 15:52:53 +02:00
XISBN.pm Bug 26364: Don't discard the passed isbn 2021-01-07 15:37:15 +01:00
XSLT.pm Bug 23406: Don't translate suppressed authorised values 2021-05-11 15:37:42 +02:00