Jonathan Druart 94315f663b Bug 9942: Make Koha fails if privacy is not respected ... If a patron has requested anonymity on returning items and the system is not correctly configured (AnonymousPatron no set or set to an inexistent patron), the application should take it into account and not fail quietly. This patch is quite radical: the script will die loudly if the privacy is not respected. To be care of the bad "Software error", some checks are done in the updatedatabase to be sure the admin will be warned is something is wrong in the configuration. Test plan: 1/ Test the updatedatabase entry: a. Turn on OPACPrivacy and set AnonymousPatron to an existing patron => You will get a warning b. Turn on OPACPrivacy and set AnonymousPatron to 0 or '' => You will get a warning c. Turn on OPACPrivacy and set the privacy to 2 (Never) for at least 1 patron Turn off OPACPrivacy => You will get a warning d. In all other cases you will get no error 2/ Test the interface a. Turn on OPACPrivacy and set the privacy to 2 (Never) for a patron b. Now you can turn off OPACPrivacy or keep it on, behavior should be the same c. check an item out the patron d. Check the item in using the check out table => fail e. Check the item in using the Check in tab => fail (not gracefully). Note that the software error could appear on other pages too. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Updatedatabase works as described On staff, if don't have correct settings for anonymity it's impossible to check-in (with OPACPrivacy on) No errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>		2015-07-07 14:52:32 -03:00
..
Acquisition
Biblio
Budgets
Circulation	Bug 13106 - Encapsulate Circulation::GetAgeRestriction() and modify it to check borrowers age as well.	2014-11-11 09:52:59 -03:00
DataTables
db_dependent	Bug 9942: Make Koha fails if privacy is not respected	2015-07-07 14:52:32 -03:00
External	Bug 14147: Add unit tests to C4::External::OverDrive	2015-05-14 11:11:58 -03:00
Koha/Plugin	Bug 12412: Add ability for plugins to convert arbitrary files to MARC from record staging tool	2015-05-04 15:33:51 -03:00
lib	Bug 14256: (follow-up) Check for unique constraint to regenerate random data	2015-06-10 12:47:07 -03:00
Members
Number	Bug 12844: Force the symbol place in the tests	2014-10-27 12:56:30 -03:00
Search
Serials
00-checkdatabase-version.t	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
00-deprecated.t	Bug 5105 Regression test for switch statement	2010-11-11 21:32:31 +13:00
00-load.t	Bug 7904 Change SIP modules to use standard LIB path	2015-02-05 14:44:54 -03:00
00-merge-conflict-markers.t	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
00-testcritic.t	Bug 8798: (follow-up) remove DBIC_DONT_VALIDATE_RELS	2013-10-14 22:51:44 +00:00
00-valid-xml.t	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Auth_with_shibboleth.t	Bug 14111 - More t/Auth_with_shibboleth.t silencing	2015-06-04 10:12:03 -03:00
AuthoritiesMarc_MARC21.t
AuthoritiesMarc_UNIMARC.t	Added unit test for AuthoritiesMarc/UNIMARC.pm	2011-12-15 13:41:41 +01:00
AuthUtils.t
Barcodes_annual.t
Barcodes_EAN13.t
Barcodes_hbyymmincr.t
Barcodes_incremental.t	Bug 5327: More basic unit tests for C4 modules	2010-11-01 15:35:50 +13:00
Barcodes_ValueBuilder.t
Biblio.t	Bug 14346: t/Biblio.t fails because of new warning	2015-06-07 18:37:32 -03:00
Bookseller.t
Boolean.t	Bug 13814: (QA followup) test for generated warnings	2015-03-15 09:03:33 -03:00
Borrower.t	Bug 13882: Tidy t/Borrower.t to fix whitespace errors	2015-04-08 12:19:15 -03:00
Branch.t	Total Test Overhaul! Most of these were stubs, and still are.	2007-10-18 16:26:44 -05:00
Breeding.t	Bug 13279: t/Breeding.t shouldn't depend on the DB	2014-11-20 09:39:53 -03:00
Budgets.t
Cache.t
Calendar.t
Charset.t	Bug 14112: Silence warnings in t/Charset.t	2015-05-27 14:32:41 -03:00
Circulation_barcodedecode.t	Bug 10900 - Incorrect calling conventions accessing C4::Context	2015-02-09 17:00:13 -03:00
ClassSortRoutine.t
ClassSortRoutine_Dewey.t	Bug 8837 [QA Followup] - Add unit tests	2014-10-28 09:39:44 -03:00
ClassSortRoutine_Generic.t
ClassSortRoutine_LCC.t
ClassSource.t
Context.t
Contract.t
Creators.t
Dates.t	Bug 14113: Silence t/Dates.t warnings and cleanup output.	2015-06-01 14:13:54 -03:00
DateUtils.t	Bug 13933: Fix t/DateUtils.t without DB	2015-04-01 13:10:16 -03:00
Debug.t	Bug 14114: Silence warns and cleanup t/Debug.t	2015-05-22 09:33:34 -03:00
dummy.t
External_Syndetics.t	Bug 5327: More basic unit tests for C4 modules	2010-11-01 15:35:50 +13:00
Form_MessagingPreferences.t
Heading.t
Images.t
ImportBatch.t	Bug 13281: t/ImportBatch.t shouldn't depend on the DB	2014-11-20 09:53:36 -03:00
Input.t
Installer_PerlDependencies.t
Installer_PerlModules.t
Installer_pm.t	Bug 4905 Runtime errors in about.pl	2010-06-24 14:16:36 -04:00
ItemCirculationAlertPreference.t
ItemType.t	Bug 13934: C4::ItemType->get should return undef if no parameter given	2015-04-10 10:18:07 -03:00
Koha.t	Bug 14200: Regression tests	2015-05-19 09:45:04 -03:00
Koha_Email.t	Bug 13172 t/Koha_Email.t was database dependent	2014-10-31 12:10:32 -03:00
Koha_MetadataRecord.t	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Koha_Template_Plugin_Cache.t
Koha_Template_Plugin_Koha.t	Bug 13758: (QA followup) revert case change that broke the tests	2015-05-07 14:12:14 -03:00
Koha_Util_FrameworkPlugin.t	Bug 13437: Preliminary changes for marc21 plugins field 008	2015-06-10 12:51:26 -03:00
Koha_Util_MARC.t	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Labels.t	Bug 9978: (followup) Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:43 -03:00
Labels_split_ccn.t	Bug 9978: (followup) Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:43 -03:00
Labels_split_ddcn.t	Bug 9978: (followup) Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:43 -03:00
Labels_split_lccn.t	Bug 9978: (followup) Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:43 -03:00
Languages.t	Bug 11944: use CGI( -utf8 ) everywhere	2015-01-13 13:07:21 -03:00
Letters.t	Bug 13601: t/Letters.t needs to mock the dateformat pref	2015-03-30 13:40:05 -03:00
Log.t
Matcher.t
Members_Attributes.t
Members_AttributeTypes.t	Bug 7919: Fix unit test (Members_AttributeTypes.t)	2012-12-07 18:26:37 -05:00
Members_Messaging.t	Bug 5327: More basic unit tests for C4 modules	2010-11-01 15:35:50 +13:00
Message.t	Bug 13282: t/Message.t shouldn't depend on the DB	2014-11-20 09:38:02 -03:00
NorwegianPatronDB.t	Bug 11401: (followup) make tests run on absent deps	2014-11-14 15:32:25 -03:00
Output.t	Bug 11944: use CGI( -utf8 ) everywhere	2015-01-13 13:07:21 -03:00
Output_JSONStream.t
Overdues.t	Bug 13283: t/Overdues.t shouldn't depend on the DB	2014-11-20 09:37:39 -03:00
Patroncards.t
Patroncards_Batch.t
Patroncards_Layout.t
Patroncards_Lib.t	Bug 5327: More basic unit tests for C4 modules	2010-11-01 15:35:50 +13:00
Patroncards_Patroncard.t
Patroncards_Profile.t	Bug 5327: More basic unit tests for C4 modules	2010-11-01 15:35:50 +13:00
Patroncards_Template.t	Bug 5327: More basic unit tests for C4 modules	2010-11-01 15:35:50 +13:00
perlcriticrc
Prices.t	Bug 12976: Fix some comment in tests	2015-02-19 09:46:44 -03:00
Print.t
QueryParser.t	Bug 12647: PQF QueryParser driver and unit tests fixes	2014-08-11 10:09:38 -03:00
RecordProcessor.t	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Review.t
Ris.t	bug 5327 added unit tests for C4/Ris.pm	2012-01-31 17:21:49 +01:00
RotatingCollections.t	Bug 13284: t/RotatingCollections.t shouldn't depend on the DB	2014-11-20 09:37:20 -03:00
Scheduler.t
Scrubber.t	Bug 14116: Silence noisy output for t/Scrubber.	2015-06-01 14:10:56 -03:00
Search.t	Bug 13278: (QA followup) use t::lib::Mocks	2014-11-19 18:11:58 -03:00
Search_PazPar2.t	Bug 14117: Silence warnings t/SearchPazPar2.t	2015-06-01 14:10:14 -03:00
SimpleMARC.t	Bug 11413: Change the field number logic	2014-11-14 12:05:40 -03:00
SIP_Sip.t	Bug 7904 Change SIP modules to use standard LIB path	2015-02-05 14:44:54 -03:00
smolder_smoke_signal
SMS.t	Bug 12642: t/SMS.t should not be db dependent	2014-07-29 11:27:55 -03:00
SocialData.t
Stats.t
SuggestionEngine.t
SuggestionEngine_AuthorityFile.t	Bug 13277: (QA followup) use t::lib::Mocks	2014-11-19 18:12:03 -03:00
TmplToken.t
XSLT.t	Bug 13276: use t::lib::Mocks::mock_dbh	2014-11-19 11:30:45 -03:00