Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Jonathan Druart cae4b98060 Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType 
This unnecessary complicated subroutine returned an arrayref and an
hashref of the patron categories available for the logged in user, for a given
category_type, ordered by categorycode.
This can now be done with the search_limited method.

Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to other
libraries. They should be ordered as before this patch, by categorycode.
- Add/edit a patron, change his/her patron category value.
- On the 3 following reports:
    reports/bor_issues_top.pl
    reports/borrowers_out.pl
    reports/cat_issues_top.pl
The display for these 3 reports are different than the 2 from the first
patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by
categorycode and the ones limited to other libraries are not displayed
(should certainly be fixed).

Note that the big part of this patch has already been tested before
(update child related: CATCODE_MULTI).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-08 13:29:22 +00:00
..
Acquisition Bug 15531: (followup) Use a quantity of 1, not null, for standing orders 2016-04-29 13:07:18 +00:00
api/v1 Bug 14868: Display required permissions in permission error response 2016-09-02 12:20:36 +00:00
Auth
Biblio
Circulation Bug 15407: Koha::Patron::Categories - replace C4::Category->all 2016-09-08 13:29:03 +00:00
Creators
data
Exporter
Holds Bug 15534 [QA Followup] - Remove superfluous lines from unit tests 2016-04-29 10:35:06 +00:00
Items Bug 16607: Remove CPL/MPL from two unit tests 2016-06-17 14:44:39 +00:00
Koha Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType 2016-09-08 13:29:22 +00:00
Labels
LDAP
Letters Bug 16942 [QA Followup] - Add unit test 2016-09-01 17:21:24 +00:00
Members Bug 15407: Koha::Patron::Categories - replace C4::Category->all 2016-09-08 13:29:03 +00:00
OAI Bug 16172: fix OAI Server tests broken by bug 15946 2016-03-31 16:51:38 +00:00
Patron Bug 16849: Move IsDebarred to Koha::Patron->is_debarred 2016-07-15 18:08:14 +00:00
Record
Reports Bug 12787 [QA Followup] - Retain change to Reports_Guided.t 2016-04-22 00:54:36 +00:00
Reserves Bug 14695 [QA Followup] - Unit Tests 2016-09-03 00:21:23 +00:00
Search
selenium Bug 13691: Add changes for 3.22 2016-07-08 20:36:57 +00:00
Serials Bug 12178: Update serial status to "claimed" when exporting to CSV 2016-07-15 14:07:40 +00:00
SIP Bug 15006: Centralize timeout logic and allow zero client timeout 2016-07-15 14:11:05 +00:00
Template/Plugin Bug 12787: Reorganise t/db_dependent files 2016-04-22 00:54:35 +00:00
Utils Bug 15407: Koha::Patron::Categories - replace C4::Category->all 2016-09-08 13:29:03 +00:00
www Bug 10171: (QA followup) Make search tests use the right form 2016-05-04 14:14:50 +00:00
XSLT_Handler
00-strict.t
Accounts.t Bug 16607: Remove CPL/MPL from two unit tests 2016-06-17 14:44:39 +00:00
Acquisition.t Bug 16934: Add test for ModOrder 2016-07-22 17:13:17 +00:00
AdditionalField.t
Amazon.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
AudioAlerts.t
Auth.t Bug 16853: Move changepassword to Koha::Patron->update_password 2016-07-15 18:09:17 +00:00
Auth_with_cas.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Auth_with_ldap.t Bug 14144: Clean ups and refactors 2016-04-29 12:40:16 +00:00
AuthorisedValues.t
AuthoritiesMarc.t
BackgroundJob.t
Barcodes.t Bug 15878 - Updated unit tests for hbyymmincr barcodes 2016-05-23 17:42:10 +00:00
Barcodes_ValueBuilder.t
Biblio.t Bug 16431: Use Koha::Cache to cache marc subfield structure 2016-07-08 12:44:58 +00:00
Bookseller.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Branch.t
Breeding.t
Budgets.t Bug 15009 [QA Followup] - Update number of tests run 2016-04-29 13:01:07 +00:00
Charset.t
check_sysprefs.t
Circulation.t Bug 14390 [QA Followup] - Unit Test 2016-08-24 16:24:20 +00:00
ClassSource.t Bug 16860: Remove the comment about the warning 2016-07-08 13:29:50 +00:00
ColumnsSettings.t Bug 16177: Fix tests for ColumnsSsettings.t 2016-04-01 19:08:23 +00:00
Context.t Bug 16813: Allow empty string for OPACBaseURL 2016-07-15 15:02:13 +00:00
Contract.t
CourseReserves.t
db_structure.t Bug 16173: db_structure.t shouldn't have a fixed number of tests 2016-04-01 19:14:53 +00:00
DecreaseLoanHighHolds.t Bug 17124: Fix tests in DecreaseLoanHighHolds.t 2016-08-18 15:57:03 +00:00
default_search_class.pl Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Filter_MARC_ViewPolicy.t Bug 11592: Add should_hide_marc method to filter 2016-09-08 11:54:16 +00:00
Fines.t
FrameworkPlugin.t
Heading_MARC21.t
Hold.t Bug 14642: (QA followup) Add tests for Koha::Hold->delete 2016-08-17 18:43:13 +00:00
Holds.t Bug 14695 [QA Followup] 2016-09-08 12:44:50 +00:00
HoldsQueue.t Bug 16671: [QA Follow-up] Replace remaining itemtype lines 2016-07-08 12:47:14 +00:00
Holidays.t Bug 15333: [QA Follow-up] Add few tests 2016-05-25 22:18:28 +00:00
ILSDI_Services.t Bug 16155: (QA followup) fix small bug in t/db_dependent/ILSDI_Services.t 2016-05-04 13:47:58 +00:00
ImportBatch.t Bug 9259: Use is instead of is_deeply 2016-07-08 13:43:53 +00:00
Installer.t
Items.t Bug 17189: Add the ability to define several memcached namespaces - replace existing occurrences 2016-09-08 10:24:46 +00:00
Items_DelItemCheck.t Bug 14504: Changes missed while fixing patches 2016-08-26 12:07:27 +00:00
KitchenSinkPlugin.kpz
Koha.t Bug 16157: Move the selected flag from GetAuthorisedValues to the templates 2016-04-07 00:16:09 +00:00
Koha_Authority.t
Koha_borrower_modifications.t Bug 16960: Update 1 missing occurrence of GetModifications 2016-08-22 11:46:05 +00:00
Koha_Database.t
Koha_ElasticSearch.t Bug 12478 Shifting tests and adding copyright headers 2016-04-26 20:20:13 +00:00
Koha_ElasticSearch_Indexer.t Bug 16453: Make Elasticsearch tests be skipped if configuration entry missing 2016-05-06 03:47:05 +00:00
Koha_Misc_Files.t
Koha_SearchEngine_Elasticsearch_Search.t Bug 16453: Make Elasticsearch tests be skipped if configuration entry missing 2016-05-06 03:47:05 +00:00
Languages.t Bug 16866: Catch warning t/db_dependent/Languages.t 2016-07-08 14:50:18 +00:00
Letters.t Bug 16805: Tweak new test message to say getalert 2016-07-08 14:45:04 +00:00
Linker_FirstMatch.t Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t 2016-08-04 20:04:24 +00:00
Log.t Bug 16829: Unit tests for logaction's 'interface parameter' 2016-08-17 18:01:50 +00:00
MarcModificationTemplates.t
Members.t Bug 16819: Unit tests for C4::Members::DelMember 2016-07-08 14:49:09 +00:00
MungeMarcPrice.t
NewsChannels.t Bug 16550: Clean the tests 2016-05-23 17:37:48 +00:00
Overdues.t
Passwordrecovery.t Bug 15585: Remove "shift on reference is experimental" warning 2016-03-22 23:08:21 +00:00
Patron.t Bug 14577 [QA Followup] 2016-04-29 11:54:23 +00:00
PatronLists.t Bug 16452: Remove the warnings raised by PatronLists.t 2016-05-05 20:44:47 +00:00
Patrons.t Bug 10459: Add tests for borrowers.updated_on 2016-06-10 17:10:23 +00:00
Plugins.t Bug 16502: Replace a few other ok-calls by is-calls 2016-06-17 14:32:40 +00:00
QueryParser.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Ratings.t Bug 15407: Koha::Patron::Categories - replace C4::Category->all 2016-09-08 13:29:03 +00:00
Record.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t Bug 14048: (QA followup) Default to 1 if no default rule 2016-07-07 10:37:01 -06:00
Reports.t
Reserves.t Bug 15407: Koha::Patron::Categories - replace GetBorrowercategory 2016-09-08 13:29:17 +00:00
Review.t
rollingloans.t
RotatingCollections.t
Search.t Bug 17201: (bug 16431 follow-up2) Remove occurrence of marcfromkohafield 2016-09-02 14:00:11 +00:00
Serials.t Bug 12178: Fix tests not to depend on dateformat syspref 2016-07-15 14:07:41 +00:00
Serials_2.t
Service.t
ShelfBrowser.t
Sitemapper.t Bug 16751: What is sitemaper? 2016-06-24 13:19:06 +00:00
Stats.t
SuggestionEngine_ExplodedTerms.t Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t 2016-07-08 13:08:09 +00:00
Suggestions.t Bug 16325: Add a test for SearchSuggestions when searching for STATUS='' 2016-05-05 20:46:01 +00:00
sysprefs.t Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
Tags.t
Templates.t
TestBuilder.t Bug 16890: Make TestBuilder generate date for date columns (and not datetime) 2016-07-15 14:59:46 +00:00
Upload.t Bug 16501: Remove some unneeded warns in Upload.t 2016-05-16 17:46:25 +00:00
UsageStats.t Bug 14048: (QA followup) Update syspref name for HEA 2016-07-07 10:37:01 -06:00
Virtualshelves.t
XISBN.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
XSLT_Handler.t
zebra_config.pl