Main Koha release repository https://koha-community.org
Find a file
Nick Clemens cae75b64dd Bug 17798: Confirm hold when printing slip from another patron's account
This patch adds a few pieces of information to the print slip button
and makes the code confirm the hold

As we are printing before the confirm, we also add the ability to pass
in the itemnumber to 'ReserveSlip'

This is slightly hacky, however, I don't see another way to allow
printing without an additional page reload.

To test:
 1 - Place a title level hold for patron A, for delivery to library B
 2 - Attempt to checkout an item from the record above to Patron B from
     library A
 3 - You receive an alert about the hold
 4 - Click "Don't check out, confirm hold, and print slip"
 5 - Confirm the slip looks correct and has item info
 6 - Confirm that item is in transit to fill hold
 7 - Revert transit status
 8 - Attempt to checkout the item to Patron B from Library B
 9 - Click "Don't check out, confirm hold, and print slip"
10 - Confirm slip is correct
11 - Confirm item is marked waiting

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 3ec73d80e2)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 96442d7ac7)
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
2023-11-14 13:42:15 -01:00
acqui Bug 34908: Sort item types alphabetically by description when adding a new empty record as an order to a basket 2023-11-13 15:10:49 +00:00
admin Bug 34748: Fix column name in columns configuration for basket table 2023-10-17 12:31:24 +01:00
api Bug 33606: Mark the endpoint as experimental 2023-11-13 15:10:56 +00:00
authorities Bug 33406: (QA follow-up) Adjust tests and tidy 2023-10-12 15:45:37 +00:00
basket Bug 33102: Display fields from biblioitems in OPAC/staff interface cart 2023-05-12 16:34:19 +01:00
bin
C4 Bug 17798: Confirm hold when printing slip from another patron's account 2023-11-14 13:42:15 -01:00
catalogue Bug 33167: (RMAINT fix) Revert 33167 2023-07-20 08:41:00 +00:00
cataloguing Bug 32379: Add check on existing item 2023-11-14 13:41:58 -01:00
circ Bug 17798: Confirm hold when printing slip from another patron's account 2023-11-14 13:42:15 -01:00
clubs
course_reserves Bug 31893: Use checkauth and do not fetch about.tt template 2023-01-31 14:09:05 +00:00
debian Bug 35242: Force memcache restart after koha upgrade 2023-11-14 13:40:55 -01:00
docs Bug 34424: Add Emily Lamancusa to QA Team 2023-11-13 15:28:49 +00:00
erm Bug 32922: Remove space in shebang 2023-02-24 07:51:37 +00:00
errors
etc Bug 30843: Add mfa_range configuration option for TOTP 2023-10-17 16:56:21 +00:00
ill
installer Bug 35185: Remove is_html flag from sample notices that are plain text 2023-11-14 13:39:17 -01:00
Koha Bug 35180: DBIC schema 2023-11-13 15:28:48 +00:00
koha-tmpl Bug 17798: Confirm hold when printing slip from another patron's account 2023-11-14 13:42:15 -01:00
labels
lib/CGI/Session/Serialize
members Bug 34910: (follow-up) alert in patron details 2023-11-13 15:22:12 +00:00
misc Bug 30024: Make link_bibs_to_authorities.pl rely on LinkerRelink 2023-11-14 13:41:06 -01:00
offline_circ
opac Bug 33819: Add page numbers to opac results breadcrumb 2023-10-17 17:35:39 +00:00
patron_lists
patroncards
plugins Bug 30367: (follow-up) Same adjustment for gitlab 2023-05-12 15:58:09 +01:00
pos Bug 34331: Use register from userenv if parameter not passed 2023-08-31 10:23:50 +00:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-07-18 11:21:31 +00:00
reports Bug 34859: Remove unnecessary params from reports-home.pl 2023-10-17 17:23:41 +00:00
reserve Bug 34634: Show expirationdate of expired holds on reserve/request.pl 2023-09-15 09:33:06 +00:00
reviews
rotating_collections
serials Bug 35073: perltidy subscription-batchedit.pl 2023-11-14 13:40:44 -01:00
services
skel
suggestion Bug 26994: List names in alphabetical order in Suggestion filter 2023-11-13 14:19:28 +00:00
svc Bug 27249: Prevent infinite loop when searching for an open day 2023-11-13 13:45:36 +00:00
t Bug 17798: Confirm hold when printing slip from another patron's account 2023-11-14 13:42:15 -01:00
tags
tools Bug 34349: Validate/escape inputs for task scheduler 2023-09-28 09:18:29 +00:00
virtualshelves Bug 34650: Remove unnecessary CSRF check on edit_form 2023-09-08 09:47:28 +00:00
xt Bug 34911: Test files from HEAD instead of 'master' 2023-10-17 16:56:23 +00:00
.editorconfig
.eslintrc.json
.gitignore Bug 33710: Ignore how-to related files 2023-05-15 13:03:55 +00:00
.htaccess
.mailmap Update .mailmap 2023-07-18 09:22:47 +00:00
.perlcriticrc
.perltidyrc Bug 30002: Adjust perltidy 2023-07-12 09:16:19 +00:00
.proverc.dist
.stylelintrc.json
about.pl Bug 35033: (QA follow-up): tidy up code 2023-11-13 15:28:49 +00:00
app.psgi
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-03-10 12:27:47 +00:00
changelanguage.pl
cpanfile Bug 32558: (QA follow-up) Move ForkManager to required 2023-03-08 14:39:16 +00:00
cypress.json Bug 33408: Extend defaultCommandTimeout for cypress 2023-05-15 13:15:43 +00:00
fix-perl-path.PL Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
gulpfile.js Bug 35103: Add option to gulp tasks to pass a list of tasks 2023-11-14 15:28:51 +01:00
help.pl
INSTALL
Koha.pm Bug 34520: DBRev 22.11.11.001 2023-11-13 15:10:50 +00:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 35019: Add a CSRF token when deleting news 2023-11-13 14:19:29 +00:00
Makefile.PL Bug 30002: (QA follow-up) Add .perltidyrc to Makefile.PL mapping 2023-07-12 09:41:28 +00:00
MANIFEST.SKIP
package.json Bug 33066: Introduce a KohaTable Vue component 2023-05-11 17:01:22 +01:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 32806: Move main-erm.ts to modules/erm.ts 2023-02-28 18:54:57 +00:00
yarn.lock Bug 33066: Introduce a KohaTable Vue component 2023-05-11 17:01:22 +01:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo