Jonathan Druart 8b685c1e80 Bug 9823: Refactor return from GetReservesFromBiblionumber ... The return from GetReservesFromBiblionumber contains an unnecessary extra variable. In scalar context an array returns its element count. Maintaining a separate count can lead to unforeseen bugs and imposes ugly constructions on the subroutine's users. Remove the useless count variable from the return This patch also changes the parameters: now the routine takes a hashref. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Placed biblio holds, future holds and item holds. Works as expected. Tested Holds.t and Reserves.t. Pass. Tested /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=999 with two holds on one item. Fine. C4/SIP/ILS/Item.pm: Looked for "whatever" and "arrayref" and could not find them anymore. Looks good. Handled a few unneeded calls in QA follow-up. Left only one point to-do for serials/routing-preview.pl. See Bugzilla. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>		2014-01-30 16:19:55 +00:00
..
Acquisition	Bug 11549: Add regression test	2014-01-23 16:17:24 +00:00
Circulation	Bug 11338: add unit tests for DelItemCheck	2013-12-25 17:07:53 +00:00
data	Bug 10684: add regression test	2013-11-14 18:04:39 +00:00
Koha	Bug 11279: (follow-up) remove unnecessary check on number of quotes	2013-12-19 15:06:39 +00:00
Labels	Bug 10333: Labels/t_Batch.t needs to create its own data	2013-09-08 02:07:19 +00:00
LDAP
Members	Bug 10481: Unit tests for C4::Members::AddEnrolmentFeeIfNeeded	2013-08-16 15:08:41 +00:00
Record
Reports	Bug 8594 - prevent the report system from breaking some subqueries	2012-09-05 10:12:06 +02:00
Serials	Bug 7688: (follow-up) rewrite 'for' loop in unit tests	2013-10-30 00:38:52 +00:00
www	Bug 8300: Add mechanized unit test for batch import	2013-05-01 07:57:11 -04:00
00-strict.t	Bug 8383: Add test to check that Perl scripts compile	2012-07-10 11:13:40 +02:00
Accounts.t
Acquisition.t	Bug 11111: UT: SearchOrders returns keys basketgroupid and basketgroupname	2013-12-05 15:38:06 +00:00
Amazon.t
Auth.t	Bug 10952: (follow-up) remove mention of KohaOpacRecentSearches cookie	2014-01-10 16:55:37 +00:00
Auth_SearchHistorySession.t	Bug 10952: (follow-up) comments fixes and unit tests	2014-01-10 16:21:18 +00:00
Auth_with_cas.t
AuthoritiesMarc.t	Bug 8890 - move two more db dependent tests	2012-10-24 17:52:42 +02:00
BackgroundJob.t	Bug 10601: (follow-up) unit tests for new ->set() and ->get()	2013-09-18 17:21:47 +00:00
Barcodes.t	Bug 6448 [2/3] Barcodes::EAN13 autoBarcode	2012-08-02 18:41:44 +02:00
Biblio.t
Bookseller.t	Bug 11457: avoid spurious test failure in t/db_dependent/Bookseller.t	2014-01-09 19:09:56 +00:00
Borrower_Debarments.t	Bug 2720: (follow-up) improve unit tests	2013-10-31 01:55:04 +00:00
Branch.t	Bug 10508: (follow-up) remove Perl 5.14 construct	2013-08-28 14:24:34 +00:00
Budgets.t	Bug 8037: (follow-up) improve GetBudgetByOrderNumber test	2013-10-31 14:57:18 +00:00
Category.t	Bug 11543: (followup) add one more test	2014-01-15 19:58:30 +00:00
check_sysprefs.t	Bug 8353 follow-up: Perltidy new test	2012-07-13 14:42:52 +02:00
Circulation.t	Bug 11336: (follow-up) fix typo in previous follow-up	2014-01-06 16:16:22 +00:00
Circulation_Branch.t	Bug 10683: (follow-up) improvements to the unit tests	2013-10-09 03:51:55 +00:00
Circulation_issue.t	Bug 10493: (follow-up) fix test errors	2013-10-23 04:25:34 +00:00
Circulation_Issuingrule.t	Bug 10767: (follow-up) remove FIXME comments	2013-08-28 14:44:01 +00:00
Circulation_issuingrules.t	Bug 10298: Followup: Adapt existing code	2013-08-09 16:35:43 +00:00
Circulation_OfflineOperation.t	Bug 10710: (follow-up) perltidy new code	2013-08-28 14:52:43 +00:00
Circulation_transfers.t	Bug 11470: fix occassional spurious test failure in Circulation_transfers.t	2014-01-06 05:31:21 +00:00
ClassSource.t	Bug 10644: (follow-up) remove inadvertant dependence on Perl 5.14	2013-08-09 18:53:20 +00:00
Context.t	Bug 10927: remove disused C4::Utils module	2013-10-03 14:53:02 +00:00
CourseReserves.t	Bug 10332: further improvements to course reserves tests	2013-06-18 16:40:43 -07:00
Csv.t	Bug 10853: (follow-up) expand unit tests for C4::Csv	2013-10-11 03:25:42 +00:00
External_BakerTaylor.t
Heading_MARC21.t
Holds.t	Bug 9823: Refactor return from GetReservesFromBiblionumber	2014-01-30 16:19:55 +00:00
HoldsQueue.t	Bug 10243: (follow-up) add unit tests	2013-10-30 03:13:23 +00:00
Holidays.t	Bug 11112: (follow-up) repair Koha::Calendar->add_holiday()	2013-12-10 18:19:15 +00:00
ILSDI_Services.t	Bug 10667: (follow-up) fix reference to UT library in test case	2013-09-16 19:22:22 +00:00
Installer.t	Bug 11541: (follow-up) move Installer.t to t/db_dependent	2014-01-14 21:43:56 +00:00
Items.t	Bug 10872: UT for GetHiddenItemnumbers and POD fix	2013-09-18 15:55:46 +00:00
KitchenSinkPlugin.kpz	Bug 7804 - Add Koha Plugin System - QA Followup 3 - Additional Unit Tests	2013-03-20 14:50:38 -04:00
Koha.t	Bug 10078: (follow-up) add regression test	2013-10-30 05:02:45 +00:00
Koha_Authority.t	Bug 5202: merge authorities from the authority file and reservoir	2013-10-10 21:32:27 +00:00
Koha_borrower_modifications.t	Bug 7067 - QA Followup - Fix failing tests	2012-12-14 08:09:01 -05:00
Koha_Database.t	Bug 8798: moving code to Koha::Database and adding tests	2013-10-14 21:08:02 +00:00
Koha_template_plugin_Branches.t	Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches	2013-12-14 01:05:56 +00:00
Koha_template_plugin_KohaDates.t
Languages.t	Bug 11545: (follow-up) move Languages.t to t/db_dependent	2014-01-14 20:48:33 +00:00
Letters.t	Bug 11208: regression test for failing SMS messages	2013-12-30 16:45:45 +00:00
Linker_FirstMatch.t
Log.t
MarcModificationTemplates.t	Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines	2013-10-31 22:50:11 +00:00
Members.t	Bug 11221: (follow-up) test for NULL rather than empty string	2013-11-19 15:35:25 +00:00
Members_columns.t	Bug 7785: (follow-up) standardize POD	2013-08-13 16:15:30 +00:00
PatronLists.t	Bug 10565: (follow-up) don't assume borrowernumber 1 exists in unit test	2013-10-14 21:30:34 +00:00
Plugins.t	Bug 9909: Don't install KitchenSink plugin if plugin dir isn't writable	2013-03-22 21:52:41 -04:00
Ratings.t
Record.t	Bug 11066: (follow-up) add regression test	2014-01-03 15:54:45 +00:00
RecordProcessor_EmbedSeeFromHeadings.t	Bug 7417: Include see from references in bibliographic searches	2012-09-13 14:19:28 +02:00
Reports.t
Reports_Guided.t	Bug 10761: (follow-up) remove inadvertant dependence on Perl 5.14	2013-08-21 16:29:18 +00:00
ReportsGuided.t	Bug 9659 follow-up: correct syntax for older Perl	2013-04-26 21:32:49 -04:00
Reserves.t	Bug 9788: (follow-up) Unit tests for changed routine GetReservesFromItemnumber	2014-01-17 05:11:48 +00:00
rollingloans.t
RotatingCollections.t	Bug 10653: (follow-up) minor tweaks to RotatingCollections tests	2013-08-16 16:09:13 +00:00
Search.t	Bug 11533: fix authority searching with no sorting when QueryParser is enabled	2014-01-24 14:02:48 +00:00
Search_SearchHistory.t	Bug 10361: (follow-up) add tests for search history functions	2013-09-04 14:22:50 +00:00
Serials.t	Bug 7688: (follow-up) have Serials.t create its test subscription	2013-10-31 05:07:44 +00:00
Serials_2.t	Bug 8435: (follow-up) handle lack of userenv gracefully	2013-10-31 15:29:42 +00:00
Service.t
ShelfBrowser.t	Bug 10856: Improve the previous and next items on the shelf browser	2013-10-04 15:56:35 +00:00
SIP_ILS.t
SQLHelper.t
SuggestionEngine_ExplodedTerms.t	Bug 8846 conflict resolution: correct path	2012-11-01 08:41:30 -04:00
Suggestions.t
sysprefs.t	Bug 10325: (follow-up) add test for overriding system preferences	2013-09-08 02:28:45 +00:00
Tags.t	Bug 7642 - fix the lost display of tag sizes	2012-10-01 17:38:27 +02:00
UploadedFile.t
VirtualShelves.t	Bug 10499: VirtualShelves.t - wrap tests in a database transaction	2013-07-16 14:17:27 +00:00
VirtualShelves_Page.t
XISBN.t	Bug 11439: (follow-up) adjust for change in list returned by OCLC XISBN	2014-01-30 15:48:48 +00:00
zebra_config.pl	Bug 11499: UT: Make zebra_setup.pl correctly set indexing mode	2014-01-10 15:42:23 +00:00