Main Koha release repository https://koha-community.org
Find a file
Colin Campbell cd40febe67 Bug 28052: Do not check SYSENV values only keys in loop
Loop is only interested in key values, because 'keys' is omitted
it is checking values as well. This can lead to misleading errors
being logged (e.g. key is undefined)
Extract keys only to loop array as in the other loops below this

Testing:
1 - tail /var/lib/koha/kohadev/sip-output.log
2 - in another tab use the sip cli tester:
   perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m checkin --item CHESS1
3 - Note errors:
Use of uninitialized value $key in index at /kohadevbox/koha/C4/SIP/Sip/MsgType.pm line 337, <STDIN> line 1.
Use of uninitialized value $key in index at /kohadevbox/koha/C4/SIP/Sip/MsgType.pm line 337, <STDIN> line 2.
4 - Apply patch and restart all the things
5 - Repeat 2
6 - Errors mentioned are gone

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-04-01 18:51:37 +02:00
acqui
admin Bug 26633: Fix indirect object notation 2021-03-16 16:08:30 +01:00
api Bug 27366: Spec changes 2021-03-16 16:08:31 +01:00
authorities
basket
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
C4 Bug 28052: Do not check SYSENV values only keys in loop 2021-04-01 18:51:37 +02:00
catalogue
cataloguing
circ
clubs
course_reserves
debian
docs
errors
etc
ill
installer Bug 27835: DBRev 20.12.00.025 2021-03-18 15:04:47 +01:00
Koha Bug 28017: Allow non-FQDN (@localhost) addresses 2021-04-01 18:51:37 +02:00
koha-tmpl Bug 27397: The description input field when defining numbering patterns is too short 2021-04-01 18:51:37 +02:00
labels
members Bug 25946: borrowerRelationship can be empty 2021-04-01 17:06:38 +02:00
misc Bug 27963: (bug 23463 follow-up) Fix touch_all_items.pl 2021-04-01 17:13:56 +02:00
offline_circ
opac Bug 27860: Fix self-registration if messages with incorrect email are inqueued 2021-03-16 12:04:05 +01:00
patron_lists
patroncards Bug 27716: Update permissions for patroncards creator 2021-03-16 16:08:30 +01:00
plugins
pos
reports
reserve Bug 26999: (follow-up) Simplify code 2021-04-01 18:51:37 +02:00
reviews
rotating_collections
serials
services
skel
suggestion
svc
t Bug 27921: Log correct timestamp for HOLD MODIFY when set waiting 2021-04-01 18:51:37 +02:00
tags
tmp/modified_authorities
tools
virtualshelves
xt
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap
.perlcriticrc
.scss-lint.yml
about.pl
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl
cpanfile Bug 27673: remove libyaml-syck-perl, and lower libyaml-libyaml-perl to 0.41 (for u16) 2021-03-01 13:50:03 +01:00
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 27835: DBRev 20.12.00.025 2021-03-18 15:04:47 +01:00
koha_perl_deps.pl
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
LICENSE
mainpage.pl
Makefile.PL
MANIFEST.SKIP
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
README
README.md
README.robots
rewrite-config.PL
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo