Main Koha release repository https://koha-community.org
Find a file
Nick Clemens ce161fda9b Bug 25273: Make match-heading rely on authority type configuration
The match-heading field is a special field used only by the linker, not accessible
to staff or patrons via the interface. This field is used to store the constructed
'search form' used for matching bib headings to authority fields.

In bug 24269 I attempted to use the mappings defined in the inferface and also inject the search term.
This did not work as too many subfields were indexed on their own and leading to false matches.
In this bug we remove the mappings for this field, and create it ourselves during
the indexing process. The C4::Headings module is still used to generate the correct form,
however, the mappings are set based on the authority types in the system. This gives the user
the ability to add new typoes, but prevents mapping changes from breaking linker functionality

To test:
 1 - Start form a sample database with ElasticSearch working
 2 - Download via Z39.50 2 authorities, one of which is a narrower heading of the other, e.g.:
    Waterworks
    Waterworks - Costs
 3 - Place a heading for the broader term in a record. e.g. Waterworks
       In 650$a, without the cataloguing authority plugin. We don't want
       the link created now.
       You need syspref BiblioAddsAuthorities => allow
 4 - Make sure linker is set to default
 5 - Attempt to link the records
       misc/link_bibs_to_authorities.pl
 6 - Linking fails
 7 - Apply patch
 8 - refresh index settings (if using a custom file, remove 'match-heading')
       You can reset mappings in the UI or run this:
       misc/search_tools/rebuild_elasticsearch.pl -v -d -r
 9 - Reindex ES
10 - Try to link again
11 - It succeeds!
12 - Run the tests
     prove t/db_dependent/Koha/SearchEngine/Elasticsearch.t

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Bug 25273: (follow-up)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-08-31 16:10:25 +02:00
acqui Bug 25033: Display both local and all pending suggestions counts if the numbers differ 2020-08-25 11:31:40 +02:00
admin Bug 25273: Make match-heading rely on authority type configuration 2020-08-31 16:10:25 +02:00
api Bug 26015: Terminology: Fix tons more staff clients to staff interfaces 2020-08-31 16:10:25 +02:00
authorities Bug 25728: Create AV when cataloguing an authority record 2020-08-24 11:19:03 +02:00
basket
C4 Bug 25273: Make match-heading rely on authority type configuration 2020-08-31 16:10:25 +02:00
catalogue Bug 26139: Centralize code for "Place hold" button (detail) 2020-08-25 11:31:49 +02:00
cataloguing Bug 25728: Create AV when adding a new item 2020-08-24 11:19:03 +02:00
circ Bug 25534: Add reason to pendingreserves.pl 2020-08-25 15:07:27 +02:00
clubs
course_reserves Bug 25606: Remove all reserve items button 2020-08-07 16:54:40 +02:00
debian Bug 26015: Terminology: Fix tons more staff clients to staff interfaces 2020-08-31 16:10:25 +02:00
docs Bug 26179: Add Timothy Alexis Vass to contributors 2020-08-13 08:09:10 +02:00
errors
etc Bug 26253: (bug 22857 follow-up) Remove duplicated mana_config in etc/koha-conf.xml 2020-08-24 10:12:39 +02:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 26015: Terminology: Fix tons more staff clients to staff interfaces 2020-08-31 16:10:25 +02:00
Koha Bug 25273: Make match-heading rely on authority type configuration 2020-08-31 16:10:25 +02:00
koha-tmpl Bug 26289: Add missing variable definition to templates 2020-08-31 16:10:25 +02:00
labels
members Bug 26076: (QA Follow up) Prevent error by using a fresh resultset 2020-08-24 10:12:49 +02:00
misc Bug 26015: Terminology: Fix tons more staff clients to staff interfaces 2020-08-31 16:10:25 +02:00
offline_circ
opac Bug 20057: System preference for auto approval of patron profile changes 2020-08-31 14:41:08 +02:00
patron_lists
patroncards
plugins
pos Bug 26023: Properly secure the cashup and refund actions 2020-08-24 10:12:42 +02:00
reports Bug 25605: Replace NULL values with '' when downloading a report as a tab separated text 2020-08-19 09:29:40 +02:00
reserve Bug 22789: (follow-up) Fix atomic update, GUI and more than one hold 2020-08-31 16:10:25 +02:00
reviews
rotating_collections
serials
services
skel
suggestion Bug 25033: (follow-up) Don't limit suggestions to branches if displaying by branch 2020-08-25 11:31:42 +02:00
svc Bug 25728: Use a svc script instead of the REST API endpoint 2020-08-24 11:19:03 +02:00
t Bug 25273: Make match-heading rely on authority type configuration 2020-08-31 16:10:25 +02:00
tags
tmp/modified_authorities
tools Bug 5428: (QA follow-up) Add searchid for deleting items in a batch and editing in batch 2020-08-13 07:55:45 +02:00
virtualshelves
xt Bug 26265: add a plan for tests 2020-08-25 15:14:30 +02:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.perlcriticrc
.scss-lint.yml
about.pl
changelanguage.pl
cpanfile
fix-perl-path.PL
gulpfile.js Bug 26228: Update gulpfile to work with Node.js v12 2020-08-18 14:47:44 +02:00
help.pl
INSTALL
Koha.pm Bug 22789: DBRev 20.06.00.031 2020-08-31 16:10:25 +02:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 25033: Display both local and all pending suggestions counts if the numbers differ 2020-08-25 11:31:40 +02:00
Makefile.PL Bug 26265: Add missing xt dir 2020-08-24 12:30:53 +02:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
package.json Bug 26228: Update gulpfile to work with Node.js v12 2020-08-18 14:47:44 +02:00
README
README.md
README.robots
rewrite-config.PL
yarn.lock Bug 26228: Update gulpfile to work with Node.js v12 2020-08-18 14:47:44 +02:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo