Main Koha release repository https://koha-community.org
Find a file
Colin Campbell d2c24f3bbf Bug 6790: Remove unnecessary variable from getroutinglist return
getroutinglist returns a count variable to indicate how many elements
are in the array. This is almost always a serious code smell. (We are
programming in a list manipulating language) The routine was executing
am unnecessary loop just to maintain that var.
Removed the variable from the routine and perldoc
refactored calls of the routine removed the c-style loops for
more idiomatic and maintainable for loops
renamed some opaquely named variables
removed a call to the routine where nothing was done with the data
moved some html out of the calling script and into the template

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-01-23 17:59:27 +01:00
acqui Bug 5473 follow-up : removed warn & replace some tabs by 4 spaces 2012-01-20 16:30:48 +01:00
admin Bug 6190: BorrowerUnwantedField syspref and removing fields from the patron entry 2012-01-06 17:30:25 +01:00
authorities Bug 7356 - Fix various typos and mis-spellings 2012-01-13 11:51:26 +01:00
basket Bug 6050 Make calls to GetItemsInfo consistent 2011-06-14 14:12:02 +12:00
C4 Bug 6790: Remove unnecessary variable from getroutinglist return 2012-01-23 17:59:27 +01:00
catalogue Bug 7097: HidePatronName not hiding on issue history 2012-01-17 18:02:00 +01:00
cataloguing Merge remote-tracking branch 'origin/new/bug_5533' 2012-01-17 16:03:14 +01:00
circ Bug 7266: flags debarred, suspended, gonenoaddress in overdue 2012-01-17 18:03:37 +01:00
debian Bug 7197 - add a Spanish readme file to the packages 2011-12-14 15:38:04 +01:00
docs Olivier Crouzet is 168th ! 2012-01-19 17:02:43 +01:00
errors Housekeeping in errors scripts 2010-05-12 07:29:03 -04:00
etc Bug 7356 - Fix various typos and mis-spellings 2012-01-13 11:51:26 +01:00
install_misc Bug 7063: add available perl packages for Debian in install_misc/debian.packages 2011-10-22 09:00:33 +13:00
installer Bug 5347: Adds columns claims_count and claimed_date in aqorders 2012-01-20 14:12:27 +01:00
Koha/Template/Plugin Bug 929 : Followup fixing date formatting 2012-01-06 13:52:08 +01:00
koha-tmpl Bug 6790: Remove unnecessary variable from getroutinglist return 2012-01-23 17:59:27 +01:00
labels Bug 6679 : Adding license statement and stopping declaring variables in a conditional 2011-12-08 10:11:27 +01:00
members Bug 6190: BorrowerUnwantedField syspref and removing fields from the patron entry 2012-01-06 17:30:25 +01:00
misc Bug 7247 - rebuild_zebra.pl -v should show all Zebra log output 2012-01-17 17:31:25 +01:00
offline_circ Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
opac Fix for Bug 7006, highlight patron changes in email 2012-01-17 17:38:16 +01:00
patroncards bug_6253: Unified member Search() 2011-10-19 16:23:02 +13:00
reports BZ6115: Acquisition reports : date filter & sorting don't work 2012-01-20 14:18:33 +01:00
reserve Bug 7059: Remove GetMemberDetails from reserve/request.pl 2011-10-20 14:07:51 +13:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections Bug 6553 : Follow up adding license statements 2011-08-13 19:54:38 +12:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Bug 6790: Remove unnecessary variable from getroutinglist return 2012-01-23 17:59:27 +01:00
skel installer: fixed chown invocation; added skel for KOHA_LOG_DIR 2007-12-17 09:13:53 -06:00
sms Bug 2505 - Add commented use warnings where missing in the sms/ directory 2010-04-21 20:25:08 +12:00
suggestion Bug 6894: Order from suggestion defaulting to wrong currency 2011-11-28 10:22:04 +01:00
svc bug 4896: granular permissions now always on (DB rev 138) 2010-06-19 07:56:03 -04:00
t Bug 5347: Followup change class for message + Unit test 2012-01-20 14:12:28 +01:00
tags Fix for Bug 2377 - Review tags: format date according to system preference 2010-10-06 09:31:56 -04:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools Bug 5347: Adds columns claims_count and claimed_date in aqorders 2012-01-20 14:12:27 +01:00
virtualshelves Fix for Bug 6957, authors disappearing when emailing lists 2011-10-20 11:34:39 +13:00
xt Bug 929 : Follow up to allow tests to check plugins too 2012-01-16 18:18:11 +01:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
about.pl Bug 7164 follow-up history.txt and perlcritic compliance 2011-12-14 15:10:28 +01:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl Bug 7038 Contextual help is always in English 2011-10-18 16:01:25 +13:00
fix-perl-path.PL installer: improvements to fix-path-perl.PL on Win32 2007-12-20 19:20:12 -06:00
help.pl Bug 6628 : Stopping a potential vulnerability 2011-11-28 10:05:58 +01:00
INSTALL Updating main INSTALL instructions 2011-10-22 09:04:19 +13:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
INSTALL.debian Updating distro specific install files 2011-10-22 09:12:15 +13:00
INSTALL.fedora7 fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00
INSTALL.opensuse Bug 7356 - Fix various typos and mis-spellings 2012-01-13 11:51:26 +01:00
INSTALL.ubuntu Updating distro specific install files 2011-10-22 09:12:15 +13:00
INSTALL.ubuntu.lucid Updating distro specific install files 2011-10-22 09:12:15 +13:00
koha_perl_deps.pl Bug 6914 - fixes for the color option of koha_perl_deps.pl 2011-12-03 07:47:38 +01:00
kohaversion.pl Koha version updated 2012-01-20 14:12:28 +01:00
LICENSE Update LICENSE with a fresh copy from upstream. This updates the FSF address, and refers to the LGPL with its current name, and changes a few other minor things of the typographical sort. No semantic changes. 2010-03-16 20:17:48 -04:00
mainpage.pl Bug 7259 - Show a count of items pending approval on staff client home and tools pages 2011-12-08 12:04:28 +01:00
Makefile.PL Updating perl version required to match reality 2011-10-19 02:57:18 +13:00
MANIFEST.SKIP Bug Fixing : 3334 2009-06-19 06:33:34 -05:00
README updated links in README 2010-05-24 08:14:16 -04:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 2 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/