Main Koha release repository https://koha-community.org
Find a file
Rafal Kopaczka e9eef04b95 Bug 12876 - Reserve in waiting/transfer status may be cancelled by user
User may cancel his own reservation at waiting or in transit status
through calling opac-modrequest.pl. Cancel button is disabled in
interface but possibility to cancel should be checked also in
opac-moderequest.pl, before calling CancelReserve().
Similar situation is with opac-modrequest-suspend.pl

This patch provides new soubroutine to chceck if user can cancel given
reserve. It's possible only when he's owner of hold and hold isn't in
transfer or waiting status.

Additionaly there are new test for this function in Reserves.t

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests, QA script and new tests.
Works as described, tested with:
.../cgi-bin/koha/opac-modrequest.pl?reserve_id=XXX

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2014-09-23 20:46:50 -03:00
acqui Bug 12827: NewOrder should not return basketno 2014-09-17 21:22:26 -03:00
admin Bug 11577: Add "Automatic renewal" to the circulation and fine rules 2014-09-17 19:23:09 -03:00
authorities Bug 12177 - Remove HTML from authorities.pl 2014-08-19 09:27:08 -03:00
basket Bug 9013 - Cart in staff interface displays location pulled from Description (OPAC) 2014-08-11 15:53:31 -03:00
C4 Bug 12876 - Reserve in waiting/transfer status may be cancelled by user 2014-09-23 20:46:50 -03:00
catalogue Bug 12330: [QA Follow-up] Consistency between opac-search and staff client 2014-09-05 12:06:04 -03:00
cataloguing Bug 6536: Include SRU searching in Breeding.pm 2014-09-01 10:09:07 -03:00
circ Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page 2014-09-17 19:23:16 -03:00
course_reserves Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
debian Bug 11577: Add an automatic renewal cronjob 2014-09-17 19:23:23 -03:00
docs Bug 7143 Updating history 2014-08-19 09:38:23 -03:00
errors Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
etc Bug 12453 - Do not use by default Host-Item-Number in UNIMARC 2014-08-24 12:32:30 -03:00
install_misc Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
installer Bug 7372: (follow-up) does execute this DB entry twice 2014-09-23 15:29:58 -03:00
Koha Bug 11577: Update DBIx 2014-09-17 21:10:27 -03:00
koha-tmpl Bug 12162 - Add class="branchcode" to body tag to make OPAC CSS-styleable per branch 2014-09-23 15:39:31 -03:00
labels Bug 11614: Untranslatable label_element_title in label management 2014-08-19 09:42:42 -03:00
members Bug 12693 - colspan calculation done by members/statistics.pl should be moved to template 2014-08-11 15:47:14 -03:00
misc Bug 11577: Add an automatic renewal cronjob 2014-09-17 19:23:23 -03:00
offline_circ Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
opac Bug 12876 - Reserve in waiting/transfer status may be cancelled by user 2014-09-23 20:46:50 -03:00
OpenILS
patron_lists Bug 10565: (follow-up) add new user permission for patron list management 2013-10-14 22:43:03 +00:00
patroncards Bug 5502 - Patron card category search field should be menu 2014-08-10 09:30:47 -03:00
plugins Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
reports Bug 11672: Untranslatable dropdown on Guided Reports and dictionary 2014-09-23 15:32:21 -03:00
reserve Bug 12287: At the moment, found is 'W', 'T' or NULL 2014-08-16 09:06:51 -03:00
reviews Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
rotating_collections Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
selenium
serials Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
services Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
suggestion Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
svc Bug 12729 - Overdue items won't show as overdue in red in circulation 2014-09-16 15:17:53 -03:00
t Bug 12876 - Reserve in waiting/transfer status may be cancelled by user 2014-09-23 20:46:50 -03:00
tags Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
test Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
tmp/modified_authorities
tools Bug 12859 - Patron import tool doesn't import extened attributes values any longer 2014-09-16 15:09:35 -03:00
virtualshelves Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
xt Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess
.mailmap Bug 12479: (QA followup) minor fixes, and tcohen added 2014-06-30 10:04:10 -03:00
about.pl Bug 12790 - Perl modules: Display required version numbers on about page 2014-09-05 10:16:17 -03:00
changelanguage.pl
edithelp.pl Bug 11661: sanitize file names supplied to edithelp.pl 2014-02-05 01:36:10 +00:00
fix-perl-path.PL
help.pl Bug 11238: contruct links to the appropriate manual version dynamically 2013-11-23 19:30:16 +00:00
INSTALL
install-CPAN.pl
INSTALL.debian
INSTALL.fedora7 Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.opensuse Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
koha_perl_deps.pl
kohaversion.pl Bug 12728: DBRev 3.17.00.025 2014-09-17 21:33:49 -03:00
LICENSE
mainpage.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
Makefile.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00
MANIFEST.SKIP
README
README.robots
rewrite-config.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/