Main Koha release repository https://koha-community.org
Find a file
Owen Leonard ec9fc2fce4 Bug 9887 [Revised] Use DataTables on circulation page
The circulation page, when the  UseTablesortForCirc preference is
enabled, uses the old tablesorter plugin. It should use DataTables
instead.

This patch removes references to the tablesorter plugin and makes these
changes to enable use of DataTables:

- Pass two new unformatted date variables to the template from
  circulation.pl so that sorting can be performed on this data.
- Add DataTables configurations for the table of checkouts and the
  table of relatives' checkouts.
- Add a new plugin to the main DataTables configuration script to allow
  sorting on data embedded in a <span>'s 'title' attribute.
- Add <span>s to each table with a title attribute containing the
  unformatted date data which DataTables needs to perform correct
  sorting.  This eliminates the need for a special sorting algorithm to
  accomodate various date and datetime formatting options.
- Set a template variable for checking whether circ exports are enabled.
  This reduces repetition. DataTables configuration changes based on how
  many columns are present.

To test, load the circulation page for patrons who match various
conditions:

- Having only checkouts from today
- Having checkouts from today and previous days
- Having checkouts only from previous days
- Having relatives who have checkouts (from today, from previous days,
  from both)

Test these situations with UseTablesortForCirc enabled and disabled.
Test these situations with circ exports enabled or disabled (with
ExportRemoveFields filled or empty, for instance).

Sorting should work correctly on all columns with the dateformat
preference set to any option.

All other circulation functions should work normally.

Revision adds missing include for table footer when there are previous
checkouts and removes &nbsp; from empty table header cells which were
messing up auto-detection of numeric data. The global CSS for table
borders has been tightened up to improve handling of alternating row
colors in DataTables-sorted tables.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass.
Note: Don't forget it's the checkout tab and to turn on the
preference to allow sorting there.
Also, while checkouts sorts dates correctly, sorting on the
details tabs was not always correct in my tests.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2013-04-15 09:10:09 -04:00
acqui Bug 9986: Two fixes for Z3950 search 2013-04-15 08:44:11 -04:00
admin Bug 6554: Followup for preferences.pl 2013-04-01 18:51:50 -04:00
authorities Bug 6554 - make Koha internally utf-8 clean 2013-04-01 18:51:49 -04:00
basket Bug 9073 - Download option from the cart should match the menu button in lists 2012-11-25 18:08:46 -05:00
C4 Bug 9986: Two fixes for Z3950 search 2013-04-15 08:44:11 -04:00
catalogue Bug 6554 - make Koha internally utf-8 clean 2013-04-01 18:51:49 -04:00
cataloguing Bug 9986: Two fixes for Z3950 search 2013-04-15 08:44:11 -04:00
circ Bug 9887 [Revised] Use DataTables on circulation page 2013-04-15 09:10:09 -04:00
debian Bug 9885 Passwords generated by command line scripts are weak 2013-03-30 21:39:43 -04:00
docs Add Aaron Wells to history as committer #207 2013-03-30 20:41:00 -04:00
errors
etc Bug 9812 - Forbid access to several files through the browser 2013-04-07 13:43:05 -04:00
install_misc Bug 9914: dependency updates for 3.12 2013-03-23 10:46:07 -04:00
installer Bug 9414 - Fix sample letters for German and Norwegian 2013-04-15 08:52:35 -04:00
Koha Bug 9971 - Plugins system is broken! 2013-04-03 06:02:09 -04:00
koha-tmpl Bug 9887 [Revised] Use DataTables on circulation page 2013-04-15 09:10:09 -04:00
labels Bug 8943 - Add table sorting to labels - Followup - Sort pulldowns in batch export. 2013-03-31 08:33:42 -04:00
members Bug 6554 - make Koha internally utf-8 clean 2013-04-01 18:51:49 -04:00
misc Bug 8200: Follow up - Removing unused file stats.pl 2013-04-07 13:38:06 -04:00
offline_circ Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly. 2013-03-21 20:35:37 -04:00
opac Bug 7853 - opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding 2013-04-07 13:34:12 -04:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patroncards Bug 9695 - Use alphabet system preference on page used to browse patrons for patron card batches 2013-03-13 08:43:25 -04:00
plugins Bug 7804 - Add Koha Plugin System - QA Followup 2 2013-03-20 14:50:19 -04:00
reports Bug 6554 - make Koha internally utf-8 clean 2013-04-01 18:51:49 -04:00
reserve Bug 6554 - make Koha internally utf-8 clean 2013-04-01 18:51:49 -04:00
reviews
rotating_collections Bug 9605: rotating collections permissions are wrong 2013-03-30 22:11:05 -04:00
selenium
serials Bug 6554: Followup for serial search 2013-04-01 18:51:50 -04:00
services
skel Bug 7804 - Add Koha Plugin System 2013-03-20 14:49:47 -04:00
sms
suggestion Bug 9226: Wrong branch filter after suggestion creation 2013-02-15 08:34:11 -05:00
svc Bug 9908 - Fixing OCLC Connexion Client 2013-03-29 21:29:10 -04:00
t Bug 9937: Add new unit tests for new routines (introduced by bug 5343) 2013-03-30 17:05:15 -04:00
tags bug 9401: remove direct reads of CGISESSID cookie by JavaScript 2013-02-01 11:05:35 -05:00
test
tmp/modified_authorities
tools Bug 9917 - Routing list tab on patron account should depend on syspref/permission 2013-03-31 08:52:35 -04:00
virtualshelves Bug 7788: [SIGNED-OFF] Followup: GetShelf call in addbybiblio script corrected 2012-05-22 12:06:26 +02:00
xt Bug 9802 - add test case to ensure man pages have correct XML 2013-03-20 15:11:10 -04:00
.htaccess
.mailmap
about.pl Bug 7440 - Remove NoZebra vestiges 2013-03-19 21:17:04 -04:00
changelanguage.pl
edithelp.pl Bug 8622: Fix theme fallback 2012-09-05 11:39:14 +02:00
fix-perl-path.PL
help.pl Bug 8949: Trying to view help on a page without any help results in a nasty error 2012-11-05 08:39:23 -05:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
install-CPAN.pl
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 7440 - Remove NoZebra vestiges 2013-03-19 21:17:04 -04:00
INSTALL.opensuse Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.ubuntu Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.ubuntu.12.04 Bug 9267 - Ubuntu 12.04 install docs broken 2013-03-07 09:46:55 -05:00
INSTALL.ubuntu.lucid Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
koha_perl_deps.pl Bug 8485 - Make koha_perl_deps.pl batch friendly Added a -b flag for brief which outputs only the perl library name (Foo::BaR), and added a -r flag for required which filters the list to required=Yes perl libraries. 2012-08-31 17:35:49 +02:00
kohaversion.pl Bug 9381: Increment version number 2013-04-07 13:48:46 -04:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Revert "Bug 7167: New version for updatedatabase" 2012-12-27 14:02:56 -05:00
Makefile.PL Bug 9890 - Fix the new plugin system for package installs 2013-03-22 16:54:04 -04:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots
rewrite-config.PL Bug 7804 - Add Koha Plugin System 2013-03-20 14:49:47 -04:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/