Koha/misc
Nick Clemens 02a404ef42 Bug 27819: Spurious item deletion errors from delete_records_via_leader.pl
The job reports errors when deleting items.

The issue seems to be that Koha::Object->delete claims in the POD to
return -1, 0, or 1 as a result, but it in fact returns the Object
itself on a successful deletion

The errors are reported as:
ERROR DELETING ITEM 501740: Koha::Item=HASH(0x55ce407a1a78)

To recreate:
 1 - Find or create a record with some items
 2 - Ensure those  items can be deleted (not on loan, etc.)
 3 - Edit the record leader and set position 5 to 'd'
 4 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm
 5 - Deletion succeeds, but reports failure on items
 6 - Apply patch
 7 - Find or create a new record as above, but this time add an
     additional item and check it out to a patron
 8 - perl misc/cronjobs/delete_records_via_leader.pl -i -v
 9 - Test mode should report 1 item to be deleted, one with error
10 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm
11 - One item should be deleted, one item not, record not deleted
12 - check the item in
13 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm
14 - Successful deletion with no error reported

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-04-28 11:16:14 +02:00
..
admin Bug 22824: Fix encoding of misc/admin/koha-preferences output 2021-03-04 16:18:42 +01:00
bin Bug 20410: Remove OpacGroupResults and PazPar2 2021-02-08 16:12:42 +01:00
cronjobs Bug 27819: Spurious item deletion errors from delete_records_via_leader.pl 2021-04-28 11:16:14 +02:00
devel Bug 25549: Remove plugin methods for broken plugins 2020-10-22 10:04:30 +02:00
interface_customization
load_testing
maintenance Bug 27963: (bug 23463 follow-up) Fix touch_all_items.pl 2021-04-01 17:13:56 +02:00
migration_tools Bug 28028: Remove misc/migration_tools/fix_onloan.pl 2021-04-21 10:51:29 +02:00
release_notes Correct Ubuntu versions in release notes - md 2020-11-30 11:19:35 +01:00
search_tools Bug 26312: (follow-up) Fix passing of exception messages 2021-04-16 11:48:31 +02:00
translator Bug 28154: Fix encoding issues on Koha-installer.pot 2021-04-16 13:53:54 +02:00
add_date_fields_to_marc_records.pl Bug 22509: (RM follow-up) Add use of Koha::Script base class 2019-06-24 15:08:33 +01:00
background_jobs_worker.pl Bug 22417: Process the jobs even if the message broker is not reachable 2020-10-05 15:26:36 +02:00
batchCompareMARCvsFrameworks.pl
batchdeletebiblios.pl
batchDeleteUnusedSubfields.pl
batchImportMARCWithBiblionumbers.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
batchRebuildBiblioTables.pl
batchRebuildItemsTables.pl
batchRepairMissingBiblionumbers.pl Bug 25306: Remove framework paramter from ModBiblioMarc 2021-01-12 16:13:50 +01:00
check_sysprefs.pl
commit_file.pl
export_borrowers.pl Bug 27486: Rename system preference delimiter to CSVDelimiter 2021-01-29 09:03:45 +01:00
export_records.pl
exportauth.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
import_patrons.pl Bug 27586: Import patrons script has a confirm switch that doesn't nothing! 2021-02-08 14:55:59 +01:00
koha-install-log Bug 20410: Remove OpacGroupResults and PazPar2 2021-02-08 16:12:42 +01:00
kohalib.pl
link_bibs_to_authorities.pl Bug 26641: Optimize CatalogModuleRelink lookup 2020-11-04 12:59:34 +01:00
load_yaml.pl
mod_zebraqueue.pl
perlmodule_ls.pl
perlmodule_rm.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
recreateIssueStatistics.pl
sax_parser_print.pl Bug 17626 (QA followup) 2016-11-22 11:29:07 +00:00
sax_parser_test.pl
sip_cli_emulator.pl Bug 26459: (follow-up) Clarify language and remove duplicated code 2021-04-07 16:08:04 +02:00
stage_file.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
z3950_responder.pl