Main Koha release repository https://koha-community.org
Find a file
Nick Clemens eeb115440a
Bug 32804: Do not adjust biblionumber when replacing items during import
This patch adjust the item matching at import to confirm that for a duplicate itemnumber or barcode
matches an existing item in the DB and uses the original biblionumber when updating the item.

When ordering in a consortium the items may be moved around, duplicate biblios added, and various matches found.
We should not allow importing of items to move them from 1 biblio to another, but  we should allow the imports
to succeed and assume itemnumber or barcode matches are authoritative. The responsibility for correct matching of items to biblio should fall on the creator of the files

To test:
 1 - Be using the sample data in koha testing docker
 2 - Stage the sample file on this report
 3 - Match on KohaBiblio(999$c) / Item processing: replace
 4 - Note the biblio match is "The complete novels / Austen, Jane"
 5 - View the staged marc, note the barcode 39999000004090 in an item
 6 - Search for that barcode
 7 - You find biblio "Five novels : complete and unabridged / Gustave Flaubert"
 8 - Import the file
 9 - Check the db:
     SELECT * FROM items WHERE biblionumber != biblioitemnumber;
10 - Note the mismatch
11 - Fix the item and set it as 'Music' type
     UPDATE items SET biblionumber = biblioitemnumber, itype='MU' WHERE biblionumber != biblioitemnumber;
12 - Apply patch, restart all
13 - Stage and import the file with the same settings
14 - Confirm the item is modified on its original biblio (99) and that item type is Book again
15 - Change itemnumber to avoid itemnumber match and reset type
     UPDATE items SET itype='MU', itemnumber=999 WHERE itemnumber=212;
16 - Stage and import with the same setttings
17 - Confirm the marcode match worked and item is updated to book on original record
18 - Delete the original item
19 - Stage and import the file with the same settings
20 - The item is successfully created
21 - Stage and import, but item processing option is 'add'
22 - Confirm 1 item ignored
23 - Check the db
     SELECT * FROM import_items WHERE barcode=39999000004090
24 - Confirm there is a line with 'error' and duplicate_barcode

JD amended patch
-        # We assume that when replaicing tiems we do not want to move them - the onus is on the importer to
+        # We assume that when replacing items we do not want to move them - the onus is on the importer to

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-03-17 09:59:11 -03:00
acqui Bug 32705: Display the column if 1 order has an invoice price 2023-03-06 14:04:12 -03:00
admin Bug 32421: Add collection column to holds to pull 2023-03-14 09:06:14 -03:00
api Bug 32734: Add REST endpoint to list biblios 2023-03-13 15:12:04 -03:00
authorities Bug 30250: Use ApplyFrameworkDefaults when importing a record 2022-11-09 14:03:22 -03:00
basket Bug 16522: (follow-up) MARC display templates and get_marc_host fixes 2023-01-30 12:10:11 -03:00
bin
C4 Bug 32804: Do not adjust biblionumber when replacing items during import 2023-03-17 09:59:11 -03:00
catalogue Bug 33070: Remove use of can_edit_items 2023-03-17 09:59:02 -03:00
cataloguing Bug 33070: Remove use of can_edit_items 2023-03-17 09:59:02 -03:00
circ Bug 32421: Add collection column to holds to pull 2023-03-14 09:06:14 -03:00
clubs Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
course_reserves Bug 20256: Use new methods 2023-02-02 11:59:26 -03:00
debian Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs simultaneously up to a limit 2023-03-06 13:57:53 -03:00
docs 22.11.00: Update history.txt 2022-11-25 15:20:02 -03:00
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI 2022-04-20 09:03:39 -10:00
etc Bug 32684: Implement SIP patron status field "too many items lost" 2023-03-14 08:49:29 -03:00
ill Bug 28909: Allow illview to use backend template 2022-08-09 13:21:39 -03:00
installer Bug 33059: Fix capitalizatoin of AV sample category descriptions 2023-03-17 09:59:09 -03:00
Koha Bug 33070: Remove use of can_edit_items 2023-03-17 09:59:02 -03:00
koha-tmpl Bug 33082: Add yellow buttons and page sections to 'copy order' pages 2023-03-17 09:59:04 -03:00
labels Bug 31633: (follow-up) Group template params 2022-10-03 14:09:59 -03:00
lib/CGI/Session/Serialize
members Bug 31095: Remove GetDebarments from members/memberentry.pl 2023-01-31 10:19:36 -03:00
misc Bug 29354: Make overdue_notices.pl send .html 2023-03-14 08:49:31 -03:00
offline_circ Bug 30016: Remove GetOpenIssue subroutine 2022-08-31 08:50:37 -03:00
opac Bug 32674: Fix placing a hold at the OPAC for serials 2023-03-06 09:51:44 -03:00
patron_lists
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins
pos Bug 30619: Add email receipt to POS 2022-09-07 15:59:34 -07:00
recalls Bug 30924: Add missing branchtransfers.reason value for recall cancellation 2022-06-13 10:30:51 -03:00
reports Bug 32613: (follow-up) Cache the tables 2023-03-06 14:45:30 -03:00
reserve Bug 32909: Load item type icons from the correct path 2023-02-15 09:21:20 -03:00
reviews
rotating_collections
serials Bug 29608: Made so doesn't require full permission 2022-09-07 13:49:53 -07:00
services
skel
suggestion Bug 32531: Restore behaviour of 'include archived' filter 2023-01-05 09:22:58 -03:00
svc Bug 15869: Change framework on overlay 2023-02-07 10:32:22 -03:00
t Bug 32804: Add unit tests 2023-03-17 09:59:09 -03:00
tags Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
tmp/modified_authorities
tools Bug 30869: Add the ability to delete stock rotation rotas 2023-02-24 17:52:23 -03:00
virtualshelves Bug 16522: (follow-up) MARC display templates and get_marc_host fixes 2023-01-30 12:10:11 -03:00
xt Bug 32741: Regression tests 2023-02-02 11:59:26 -03:00
.editorconfig
.eslintrc.json
.gitignore Bug 32609: Add compiled css files to gitignore 2023-02-10 11:07:52 -03:00
.htaccess
.mailmap Bug 32582: Fix error in .mailmap 2023-01-17 09:27:15 +00:00
.perlcriticrc
.proverc.dist
.stylelintrc.json Bug 31528: (follow-up) A few additional rules 2022-10-03 08:23:15 -03:00
about.pl Bug 3831: Add a warning to about page when there is no FA framework 2023-03-10 10:19:05 -03:00
app.psgi
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl
cpanfile Bug 32558: (QA follow-up) Move ForkManager to required 2023-03-07 11:03:32 -03:00
cypress.json Bug 32030: Move cypress to t/ 2022-11-08 09:44:51 -03:00
fix-perl-path.PL
gulpfile.js Bug 32978: Replace node-sass with dart-sass 2023-02-22 10:03:39 -03:00
help.pl
INSTALL
Koha.pm Bug 32057: DBRev 22.12.00.013 2023-03-14 08:58:37 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 31028: Add ability to report concerns from the staff interface 2023-03-06 11:23:17 -03:00
Makefile.PL Bug 32806: (follow-up) Rename main.js to erm.js 2023-02-27 11:12:01 -03:00
MANIFEST.SKIP
package.json Bug 32978: Replace node-sass with dart-sass 2023-02-22 10:03:39 -03:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 32806: Move main-erm.ts to modules/erm.ts 2023-02-27 11:12:01 -03:00
yarn.lock Bug 32978: Updated yarn.lock 2023-02-22 10:03:40 -03:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo