Main Koha release repository https://koha-community.org
Find a file
Jonathan Druart efa3525c8d
Bug 23590: Add ability to edit the manager of a suggestion
Prior to this patch there was an hidden behavior that set the manager to
the logged in user when a suggestion was edited. This patch proposes to
let the librarian pick another manager.
Other small adjustements will be added to polish this new behavior:
 * Create 2 new DB columns: suggestions.lastmodificationby and
 suggestion.lastmodificationdate
 * Choose a manager when editing a suggestion
 * Batch modify suggestions and set a manager for them
 * Let notify the new manager using the TO_PROCESS letter
 * Display the manageddate, lastmodificationby and lastmodificationdate
 info where appropriate

This first patch adds a new "Select manager" link when editing a
suggestion.

Test plan for the whole patchset:
0/
  a. Execute the update DB entry, generate the new DBIC file and restart all
  b. Create at least 2 patrons with the suggestions_manage permission
1/ Submit a new suggestion (OPAC or staff, not important)
2/ Accept it
3/ Edit it
=> "Last modification by" is empty
=> You see that you are the manager of this suggestion
4/ Click "Select manager" and search for a new manager
=> The patron search will only display patrons with the
suggestions_manage permission
5/ Save
6/ Edit again
=> The manager is set to you, but there is a note saying that previously
it was the patron you picked
=> The "Last modification by" is set to you
7/ Click "Keep existing manager"
=> The manager is now set to the previous manager
8/ Select another manager (which has a valid email address defined)
9/ Click the "notify" checkbox
10/ Save
11/ Confirm that a TO_PROCESS notice has been generated into the
message_queue table
12/ Create at least one other suggestion
13/ List the suggestions
=> There is a 4th action column to assign a manager to several
suggestions in one go.
14/ Use this new button and confirm that it works as expected
15/ Go to your purchase suggestion list (OPAC and staff)
=> You see the "managed date" displayed in a new column

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-03-25 09:34:15 +00:00
acqui Bug 24276: Add FillWithDefaultValues call in neworderempty 2020-03-24 11:21:52 +00:00
admin Bug 13881: (QA follow-up) Check for manage_libraries permission 2020-03-25 09:19:34 +00:00
api/v1 Bug 24476: Rename autorenewal to autorenew_checkouts 2020-03-24 11:23:54 +00:00
authorities Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
basket
C4 Bug 24476: Rename autorenewal to autorenew_checkouts 2020-03-24 11:23:54 +00:00
catalogue Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
cataloguing Bug 22098: (QA follow-up) Improving documentation 2020-03-24 10:55:59 +00:00
circ Bug 24837: Rename selectbranchprinter.pl to set-library.pl 2020-03-24 11:07:22 +00:00
clubs Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
course_reserves
debian Bug 24052: Add koha_xslt_security to koha-conf.xml 2020-03-24 10:42:23 +00:00
docs Koha 19.12 - Dobbie is a free elf... 2019-12-02 17:13:15 +00:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 24052: Add koha_xslt_security to koha-conf.xml 2020-03-24 10:42:23 +00:00
ill Bug 23112: Add circulation to ILL requests 2020-03-10 10:58:58 +00:00
installer Bug 13881: DBRev 19.12.00.054 2020-03-25 09:29:46 +00:00
Koha Bug 22771: (QA follow-up) Fix POD 2020-03-25 09:31:46 +00:00
koha-tmpl Bug 23590: Add ability to edit the manager of a suggestion 2020-03-25 09:34:15 +00:00
labels Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
members Bug 24476: Allow patrons to opt out of auto-renewal 2020-03-24 11:23:47 +00:00
misc Bug 24476: Rename autorenewal to autorenew_checkouts 2020-03-24 11:23:54 +00:00
offline_circ Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
opac Bug 24754: (QA follow-up) Add timestamp, remove 11th parameter 2020-03-25 09:32:48 +00:00
patron_lists
patroncards Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
plugins Bug 23975: (follow-up) Don't rely on save_to being present 2020-03-03 09:19:04 +00:00
pos Bug 24492: (RM follow-up) Redirect to correct page after cashup 2020-03-05 14:16:58 +00:00
reports Bug 20443: Use search_with_library_limits for attribute types 2020-03-23 13:49:22 +00:00
reserve Bug 24802: Updating holds can cause suspensions to apply to wrong hold 2020-03-06 09:56:40 +00:00
reviews
rotating_collections
serials Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
services
skel
suggestion Bug 23590: Add ability to edit the manager of a suggestion 2020-03-25 09:34:15 +00:00
svc Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
t Bug 22771: Respect nonfiling indicators for search fields 2020-03-25 09:31:24 +00:00
tags
tmp/modified_authorities
tools Bug 20443: Use search_with_library_limits for attribute types 2020-03-23 13:49:22 +00:00
virtualshelves Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
xt Bug 24583: adjust xt/sample_notices.t 2020-03-09 15:19:01 +00:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json
.gitignore
.htaccess
.mailmap
.scss-lint.yml
about.pl Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
changelanguage.pl
cpanfile Bug 24573: Add missing dependencies to cpanfile 2020-03-06 09:58:54 +00:00
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 13881: DBRev 19.12.00.054 2020-03-25 09:29:46 +00:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 19735: Move Perl deps definitions into a cpanfile 2020-02-12 16:33:02 +00:00
MANIFEST.SKIP
package.json Bug 23025: security vulnerability detected in fstream < 1.0.12 defined in yarn.lock 2019-11-27 11:30:17 +00:00
README
README.md
README.robots
rewrite-config.PL
yarn.lock Bug 23025: Update yarn.lock 2019-11-27 11:30:17 +00:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo