Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
39602 commits 35 branches 612 tags 1.8 GiB
Perl 45.3%
JavaScript 39.4%
HTML 7.2%
XSLT 3.9%
Vue 1.4%
Other 2.3%
Find a file
Nick Clemens f1c2974d7b Bug 25969: Don't set itemnumber as reserve->itemnumber 
When a hold is checked in at the wrong destination we revert the found status
For a title level hold this means we return it to a title level hold, with no itemnumber

When we checkin the item we find the hold, but won't set the itemnumber in the hold until it is confirmed

In the script we were setting the itemnumber param, but then setting it again using the reserve itemnumber.
In all conditions before the itemnumber has been set, we don't need to set it again, especially when we do
so incorrectly

To test:
- Log in at Library A
- Place hold on item at Library A, for pickup at Library A
- Check item in at Library A
- Click "Confirm hold"
- Set library to Library B
- Check item in again (try with both the box on reutrns.pl and the box in the header)
- Click "Confirm hold and transfer"
- get error: Can't call method "biblio" on an undefined value at /kohadevbox/koha/circ/returns.pl line 147
- apply patch
- repeat
- success!
- confirm trappings of holds works as normally otherwise too

Signed-off-by: Daniel Gaghan <daniel.gaghan@pueblolibrary.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-09-18 10:38:09 +02:00
acqui Bug 23682: Fix use Koha::Plugins::Handler statements 2020-09-03 15:00:48 +02:00
admin Bug 23816: Add minimum password length and require strong password overrides by category 2020-09-09 15:39:52 +02:00
api Bug 26271: Add null to the list of accepted account_line data types 2020-09-03 14:18:23 +02:00
authorities Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
basket Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
C4 Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
catalogue Bug 15851: (QA follow-up) Fix booleans to uppercase to make this work for Elasticsearch and UseControlNumber 2020-09-03 14:18:23 +02:00
cataloguing Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
circ Bug 25969: Don't set itemnumber as reserve->itemnumber 2020-09-18 10:38:09 +02:00
clubs Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
course_reserves Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
debian Bug 25541: (QA follow-up) Default to disabled + Correct message 2020-09-03 14:18:23 +02:00
docs Bug 26179: Add Timothy Alexis Vass to contributors 2020-08-13 08:09:10 +02:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 25541: (QA follow-up) Default to disabled + Correct message 2020-09-03 14:18:23 +02:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 26007: (QA follow-up) Fix English yml file 2020-09-11 09:56:56 +02:00
Koha Bug 26470: Store the item before calling the after action hook 2020-09-18 10:38:01 +02:00
koha-tmpl Bug 26269: Fix variable name mismatch for cash_register in paycollect 2020-09-18 10:38:04 +02:00
labels Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
members Bug 26269: Fix variable name mismatch for cash_register in paycollect 2020-09-18 10:38:04 +02:00
misc Bug 26420: Use translated notices for overdue_notices.pl 2020-09-18 10:38:05 +02:00
offline_circ Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
opac Bug 23816: Add minimum password length and require strong password overrides by category 2020-09-09 15:39:52 +02:00
patron_lists Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
patroncards Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
plugins Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
pos Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
reports Bug 17801: Use issuedate for limits in Most Circulated Items 2020-09-03 14:18:23 +02:00
reserve Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
reviews Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
rotating_collections Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
serials Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 25033: (follow-up) Don't limit suggestions to branches if displaying by branch 2020-08-25 11:31:42 +02:00
svc Bug 26331: Make svc/letters/preview executable 2020-09-03 13:40:00 +02:00
t Bug 26470: Regression tests 2020-09-18 10:38:01 +02:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools Bug 24663: Fix one missing occurrence 2020-09-09 15:39:51 +02:00
virtualshelves Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
xt Bug 26384: (QA follow-up) Fix two exceptions 2020-09-11 09:56:56 +02:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Bug 26394: Update .mailmap 2020-09-11 09:56:56 +02:00
.perlcriticrc Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
cpanfile Bug 25723: Drop DateTime::Set from cpanfile 2020-07-20 17:45:31 +02:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 23816: DBRev 20.06.00.037 2020-09-09 15:39:52 +02:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
Makefile.PL Bug 26265: Add missing xt dir 2020-08-24 12:30:53 +02:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
package.json Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-07-21 14:34:25 +02:00
yarn.lock Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo