Main Koha release repository https://koha-community.org
Find a file
Aleisha Amohia f406aa2ae3
Bug 24266: (alternate patch) Only use defined borrowernumbers in reconcile_balances.pl cron
I believe the error is triggered when borrowernumbers are left empty in
the accountlines table. Not sure why this would happen, but it appears
to be what causes the problem.

Do not apply the first patch if testing this patch.

To test:
1) sudo koha-mysql INSTANCENAME
2) Create a test borrower, add any payment etc to create an accountline,
    then delete this borrower
3) ensure the AccountAutoReconcile syspref is disabled
4) Go to another borrower's accounting tab
5) Create a manual credit or debit. Confirm this shows in the 'Make a
payment' tab as an amount that COULD be applied, but isn't automatically
applied
6) in your terminal, run the reconcile_balances.pl script
7) Confirm the error does not show in the logs and the balance for
the borrower is correctly reconciled.

Sponsored-by: Horowhenua District Council
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-04-14 08:21:31 +01:00
acqui Bug 18177: remove aqbooksellers.booksellerurl 2020-03-27 12:15:47 +00:00
admin Bug 4461: Fix status and borrowernumber fields in problem_reports and more 2020-04-06 11:18:59 +01:00
api/v1 Bug 24476: Rename autorenewal to autorenew_checkouts 2020-03-24 11:23:54 +00:00
authorities Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
basket
C4 Bug 25095: Remove warn left in FeePayment.pm 2020-04-14 08:20:53 +01:00
catalogue Bug 20415: Remove UseKohaPlugins system preference 2020-03-26 11:42:02 +00:00
cataloguing Bug 24027: Call ModZebra once after all items added/deleted in a batch 2020-04-14 08:14:42 +01:00
circ Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
clubs Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-03-23 09:51:36 +00:00
debian Bug 18227: (QA follow-up) Add fix to koha-common.postinst 2020-04-06 11:02:27 +01:00
docs
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 18227: Handle utf8 in Koha::Logger 2020-04-06 11:02:14 +01:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Koha Bug 24027: Add POD about the new parameter in Koha::Item->store 2020-04-14 08:15:19 +01:00
koha-tmpl Bug 7046: (RM follow-up) Add Filters 2020-04-08 13:18:46 +01:00
labels Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
members Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
misc Bug 24266: (alternate patch) Only use defined borrowernumbers in reconcile_balances.pl cron 2020-04-14 08:21:31 +01:00
offline_circ Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
opac Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
plugins Bug 20415: Remove UseKohaPlugins system preference 2020-03-26 11:42:02 +00:00
pos Bug 24492: (RM follow-up) Varaible name corretion 2020-04-06 10:38:00 +01:00
reports Bug 24940: Serials statistics wizard: order vendor list alphabetically 2020-04-08 11:46:21 +01:00
reserve Bug 16547: Do not display "multi holds" view if only one is selected 2020-04-06 10:41:02 +01:00
reviews
rotating_collections
serials Bug 25081: Fix wrong comment 2020-04-08 11:53:37 +01:00
services
skel
suggestion Bug 23590: Create a separate template notice NOTIFY_MANAGER 2020-03-25 09:35:46 +00:00
svc Bug 4461: Fix status and borrowernumber fields in problem_reports and more 2020-04-06 11:18:59 +01:00
t Bug 22778: Add unit test 2020-04-14 08:19:34 +01:00
tags
tmp/modified_authorities
tools Bug 4461: (follow-up) Creating sample notice and other fixes 2020-04-06 11:16:38 +01:00
virtualshelves
xt Bug 24583: adjust xt/sample_notices.t 2020-03-09 15:19:01 +00:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
.mailmap
.scss-lint.yml
about.pl Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00
changelanguage.pl
cpanfile Bug 24573: Add missing dependencies to cpanfile 2020-03-06 09:58:54 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
INSTALL
Koha.pm Bug 20754: DBRev 19.12.00.067 2020-04-06 12:28:58 +01:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl
LICENSE
mainpage.pl Bug 4461: Fix status and borrowernumber fields in problem_reports and more 2020-04-06 11:18:59 +01:00
Makefile.PL
MANIFEST.SKIP
package.json
README
README.md
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo