Main Koha release repository https://koha-community.org
Find a file
Mark Tompsett f5320c4bf8 Bug 12330: OpacHiddenItems not affecting Advanced Search
This patch affects only the area displayed on Advanced Search
by setting the AdvancedSearchTypes OPAC system preference
accordingly. Prior to this patch, no filtering based on
OpacHiddenItems was done. This patch determines if itemtypes,
collections, or shelving locations are hidden and prevents
them from being shown.

TEST PLAN
---------
 1) Back up your DB (always handy)
 2) Set the Searching system preference AdvancedSearchTypes to:
    'itemtypes|ccode|loc' (without the single quotes).
 3) Set the OPAC system preference OpacHiddenItems to include the
    lines:
     itype: [{list of itemtype codes separated by commas}]
     location: [{list of comma delimited shelving location codes}]
     ccode: [{list of comma delimited collection codes}]
    Make sure to exclude one value for each, so there will be at
    least one known thing on each tab.
 4) Open the OPAC.
 5) Click on 'Advanced Search'
    -- three tabs appear: Itemtypes, Collection, Shelving location
    -- Everything is visible
 6) Set the Searching system preference AdvancedSearchTypes to:
    'itemtypes | ccode |     loc' (without the single quotes).
 7) Refresh the OPAC.
    -- There will be three tabs, but ugliness ensues.
 8) Apply the patch
 9) Refresh the OPAC.
    -- You will see: Itemtypes, Collection, Shelving location
    -- Only excluded values from OpacHiddenItems will be seen.
10) Run koha qa test tools

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
All tests pass

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Small rewording in comment only.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2014-09-05 12:05:58 -03:00
acqui Bug 6536: Include SRU searching in Breeding.pm 2014-09-01 10:09:07 -03:00
admin Bug 7498 - Cloning a budget, enable change of description 2014-09-05 10:21:30 -03:00
authorities Bug 12177 - Remove HTML from authorities.pl 2014-08-19 09:27:08 -03:00
basket Bug 9013 - Cart in staff interface displays location pulled from Description (OPAC) 2014-08-11 15:53:31 -03:00
C4 Bug 8735 - Expire holds waiting only on days the library is open - Followup - Switch from C4::Calendar to Koha::Calendar 2014-09-05 11:51:01 -03:00
catalogue Bug 12675: Remove CGI::scrolling_list from labeledMARCdetail.pl 2014-08-03 16:53:00 -03:00
cataloguing Bug 6536: Include SRU searching in Breeding.pm 2014-09-01 10:09:07 -03:00
circ Bug 12523 - Add patron email in Holds awaiting pickup circulation rapport 2014-08-07 16:18:23 -03:00
course_reserves Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
debian Bug 12869 - update the version in build-git-snapshot 2014-09-05 10:14:14 -03:00
docs Bug 7143 Updating history 2014-08-19 09:38:23 -03:00
errors Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
etc Bug 12453 - Do not use by default Host-Item-Number in UNIMARC 2014-08-24 12:32:30 -03:00
install_misc Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
installer Bug 12864: Add LOC SRU server to sample z3950servers.sql 2014-09-05 11:56:59 -03:00
Koha Bug 6536: (RM followup) make DBIx::Class::Schema::Loader happy 2014-09-01 10:25:25 -03:00
koha-tmpl Bug 8735 [QA Followup 2] - Remove extra period, add bug number to db update 2014-09-05 11:51:09 -03:00
labels Bug 11614: Untranslatable label_element_title in label management 2014-08-19 09:42:42 -03:00
members Bug 12693 - colspan calculation done by members/statistics.pl should be moved to template 2014-08-11 15:47:14 -03:00
misc Bug 12061 - tmpl_process3.pl - Include/exclude file by name 2014-09-01 11:00:15 -03:00
offline_circ Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
opac Bug 12330: OpacHiddenItems not affecting Advanced Search 2014-09-05 12:05:58 -03:00
OpenILS
patron_lists Bug 10565: (follow-up) add new user permission for patron list management 2013-10-14 22:43:03 +00:00
patroncards Bug 5502 - Patron card category search field should be menu 2014-08-10 09:30:47 -03:00
plugins Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
reports Bug 12707: Remove CGI::scrolling_list from some Reports 2014-08-15 14:47:23 -03:00
reserve Bug 12287: At the moment, found is 'W', 'T' or NULL 2014-08-16 09:06:51 -03:00
reviews Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
rotating_collections Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
selenium
serials Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
services Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
suggestion Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
svc Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled 2014-07-30 14:29:29 -03:00
t Bug 8735 [QA Followup] - Add Unit Tests 2014-09-05 11:51:04 -03:00
tags Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
test Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
tmp/modified_authorities
tools Bug 12705 - News not possible for one sublanguage if two sublanguages are installed 2014-09-01 12:34:47 -03:00
virtualshelves Bug 11349: Make the QA script happy 2014-07-17 11:06:06 -03:00
xt Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess
.mailmap Bug 12479: (QA followup) minor fixes, and tcohen added 2014-06-30 10:04:10 -03:00
about.pl Bug 12790 - Perl modules: Display required version numbers on about page 2014-09-05 10:16:17 -03:00
changelanguage.pl
edithelp.pl Bug 11661: sanitize file names supplied to edithelp.pl 2014-02-05 01:36:10 +00:00
fix-perl-path.PL
help.pl Bug 11238: contruct links to the appropriate manual version dynamically 2013-11-23 19:30:16 +00:00
INSTALL
install-CPAN.pl
INSTALL.debian
INSTALL.fedora7 Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.opensuse Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.ubuntu
koha_perl_deps.pl
kohaversion.pl Bug 8735: DBRev 3.17.00.020 2014-09-05 11:52:05 -03:00
LICENSE
mainpage.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
Makefile.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00
MANIFEST.SKIP
README
README.robots
rewrite-config.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/