Koha/C4
Fridolin Somers 28b5880d71 Bug 27683: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref
C4::Items::GetAnalyticsCount is part of the easy analytics feature.
Like Bug 20702 make early return when the system preference EasyAnalyticalRecords is disabled.
Actually it may block an item deletion for wrong reason.

Test plan :
1) Dont apply patch
2) Build an item and a linked analytical record with 773$0 and $9
3) Enable EasyAnalyticalRecords
4) Try to delete the item
5) You have an alert because linked to analytics
6) Disable EasyAnalyticalRecords
7) Try to delete the item
8) You have an alert because linked to analytics
9) Apply patch
10) Try to delete the item
11) No alert, it works :D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit dfc390940d)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2022-08-23 19:38:42 +00:00
..
AuthoritiesMarc
Barcodes Bug 26328: Cast barcode from varchar to integer for incremental barcode 2022-03-23 10:50:51 -10:00
ClassSortRoutine
ClassSplitRoutine
Creators Bug 24001: Fix Card template/rpinter profile creation and edit 2022-04-28 10:49:20 -10:00
External
Form
Heading
ILSDI Bug 29924: Update ILSDI to be aware of expired passwords 2022-05-06 10:33:09 -10:00
Installer Bug 30731: Remove Readonly::XS::MAGIC_COOKIE 2022-06-10 15:18:51 +00:00
Labels
Linker Bug 28676: Cache and retrieve match_count when searching a cached heading 2021-09-20 12:06:56 +02:00
Members
OAI
Output
Patroncards Bug 25459: Makes barcode position respect units in patron cards layout 2021-11-02 16:50:01 +01:00
Reports Bug 29695: Remove C4::Reports::Guided::_get_column_defs 2022-04-12 11:40:16 +02:00
Search Bug 29915: Tiny session adjustments 2022-03-22 10:17:33 -10:00
Serials
SIP Bug 29094: Adding hold via SIP should check if patron can hold item first 2022-08-23 17:12:15 +00:00
Utils Bug 29648: (QA follow-up) Minor POD fix 2022-04-27 11:20:45 -10:00
Accounts.pm
Acquisition.pm Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
Auth.pm Bug 30842: 2FA - Allow at least one old TOTP 2022-06-10 15:01:07 +00:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm Bug 28417: Don't require C4::Auth_with_cas from opac-user if not needed 2021-11-03 15:40:52 +01:00
Auth_with_ldap.pm
Auth_with_shibboleth.pm
AuthoritiesMarc.pm Bug 30464: Make BatchUpdateAuthority update the index in one request 2022-05-05 11:17:36 -10:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm Bug 30789: Improve performance of AddBiblio 2022-07-12 17:34:41 +00:00
Breeding.pm Bug 29391: Improve output of reservoir search 2022-01-09 21:04:17 -10:00
Budgets.pm Bug 24190: (follow-up) Rename AcqLog 2021-09-21 20:22:57 +02:00
Calendar.pm
Charset.pm Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
Circulation.pm Bug 30409: (QA follow-up) Avoid uninitialized variable warnings 2022-07-13 13:50:08 -06:00
ClassSortRoutine.pm Bug 29951: Fix EXPORT for C4::ClassS*Routine modules 2022-08-12 16:52:14 +00:00
ClassSource.pm Bug 29951: Fix EXPORT for C4::ClassS*Routine modules 2022-08-12 16:52:14 +00:00
ClassSplitRoutine.pm Bug 29951: Fix EXPORT for C4::ClassS*Routine modules 2022-08-12 16:52:14 +00:00
Context.pm Bug 30702: Fix Context.pm L785 warning on sessionID 2022-05-06 10:33:10 -10:00
Contract.pm
CourseReserves.pm
Creators.pm
Heading.pm Bug 25616: Uppercase hard coded lower case boolean operators for Elasticsearch 2022-02-24 14:35:36 -10:00
HoldsQueue.pm Bug 29346: Use fully qualified names for C4:Circulation routines in C4::HoldsQueue 2022-05-05 11:17:36 -10:00
HTML5Media.pm Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
ImportBatch.pm Bug 29333: Fix encoding of imported UNIMARC authorities 2022-08-23 15:30:11 +00:00
ImportExportFramework.pm Bug 13952: (follow-up) JS translatability, clean warns, other 2022-04-04 16:23:46 +02:00
InstallAuth.pm Bug 26019: Koha should set SameSite attribute on cookies 2022-04-13 15:55:38 +02:00
Installer.pm Bug 30620: Add a warning about /*!VERSION lines in kohastructure 2022-05-02 11:22:57 -10:00
ItemCirculationAlertPreference.pm Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
Items.pm Bug 27683: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref 2022-08-23 19:38:42 +00:00
Koha.pm Bug 29883: avoid uninitialized value warn in GetAuthorisedValues sub 2022-06-06 15:31:49 +00:00
Labels.pm
Languages.pm
Letters.pm Bug 30781: Fix warning in GetPreparedLetter 2022-06-10 16:33:43 +00:00
Linker.pm
Log.pm Bug 28692: (QA follow-up) Fix test for objects 2021-11-16 14:00:20 +01:00
MarcModificationTemplates.pm
Matcher.pm
Members.pm Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
Message.pm
Output.pm Bug 30969: Cross site scripting (XSS) attack in OPAC authority search ( opac-authorities-home.pl ) 2022-07-25 14:21:14 +00:00
Overdues.pm Bug 30788: Fix warning in Overdues.pm when fine is empty in circ rules 2022-06-10 14:53:54 +00:00
Patroncards.pm
Record.pm Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
Reports.pm
Reserves.pm Bug 12630: Rebase tests and cover CheckReserves 2022-07-15 17:37:46 +00:00
Ris.pm
RotatingCollections.pm
Scheduler.pm
Scrubber.pm
Search.pm Bug 30327: Fix tests 2022-07-29 16:33:21 +00:00
Serials.pm Bug 23352: Set default collection code when creating subscription 2022-05-10 15:17:17 -10:00
Service.pm
ShelfBrowser.pm
SMS.pm
SocialData.pm
Stats.pm Bug 19532: Recalls objects and tests 2022-03-14 22:45:51 -10:00
Suggestions.pm Bug 28855: Purging suggestions test should not be on timestamp 2021-12-15 12:14:47 -10:00
Tags.pm
Templates.pm Bug 26019: Koha should set SameSite attribute on cookies 2022-04-13 15:55:38 +02:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm
UsageStats.pm Bug 30237: Replace AutoEmailOpacUser with AutoEmailNewUser 2022-04-20 09:03:39 -10:00
XISBN.pm
XSLT.pm Bug 30291: Changes to controller scripts 2022-05-05 11:17:36 -10:00