Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/C4
History
Kyle M Hall faab00b88a Bug 13841 - Returns via backdating or SIP2 can create new fines with an amount outstanding of 0 
Due to the way AddReturn and UpdateFine work, if you pass in a return
date to AddReturn, and that item has a calculated fine of 0, Koha will
insert the 0 amount fine into accountlines.

This is good behavior when we want to update an existing fine, but bad
behavior if there was no fine to begin with!

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/Circulation.t
3) Note the test fails
4) Apply this patch
5) prove t/db_dependent/Circulation.t
6) Note the test passes

Signed-off-by: Jen DeMuth <jdemuth@roseville.ca.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Confirmed the problem in the staff interface and that the patch
fixes it. Also tested that fines still get calculated.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2015-03-31 11:36:07 -03:00
..
AuthoritiesMarc
Barcodes Bug 13603 - autoBarcode setting hbyymmincr not taking month into account when looking up next increment 2015-02-13 14:11:59 -03:00
Bookseller
ClassSortRoutine Bug 8837: Dewey cn_sort inaccurate 2014-10-28 09:39:29 -03:00
Creators Bug 13407: Removing depricated code included in PDF::Reuse 2015-01-07 20:18:53 -03:00
External Bug 12858 [QA Followup] - Don't call webservice if we have no data 2015-02-20 10:22:51 -03:00
Form Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
Heading Bug 10308 - local subjects can use authorities too 2014-09-01 10:45:07 -03:00
ILSDI Bug 5786 - Move AllowOnShelfHolds and OPACItemHolds system prefs to the Circulation Matrix 2015-03-25 10:33:14 -03:00
Installer Bug 13601: get rid of DateTime::Format::DateParse 2015-03-30 13:40:00 -03:00
Labels Bug 10773 - Add item-level descriptions for Label Printing 2015-03-30 13:22:35 -03:00
Linker
Members Bug 13194: Fix typo in SetMessagingPreferencesFromDefaults POD 2014-11-06 10:14:13 -03:00
OAI
Output
Patroncards Bug 13709 - Patron cards creator utf-8 encoding and ttf fonts broken 2015-03-19 14:59:33 -03:00
Reports Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
Search Bug 11430: delete search history by id - API changes 2015-03-11 15:02:37 -03:00
Serials
SIP Bug 12820: [QA Followup] Tab and whitespace cleanup 2015-03-25 11:26:12 -03:00
Utils Bug 13894: Make reserve.pl not using C4::Members::Search 2015-03-30 12:56:53 -03:00
VirtualShelves Bug 5786 - Move AllowOnShelfHolds and OPACItemHolds system prefs to the Circulation Matrix 2015-03-25 10:33:14 -03:00
Accounts.pm Bug 12865 - 'Pay amount toward all fines' does not record payment note 2014-11-25 16:38:46 -03:00
Acquisition.pm Bug 12648: (QA followup) Rename aqorderusers to aqorder_users 2015-03-11 11:48:28 -03:00
Auth.pm Bug 10328 - Rename opaccolorstylesheet to OpacAdditionalStylesheet 2015-03-31 11:30:54 -03:00
Auth_cas_servers.yaml.orig
Auth_with_cas.pm Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
Auth_with_ldap.pm Bug 9165: (Followup) Tidied code slightly 2014-11-27 14:58:46 -03:00
Auth_with_shibboleth.pm
AuthoritiesMarc.pm Bug 12861: (follow-up) Noisy warn in error logs 2015-01-21 10:47:47 -03:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm Bug 11944: FIX Error on editing an authority 2015-01-13 13:07:11 -03:00
Bookseller.pm Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller 2014-12-31 14:15:58 -03:00
Boolean.pm
Branch.pm Bug 9350: Making changes so that you can add the new fields to branches 2014-10-27 10:38:16 -03:00
Breeding.pm Bug 11961 - Add a "Z39.50 search" button to the authority creation and modification pages. 2015-01-24 18:19:06 -03:00
Budgets.pm Bug 11714 - GetBudgetHierarchy needs optimization 2014-10-31 16:41:46 -03:00
Calendar.pm
Category.pm
Charset.pm Bug 11944: revert unneeded IsStringUTF8ish behaviour change 2015-01-13 13:07:52 -03:00
Circulation.pm Bug 11201: Display overdues in red 2015-03-31 11:30:55 -03:00
ClassSortRoutine.pm
ClassSource.pm
Context.pm Bug 13645: Use DBIx::Connector 2015-02-20 14:37:08 -03:00
Contract.pm
CourseReserves.pm
Creators.pm
Csv.pm
Dates.pm
Debug.pm Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
Heading.pm
HoldsQueue.pm
HTML5Media.pm
Images.pm
ImportBatch.pm Bug 13222 - Accessors for import_record.status have variable names suggesting overlay_status 2015-01-14 21:27:49 -03:00
ImportExportFramework.pm
Input.pm Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
InstallAuth.pm Bug 10900 - Incorrect calling conventions accessing C4::Context 2015-02-09 17:00:13 -03:00
Installer.pm Bug 11944: replace use of utf8 with Encode 2015-01-13 13:06:45 -03:00
ItemCirculationAlertPreference.pm
Items.pm Bug 5786 - Move AllowOnShelfHolds and OPACItemHolds system prefs to the Circulation Matrix 2015-03-25 10:33:14 -03:00
ItemType.pm Bug 11944: Fix encoding issue in C4::ItemType 2015-01-13 13:07:33 -03:00
Koha.pm Bug 13167 Stage MARC for Import hangs for biblio containing invalid ISBN-13 2015-01-04 11:15:24 -03:00
Labels.pm
Languages.pm
Letters.pm Bug 12739: (QA followup) use 'UTF-8' instead of 'utf8' 2015-03-30 13:36:48 -03:00
Linker.pm
Log.pm
MarcModificationTemplates.pm Bug 11413: Fix field_numbers 2014-11-14 12:05:47 -03:00
Matcher.pm
Members.pm Bug 13740: Fix null vs not null in the query 2015-03-31 10:54:30 -03:00
Message.pm Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices 2015-01-04 11:20:10 -03:00
NewsChannels.pm
Output.pm Bug 13684: C4::Budgets should not be used in C4::Output 2015-02-16 23:36:40 -03:00
Overdues.pm Bug 13841 - Returns via backdating or SIP2 can create new fines with an amount outstanding of 0 2015-03-31 11:36:07 -03:00
Patroncards.pm
Print.pm
Ratings.pm
Record.pm Bug 13190: Reintroduce the checkouts export feature 2014-11-06 10:00:30 -03:00
Reports.pm Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
Reserves.pm Bug 5786 [QA Followup] 2015-03-25 10:33:31 -03:00
Review.pm
Ris.pm Bug 13360: C4::Ris assumes that hash keys are ordered - KW 2014-12-28 19:56:31 -03:00
RotatingCollections.pm Bug 8836 [QA Followup] - Prevent multiple collections from having the same title 2014-11-06 15:12:20 -03:00
Scheduler.pm
Scrubber.pm
Search.pm Bug 13636 - Staff search results item status incorrect for holds 2015-02-11 10:20:35 -03:00
Serials.pm Bug 13746: On creating a new subscription, notes fields get confused 2015-03-15 08:40:05 -03:00
Service.pm Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
ShelfBrowser.pm
SMS.pm Bug 3186 [QA Followup] - Don't return undef, just return 2014-10-30 01:23:12 -03:00
SocialData.pm
SQLHelper.pm Bug 11425: Get column names using DBIX 2014-11-04 19:10:28 -03:00
Stats.pm Bug 10860 - Change "in-house use" to "on-site checkout" 2014-11-03 10:26:22 -03:00
Suggestions.pm Bug 13007: Special case budgetid == '' 2015-02-09 15:49:57 -03:00
Tags.pm Bug 12916 - Use of uninitialized values $max and $min in C4/Tags.pm 2014-10-30 00:31:36 -03:00
Templates.pm Bug 10328 - Rename opaccolorstylesheet to OpacAdditionalStylesheet 2015-03-31 11:30:54 -03:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm
UploadedFile.pm
UsageStats.pm Bug 5786 - Move AllowOnShelfHolds and OPACItemHolds system prefs to the Circulation Matrix 2015-03-25 10:33:14 -03:00
VirtualShelves.pm Bug 13417: Remove warnings 2015-02-13 13:52:24 -03:00
XISBN.pm
XSLT.pm Bug 12655 [Revised] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in XSLT 2014-10-30 09:35:12 +13:00