Owen Leonard fd74b271db Bug 15887: Revise layout and behavior of item search fields management ... This patch adds some JavaScript to the item search fields management page so that the add form is not displayed by default. This simplifies the interface and makes it more consistent with other similar interfaces. Also changed in this patch: - Changing instances of "Items search fields" to "Item search fields." - Correct form structure to use ordered list - Add "required" classes and enable built-in JS form validation. - Add explicitly labeled "Choose" options to <select>s. - Add missing ids to form fields (labels don't work without them). - Correct classes of message and alert dialogs. - Add JS confirmation of deletions. - Convert MARC tag and subfield dropdowns to regular inputs (Bug 15384). To test, apply the patch and go to Administration. - Confirm that the "Item search fields" link is correct. - Follow the link and confirm that the list of existing fields is shown by default, or a message saying there are no existing fields. - Click the "New search field" button and confirm that it displays the entry form. - Confirm that submitting an empty form does not work. - Confirm that clicking the "Cancel" link correctly hides the form. - Confirm that submitting valid data works correctly. - In the table of existing item search fields, confirm that the "Edit" button works correctly. - Confirm that submitting edits works correctly. - In the table of existing item search fields, confirm that clicking "Delete" highlights the row in question and a confirmation dialog appears. - Test both canceling and confirming deletion. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. JSHint OK, koha-qa OK. Revision per QA: Undid the change making tag and subfield inputs text fields. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>		2016-03-02 22:36:17 +00:00
..
catalogue	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues	2016-02-11 19:39:53 +00:00
csv_headers	Bug 14636: Item search - improving display	2015-12-30 12:44:26 +00:00
virtualshelves/merge
acquisitions-add-to-basket.inc
acquisitions-menu.inc
acquisitions-search.inc	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues	2016-02-11 19:39:53 +00:00
acquisitions-toolbar.inc
additem.js.inc
admin-items-search-field-form.inc	Bug 15887: Revise layout and behavior of item search fields management	2016-03-02 22:36:17 +00:00
admin-menu.inc	Bug 15887: Revise layout and behavior of item search fields management	2016-03-02 22:36:17 +00:00
auth-finder-search.inc	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues	2016-02-11 19:39:53 +00:00
authorities-search-results.inc	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues	2016-02-11 19:39:53 +00:00
authorities-search.inc	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues	2016-02-11 19:39:53 +00:00
authorities-toolbar.inc	Bug 15381: Remove getauthtypes and getauthtype	2015-12-31 18:59:02 +00:00
authorities.inc	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues	2016-02-11 19:39:53 +00:00
authorities_js.inc
av-build-dropbox.inc
biblio-default-view.inc
biblio-view-menu.inc
borrower_debarments.inc	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues	2016-02-11 19:39:53 +00:00
branch-selector.inc
browser-strings.inc
budgets-active-currency.inc	Bug 15049: (followup) Add warning about "No active currency"	2015-12-30 23:34:34 +00:00
budgets-admin-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
budgets-admin-toolbar.inc
calendar.inc	Bug 12072: Make datepicker and templates to be aware of dmydot format	2015-11-19 13:15:19 -03:00
cat-menu.inc
cat-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
cat-toolbar.inc	Bug 13642 - Adding new features for Dublin Core metadata	2016-01-27 06:23:07 +00:00
cataloging-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
cateditor-ui.inc	Bug 15344: Remove unucessary call to GetMemberDetails	2015-12-30 11:53:18 +00:00
cateditor-widgets-marc21.inc
checkin-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
checkouts-table-footer.inc	Bug 14948 - Display amounts right aligned in tables on patron pages	2015-12-30 04:25:51 +00:00
checkouts-table.inc	Bug 12920 [QA Followup] - Show override option below checkouts table when allowed	2016-02-24 03:10:20 +00:00
circ-menu.inc	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues	2016-02-11 19:39:53 +00:00
circ-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
cities-admin-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
columns_settings.inc	Bug 15674: Use double-quote instead of simple-quote	2016-03-02 00:58:13 +00:00
contracts-admin-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
currencies-admin-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
datatables-strings.inc
datatables.inc	Bug 15285: Update common files	2016-02-24 00:02:49 +00:00
date-format.inc	Bug 12072: Make datepicker and templates to be aware of dmydot format	2015-11-19 13:15:19 -03:00
doc-head-close-receipt.inc
doc-head-close.inc	Bug 15910 - Move header search keep text JavaScript into staff-global.js	2016-03-02 03:50:00 +00:00
doc-head-open.inc
empty_line.inc
facets.inc	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues	2016-02-11 19:39:53 +00:00
form-blocks.inc
format_price.inc
greybox.inc
guided-reports-view.inc
header.inc	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues	2016-02-11 19:39:53 +00:00
help-bottom.inc
help-top.inc
home-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
installer-doc-head-close.inc
intranet-bottom.inc
intranetstylesheet.inc
labels-toolbar.inc
letters-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
member-alt-address-style-de.inc	Bug 15373: Changing Zip to ZIP on OPAC and Intranet	2015-12-30 16:30:35 +00:00
member-alt-address-style-us.inc	Bug 15373: Changing Zip to ZIP on OPAC and Intranet	2015-12-30 16:30:35 +00:00
member-alt-contact-style-de.inc	Bug 15373: Changing Zip to ZIP on OPAC and Intranet	2015-12-30 16:30:35 +00:00
member-alt-contact-style-us.inc	Bug 15373: Changing Zip to ZIP on OPAC and Intranet	2015-12-30 16:30:35 +00:00
member-display-address-style-de.inc	Bug 15542: Change for the German style address format	2016-01-23 19:15:08 +00:00
member-display-address-style-us.inc	Bug 15542: Always display the patron's info the same way.	2016-01-23 19:15:08 +00:00
member-main-address-style-de.inc	Bug 15631: Koha::Cities - remove getidcity and GetCities	2016-02-24 03:53:52 +00:00
member-main-address-style-us.inc	Bug 15631: Koha::Cities - remove getidcity and GetCities	2016-02-24 03:53:52 +00:00
members-menu.inc
members-toolbar.inc	Bug 15096: Export today's checked in barcodes: Display warning if reading history is set to "never"	2016-01-27 06:02:43 +00:00
merge-record-strings.inc	Bug 8064: Change the way target record is built.	2015-11-09 15:08:57 -03:00
merge-record.inc	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues	2016-02-11 19:39:53 +00:00
messaging-preference-form.inc
nl-search-form.tt
page-numbers.inc	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues	2016-02-11 19:39:53 +00:00
patron-search-box.inc	Bug 15706: (follow-up) Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
patron-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
patron-title.inc
patron-toolbar.inc
patroncards-errors.inc
patroncards-toolbar.inc
patrons-admin-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
permissions.inc	Bug 15289 [QA Followup] - Fix minor language issue	2015-12-30 02:51:50 +00:00
popup-bottom.inc
prefs-admin-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
prefs-menu.inc
printers-admin-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
quotes-toolbar.inc
quotes-upload-toolbar.inc
reports-menu.inc
reports-toolbar.inc	Bug 15321 - Add delete report link to Show, Edit and Run screens	2015-12-31 15:44:29 +00:00
resort_form.inc
rotating-collections-toolbar.inc
search_indexes.inc
serials-menu.inc
serials-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
serials-toolbar.inc
slip-print.inc	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues	2016-02-11 19:39:53 +00:00
strings.inc	Bug 14310 [QA Followup] - Deal with error conditions	2016-01-27 06:20:19 +00:00
subscriptions-search.inc
subtypes_unimarc.inc
suggestions-add-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00
timepicker.inc
tools-item-action.inc
tools-menu.inc	Bug 15211: Patron card creator needs tools sidebar	2015-12-31 14:58:58 +00:00
tools-nomatch-action.inc
tools-overlay-action.inc
validator-strings.inc
vendor-menu.inc
virtualshelves-toolbar.inc	Bug 15453: Assign the correct shelfid to the download list links	2016-01-07 18:54:34 +00:00
wysiwyg-systempreferences.inc
z3950-admin-search.inc	Bug 15706: Changing to circulate_remaining_permissions	2016-02-23 22:38:46 +00:00