Main Koha release repository https://koha-community.org
Find a file
Owen Leonard fd74b271db Bug 15887: Revise layout and behavior of item search fields management
This patch adds some JavaScript to the item search fields management
page so that the add form is not displayed by default. This simplifies
the interface and makes it more consistent with other similar
interfaces.

Also changed in this patch:
- Changing instances of "Items search fields" to "Item search fields."
- Correct form structure to use ordered list
- Add "required" classes and enable built-in JS form validation.
- Add explicitly labeled "Choose" options to <select>s.
- Add missing ids to form fields (labels don't work without them).
- Correct classes of message and alert dialogs.
- Add JS confirmation of deletions.
- Convert MARC tag and subfield dropdowns to regular inputs (Bug 15384).

To test, apply the patch and go to Administration.

- Confirm that the "Item search fields" link is correct.
- Follow the link and confirm that the list of existing fields is shown
  by default, or a message saying there are no existing fields.
- Click the "New search field" button and confirm that it displays the
  entry form.
  - Confirm that submitting an empty form does not work.
  - Confirm that clicking the "Cancel" link correctly hides the form.
  - Confirm that submitting valid data works correctly.
- In the table of existing item search fields, confirm that the "Edit"
  button works correctly.
  - Confirm that submitting edits works correctly.
- In the table of existing item search fields, confirm that clicking
  "Delete" highlights the row in question and a confirmation dialog
  appears.
  - Test both canceling and confirming deletion.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as described. JSHint OK, koha-qa OK.

Revision per QA: Undid the change making tag and subfield inputs text
fields.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-03-02 22:36:17 +00:00
acqui Bug 15629: Koha::Libraries - Remove GetBranchDetail 2016-02-24 03:55:06 +00:00
admin Bug 14753: Add the "page" parameter in the yml file 2016-03-02 04:18:33 +00:00
api/v1 Bug 13799: Add types for patron's fields in Swagger spec 2015-11-04 13:47:33 -03:00
authorities Bug 15358: Fix authorities merge 2016-02-03 23:03:33 +00:00
basket Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
C4 Bug 14659: Allow patrons to enter card number and patron category on OPAC registration page 2016-03-02 04:29:38 +00:00
catalogue Bug 15629 [QA Followup] 2016-02-24 03:55:07 +00:00
cataloguing Bug 14199: Database revision for marc21_orgcode.pl 2016-02-26 14:04:29 +00:00
circ Bug 14134 - Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set 2016-03-02 04:46:06 +00:00
course_reserves Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
debian Bug 14532: (followup) Use tar's --exclude for simplicity 2016-03-02 04:39:51 +00:00
docs Bug 7143: Adding releases and fixing some missing tabs 2016-01-06 16:03:30 -07:00
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
etc Bug 12549: Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems 2016-02-24 01:06:13 +00:00
install_misc Bug 13642 - Remove MARC::Crosswalk::DublinCore from Koha 2016-01-27 06:23:08 +00:00
installer DBREV Bug 14659 - Allow patrons to enter card number and patron category on OPAC registration page 2016-03-02 04:37:40 +00:00
Koha Bug 14659: (QA followup) switch to using Koha::Patron::Categories 2016-03-02 04:29:39 +00:00
koha-tmpl Bug 15887: Revise layout and behavior of item search fields management 2016-03-02 22:36:17 +00:00
labels Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
members Bug 15629 [QA Followup] 2016-02-24 03:55:07 +00:00
misc Bug 15675 - Add issue_id column to accountlines and use it for updating fines 2016-03-02 03:24:45 +00:00
offline_circ Bug 15764: Fix timestamp sent by KOCT 2016-02-23 20:53:18 +00:00
opac Bug 14659: Allow patrons to enter card number and patron category on OPAC registration page 2016-03-02 04:29:38 +00:00
OpenILS
patron_lists Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
patroncards Bug 15573: String and translatability fix to Patron Card Creator 2016-01-27 05:36:52 +00:00
plugins Bug 14951: Remove C4::Dates from plugins/*.pl files 2015-10-06 10:29:42 -03:00
reports Bug 15800: Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory 2016-03-02 03:54:16 +00:00
reserve Bug 15629: Koha::Libraries - Remove GetBranchDetail 2016-02-24 03:55:06 +00:00
reviews Bug 14779: Cannot paginate reviews 2015-09-07 11:38:26 -03:00
rotating_collections Bug 15066: Make transfer rotating collection works under Plack 2015-11-05 09:50:09 -03:00
selenium
serials Bug 14641: [SIGNED-OFF] Warns in subscription-add.pl 2016-01-27 04:31:27 +00:00
services Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
skel
sms Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
suggestion Bug 15624: Spelling mistake in suggestion.pl 2016-01-27 05:09:09 +00:00
svc Bug 14310 [QA Followup] - Use output_with_http_headers, return 403s 2016-01-27 06:20:19 +00:00
t Bug 15947: move SIPILS.t to DB-dependent test directory 2016-03-02 22:02:10 +00:00
tags Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax 2015-11-02 12:49:13 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
tools Bug 15923: Take the id list file into account when exporting records 2016-03-02 00:43:11 +00:00
virtualshelves Bug 15810: Make sure the CGI->param is not called in a list context when creating private shelves 2016-02-22 20:32:18 +00:00
xt Bug 13632: (QA followup) remove xt/permissions.t 2015-10-19 12:42:59 -03:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess
.mailmap (RM followup) .mailmap updates 2015-05-22 17:02:21 -03:00
about.pl Bug 15721: About page does not display Apache version 2016-03-02 03:22:51 +00:00
changelanguage.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
edithelp.pl Bug 14813: Fix encoding issues on editing help pages 2015-09-16 10:42:15 -03:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 14812: Display the help in the correct language 2015-10-02 15:06:08 -03:00
INSTALL
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
INSTALL.debian
INSTALL.fedora7 Bug 13642 - Remove MARC::Crosswalk::DublinCore from Koha 2016-01-27 06:23:08 +00:00
INSTALL.opensuse
INSTALL.ubuntu
Koha.pm DBREV Bug 14659 - Allow patrons to enter card number and patron category on OPAC registration page 2016-03-02 04:37:40 +00:00
koha_perl_deps.pl
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
LICENSE
mainpage.pl Bug 10904: (QA followup) Use branch limit if either IndependentBranches or IndependentBranchesPatronModifications is enabled 2015-11-02 12:34:46 -03:00
Makefile.PL Bug 12549: (QA followup) missing newline in CLI dialog 2016-02-24 01:06:13 +00:00
MANIFEST.SKIP
README
README.md Bug 15465 [QA Followup] - Update wording, switch logo, add links 2016-02-24 04:02:26 +00:00
README.robots
rewrite-config.PL Bug 12549: Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems 2016-02-24 01:06:13 +00:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-comminity.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo