t/db_dependent/Circulation/transfers.t

   1 #!/usr/bin/perl
   2
   3 # This file is part of Koha.
   4 #
   5 # Koha is free software; you can redistribute it and/or modify it
   6 # under the terms of the GNU General Public License as published by
   7 # the Free Software Foundation; either version 3 of the License, or
   8 # (at your option) any later version.
   9 #
  10 # Koha is distributed in the hope that it will be useful, but
  11 # WITHOUT ANY WARRANTY; without even the implied warranty of
  12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13 # GNU General Public License for more details.
  14 #
  15 # You should have received a copy of the GNU General Public License
  16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
  17
  18 use Modern::Perl;
  19 use C4::Context;
  20 use C4::Circulation;
  21 use C4::Biblio;
  22 use C4::Items;
  23 use Koha::Database;
  24 use Koha::DateUtils;
  25 use DateTime::Duration;
  26 use Koha::Item::Transfers;
  27
  28 use t::lib::TestBuilder;
  29
  30 use Test::More tests => 25;
  31 use Test::Deep;
  32
  33 BEGIN {
  34     use_ok('C4::Circulation');
  35 }
  36 can_ok(
  37     'C4::Circulation',
  38     qw(
  39       CreateBranchTransferLimit
  40       DeleteBranchTransferLimits
  41       DeleteTransfer
  42       GetTransfers
  43       GetTransfersFromTo
  44       )
  45 );
  46
  47 my $schema = Koha::Database->schema;
  48 $schema->storage->txn_begin;
  49 my $builder = t::lib::TestBuilder->new;
  50
  51 my $dbh = C4::Context->dbh;
  52 $dbh->do(q|DELETE FROM issues|);
  53 $dbh->do(q|DELETE FROM borrowers|);
  54 $dbh->do(q|DELETE FROM items|);
  55 $dbh->do(q|DELETE FROM branches|);
  56 $dbh->do(q|DELETE FROM branch_transfer_limits|);
  57 $dbh->do(q|DELETE FROM branchtransfers|);
  58
  59 ## Create sample datas
  60 # Add branches
  61 my $branchcode_1 = $builder->build( { source => 'Branch', } )->{branchcode};
  62 my $branchcode_2 = $builder->build( { source => 'Branch', } )->{branchcode};
  63 # Add itemtype
  64 my $itemtype = $builder->build( { source => 'Itemtype' } )->{itemtype};
  65
  66 #Add biblio and items
  67 my $record = MARC::Record->new();
  68 $record->append_fields(
  69     MARC::Field->new( '952', '0', '0', a => $branchcode_1 ) );
  70 my ( $biblionumber, $biblioitemnumber ) = C4::Biblio::AddBiblio( $record, '', );
  71
  72 my $item_id1 = Koha::Item->new(
  73     {
  74         biblionumber   => $biblionumber,
  75         barcode        => 1,
  76         itemcallnumber => 'callnumber1',
  77         homebranch     => $branchcode_1,
  78         holdingbranch  => $branchcode_1,
  79         itype          => $itemtype
  80     },
  81 )->store->itemnumber;
  82 my $item_id2 = Koha::Item->new(
  83     {
  84         biblionumber   => $biblionumber,
  85         barcode        => 2,
  86         itemcallnumber => 'callnumber2',
  87         homebranch     => $branchcode_1,
  88         holdingbranch  => $branchcode_1,
  89         itype          => $itemtype
  90     },
  91 )->store->itemnumber;
  92 my $item_id3 = Koha::Item->new(
  93     {
  94         biblionumber   => $biblionumber,
  95         barcode        => 3,
  96         itemcallnumber => 'callnumber3',
  97         homebranch     => $branchcode_1,
  98         holdingbranch  => $branchcode_1,
  99         itype          => $itemtype
 100     },
 101 )->store->itemnumber;
 102 my $item_id4 = Koha::Item->new(
 103     {
 104         biblionumber   => $biblionumber,
 105         barcode        => 4,
 106         itemcallnumber => 'callnumber4',
 107         homebranch     => $branchcode_1,
 108         holdingbranch  => $branchcode_1,
 109         itype          => $itemtype
 110     },
 111 )->store->itemnumber;
 112
 113 #Add transfers
 114 my $trigger = 'Manual';
 115 ModItemTransfer(
 116     $item_id1,
 117     $branchcode_1,
 118     $branchcode_2,
 119     $trigger
 120 );
 121
 122 my $item_obj = Koha::Items->find({ itemnumber => $item_id1 });
 123 is( $item_obj->holdingbranch, $branchcode_1, "Item should be held at branch that initiates transfer");
 124
 125 ModItemTransfer(
 126     $item_id2,
 127     $branchcode_1,
 128     $branchcode_2,
 129     $trigger
 130 );
 131
 132 # Add an "unsent" transfer for tests
 133 ModItemTransfer(
 134     $item_id3,
 135     $branchcode_1,
 136     $branchcode_2,
 137     $trigger
 138 );
 139 my $transfer_requested = Koha::Item::Transfers->search( { itemnumber => $item_id3 }, { rows => 1 })->single;
 140 $transfer_requested->set({ daterequested => dt_from_string, datesent => undef })->store;
 141
 142 # Add a "cancelled" transfer for tests
 143 ModItemTransfer(
 144     $item_id4,
 145     $branchcode_1,
 146     $branchcode_2,
 147     $trigger
 148 );
 149 my $transfer_cancelled = Koha::Item::Transfers->search( { itemnumber => $item_id4 }, { rows => 1 })->single;
 150 $transfer_cancelled->set( { daterequested => dt_from_string, datesent => undef, datecancelled => dt_from_string } )->store;
 151
 152 #Begin Tests
 153 #Test CreateBranchTransferLimit
 154 is(
 155     CreateBranchTransferLimit(
 156         $branchcode_2,
 157         $branchcode_1, 'CODE'
 158     ),
 159     1,
 160     "A Branch TransferLimit has been added"
 161 );
 162 is(CreateBranchTransferLimit(),undef,
 163     "Without parameters CreateBranchTransferLimit returns undef");
 164 is(CreateBranchTransferLimit($branchcode_2),undef,
 165     "With only tobranch CreateBranchTransferLimit returns undef");
 166 is(CreateBranchTransferLimit(undef,$branchcode_2),undef,
 167     "With only frombranch CreateBranchTransferLimit returns undef");
 168 #FIXME: Currently, we can add a transferlimit even to nonexistent branches because in the database,
 169 #branch_transfer_limits.toBranch and branch_transfer_limits.fromBranch aren't foreign keys
 170 #is(CreateBranchTransferLimit(-1,-1,'CODE'),0,"With wrong CreateBranchTransferLimit returns 0 - No transfertlimit added");
 171
 172 #Test GetTransfers
 173 my @transfers = GetTransfers($item_id1);
 174 cmp_deeply(
 175     \@transfers,
 176     [ re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'), $branchcode_1, $branchcode_2, re('[0-9]*'), re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'), 'Manual' ],
 177     "Transfers of the item1"
 178 );    #NOTE: Only the first transfer is returned
 179 @transfers = GetTransfers;
 180 is_deeply( \@transfers, [],
 181     "GetTransfers without params returns an empty array" );
 182 @transfers = GetTransfers(-1);
 183 is_deeply( \@transfers, [],
 184     "GetTransfers with a wrong item id returns an empty array" );
 185
 186 #Test GetTransfersFromTo
 187 my @transferfrom1to2 = GetTransfersFromTo( $branchcode_1,
 188     $branchcode_2 );
 189 cmp_deeply(
 190     \@transferfrom1to2,
 191     [
 192         {
 193             branchtransfer_id => re('[0-9]*'),
 194             itemnumber        => $item_id1,
 195             datesent          => re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'),
 196             frombranch        => $branchcode_1
 197         },
 198         {
 199             branchtransfer_id => re('[0-9]*'),
 200             itemnumber        => $item_id2,
 201             datesent          => re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'),
 202             frombranch        => $branchcode_1
 203         }
 204     ],
 205     "Item1 and Item2 has been transferred from branch1 to branch2"
 206 );
 207 my @transferto = GetTransfersFromTo( undef, $branchcode_2 );
 208 is_deeply( \@transferto, [],
 209     "GetTransfersfromTo without frombranch returns an empty array" );
 210 my @transferfrom = GetTransfersFromTo( $branchcode_1 );
 211 is_deeply( \@transferfrom, [],
 212     "GetTransfersfromTo without tobranch returns an empty array" );
 213 @transferfrom = GetTransfersFromTo();
 214 is_deeply( \@transferfrom, [],
 215     "GetTransfersfromTo without params returns an empty array" );
 216
 217 #Test DeleteBranchTransferLimits
 218 is(
 219     C4::Circulation::DeleteBranchTransferLimits( $branchcode_1 ),
 220     1,
 221     "A Branch TransferLimit has been deleted"
 222 );
 223 is(C4::Circulation::DeleteBranchTransferLimits(),undef,"Without parameters DeleteBranchTransferLimit returns undef");
 224 is(C4::Circulation::DeleteBranchTransferLimits('B'),'0E0',"With a wrong id DeleteBranchTransferLimit returns 0E0");
 225
 226 #Test DeleteTransfer
 227 is( C4::Circulation::DeleteTransfer($item_id1),
 228     1, "A the item1's transfer has been deleted" );
 229 is(C4::Circulation::DeleteTransfer(),undef,"Without itemid DeleteTransfer returns undef");
 230 is(C4::Circulation::DeleteTransfer(-1),'0E0',"with a wrong itemid DeleteTranfer returns 0E0");
 231
 232 #Test TransferSlip
 233 is( C4::Circulation::TransferSlip($branchcode_1, undef, 5, $branchcode_2),
 234     undef, "No tranferslip if invalid or undef itemnumber or barcode" );
 235 is( C4::Circulation::TransferSlip($branchcode_1, $item_id1, 1, $branchcode_2)->{'code'},
 236     'TRANSFERSLIP', "Get a transferslip on valid itemnumber and/or barcode" );
 237 cmp_deeply(
 238     C4::Circulation::TransferSlip($branchcode_1, $item_id1, undef, $branchcode_2),
 239     C4::Circulation::TransferSlip($branchcode_1, undef, 1, $branchcode_2),
 240     "Barcode and itemnumber for same item both generate same TransferSlip"
 241     );
 242
 243 $dbh->do("DELETE FROM branchtransfers");
 244 ModItemTransfer(
 245     $item_id1,
 246     $branchcode_1,
 247     $branchcode_2,
 248     $trigger
 249 );
 250 my $transfer = Koha::Item::Transfers->search()->next();
 251 ModItemTransfer(
 252     $item_id1,
 253     $branchcode_1,
 254     $branchcode_2,
 255     $trigger
 256 );
 257 $transfer->{_result}->discard_changes;
 258 ok( $transfer->datecancelled, 'Date cancelled is set when new transfer is initiated' );
 259 is( $transfer->cancellation_reason, "Manual", 'Cancellation reason is set correctly when new transfer is initiated' );
 260
 261 $schema->storage->txn_rollback;
 262