3 # Copyright 2015 Koha Development team
5 # This file is part of Koha
7 # Koha is free software; you can redistribute it and/or modify it
8 # under the terms of the GNU General Public License as published by
9 # the Free Software Foundation; either version 3 of the License, or
10 # (at your option) any later version.
12 # Koha is distributed in the hope that it will be useful, but
13 # WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 # GNU General Public License for more details.
17 # You should have received a copy of the GNU General Public License
18 # along with Koha; if not, see <http://www.gnu.org/licenses>.
21 use Test::More tests => 161;
24 use Encode qw( encode_utf8 );
27 # To be replaced by t::lib::Mock
30 use Koha::Patron::Relationships;
32 use File::Temp qw(tempfile tempdir);
33 my $temp_dir = tempdir('Koha_patrons_import_test_XXXX', CLEANUP => 1, TMPDIR => 1);
36 use t::lib::TestBuilder;
37 my $builder = t::lib::TestBuilder->new;
39 my $schema = Koha::Database->new->schema;
40 $schema->storage->txn_begin;
42 # ########## Tests start here #############################
43 # Given ... we can use the module
44 BEGIN { use_ok('Koha::Patrons::Import'); }
46 my $patrons_import = new_ok('Koha::Patrons::Import');
48 subtest 'test_methods' => sub {
51 # Given ... we can reach the method(s)
52 my @methods = ('import_patrons',
53 'set_attribute_types',
56 'generate_patron_attributes',
60 can_ok('Koha::Patrons::Import', @methods);
63 subtest 'test_attributes' => sub {
66 my @attributes = ('today_iso', 'text_csv');
67 can_ok('Koha::Patrons::Import', @attributes);
70 # Tests for Koha::Patrons::Import::import_patrons()
71 # Given ... nothing much. When ... Then ...
73 warning_is { $result = $patrons_import->import_patrons(undef) }
74 { carped => 'No file handle passed in!' },
75 " Koha::Patrons::Import->import_patrons carps if no file handle is passed";
76 is($result, undef, 'Got the expected undef from import_patrons with nothing much');
78 # Given ... some params but no file handle.
79 my $params_0 = { some_stuff => 'random stuff', };
83 warning_is { $result_0 = $patrons_import->import_patrons($params_0) }
84 { carped => 'No file handle passed in!' },
85 " Koha::Patrons::Import->import_patrons carps if no file handle is passed";
86 is($result_0, undef, 'Got the expected undef from import_patrons with no file handle');
88 # Given ... a file handle to file with headers only.
89 t::lib::Mocks::mock_preference('ExtendedPatronAttributes', 0);
90 t::lib::Mocks::mock_preference('dateformat', 'us');
92 my $csv_headers = 'cardnumber,surname,firstname,title,othernames,initials,streetnumber,streettype,address,address2,city,state,zipcode,country,email,phone,mobile,fax,dateofbirth,branchcode,categorycode,dateenrolled,dateexpiry,userid,password';
93 my $res_header = 'cardnumber, surname, firstname, title, othernames, initials, streetnumber, streettype, address, address2, city, state, zipcode, country, email, phone, mobile, fax, dateofbirth, branchcode, categorycode, dateenrolled, dateexpiry, userid, password';
94 my $csv_one_line = '1000,Nancy,Jenkins,Dr,,NJ,78,Circle,Bunting,El Paso,Henderson,Texas,79984,United States,ajenkins0@sourceforge.net,7-(388)559-6763,3-(373)151-4471,8-(509)286-4001,10/16/1965,CPL,PT,12/28/2014,07/01/2015,jjenkins0,DPQILy';
95 my $csv_one_line_a = '1001,Nancy,Jenkins,Dr,,NJ,78,Circle,Bunting,El Paso,Henderson,Texas,79984,United States,ajenkins0@sourceforge.net,7-(388)559-6763,3-(373)151-4471,8-(509)286-4001,10/16/1965,CPL,PT,12/28/2014,07/01/2015,jjenkins0,DPQILy';
97 my $filename_1 = make_csv($temp_dir, $csv_headers, $csv_one_line);
98 open(my $handle_1, "<", $filename_1) or die "cannot open < $filename_1: $!";
99 my $params_1 = { file => $handle_1, };
102 my $result_1 = $patrons_import->import_patrons($params_1);
105 is($result_1->{already_in_db}, 0, 'Got the expected 0 already_in_db from import_patrons with no matchpoint defined');
106 is(scalar @{$result_1->{errors}}, 0, 'Got the expected 0 size error array from import_patrons with no matchpoint defined');
108 is($result_1->{feedback}->[0]->{feedback}, 1, 'Got the expected 1 feedback from import_patrons with no matchpoint defined');
109 is($result_1->{feedback}->[0]->{name}, 'headerrow', 'Got the expected header row name from import_patrons with no matchpoint defined');
110 is($result_1->{feedback}->[0]->{value}, $res_header, 'Got the expected header row value from import_patrons with no matchpoint defined');
112 is($result_1->{feedback}->[1]->{feedback}, 1, 'Got the expected second feedback from import_patrons with no matchpoint defined');
113 is($result_1->{feedback}->[1]->{name}, 'lastimported', 'Got the expected last imported name from import_patrons with no matchpoint defined');
114 like($result_1->{feedback}->[1]->{value}, qr/^Nancy \/ \d+/, 'Got the expected second header row value from import_patrons with no matchpoint defined');
116 is($result_1->{imported}, 1, 'Got the expected 1 imported result from import_patrons with no matchpoint defined');
117 is($result_1->{invalid}, 0, 'Got the expected 0 invalid result from import_patrons with no matchpoint defined');
118 is($result_1->{overwritten}, 0, 'Got the expected 0 overwritten result from import_patrons with no matchpoint defined');
120 # Given ... a valid file handle, a bad matchpoint resulting in invalid card number
121 my $filename_2 = make_csv($temp_dir, $csv_headers, $csv_one_line);
122 open(my $handle_2, "<", $filename_2) or die "cannot open < $filename_2: $!";
123 my $params_2 = { file => $handle_2, matchpoint => 'SHOW_BCODE', };
126 my $result_2 = $patrons_import->import_patrons($params_2);
129 is($result_2->{already_in_db}, 0, 'Got the expected 0 already_in_db from import_patrons with invalid card number');
130 is($result_2->{errors}->[0]->{borrowernumber}, undef, 'Got the expected undef borrower number from import patrons with invalid card number');
131 is($result_2->{errors}->[0]->{cardnumber}, 1000, 'Got the expected 1000 card number from import patrons with invalid card number');
132 is($result_2->{errors}->[0]->{invalid_cardnumber}, 1, 'Got the expected invalid card number from import patrons with invalid card number');
134 is($result_2->{feedback}->[0]->{feedback}, 1, 'Got the expected 1 feedback from import_patrons with invalid card number');
135 is($result_2->{feedback}->[0]->{name}, 'headerrow', 'Got the expected header row name from import_patrons with invalid card number');
136 is($result_2->{feedback}->[0]->{value}, $res_header, 'Got the expected header row value from import_patrons with invalid card number');
138 is($result_2->{imported}, 0, 'Got the expected 0 imported result from import_patrons with invalid card number');
139 is($result_2->{invalid}, 1, 'Got the expected 1 invalid result from import_patrons with invalid card number');
140 is($result_2->{overwritten}, 0, 'Got the expected 0 overwritten result from import_patrons with invalid card number');
142 # Given ... valid file handle, good matchpoint that matches should not overwrite when not set.
143 my $filename_3 = make_csv($temp_dir, $csv_headers, $csv_one_line);
144 open(my $handle_3, "<", $filename_3) or die "cannot open < $filename_3: $!";
145 my $params_3 = { file => $handle_3, matchpoint => 'cardnumber', };
148 my $result_3 = $patrons_import->import_patrons($params_3);
151 is($result_3->{already_in_db}, 1, 'Got the expected 1 already_in_db from import_patrons with duplicate userid');
152 is($result_3->{errors}->[0]->{duplicate_userid}, undef, 'No duplicate userid error from import patrons with duplicate userid (it is our own)');
153 is($result_3->{errors}->[0]->{userid}, undef, 'No duplicate userid error from import patrons with duplicate userid (it is our own)');
155 is($result_3->{feedback}->[0]->{feedback}, 1, 'Got 1 expected feedback from import_patrons that matched but not overwritten');
156 is($result_3->{feedback}->[0]->{name}, 'headerrow', 'Got the expected header row name from import_patrons with duplicate userid');
157 is($result_3->{feedback}->[0]->{value}, $res_header, 'Got the expected header row value from import_patrons with duplicate userid');
159 is($result_3->{imported}, 0, 'Got the expected 0 imported result from import_patrons');
160 is($result_3->{invalid}, 0, 'Got the expected 0 invalid result from import_patrons');
161 is($result_3->{overwritten}, 0, 'Got the expected 0 overwritten result from import_patrons that matched');
163 # Given ... valid file handle, good matchpoint that matches should overwrite when set.
164 my $filename_3a = make_csv($temp_dir, $csv_headers, $csv_one_line);
165 open(my $handle_3a, "<", $filename_3a) or die "cannot open < $filename_3: $!";
166 my $params_3a = { file => $handle_3a, matchpoint => 'cardnumber', overwrite_cardnumber => 1};
170 warning_is { $result_3a = $patrons_import->import_patrons($params_3a) }
172 "No warning raised by import_patrons";
175 is($result_3a->{already_in_db}, 0, 'Got the expected 0 already_in_db from import_patrons when matched and overwrite set');
176 is($result_3a->{errors}->[0]->{duplicate_userid}, undef, 'No duplicate userid error from import patrons with duplicate userid (it is our own)');
177 is($result_3a->{errors}->[0]->{userid}, undef, 'No duplicate userid error from import patrons with duplicate userid (it is our own)');
179 is($result_3a->{feedback}->[0]->{feedback}, 1, 'Got 1 expected feedback from import_patrons that matched and overwritten');
180 is($result_3a->{feedback}->[0]->{name}, 'headerrow', 'Got the expected header row name from import_patrons with duplicate userid');
181 is($result_3a->{feedback}->[0]->{value}, $res_header, 'Got the expected header row value from import_patrons with duplicate userid');
183 is($result_3a->{imported}, 0, 'Got the expected 0 imported result from import_patrons');
184 is($result_3a->{invalid}, 0, 'Got the expected 0 invalid result from import_patrons');
185 is($result_3a->{overwritten}, 1, 'Got the expected 1 overwritten result from import_patrons that matched');
187 # Given ... valid file handle, good matchpoint that does not match and conflicting userid.
188 my $filename_3b = make_csv($temp_dir, $csv_headers, $csv_one_line_a);
189 open(my $handle_3b, "<", $filename_3b) or die "cannot open < $filename_3: $!";
190 my $params_3b = { file => $handle_3b, matchpoint => 'cardnumber', };
193 my $result_3b = $patrons_import->import_patrons($params_3b);
196 is($result_3b->{already_in_db}, 0, 'Got the expected 0 already_in_db from import_patrons with duplicate userid');
197 is($result_3b->{errors}->[0]->{duplicate_userid}, 1, 'Got the expected duplicate userid error from import patrons with duplicate userid');
198 is($result_3b->{errors}->[0]->{userid}, 'jjenkins0', 'Got the expected userid error from import patrons with duplicate userid');
200 is($result_3b->{feedback}->[0]->{feedback}, 1, 'Got the expected 1 feedback from import_patrons with duplicate userid');
201 is($result_3b->{feedback}->[0]->{name}, 'headerrow', 'Got the expected header row name from import_patrons with duplicate userid');
202 is($result_3b->{feedback}->[0]->{value}, $res_header, 'Got the expected header row value from import_patrons with duplicate userid');
204 is($result_3b->{imported}, 0, 'Got the expected 0 imported result from import_patrons with duplicate userid');
205 is($result_3b->{invalid}, 1, 'Got the expected 1 invalid result from import_patrons with duplicate userid');
206 is($result_3b->{overwritten}, 0, 'Got the expected 0 overwritten result from import_patrons with duplicate userid');
208 # Given ... a new input and mocked C4::Context
209 t::lib::Mocks::mock_preference('ExtendedPatronAttributes', 1);
210 my $attribute = $builder->build({ source => "BorrowerAttributeType"});
212 my $csv_headers_a = 'cardnumber,surname,firstname,title,othernames,initials,streetnumber,streettype,address,address2,city,state,zipcode,country,email,phone,mobile,fax,dateofbirth,branchcode,categorycode,dateenrolled,dateexpiry,userid,password,patron_attributes';
213 my $res_header_a = 'cardnumber, surname, firstname, title, othernames, initials, streetnumber, streettype, address, address2, city, state, zipcode, country, email, phone, mobile, fax, dateofbirth, branchcode, categorycode, dateenrolled, dateexpiry, userid, password, patron_attributes';
214 my $new_input_line = '1001,Donna,Sullivan,Mrs,Henry,DS,59,Court,Burrows,Reading,Salt Lake City,Pennsylvania,19605,United States,hsullivan1@purevolume.com,3-(864)009-3006,7-(291)885-8423,1-(879)095-5038,09/19/1970,LPL,PT,03/04/2015,07/01/2015,hsullivan1,8j6P6Dmap,'.$attribute->{code}.':1';
215 my $filename_4 = make_csv($temp_dir, $csv_headers_a, $new_input_line);
216 open(my $handle_4, "<", $filename_4) or die "cannot open < $filename_4: $!";
217 my $params_4 = { file => $handle_4, matchpoint => $attribute->{code}, };
220 my $result_4 = $patrons_import->import_patrons($params_4);
223 is($result_4->{already_in_db}, 0, 'Got the expected 0 already_in_db from import_patrons with extended user');
224 is(scalar @{$result_4->{errors}}, 0, 'Got the expected 0 size error array from import_patrons with extended user');
226 is($result_4->{feedback}->[0]->{feedback}, 1, 'Got the expected 1 feedback from import_patrons with extended user');
227 is($result_4->{feedback}->[0]->{name}, 'headerrow', 'Got the expected header row name from import_patrons with extended user');
228 is($result_4->{feedback}->[0]->{value}, $res_header_a, 'Got the expected header row value from import_patrons with extended user');
230 is($result_4->{feedback}->[1]->{feedback}, 1, 'Got the expected second feedback from import_patrons with extended user');
231 is($result_4->{feedback}->[1]->{name}, 'attribute string', 'Got the expected attribute string from import_patrons with extended user');
232 is($result_4->{feedback}->[1]->{value}, $attribute->{code}.':1', 'Got the expected second feedback value from import_patrons with extended user');
234 is($result_4->{feedback}->[2]->{feedback}, 1, 'Got the expected third feedback from import_patrons with extended user');
235 is($result_4->{feedback}->[2]->{name}, 'lastimported', 'Got the expected last imported name from import_patrons with extended user');
236 like($result_4->{feedback}->[2]->{value}, qr/^Donna \/ \d+/, 'Got the expected third feedback value from import_patrons with extended user');
238 is($result_4->{imported}, 1, 'Got the expected 1 imported result from import_patrons with extended user');
239 is($result_4->{invalid}, 0, 'Got the expected 0 invalid result from import_patrons with extended user');
240 is($result_4->{overwritten}, 0, 'Got the expected 0 overwritten result from import_patrons with extended user');
242 seek $handle_4,0,0; #Reset to verify finding a matched patron works
243 my $result_4a = $patrons_import->import_patrons($params_4);
244 is($result_4a->{already_in_db}, 1, 'Got the expected 1 already_in_db from import_patrons with extended user matched');
245 is(scalar @{$result_4->{errors}}, 0, 'Got the expected 0 size error array from import_patrons with extended user matched');
247 is($result_4a->{feedback}->[0]->{feedback}, 1, 'Got the expected 1 feedback from import_patrons with extended user matched');
248 is($result_4a->{feedback}->[0]->{name}, 'headerrow', 'Got the expected header row name from import_patrons with extended user matched');
249 is($result_4a->{feedback}->[0]->{value}, $res_header_a, 'Got the expected header row value from import_patrons with extended user matched');
251 is($result_4a->{feedback}->[1]->{feedback}, 1, 'Got the expected second feedback from import_patrons with extended user matched');
252 is($result_4a->{feedback}->[1]->{name}, 'attribute string', 'Got the expected attribute string from import_patrons with extended user matched');
253 is($result_4a->{feedback}->[1]->{value}, $attribute->{code}.':1', 'Got the expected second feedback value from import_patrons with extended user matched');
255 is($result_4a->{feedback}->[2]->{already_in_db}, '1', 'Got the expected already_in_db from import_patrons with extended user matched');
256 like($result_4a->{feedback}->[2]->{value}, qr/^Donna \/ \d+/, 'Got the expected third feedback value from import_patrons with extended user matched');
258 is($result_4a->{imported}, 0, 'Got the expected 0 imported result from import_patrons with extended user matched');
259 is($result_4a->{invalid}, 0, 'Got the expected 0 invalid result from import_patrons with extended user matched');
260 is($result_4a->{overwritten}, 0, 'Got the expected 0 overwritten result from import_patrons with extended user matched');
262 t::lib::Mocks::mock_preference('ExtendedPatronAttributes', 0);
264 my $surname ='Chloé❤';
265 # Given ... 3 new inputs. One with no branch code, one with unexpected branch code.
266 my $input_no_branch = qq|1002,$surname,Reynolds,Mr,Patricia,JR,12,Hill,Kennedy,Saint Louis,Colorado Springs,Missouri,63131,United States,preynolds2i\@washington.edu,7-(925)314-9514,0-(315)973-8956,4-(510)556-2323,09/18/1967,,PT,05/07/2015,07/01/2015,preynolds2,K3HiDzl|;
267 my $input_good_branch = qq|1003,$surname,Richardson,Mr,Kimberly,LR,90,Place,Bayside,Atlanta,Erie,Georgia,31190,United States,krichardson3\@pcworld.com,8-(035)185-0387,4-(796)518-3676,3-(644)960-3789,04/13/1954,RPL,PT,06/06/2015,07/01/2015,krichardson3,P3EO0MVRPXbM|;
268 my $input_na_branch = qq|1005,$surname,Greene,Mr,Michael,RG,3,Avenue,Grim,Peoria,Jacksonville,Illinois,61614,United States,mgreene5\@seesaa.net,3-(941)565-5752,1-(483)885-8138,4-(979)577-6908,02/09/1957,ZZZ,ST,04/02/2015,07/01/2015,mgreene5,or4ORT6JH|;
270 my $filename_5 = make_csv($temp_dir, $csv_headers, encode_utf8($input_no_branch), encode_utf8($input_good_branch), encode_utf8($input_na_branch));
271 open(my $handle_5, "<", $filename_5) or die "cannot open < $filename_5: $!";
272 my $params_5 = { file => $handle_5, matchpoint => 'cardnumber', };
275 my $result_5 = $patrons_import->import_patrons($params_5);
278 is($result_5->{already_in_db}, 0, 'Got the expected 0 already_in_db from import_patrons for branch tests');
280 is($result_5->{errors}->[0]->{missing_criticals}->[0]->{borrowernumber}, 'UNDEF', 'Got the expected undef borrower number error from import patrons for branch tests');
281 is($result_5->{errors}->[0]->{missing_criticals}->[0]->{key}, 'branchcode', 'Got the expected branch code key from import patrons for branch tests');
282 is($result_5->{errors}->[0]->{missing_criticals}->[0]->{line}, 2, 'Got the expected 2 line number error from import patrons for branch tests');
283 is($result_5->{errors}->[0]->{missing_criticals}->[0]->{lineraw}, $input_no_branch."\r\n", 'Got the expected lineraw error from import patrons for branch tests');
284 is($result_5->{errors}->[0]->{missing_criticals}->[0]->{surname}, $surname, 'Got the expected surname error from import patrons for branch tests');
286 is($result_5->{errors}->[1]->{missing_criticals}->[0]->{borrowernumber}, 'UNDEF', 'Got the expected undef borrower number error from import patrons for branch tests');
287 is($result_5->{errors}->[1]->{missing_criticals}->[0]->{branch_map}, 1, 'Got the expected 1 branchmap error from import patrons for branch tests');
288 is($result_5->{errors}->[1]->{missing_criticals}->[0]->{key}, 'branchcode', 'Got the expected branch code key from import patrons for branch tests');
289 is($result_5->{errors}->[1]->{missing_criticals}->[0]->{line}, 4, 'Got the expected 4 line number error from import patrons for branch tests');
290 is($result_5->{errors}->[1]->{missing_criticals}->[0]->{lineraw}, $input_na_branch."\r\n", 'Got the expected lineraw error from import patrons for branch tests');
291 is($result_5->{errors}->[1]->{missing_criticals}->[0]->{surname}, $surname, 'Got the expected surname error from import patrons for branch tests');
292 is($result_5->{errors}->[1]->{missing_criticals}->[0]->{value}, 'ZZZ', 'Got the expected ZZZ value error from import patrons for branch tests');
294 is($result_5->{feedback}->[0]->{feedback}, 1, 'Got the expected 1 feedback from import_patrons for branch tests');
295 is($result_5->{feedback}->[0]->{name}, 'headerrow', 'Got the expected header row name from import_patrons for branch tests');
296 is($result_5->{feedback}->[0]->{value}, $res_header, 'Got the expected header row value from import_patrons for branch tests');
298 is($result_5->{feedback}->[1]->{feedback}, 1, 'Got the expected 1 feedback from import_patrons for branch tests');
299 is($result_5->{feedback}->[1]->{name}, 'lastimported', 'Got the expected lastimported name from import_patrons for branch tests');
300 like($result_5->{feedback}->[1]->{value}, qr/^$surname \/ \d+/, 'Got the expected last imported value from import_patrons with for branch tests');
302 is($result_5->{imported}, 1, 'Got the expected 1 imported result from import patrons for branch tests');
303 is($result_5->{invalid}, 2, 'Got the expected 2 invalid result from import patrons for branch tests');
304 is($result_5->{overwritten}, 0, 'Got the expected 0 overwritten result from import patrons for branch tests');
306 # Given ... 3 new inputs. One with no category code, one with unexpected category code.
307 my $input_no_category = '1006,Christina,Olson,Rev,Kimberly,CO,8,Avenue,Northridge,Lexington,Wilmington,Kentucky,40510,United States,kolson6@dropbox.com,7-(810)636-6048,1-(052)012-8984,8-(567)232-7818,03/26/1952,FFL,,09/07/2014,01/07/2015,kolson6,x5D3qGbLlptx';
308 my $input_good_category = '1007,Peter,Peters,Mrs,Lawrence,PP,6,Trail,South,Oklahoma City,Topeka,Oklahoma,73135,United States,lpeters7@bandcamp.com,5-(992)205-9318,0-(732)586-9365,3-(448)146-7936,08/16/1983,PVL,T,03/24/2015,07/01/2015,lpeters7,Z19BrQ4';
309 my $input_na_category = '1008,Emily,Richards,Ms,Judy,ER,73,Way,Kedzie,Fort Wayne,Phoenix,Indiana,46825,United States,jrichards8@arstechnica.com,5-(266)658-8957,3-(550)500-9107,7-(816)675-9822,08/09/1984,FFL,ZZ,11/09/2014,07/01/2015,jrichards8,D5PvU6H2R';
311 my $filename_6 = make_csv($temp_dir, $csv_headers, $input_no_category, $input_good_category, $input_na_category);
312 open(my $handle_6, "<", $filename_6) or die "cannot open < $filename_6: $!";
313 my $params_6 = { file => $handle_6, matchpoint => 'cardnumber', };
316 my $result_6 = $patrons_import->import_patrons($params_6);
319 is($result_6->{already_in_db}, 0, 'Got the expected 0 already_in_db from import_patrons for category tests');
321 is($result_6->{errors}->[0]->{missing_criticals}->[0]->{borrowernumber}, 'UNDEF', 'Got the expected undef borrower number error from import patrons for category tests');
322 is($result_6->{errors}->[0]->{missing_criticals}->[0]->{key}, 'categorycode', 'Got the expected category code key from import patrons for category tests');
323 is($result_6->{errors}->[0]->{missing_criticals}->[0]->{line}, 2, 'Got the expected 2 line number error from import patrons for category tests');
324 is($result_6->{errors}->[0]->{missing_criticals}->[0]->{lineraw}, $input_no_category."\r\n", 'Got the expected lineraw error from import patrons for category tests');
325 is($result_6->{errors}->[0]->{missing_criticals}->[0]->{surname}, 'Christina', 'Got the expected surname error from import patrons for category tests');
327 is($result_6->{errors}->[1]->{missing_criticals}->[0]->{borrowernumber}, 'UNDEF', 'Got the expected undef borrower number error from import patrons for category tests');
328 is($result_6->{errors}->[1]->{missing_criticals}->[0]->{category_map}, 1, 'Got the expected 1 category_map error from import patrons for category tests');
329 is($result_6->{errors}->[1]->{missing_criticals}->[0]->{key}, 'categorycode', 'Got the expected category code key from import patrons for category tests');
330 is($result_6->{errors}->[1]->{missing_criticals}->[0]->{line}, 4, 'Got the expected 4 line number error from import patrons for category tests');
331 is($result_6->{errors}->[1]->{missing_criticals}->[0]->{lineraw}, $input_na_category."\r\n", 'Got the expected lineraw error from import patrons for category tests');
332 is($result_6->{errors}->[1]->{missing_criticals}->[0]->{surname}, 'Emily', 'Got the expected surname error from import patrons for category tests');
333 is($result_6->{errors}->[1]->{missing_criticals}->[0]->{value}, 'ZZ', 'Got the expected ZZ value error from import patrons for category tests');
335 is($result_6->{feedback}->[0]->{feedback}, 1, 'Got the expected 1 feedback from import_patrons for category tests');
336 is($result_6->{feedback}->[0]->{name}, 'headerrow', 'Got the expected header row name from import_patrons for category tests');
337 is($result_6->{feedback}->[0]->{value}, $res_header, 'Got the expected header row value from import_patrons for category tests');
339 is($result_6->{feedback}->[1]->{feedback}, 1, 'Got the expected 1 feedback from import_patrons for category tests');
340 is($result_6->{feedback}->[1]->{name}, 'lastimported', 'Got the expected lastimported name from import_patrons for category tests');
341 like($result_6->{feedback}->[1]->{value}, qr/^Peter \/ \d+/, 'Got the expected last imported value from import_patrons with for category tests');
343 is($result_6->{imported}, 1, 'Got the expected 1 imported result from import patrons for category tests');
344 is($result_6->{invalid}, 2, 'Got the expected 2 invalid result from import patrons for category tests');
345 is($result_6->{overwritten}, 0, 'Got the expected 0 overwritten result from import patrons for category tests');
347 # Given ... 2 new inputs. One without dateofbirth, dateenrolled and dateexpiry values.
348 my $input_complete = '1009,Christina,Harris,Dr,Philip,CH,99,Street,Grayhawk,Baton Rouge,Dallas,Louisiana,70810,United States,pharris9@hp.com,9-(317)603-5513,7-(005)062-7593,8-(349)134-1627,06/19/1969,IPT,PT,04/09/2015,07/01/2015,pharris9,NcAhcvvnB';
349 my $input_no_date = '1010,Ralph,Warren,Ms,Linda,RW,6,Way,Barby,Orlando,Albany,Florida,32803,United States,lwarrena@multiply.com,7-(579)753-7752,6-(847)086-7566,9-(122)729-8226,26/01/2001,LPL,T,25/01/2001,24/01/2001,lwarrena,tJ56RD4uV';
351 my $filename_7 = make_csv($temp_dir, $csv_headers, $input_complete, $input_no_date);
352 open(my $handle_7, "<", $filename_7) or die "cannot open < $filename_7: $!";
353 my $params_7 = { file => $handle_7, matchpoint => 'cardnumber', };
356 my $result_7 = $patrons_import->import_patrons($params_7);
359 is($result_7->{already_in_db}, 0, 'Got the expected 0 already_in_db from import_patrons for dates tests');
360 is(scalar @{$result_7->{errors}}, 1, 'Got the expected 1 error array size from import_patrons for dates tests');
361 is(scalar @{$result_7->{errors}->[0]->{missing_criticals}}, 3, 'Got the expected 3 missing critical errors from import_patrons for dates tests');
363 is($result_7->{errors}->[0]->{missing_criticals}->[0]->{bad_date}, 1, 'Got the expected 1 bad_date error from import patrons for dates tests');
364 is($result_7->{errors}->[0]->{missing_criticals}->[0]->{borrowernumber}, 'UNDEF', 'Got the expected undef borrower number error from import patrons for dates tests');
365 is($result_7->{errors}->[0]->{missing_criticals}->[0]->{key}, 'dateofbirth', 'Got the expected dateofbirth key from import patrons for dates tests');
366 is($result_7->{errors}->[0]->{missing_criticals}->[0]->{line}, 3, 'Got the expected 2 line number error from import patrons for dates tests');
367 is($result_7->{errors}->[0]->{missing_criticals}->[0]->{lineraw}, $input_no_date."\r\n", 'Got the expected lineraw error from import patrons for dates tests');
368 is($result_7->{errors}->[0]->{missing_criticals}->[0]->{surname}, 'Ralph', 'Got the expected surname error from import patrons for dates tests');
370 is($result_7->{errors}->[0]->{missing_criticals}->[1]->{key}, 'dateenrolled', 'Got the expected dateenrolled key from import patrons for dates tests');
371 is($result_7->{errors}->[0]->{missing_criticals}->[2]->{key}, 'dateexpiry', 'Got the expected dateexpiry key from import patrons for dates tests');
373 is(scalar @{$result_7->{feedback}}, 2, 'Got the expected 2 feedback from import patrons for dates tests');
374 is($result_7->{feedback}->[0]->{feedback}, 1, 'Got the expected 1 feedback from import_patrons for dates tests');
375 is($result_7->{feedback}->[0]->{name}, 'headerrow', 'Got the expected header row name from import_patrons for dates tests');
376 is($result_7->{feedback}->[0]->{value}, $res_header, 'Got the expected header row value from import_patrons for dates tests');
378 is($result_7->{feedback}->[1]->{feedback}, 1, 'Got the expected 1 feedback from import_patrons for dates tests');
379 is($result_7->{feedback}->[1]->{name}, 'lastimported', 'Got the expected lastimported from import_patrons for dates tests');
380 like($result_7->{feedback}->[1]->{value}, qr/^Christina \/ \d+/, 'Got the expected lastimported value from import_patrons for dates tests');
382 is($result_7->{imported}, 1, 'Got the expected 1 imported result from import patrons for dates tests');
383 is($result_7->{invalid}, 1, 'Got the expected 1 invalid result from import patrons for dates tests');
384 is($result_7->{overwritten}, 0, 'Got the expected 0 overwritten result from import patrons for dates tests');
386 subtest 'test_import_without_cardnumber' => sub {
389 #Remove possible existing user with a "" as cardnumber
390 my $blank_card = Koha::Patrons->find({ cardnumber => '' });
391 $blank_card->delete if $blank_card;
393 my $branchcode = $builder->build({ source => "Branch"})->{branchcode};
394 my $categorycode = $builder->build({ source => "Category"})->{categorycode};
395 my $csv_headers = 'surname, branchcode, categorycode';
396 my $res_headers = 'surname, branchcode, categorycode';
397 my $csv_nocard_1 = "Squarepants,$branchcode,$categorycode";
398 my $csv_nocard_2 = "Star,$branchcode,$categorycode";
400 my $filename_1 = make_csv($temp_dir, $csv_headers, $csv_nocard_1, $csv_nocard_2);
401 open(my $handle_1, "<", $filename_1) or die "cannot open < $filename_1: $!";
402 my $params_1 = { file => $handle_1, };
404 my $defaults = { cardnumber => "" }; #currently all the defaults come as "" if not filled
406 my $result = $patrons_import->import_patrons($params_1, $defaults);
407 like($result->{feedback}->[1]->{value}, qr/^Squarepants \/ \d+/, 'First borrower imported as expected');
408 like($result->{feedback}->[2]->{value}, qr/^Star \/ \d+/, 'Second borrower imported as expected');
412 subtest 'test_import_with_cardnumber_0' => sub {
415 #Remove possible existing user with a "" as cardnumber
416 my $zero_card = Koha::Patrons->find({ cardnumber => 0 });
417 $zero_card->delete if $zero_card;
419 my $branchcode = $builder->build({ source => "Branch"})->{branchcode};
420 my $categorycode = $builder->build({ source => "Category"})->{categorycode};
421 my $csv_headers = 'cardnumber,surname, branchcode, categorycode';
422 my $res_headers = 'cardnumber,surname, branchcode, categorycode';
423 my $csv_nocard_1 = "0,Squarepants,$branchcode,$categorycode";
425 my $filename_1 = make_csv($temp_dir, $csv_headers, $csv_nocard_1);
426 open(my $handle_1, "<", $filename_1) or die "cannot open < $filename_1: $!";
427 my $params_1 = { file => $handle_1, };
429 my $defaults = { cardnumber => "" }; #currently all the defaults come as "" if not filled
431 my $result = $patrons_import->import_patrons($params_1, $defaults);
432 like($result->{feedback}->[1]->{value}, qr/^Squarepants \/ \d+/, 'First borrower imported as expected');
433 $zero_card = Koha::Patrons->find({ cardnumber => 0 });
434 is($zero_card->surname.$zero_card->branchcode.$zero_card->categorycode,'Squarepants'.$branchcode.$categorycode,"Patron with cardnumber 0 is the imported patron");
438 subtest 'Import patron with guarantor' => sub {
440 t::lib::Mocks::mock_preference( 'borrowerRelationship', 'guarantor' );
442 my $category = $builder->build( { source => 'Category' } )->{categorycode};
443 my $branch = $builder->build( { source => 'Branch' } )->{branchcode};
444 my $guarantor = Koha::Patron->new(
446 surname => 'Guarantor',
447 branchcode => $branch,
448 categorycode => $category,
451 my $guarantor_id = $guarantor->id;
453 my $branchcode = $builder->build( { source => "Branch" } )->{branchcode};
454 my $categorycode = $builder->build( { source => "Category" } )->{categorycode};
455 my $csv_headers = 'cardnumber,surname, branchcode, categorycode, guarantor_id, guarantor_relationship';
456 my $csv = "kylemhall,Hall,$branchcode,$categorycode,$guarantor_id,guarantor";
458 my $filename_1 = make_csv( $temp_dir, $csv_headers, $csv );
459 open( my $handle_1, "<", $filename_1 ) or die "cannot open < $filename_1: $!";
460 my $params_1 = { file => $handle_1, };
462 my $result = $patrons_import->import_patrons( $params_1 );
463 like( $result->{feedback}->[1]->{value}, qr/^Hall \/ \d+/, 'First borrower imported as expected' );
464 my $patron = Koha::Patrons->find( { cardnumber => 'kylemhall' } );
465 is( $patron->surname, "Hall", "Patron was created" );
467 my $r = Koha::Patron::Relationships->find( { guarantor_id => $guarantor_id } );
468 ok( $r, 'Found relationship' );
469 is( $r->guarantee->cardnumber, 'kylemhall', 'Found the correct guarantee' );
472 subtest 'test_import_with_password_overwrite' => sub {
475 #Remove possible existing user to avoid clashes
476 my $ernest = Koha::Patrons->find({ userid => 'ErnestP' });
477 $ernest->delete if $ernest;
480 my $branchcode = $builder->build({ source => "Branch"})->{branchcode};
481 my $categorycode = $builder->build({ source => "Category", value => { category_type => 'A' } })->{categorycode};
482 my $staff_categorycode = $builder->build({ source => "Category", value => { category_type => 'S' } })->{categorycode};
483 my $csv_headers = 'surname,userid,branchcode,categorycode,password';
484 my $csv_password = "Worrell,ErnestP,$branchcode,$categorycode,Ernest11";
485 my $csv_password_change = "Worrell,ErnestP,$branchcode,$categorycode,Vern1234";
486 my $csv_blank_password = "Worel,ErnestP,$branchcode,$categorycode,";
487 my $defaults = { cardnumber => "" }; #currently all the defaults come as "" if not filled
488 my $csv_staff_password_change = "Worrell,ErnestP,$branchcode,$staff_categorycode,Vern1234";
490 #Make the test files for importing
491 my $filename_1 = make_csv($temp_dir, $csv_headers, $csv_password);
492 open(my $handle_1, "<", $filename_1) or die "cannot open < $filename_1: $!";
493 my $params_1 = { file => $handle_1, matchpoint => 'userid', overwrite_passwords => 1, overwrite_cardnumber => 1};
494 my $filename_2 = make_csv($temp_dir, $csv_headers, $csv_password_change);
495 open(my $handle_2, "<", $filename_2) or die "cannot open < $filename_2: $!";
496 my $params_2 = { file => $handle_2, matchpoint => 'userid', overwrite_passwords => 1, overwrite_cardnumber => 1};
498 my $filename_3 = make_csv($temp_dir, $csv_headers, $csv_blank_password);
499 open(my $handle_3, "<", $filename_3) or die "cannot open < $filename_3: $!";
500 my $params_3 = { file => $handle_3, matchpoint => 'userid', overwrite_passwords => 1, overwrite_cardnumber => 1};
502 my $filename_4 = make_csv($temp_dir, $csv_headers, $csv_staff_password_change);
503 open(my $handle_4, "<", $filename_4) or die "cannot open < $filename_4: $!";
504 my $params_4 = { file => $handle_4, matchpoint => 'userid', overwrite_passwords => 1, overwrite_cardnumber => 1};
507 my $result = $patrons_import->import_patrons($params_1, $defaults);
508 like($result->{feedback}->[1]->{value}, qr/^Worrell \/ \d+/, 'First borrower imported as expected');
509 $ernest = Koha::Patrons->find({ userid => 'ErnestP' });
510 isnt($ernest->password,'Ernest',"New patron is imported, password is encrypted");
512 #Save info to double check
513 my $orig_pass = $ernest->password;
515 $result = $patrons_import->import_patrons($params_2, $defaults);
516 $ernest = Koha::Patrons->find({ userid => 'ErnestP' });
517 isnt($ernest->password,$orig_pass,"New patron is overwritten, password is overwritten");
518 isnt($ernest->password,'Vern',"Password is overwritten and is encrypted from value provided");
520 #Save info to check not changed
521 $orig_pass = $ernest->password;
523 $result = $patrons_import->import_patrons($params_3, $defaults);
524 $ernest = Koha::Patrons->find({ userid => 'ErnestP' });
525 is($ernest->surname,'Worel',"Patron is overwritten, surname changed");
526 is($ernest->password,$orig_pass,"Patron was overwritten but password is not overwritten if blank");
528 $ernest->category($staff_categorycode);
531 $result = $patrons_import->import_patrons($params_4, $defaults);
532 $ernest = Koha::Patrons->find({ userid => 'ErnestP' });
533 is($ernest->surname,'Worrell',"Patron is overwritten, surname changed");
534 is($ernest->password,$orig_pass,"Patron is imported, password is not changed for staff");
539 subtest 'test_prepare_columns' => sub {
542 # Given ... no header row
547 my @csvcolumns_0 = $patrons_import->prepare_columns({headerrow => undef, keycol => \%csvkeycol_0, errors => \@errors_0, });
550 is(scalar @csvcolumns_0, 0, 'Got the expected empty column array from prepare columns with no header row');
552 is(scalar @errors_0, 1, 'Got the expected 1 entry in error array from prepare columns with no header row');
553 is($errors_0[0]->{badheader}, 1, 'Got the expected 1 badheader from prepare columns with no header row');
554 is($errors_0[0]->{line}, 1, 'Got the expected 1 line from prepare columns with no header row');
555 is($errors_0[0]->{lineraw}, undef, 'Got the expected undef lineraw from prepare columns with no header row');
557 # Given ... a good header row with plenty of whitespaces
558 my $headerrow_1 = 'a, b , c, , d';
563 my @csvcolumns_1 = $patrons_import->prepare_columns({headerrow => $headerrow_1, keycol => \%csvkeycol_1, errors => \@errors_1, });
566 is(scalar @csvcolumns_1, 5, 'Got the expected 5 column array from prepare columns');
567 is($csvcolumns_1[0], 'a', 'Got the expected a header from prepare columns');
568 is($csvcolumns_1[1], 'b', 'Got the expected b header from prepare columns');
569 is($csvcolumns_1[2], 'c', 'Got the expected c header from prepare columns');
570 is($csvcolumns_1[3], '', 'Got the expected empty header from prepare columns');
571 is($csvcolumns_1[4], 'd', 'Got the expected d header from prepare columns');
573 is($csvkeycol_1{a}, 0, 'Got the expected 0 value for key a from prepare columns hash');
574 is($csvkeycol_1{b}, 1, 'Got the expected 1 value for key b from prepare columns hash');
575 is($csvkeycol_1{c}, 2, 'Got the expected 2 value for key c from prepare columns hash');
576 is($csvkeycol_1{''}, 3, 'Got the expected 3 value for empty string key from prepare columns hash');
577 is($csvkeycol_1{d}, 4, 'Got the expected 4 value for key d from prepare columns hash');
580 subtest 'test_set_column_keys' => sub {
583 # Given ... nothing at all
585 my $attr_type_0 = $patrons_import->set_attribute_types(undef);
586 is($attr_type_0, undef, 'Got the expected undef attribute type from set attribute types with nothing');
588 # Given ... extended but not matchpoint
589 my $params_1 = { extended => 1, matchpoint => undef, };
592 my $attr_type_1 = $patrons_import->set_attribute_types($params_1);
593 is($attr_type_1, undef, 'Got the expected undef attribute type from set attribute types with no matchpoint');
595 # Given ... extended and unexpected matchpoint
596 my $params_2 = { extended => 1, matchpoint => 'unexpected', };
599 my $attr_type_2 = $patrons_import->set_attribute_types($params_2);
600 is($attr_type_2, undef, 'Got the expected undef attribute type from set attribute types with unexpected matchpoint');
603 my $code_3 = 'SHOW_BCODE';
604 my $params_3 = { extended => 1, matchpoint => $code_3, };
607 my $attr_type_3 = $patrons_import->set_attribute_types($params_3);
610 isa_ok($attr_type_3, 'Koha::Patron::Attribute::Type');
611 is($attr_type_3->code, $code_3, 'Got the expected code attribute type from set attribute types');
614 subtest 'test_set_column_keys' => sub {
617 my @columns = Koha::Patrons->columns;
618 # Given ... nothing at all
620 my @columnkeys_0 = $patrons_import->set_column_keys(undef);
621 # -1 because we do not want the borrowernumber column
622 # +2 for guarantor id and guarantor relationship
623 is(scalar @columnkeys_0, @columns - 1 + 2, 'Got the expected array size from set column keys with undef extended');
625 # Given ... extended.
629 my @columnkeys_1 = $patrons_import->set_column_keys($extended);
630 is(scalar @columnkeys_1, @columns - 1 + 2 + $extended, 'Got the expected array size from set column keys with extended');
633 subtest 'test_generate_patron_attributes' => sub {
636 # Given ... nothing at all
638 my $result_0 = $patrons_import->generate_patron_attributes(undef, undef, undef);
639 is($result_0, undef, 'Got the expected undef from set patron attributes with nothing');
641 # Given ... not extended.
645 my $result_1 = $patrons_import->generate_patron_attributes($extended_1, undef, undef);
646 is($result_1, undef, 'Got the expected undef from set patron attributes with not extended');
648 # Given ... NO patrons attributes
650 my $patron_attributes_2 = undef;
654 my $result_2 = $patrons_import->generate_patron_attributes($extended_2, $patron_attributes_2, \@feedback_2);
657 is($result_2, undef, 'Got the expected undef from set patron attributes with no patrons attributes');
658 is(scalar @feedback_2, 0, 'Got the expected 0 size feedback array from set patron attributes with no patrons attributes');
660 # Given ... some patrons attributes
661 my $patron_attributes_3 = "homeroom:1150605,grade:01";
665 my $result_3 = $patrons_import->generate_patron_attributes($extended_2, $patron_attributes_3, \@feedback_3);
668 ok($result_3, 'Got some data back from set patron attributes');
669 is($result_3->[0]->{code}, 'grade', 'Got the expected first code from set patron attributes');
670 is($result_3->[0]->{attribute}, '01', 'Got the expected first value from set patron attributes');
672 is($result_3->[1]->{code}, 'homeroom', 'Got the expected second code from set patron attributes');
673 is($result_3->[1]->{attribute}, 1150605, 'Got the expected second value from set patron attributes');
675 is(scalar @feedback_3, 1, 'Got the expected 1 array size from set patron attributes with extended user');
676 is($feedback_3[0]->{feedback}, 1, 'Got the expected second feedback from set patron attributes with extended user');
677 is($feedback_3[0]->{name}, 'attribute string', 'Got the expected attribute string from set patron attributes with extended user');
678 is($feedback_3[0]->{value}, 'homeroom:1150605,grade:01', 'Got the expected feedback value from set patron attributes with extended user');
681 subtest 'test_check_branch_code' => sub {
684 # Given ... no branch code.
685 my $borrowerline = 'some, line';
686 my $line_number = 78;
687 my @missing_criticals = ();
690 $patrons_import->check_branch_code(undef, $borrowerline, $line_number, \@missing_criticals);
693 is(scalar @missing_criticals, 1, 'Got the expected missing critical array size of 1 from check_branch_code with no branch code');
695 is($missing_criticals[0]->{key}, 'branchcode', 'Got the expected branchcode key from check_branch_code with no branch code');
696 is($missing_criticals[0]->{line}, $line_number, 'Got the expected line number from check_branch_code with no branch code');
697 is($missing_criticals[0]->{lineraw}, $borrowerline, 'Got the expected lineraw value from check_branch_code with no branch code');
699 # Given ... unknown branch code
700 my $branchcode_1 = 'unexpected';
701 my $borrowerline_1 = 'some, line,'.$branchcode_1;
702 my $line_number_1 = 79;
703 my @missing_criticals_1 = ();
706 $patrons_import->check_branch_code($branchcode_1, $borrowerline_1, $line_number_1, \@missing_criticals_1);
709 is(scalar @missing_criticals_1, 1, 'Got the expected missing critical array size of 1 from check_branch_code with unexpected branch code');
711 is($missing_criticals_1[0]->{branch_map}, 1, 'Got the expected 1 branch_map from check_branch_code with unexpected branch code');
712 is($missing_criticals_1[0]->{key}, 'branchcode', 'Got the expected branchcode key from check_branch_code with unexpected branch code');
713 is($missing_criticals_1[0]->{line}, $line_number_1, 'Got the expected line number from check_branch_code with unexpected branch code');
714 is($missing_criticals_1[0]->{lineraw}, $borrowerline_1, 'Got the expected lineraw value from check_branch_code with unexpected branch code');
715 is($missing_criticals_1[0]->{value}, $branchcode_1, 'Got the expected value from check_branch_code with unexpected branch code');
717 # Given ... a known branch code. Relies on database sample data
718 my $branchcode_2 = 'FFL';
719 my $borrowerline_2 = 'some, line,'.$branchcode_2;
720 my $line_number_2 = 80;
721 my @missing_criticals_2 = ();
724 $patrons_import->check_branch_code($branchcode_2, $borrowerline_2, $line_number_2, \@missing_criticals_2);
727 is(scalar @missing_criticals_2, 0, 'Got the expected missing critical array size of 0 from check_branch_code');
730 subtest 'test_check_borrower_category' => sub {
733 # Given ... no category code.
734 my $borrowerline = 'some, line';
735 my $line_number = 781;
736 my @missing_criticals = ();
739 $patrons_import->check_borrower_category(undef, $borrowerline, $line_number, \@missing_criticals);
742 is(scalar @missing_criticals, 1, 'Got the expected missing critical array size of 1 from check_branch_code with no category code');
744 is($missing_criticals[0]->{key}, 'categorycode', 'Got the expected categorycode key from check_branch_code with no category code');
745 is($missing_criticals[0]->{line}, $line_number, 'Got the expected line number from check_branch_code with no category code');
746 is($missing_criticals[0]->{lineraw}, $borrowerline, 'Got the expected lineraw value from check_branch_code with no category code');
748 # Given ... unknown category code
749 my $categorycode_1 = 'unexpected';
750 my $borrowerline_1 = 'some, line, line, '.$categorycode_1;
751 my $line_number_1 = 791;
752 my @missing_criticals_1 = ();
755 $patrons_import->check_borrower_category($categorycode_1, $borrowerline_1, $line_number_1, \@missing_criticals_1);
758 is(scalar @missing_criticals_1, 1, 'Got the expected missing critical array size of 1 from check_branch_code with unexpected category code');
760 is($missing_criticals_1[0]->{category_map}, 1, 'Got the expected 1 category_map from check_branch_code with unexpected category code');
761 is($missing_criticals_1[0]->{key}, 'categorycode', 'Got the expected branchcode key from check_branch_code with unexpected category code');
762 is($missing_criticals_1[0]->{line}, $line_number_1, 'Got the expected line number from check_branch_code with unexpected category code');
763 is($missing_criticals_1[0]->{lineraw}, $borrowerline_1, 'Got the expected lineraw value from check_branch_code with unexpected category code');
764 is($missing_criticals_1[0]->{value}, $categorycode_1, 'Got the expected value from check_branch_code with unexpected category code');
766 # Given ... a known category code. Relies on database sample data.
767 my $categorycode_2 = 'T';
768 my $borrowerline_2 = 'some, line,'.$categorycode_2;
769 my $line_number_2 = 801;
770 my @missing_criticals_2 = ();
773 $patrons_import->check_borrower_category($categorycode_2, $borrowerline_2, $line_number_2, \@missing_criticals_2);
776 is(scalar @missing_criticals_2, 0, 'Got the expected missing critical array size of 0 from check_branch_code');
779 subtest 'test_format_dates' => sub {
782 # Given ... no borrower data.
783 my $borrowerline = 'another line';
784 my $line_number = 987;
785 my @missing_criticals = ();
787 my $params = {borrower => \%borrower, lineraw => $borrowerline, line => $line_number, missing_criticals => \@missing_criticals, };
790 $patrons_import->format_dates($params);
793 ok( not(%borrower), 'Got the expected no borrower from format_dates with no dates');
794 is(scalar @missing_criticals, 0, 'Got the expected missing critical array size of 0 from format_dates with no dates');
796 # Given ... some good dates
797 my @missing_criticals_1 = ();
798 my $dateofbirth_1 = '2016-05-03';
799 my $dateenrolled_1 = '2016-05-04';
800 my $dateexpiry_1 = '2016-05-06';
801 my $borrower_1 = { dateofbirth => $dateofbirth_1, dateenrolled => $dateenrolled_1, dateexpiry => $dateexpiry_1, };
802 my $params_1 = {borrower => $borrower_1, lineraw => $borrowerline, line => $line_number, missing_criticals => \@missing_criticals_1, };
805 $patrons_import->format_dates($params_1);
808 is($borrower_1->{dateofbirth}, $dateofbirth_1, 'Got the expected date of birth from format_dates with good dates');
809 is($borrower_1->{dateenrolled}, $dateenrolled_1, 'Got the expected date of birth from format_dates with good dates');
810 is($borrower_1->{dateexpiry}, $dateexpiry_1, 'Got the expected date of birth from format_dates with good dates');
811 is(scalar @missing_criticals_1, 0, 'Got the expected missing critical array size of 0 from check_branch_code with good dates');
813 # Given ... some very bad dates
814 my @missing_criticals_2 = ();
815 my $dateofbirth_2 = '03-2016-05';
816 my $dateenrolled_2 = '04-2016-05';
817 my $dateexpiry_2 = '06-2016-05';
818 my $borrower_2 = { dateofbirth => $dateofbirth_2, dateenrolled => $dateenrolled_2, dateexpiry => $dateexpiry_2, };
819 my $params_2 = {borrower => $borrower_2, lineraw => $borrowerline, line => $line_number, missing_criticals => \@missing_criticals_2, };
822 $patrons_import->format_dates($params_2);
825 is($borrower_2->{dateofbirth}, '', 'Got the expected empty date of birth from format_dates with bad dates');
826 is($borrower_2->{dateenrolled}, '', 'Got the expected emptydate of birth from format_dates with bad dates');
827 is($borrower_2->{dateexpiry}, '', 'Got the expected empty date of birth from format_dates with bad dates');
829 is(scalar @missing_criticals_2, 3, 'Got the expected missing critical array size of 3 from check_branch_code with bad dates');
830 is($missing_criticals_2[0]->{bad_date}, 1, 'Got the expected first bad date flag from check_branch_code with bad dates');
831 is($missing_criticals_2[0]->{key}, 'dateofbirth', 'Got the expected dateofbirth key from check_branch_code with bad dates');
832 is($missing_criticals_2[0]->{line}, $line_number, 'Got the expected first line from check_branch_code with bad dates');
833 is($missing_criticals_2[0]->{lineraw}, $borrowerline, 'Got the expected first lineraw from check_branch_code with bad dates');
835 is($missing_criticals_2[1]->{bad_date}, 1, 'Got the expected second bad date flag from check_branch_code with bad dates');
836 is($missing_criticals_2[1]->{key}, 'dateenrolled', 'Got the expected dateenrolled key from check_branch_code with bad dates');
837 is($missing_criticals_2[1]->{line}, $line_number, 'Got the expected second line from check_branch_code with bad dates');
838 is($missing_criticals_2[1]->{lineraw}, $borrowerline, 'Got the expected second lineraw from check_branch_code with bad dates');
840 is($missing_criticals_2[2]->{bad_date}, 1, 'Got the expected third bad date flag from check_branch_code with bad dates');
841 is($missing_criticals_2[2]->{key}, 'dateexpiry', 'Got the expected dateexpiry key from check_branch_code with bad dates');
842 is($missing_criticals_2[2]->{line}, $line_number, 'Got the expected third line from check_branch_code with bad dates');
843 is($missing_criticals_2[2]->{lineraw}, $borrowerline, 'Got the expected third lineraw from check_branch_code with bad dates');
846 subtest 'patron_attributes' => sub {
850 t::lib::Mocks::mock_preference('ExtendedPatronAttributes', 1);
852 my $unique_attribute_type = $builder->build_object(
854 class => 'Koha::Patron::Attribute::Types',
855 value => { unique_id=> 1, repeatable => 0 }
858 my $repeatable_attribute_type = $builder->build_object(
860 class => 'Koha::Patron::Attribute::Types',
861 value => { unique_id => 0, repeatable => 1 }
864 my $normal_attribute_type = $builder->build_object(
866 class => 'Koha::Patron::Attribute::Types',
867 value => { unique_id => 0, repeatable => 0 }
870 my $non_existent_attribute_type = $builder->build_object(
872 class => 'Koha::Patron::Attribute::Types',
875 my $non_existent_attribute_type_code = $non_existent_attribute_type->code;
876 $non_existent_attribute_type->delete;
878 our $cardnumber = "1042";
880 # attributes is { code => \@attributes }
882 my ($attributes) = @_;
884 my $csv_headers = 'cardnumber,surname,firstname,branchcode,categorycode,patron_attributes';
885 my @attributes_str = map { my $code = $_; map { sprintf "%s:%s", $code, $_ } @{ $attributes->{$code} } } keys %$attributes;
886 my $attributes_str = join ',', @attributes_str;
887 my $csv_line = sprintf '%s,John,D,MPL,PT,"%s"', $cardnumber, $attributes_str;
888 my $filename = make_csv( $temp_dir, $csv_headers, $csv_line );
889 open( my $fh, "<:encoding(utf8)", $filename ) or die "cannot open $filename: $!";
893 { # Everything good, we create a patron with 3 attributes
895 $unique_attribute_type->code => ['my unique attribute 1'],
896 $repeatable_attribute_type->code => [ 'my repeatable attribute 1', 'my repeatable attribute 2' ],
897 $normal_attribute_type->code => ['my normal attribute 1'],
899 my $fh = build_csv({ %$attributes });
900 my $result = $patrons_import->import_patrons({file => $fh});
902 is( $result->{imported}, 1 );
904 my $patron = Koha::Patrons->find({cardnumber => $cardnumber});
905 compare_patron_attributes($patron->extended_attributes->unblessed, { %$attributes } );
910 $builder->build_object(
912 class => 'Koha::Patron::Attributes',
913 value => { code => $unique_attribute_type->code, attribute => 'unique' }
918 $unique_attribute_type->code => ['unique'],
919 $normal_attribute_type->code => ['my normal attribute 1']
921 my $fh = build_csv({ %$attributes });
923 my $result = $patrons_import->import_patrons({file => $fh, matchpoint => 'cardnumber'});
924 my $error = $result->{errors}->[0];
925 is( $error->{patron_attribute_unique_id_constraint}, 1 );
926 is( $error->{patron_id}, $cardnumber );
927 is( $error->{attribute}->code, $unique_attribute_type->code );
929 my $patron = Koha::Patrons->find({cardnumber => $cardnumber});
930 is( $patron, undef );
936 # got is { code => $code, attribute => $attribute }
937 # expected is { $code => \@attributes }
938 sub compare_patron_attributes {
939 my ( $got, $expected ) = @_;
941 $got = [ map { { code => $_->{code}, attribute => $_->{attribute} } } @$got ];
945 map { { code => $code, attribute => $_ } } @{ $expected->{$code} }
948 for my $v ( $got, $expected ) {
951 $a->{code} cmp $b->{code} || $a->{attribute} cmp $b->{attribute}
955 is_deeply($got, $expected);
958 # ###### Test utility ###########
960 my ($temp_dir, @lines) = @_;
962 my ($fh, $filename) = tempfile( DIR => $temp_dir) or die $!;
963 print $fh $_."\r\n" foreach @lines;