koha.git
13 years agobug 2295 [followup 1/2]: added name to one of tests in icondirectories.t
Galen Charlton [Mon, 7 Jul 2008 17:54:48 +0000 (12:54 -0500)]
bug 2295 [followup 1/2]: added name to one of tests in icondirectories.t

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2295 [4/4]: moving C4::Labels tests into t/lib/KohaTest
Andrew Moore [Mon, 7 Jul 2008 17:54:49 +0000 (12:54 -0500)]
bug 2295 [4/4]: moving C4::Labels tests into t/lib/KohaTest

t/Labels.t was dependent on a working test database, so I'm moving those
tests into t/lib/KohaTest

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2295 [3/4]: moving C4::Items tests into t/lib/KohaTest
Andrew Moore [Mon, 7 Jul 2008 17:54:50 +0000 (12:54 -0500)]
bug 2295 [3/4]: moving C4::Items tests into t/lib/KohaTest

The t/Items.t tests were actually dependent on the database, so I'm moving them
into t/lib/KohaTest.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2295 [2/4]: moving icondirectories.t from t to xt
Andrew Moore [Mon, 7 Jul 2008 17:54:47 +0000 (12:54 -0500)]
bug 2295 [2/4]: moving icondirectories.t from t to xt

the icondirectories.t test depends on the database, so it needed to be
moved. But, it's really more of an author test since it's testinging the
correct structure of our distribution, so I'm moving it to xt/author.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2295 [1/4]: moving C4::Dates tests into database dependent tests
Andrew Moore [Mon, 7 Jul 2008 17:54:51 +0000 (12:54 -0500)]
bug 2295 [1/4]: moving C4::Dates tests into database dependent tests

the t/Dates.t tests were actually databasase dependent. This patch replaces
t/Dates.t with t/lib/KohaTest/Dates/Usage.pm that relies on a database.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoBUGFIX : unimarc leader is 24, not 25. Fixing the javascript test
Paul POULAIN [Wed, 2 Jul 2008 17:48:01 +0000 (19:48 +0200)]
BUGFIX : unimarc leader is 24, not 25. Fixing the javascript test

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoBug#: 1989
DeAndre Carroll [Thu, 3 Jul 2008 18:01:12 +0000 (13:01 -0500)]
Bug#: 1989

Changed date popups in scheduler.tmpl to a date picker element
Made corresponding changes to scheduler.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2275: making SMS::Send module optional
Andrew Moore [Thu, 3 Jul 2008 19:08:46 +0000 (14:08 -0500)]
bug 2275: making SMS::Send module optional

I wrapped the use of the SMS::Send module in an eval to make failures graceful if it
is not present.
I also fixed an error with the number of tests in the SMS::Send tests.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agotest suite: way to run single test file
Galen Charlton [Thu, 3 Jul 2008 18:34:03 +0000 (13:34 -0500)]
test suite: way to run single test file

Added support for a new target in the test Makefile
to run a single test module.  If you do (for example)

make test-single TEST_FILES=lib/KohaTest/Biblio.pm

only the tests in that module will be run.  Unlike
the full test suite as run via 'make test', 'make test-single'
does not clear the test database before running the
tests.

Please note that "TEST_FILES=path/to/test/class.pm" is
required when using 'make test-single'.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoBarcodes - OO replacements, extensible module, tests.
Joe Atzberger [Thu, 3 Jul 2008 19:18:01 +0000 (14:18 -0500)]
Barcodes - OO replacements, extensible module, tests.

This code is intended to replace current value_builder code in 3.2, but
it does not affect it directly (yet) and is safe to include in 3.0.
This structure will be used to handle more complicated formats, like those
with checkdigits.  Please note that "incremental" format is still STRONGLY
recommended because it will always perform the best, and most flexibly.
The desire to include other information (like branchcode) should compel
the proper use of the barcode generator to print the info ON the barcode,
not IN the barcode.

One of the nicer features of this structure is that you are able to
create a new barcode (of the same type) based on any previous Barcodes object.
That means you can create an array of 51 consecutive barcodes like:
my $x = C4::Barcodes->new('annual'); # for example
my @set = ($x);
for (1..50) {
push @set, $x=$x->new;
}
Importantly, this can happen without referencing the database after the
first constructor.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2171: remove cancel transfer
Galen Charlton [Thu, 3 Jul 2008 21:27:13 +0000 (16:27 -0500)]
bug 2171: remove cancel transfer

The "transfers to receive" report included
unused code to delete a transfer.  Since the
"transfers to receive" report is still useful
to give a library a report of items that it should
expect to receive, I am retaining the report.  However,
since the cancel transfer functionality would not
work even if it were uncommented in the template, that
portion is removed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2171: removed "Transfers to do" report
Galen Charlton [Thu, 3 Jul 2008 21:27:12 +0000 (16:27 -0500)]
bug 2171: removed "Transfers to do" report

This hold request and transfer report no longer
works now that hold requests are processed via
checking items in.

This patch removes the report; please consult
the koha-devel message re "RFC - remove circ/transferstodo.pl prior to general release"
for more details.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2305: install tags/* to intranet CGI directory
Galen Charlton [Thu, 3 Jul 2008 20:07:46 +0000 (15:07 -0500)]
bug 2305: install tags/* to intranet CGI directory

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2297: improve ModBiblio() to avoid duplicate item fields
Galen Charlton [Thu, 3 Jul 2008 19:40:59 +0000 (14:40 -0500)]
bug 2297: improve ModBiblio() to avoid duplicate item fields

Prior to this patch, ModBiblio() would append
item tags from the previous version of the bib record
to the incoming bib record before saving the results,
even if the incoming bib record already has embedded
item tags.

For example, if a bib is retrieved using GetMarcBiblio() then
saved using ModBiblio(), the caller was obliged
to delete any item tags first to avoid duplication.

ModBiblio() now deletes item tags supplied in the
incoming MARC record.  This eliminates the possibility
of duplication, and removes any implication that
ModBiblio() can or should be used to modify item
records - ModItem() should be used for that.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agocommenting warn
Paul POULAIN [Wed, 2 Jul 2008 17:48:00 +0000 (19:48 +0200)]
commenting warn

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agotest suite add_biblios: don't use zebraqueue_daemon
Galen Charlton [Tue, 1 Jul 2008 17:36:29 +0000 (12:36 -0500)]
test suite add_biblios: don't use zebraqueue_daemon

The add_biblios() routine now reindexes all bibs
in batch instead of waiting for zebraqueue_daemon - this
is moderately faster.  A separate set of test
cases for zebraqueue_deamon will be witten.

No documentation changes.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoSimpleSearch test cases - make more robust
Galen Charlton [Tue, 1 Jul 2008 17:36:28 +0000 (12:36 -0500)]
SimpleSearch test cases - make more robust

Test cases in KohaTest/Search/SimpleSearch.pm assumed
that they were the first to call add_biblios(); as
this is not necessarily true when the entire test
suite is run, test now counts how many 'Finn Test'
bibs already exist.

No documentation changes.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2293: better validation in overdue rules editor
Galen Charlton [Tue, 1 Jul 2008 16:53:23 +0000 (11:53 -0500)]
bug 2293: better validation in overdue rules editor

If a rule should not be saved because a delay is
given but no letter or debar action is specified
for that delay, an error message is now reported.

Also:

* use "dialog alert" CSS class for confirmation
  that form was saved
* if form input is saved, retrieve the settings from the
  database again when displaying the form - this will
  help turn up any bugs where the script is not
  saving the overdue rules correctly.
* fix display of patron category in error messages

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agooverdue rules - added JavaScript for branch selector
Galen Charlton [Tue, 1 Jul 2008 16:53:22 +0000 (11:53 -0500)]
overdue rules - added JavaScript for branch selector

This makes the overdue notice rule editor consistent
with the branch selector for the circulation rules
editor.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2292: save overdule rules to correct branch
Galen Charlton [Tue, 1 Jul 2008 16:53:21 +0000 (11:53 -0500)]
bug 2292: save overdule rules to correct branch

Save overdue rules to the selected branch, not always
to the default branch.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2291: sort branches and letter types
Galen Charlton [Tue, 1 Jul 2008 16:53:20 +0000 (11:53 -0500)]
bug 2291: sort branches and letter types

The drop-down lists of branches and letter templates
in the overdue notice/status triggers tool are now
sorted in ascending alphabetical order.

No documentation change.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agospelling correction in comment in javascript file
Andrew Moore [Mon, 30 Jun 2008 14:14:42 +0000 (09:14 -0500)]
spelling correction in comment in javascript file

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoOAI package handle correctly unicode content
Philippe Jaillon [Mon, 30 Jun 2008 14:07:36 +0000 (16:07 +0200)]
OAI package handle correctly unicode content

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2176: spelling correction
Andrew Moore [Mon, 30 Jun 2008 13:22:17 +0000 (08:22 -0500)]
bug 2176: spelling correction

correcting spelling in opac messaging tab.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoOPACUserCSS has wrong default value (fix for 2211, for french)
Paul POULAIN [Mon, 30 Jun 2008 13:11:28 +0000 (15:11 +0200)]
OPACUserCSS has wrong default value (fix for 2211, for french)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agofrench updated
Paul POULAIN [Mon, 30 Jun 2008 13:11:27 +0000 (15:11 +0200)]
french updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2278 - fix results pagination in auth_finder
Galen Charlton [Thu, 26 Jun 2008 21:16:16 +0000 (16:16 -0500)]
bug 2278 - fix results pagination in auth_finder

Fix same as for 2205 - the orderby parameter is
currently required for authority searches.

Also set default results per page to 20 instead of
19.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoDocuments translator dependency on 'gettext' Linux tools and add it to debian.packages
Frederic Demians [Thu, 26 Jun 2008 05:03:28 +0000 (07:03 +0200)]
Documents translator dependency on 'gettext' Linux tools and add it to debian.packages

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoFix alternating "highlight" to use __odd__ and combine consequetive
Joe Atzberger [Thu, 26 Jun 2008 01:00:33 +0000 (20:00 -0500)]
Fix alternating "highlight" to use __odd__ and combine consequetive

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoBugfix Correcting opac-shelves template to allow patron to set list category to publi...
Chris Nighswonger [Wed, 25 Jun 2008 23:34:51 +0000 (18:34 -0500)]
Bugfix Correcting opac-shelves template to allow patron to set list category to public or private

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoBugfix correcting 'New List' behavior on opac-search.pl
Chris Nighswonger [Wed, 25 Jun 2008 23:34:50 +0000 (18:34 -0500)]
Bugfix correcting 'New List' behavior on opac-search.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoCorrecting mistyped var names and adding error trapping to C4::VirtualShelves::Page
Chris Nighswonger [Wed, 25 Jun 2008 23:34:49 +0000 (18:34 -0500)]
Correcting mistyped var names and adding error trapping to C4::VirtualShelves::Page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoScript to correct faulty statistics table entries.
Joe Atzberger [Wed, 25 Jun 2008 23:21:28 +0000 (18:21 -0500)]
Script to correct faulty statistics table entries.

This is the first iteration of this script, likely to be expanded
if other mappings are determined.  Currently it populates the
itemtype for all statistics that have itemnumbers and then pulls
borrownumbers from old_issues (or issues).  This has the benign
side effect of ignoring whether or not itemtype was a different
value at the time of the transaction.

It then tries to populate null borrowernumbers using a fairly
conservative approach, only where exactly one match exists, else warns.

The process of updating statistics is needlessly complex based on the
lack of a reliable primary key.  ALL such tables should have a numerical
primary key.  The impression that the timestamp and any other fields
are enough to combine for a "unique enough" key is wrong.  For example,
running SIP tests will add multiple transactions that might share
borrowernumber, itemnumber and timestamp.  Key uniqueness should be
logically inherent, not de facto.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoadding 'gettext' as this is requred by the translation utility
Joshua Ferraro [Thu, 26 Jun 2008 10:33:47 +0000 (05:33 -0500)]
adding 'gettext' as this is requred by the translation utility

13 years agobug 2176: fix typo in column name (DB rev 096)
Galen Charlton [Wed, 25 Jun 2008 20:24:41 +0000 (15:24 -0500)]
bug 2176: fix typo in column name (DB rev 096)

In borrower_message_preferences, wants_digets => wants_digest

Note that the typo is present only in databases that had
borrower_message_preferences created via updatedatabase.pl.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug: 2269 - adding a perltidyrc file
Andrew Moore [Mon, 23 Jun 2008 17:55:31 +0000 (12:55 -0500)]
bug: 2269 - adding a perltidyrc file

This patch adds xt/perltidyrc, a suggested perltidy configuration file.

It's in the xt directory because I'd like to eventually tie it in with Test::Perl::Critic
to run automated tests on tidyness and other Perl::Critic policies. That stuff belongs in
the xt directory since it's testing for developers use only.

I have only turned on a few directives based on the suggestions by MJ, historical discussion on
the mailing lists, and what I was told when I started contributing to koha. There are many other
directives in this file that are commented out. They are supposed to represent the defaults and
can be adjusted in the future if desired.

Use of this file is encouraged, but not required. It would be really nice if you could at least run
it on new files that you contribute. I would recommend not running it on files that are already
part of koha without writing some tests for those files and discussing your intentions to reformat
entire files in bulk.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug: 2272 - remove warning from C4::Koha::getitemtypeimagedir
Andrew Moore [Mon, 23 Jun 2008 17:35:58 +0000 (12:35 -0500)]
bug: 2272 - remove warning from C4::Koha::getitemtypeimagedir

I changed getitemtypeimagedir to set a default on its argument so that it would not complain if not passed 'opac'.
I improved the documentation on the method.
I edited the t/icondirecotries.t test script to explicitly pass an argument to both getitemtypeimagedir calls.
 - and I adjusted one line of whitespace to make similar things look similar
I added a test module for C4::Koha
I added a test module for C4::Koha::getitemtypeimagedir.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agofix Date::ICal typo
Galen Charlton [Wed, 25 Jun 2008 16:41:38 +0000 (11:41 -0500)]
fix Date::ICal typo

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoInteractive tests for SIP abstraction representation and Members.
Joe Atzberger (siptest [Tue, 24 Jun 2008 22:35:13 +0000 (17:35 -0500)]
Interactive tests for SIP abstraction representation and Members.

The test for members is useful to compare against the SIP (ILS)
representation.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoBugfix Circulation, Expand ILS::Patron mapping.
Joe Atzberger (siptest [Tue, 24 Jun 2008 22:35:12 +0000 (17:35 -0500)]
Bugfix Circulation, Expand ILS::Patron mapping.

ILS::Patron is where most of the intelligence for SIP's representation
is lodged.  Currently there is difficulty with C4::Members functions.
GetMemberDetails is required for the needed flags, but it returns
empty structure on bad barcodes, where it should be undef.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2254 [3/3]: add authority type check
Galen Charlton [Wed, 25 Jun 2008 16:30:03 +0000 (11:30 -0500)]
bug 2254 [3/3]: add authority type check

Added a test to the MARC framework checks to
verify that all authority types used in a framework
are defined.

Documentation changes: possible new screenshots
and text to describe the new test.

NOTE: This patch adds strings to the checkmarc template, and thus
      violates the string freeze for 3.0.  I'm submitting anyway
      because 2254 is a blocker, but if no exception is made,
      it is safe to not apply this patch for 3.0.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2254 [2/3]: fix authority types in MARC21 frameworks (DB rev 095)
Galen Charlton [Wed, 25 Jun 2008 16:30:02 +0000 (11:30 -0500)]
bug 2254 [2/3]: fix authority types in MARC21 frameworks (DB rev 095)

Corrected two errors found in the authority types used
in the MARC21 frameworks:

* one subfield that used "Meeting Name" instead of "MEETI_NAME"
* various subfields that used "CORP0_NAME" instead of "CORPO_NAME"

The biggest visible consequence of this change is that corporate
name headings (110, 610, 710, 810, etc.) will now link correctly
to their authority records.

In addition, brought the fr-FR MARC21 framework scripts up-to-date
with respect to the changes made to the English versions.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2254 [1/3]: fixed GetAuthType(); avoid crash
Galen Charlton [Wed, 25 Jun 2008 16:30:01 +0000 (11:30 -0500)]
bug 2254 [1/3]: fixed GetAuthType(); avoid crash

Improved C4::AuthoritiesMarc::GetAuthType() so that
it returns either a hashref (if the authority type exists)
or undef (if it does not exist).  The same
accessor should not be used to either return a single
value or all values of a settings list.  Note that
all existing clients of GetAuthType are expecting
either a single hashref or undef; none of them
expected the arrayref that could be returned by
the previous version of the accessor.

When BiblioAddsAuthorities is ON, addbiblio.pl
now checks the return value of GetAuthType and
no longer crashes as follows if the MARC framework
specifies an invalid authority type for a given subfield:

Can't coerce array into hash at .../cataloging/addbiblio.pl line 738.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2206: always have $9 for headings fields
Galen Charlton [Tue, 24 Jun 2008 22:12:23 +0000 (17:12 -0500)]
bug 2206: always have $9 for headings fields

If a field can be linked to an authority record (i.e.,
an authtypecode is defined for subfield $a), always
include the subfield $9 in a (readonly) input element even
if it is marked hidden per the MARC framework.

Prior to this patch, a $9 marked hidden per the framework
would not be included in the form, causing the authority record
number link to not be added when choosing a heading from the authority
finder.  In other words, with BiblioAddsAuthorities OFF,
any authorized headings in bibs added via the MARC editor
would not have the subfield $9, and thus would appear
to not be used by any bibs.

Note that subfield $9 is set to be readonly, as changing the
authority number link does not currently change the
heading stored in the bib record.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoclean up old-style calls to GetMemberDetails
Galen Charlton [Tue, 24 Jun 2008 15:21:12 +0000 (10:21 -0500)]
clean up old-style calls to GetMemberDetails

GetMemberDetails() returns only one hashref now,
not two.  In all cases where the caller was
expecting two output values, the $flags return
was ignored anyway.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoPOD fixes - C4/Members.pm
Galen Charlton [Tue, 24 Jun 2008 15:04:41 +0000 (10:04 -0500)]
POD fixes - C4/Members.pm

Corrected and improved the description of the
return values of GetMemberDetails.

Also fixed errors reported by the podcorrectness
test.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2252: item-level hold not waiting until priority = 0
Galen Charlton [Mon, 23 Jun 2008 20:33:32 +0000 (15:33 -0500)]
bug 2252: item-level hold not waiting until priority = 0

When returning an item that has an item-level hold on it,
CheckReserves() will not consider it waiting unless the
priority has been set to 0 (i.e., the item has specifically
been marked as filling the request.)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2273: not-for-loan item should not fill hold request
Galen Charlton [Mon, 23 Jun 2008 16:15:01 +0000 (11:15 -0500)]
bug 2273: not-for-loan item should not fill hold request

If an item is not for loan (i.e., items.notforloan is not null),
do not use it to fill a title-level hold request when
item is checked in.  Prior to this patch, a notforloan item
could fill a request - CheckReserves() was checking only
the item's item type's not for loan flag.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoNote optional modules, for later reference.
MJ Ray [Mon, 23 Jun 2008 15:33:50 +0000 (16:33 +0100)]
Note optional modules, for later reference.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoremoving maxItemsInSearchResults syspref from script
Joshua Ferraro [Tue, 24 Jun 2008 12:30:43 +0000 (07:30 -0500)]
removing maxItemsInSearchResults syspref from script

13 years agoslef's patch for 'Algorithm::CheckDigits' => 0.50, v3.00.00-stableRC1
Joshua Ferraro [Mon, 23 Jun 2008 15:35:55 +0000 (10:35 -0500)]
slef's patch for 'Algorithm::CheckDigits'          => 0.50,

13 years agonew automated test for template translatability
Galen Charlton [Mon, 23 Jun 2008 15:01:33 +0000 (10:01 -0500)]
new automated test for template translatability

This test verifies that the English OPAC and staff templates
can be processed by the string extractor (tmpl_process3.pl)
without error.  If a template contains a parsing error
(at least as far as tmpl_process3.pl is concerned), it may
not be correctly converted when a language translation
is applied.

To run this test, do

prove -v xt/author/translatable-templates.t

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoUpdating release number
Joshua Ferraro [Mon, 23 Jun 2008 13:05:49 +0000 (08:05 -0500)]
Updating release number

13 years agoUpdating translations prior to RC1 release
Joshua Ferraro [Mon, 23 Jun 2008 13:04:10 +0000 (08:04 -0500)]
Updating translations prior to RC1 release

13 years agoDB Bump 094 - bug 2268 -- allow mixed case subfield labels in MARC21 by changing...
Ryan Higgins [Sun, 22 Jun 2008 21:35:48 +0000 (16:35 -0500)]
DB Bump 094 - bug 2268 -- allow mixed case subfield labels in MARC21 by changing db column collation.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoCorrecting Release notes to read RC1 rather than Beta
Chris Nighswonger [Sat, 21 Jun 2008 11:02:01 +0000 (06:02 -0500)]
Correcting Release notes to read RC1 rather than Beta

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agotranslation fix
Joshua Ferraro [Mon, 23 Jun 2008 12:20:21 +0000 (07:20 -0500)]
translation fix

13 years agoFixed errors for translation
Joshua Ferraro [Mon, 23 Jun 2008 12:11:40 +0000 (07:11 -0500)]
Fixed errors for translation

13 years agoFixed errors for translation
Joshua Ferraro [Mon, 23 Jun 2008 12:11:06 +0000 (07:11 -0500)]
Fixed errors for translation

13 years agoUpdating all translations except for:
Joshua Ferraro [Sat, 21 Jun 2008 04:23:07 +0000 (23:23 -0500)]
Updating all translations except for:

el-GR-i-staff-t-prog-v-3000000.po
es-ES-i-staff-t-prog-v-3000000.po
hy-Armn-i-staff-prog-v-3000000.po
ru-RU-i-staff-t-prog-v-3000000.po
tr-TR-i-staff-t-prog-v-3000000.po
uk-UA-i-staff-t-prog-v-3000000.po
zh-Hans-CN-i-staff-t-prog-v-3000000.po

These will require extensive modifs to apply correctly due to
syntax problems.

13 years agoAdding release notes for 3.0 stable RC1
Joshua Ferraro [Sat, 21 Jun 2008 02:34:26 +0000 (21:34 -0500)]
Adding release notes for 3.0 stable RC1

13 years agoUpdates to translation files (pre-update.pl)
Joshua Ferraro [Sat, 21 Jun 2008 02:18:41 +0000 (21:18 -0500)]
Updates to translation files (pre-update.pl)

13 years agoworkaround for translation script
Joshua Ferraro [Sat, 21 Jun 2008 01:12:55 +0000 (20:12 -0500)]
workaround for translation script

13 years agoworkaround for translation script
Joshua Ferraro [Sat, 21 Jun 2008 01:02:12 +0000 (20:02 -0500)]
workaround for translation script

13 years agoworkaround for translation update script
Joshua Ferraro [Sat, 21 Jun 2008 00:59:54 +0000 (19:59 -0500)]
workaround for translation update script

13 years agoAdding Public note to default Normal view in opac-detail page.
Ryan Higgins [Fri, 20 Jun 2008 23:39:04 +0000 (18:39 -0500)]
Adding Public note to default Normal view in opac-detail page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agofix for 1913: Remove opaclargeimage system preference
Joshua Ferraro [Fri, 20 Jun 2008 23:38:10 +0000 (18:38 -0500)]
fix for 1913: Remove opaclargeimage system preference

13 years agobug 1553 - fix breadcrumbs on add by suggestion page.
Ryan Higgins [Fri, 20 Jun 2008 23:19:06 +0000 (18:19 -0500)]
bug 1553 - fix breadcrumbs on add by suggestion page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agofix for bug 2255: Sys Prefs need to be moved from Local Use
Joshua Ferraro [Fri, 20 Jun 2008 23:18:39 +0000 (18:18 -0500)]
fix for bug 2255: Sys Prefs need to be moved from Local Use

13 years agobug 1839 - add default shipment date to today.
Ryan Higgins [Fri, 20 Jun 2008 23:04:00 +0000 (18:04 -0500)]
bug 1839 - add default shipment date to today.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoRemove input for shipping cost as per bug 1965.
Ryan Higgins [Fri, 20 Jun 2008 23:03:44 +0000 (18:03 -0500)]
Remove input for shipping cost as per bug 1965.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoTidying up the Lists button menu
Chris Nighswonger [Fri, 20 Jun 2008 22:57:27 +0000 (17:57 -0500)]
Tidying up the Lists button menu

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2002: show item's in transit status in OPAC holds list
Galen Charlton [Fri, 20 Jun 2008 22:53:20 +0000 (17:53 -0500)]
bug 2002: show item's in transit status in OPAC holds list

If item is in transit, show that status in the OPAC
user's hold list rather than "waiting to be pulled".

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoDATABASE UPDATE: change copynumber column to allow free text - [ bug 2223 ] - WARNING...
Ryan Higgins [Fri, 20 Jun 2008 22:48:38 +0000 (17:48 -0500)]
DATABASE UPDATE: change copynumber column to allow free text - [ bug 2223 ] - WARNING, will take some time for large db.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoCorrecting "Your Lists" to display properly when no lists exist.
Chris Nighswonger [Fri, 20 Jun 2008 22:48:15 +0000 (17:48 -0500)]
Correcting "Your Lists" to display properly when no lists exist.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoINSTALL.opensuse - updated URL for Koha 3 RC1 .tar.gz
Ricardo Dias Marques [Fri, 20 Jun 2008 23:45:33 +0000 (00:45 +0100)]
INSTALL.opensuse - updated URL for Koha 3 RC1 .tar.gz

Updated wget line in INSTALL.opensuse for downloading
the Koha 3 RC1 ".tar.gz" file

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug: 2176 improvements to database upgrade path
Andrew Moore [Fri, 20 Jun 2008 22:43:13 +0000 (17:43 -0500)]
bug: 2176 improvements to database upgrade path

This patch calls the new optional database SQL scripts to that sensible data is isntalled.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2248 [2/2]: import item status display in search results
Galen Charlton [Fri, 20 Jun 2008 22:37:05 +0000 (17:37 -0500)]
bug 2248 [2/2]: import item status display in search results

The in transit status now displays as such in the
OPAC search results.  In the non-XSLT version, the status
is checked only for bibs having 20 or fewer items to avoid
extra hits on the database during result set presentation.
In the XSLT version, all items are checked.

Note that because an item's transfer status is not
stored in the MARC record, the transfer status
has no effect when limiting a search by item
availability.  For a future version, the transit status
should be added to the Zebra index.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2248 [1/2]: improve item status display in OPAC detail
Galen Charlton [Fri, 20 Jun 2008 22:37:04 +0000 (17:37 -0500)]
bug 2248 [1/2]: improve item status display in OPAC detail

The following statuses are now displayed correctly in the
bib details page in the OPAC:

* In transit
* Damaged
* Not for loan

Prior to this patch, items of these statuses displayed
as available.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agofix for 2117: opacbookbag should have the term 'cart' in the description
Joshua Ferraro [Fri, 20 Jun 2008 22:45:07 +0000 (17:45 -0500)]
fix for 2117: opacbookbag should have the term 'cart' in the description

13 years agofix for 2118: virtualshelves should say 'list' in the description
Joshua Ferraro [Fri, 20 Jun 2008 22:44:02 +0000 (17:44 -0500)]
fix for 2118: virtualshelves should say 'list' in the description

13 years agofix to 2142: maxItemsInSearchResults No longer used
Joshua Ferraro [Fri, 20 Jun 2008 22:42:42 +0000 (17:42 -0500)]
fix to 2142: maxItemsInSearchResults No longer used

13 years agofix to bug 1914: OpacNav system preference description contains typo
Joshua Ferraro [Fri, 20 Jun 2008 22:29:18 +0000 (17:29 -0500)]
fix to bug 1914: OpacNav system preference description contains typo

13 years agofix for 1948: LibraryName has wrong description
Joshua Ferraro [Fri, 20 Jun 2008 22:28:10 +0000 (17:28 -0500)]
fix for 1948: LibraryName has wrong description

13 years agofix to 2211: OPACUserCSS has wrong default value
Joshua Ferraro [Fri, 20 Jun 2008 22:26:12 +0000 (17:26 -0500)]
fix to 2211: OPACUserCSS has wrong default value

13 years agofix to 2179: Language Issue: Should be Holds not Reserves
Joshua Ferraro [Fri, 20 Jun 2008 22:09:49 +0000 (17:09 -0500)]
fix to 2179: Language Issue: Should be Holds not Reserves

13 years agofix for bug 1961: sprintf value needed in C4/Circulation.pm
Joshua Ferraro [Fri, 20 Jun 2008 22:04:27 +0000 (17:04 -0500)]
fix for bug 1961: sprintf value needed in C4/Circulation.pm

13 years agopatch from cnighs, fixing warn in Context.pm
Joshua Ferraro [Fri, 20 Jun 2008 22:00:58 +0000 (17:00 -0500)]
patch from cnighs, fixing warn in Context.pm

13 years agobugfix for bug introduced by anonymous session code
Chris Nighswonger [Fri, 20 Jun 2008 21:44:52 +0000 (16:44 -0500)]
bugfix for bug introduced by anonymous session code

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agobug 2201 - autoBarcode code in acq is old. Modified to only work with 'increment...
Ryan Higgins [Fri, 20 Jun 2008 21:36:01 +0000 (16:36 -0500)]
bug 2201 - autoBarcode code in acq is old. Modified to only work with 'increment', and added FIXME

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agofix for bug 2045: Network Printers Setting Does Nothing?
Joshua Ferraro [Fri, 20 Jun 2008 21:41:14 +0000 (16:41 -0500)]
fix for bug 2045: Network Printers Setting Does Nothing?

13 years agofix for 2199 for new installations, existing installations
Joshua Ferraro [Fri, 20 Jun 2008 21:35:29 +0000 (16:35 -0500)]
fix for 2199 for new installations, existing installations
can just change it manually in sysprefs to YesNo

13 years agoRemove EXPRs from includes file.
Joe Atzberger (siptest [Fri, 20 Jun 2008 21:21:14 +0000 (16:21 -0500)]
Remove EXPRs from includes file.

This prevents the following log entries:
    error EXPR:at pos 42: non-initialized variable OPACViewOthersSuggestions
EXPR must NOT be used unless the author can guarantee ALL names referenced
will be defined at the BEGINNING of TMPL execution.  That suggests that in
.inc files, only variables populated by get_template... are valid, since
the author cannot guarantee what other templates might include the file.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoCreated INSTALL.opensuse file
Ricardo Dias Marques [Fri, 20 Jun 2008 21:56:21 +0000 (22:56 +0100)]
Created INSTALL.opensuse file

Created installation instructions for installing Koha 3 in openSUSE 11.0

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoAnother API call fix to get the vendor name.
Ryan Higgins [Fri, 20 Jun 2008 20:56:40 +0000 (15:56 -0500)]
Another API call fix to get the vendor name.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoUse C4::Debug to conditionalize warn.
Joe Atzberger [Fri, 20 Jun 2008 20:18:15 +0000 (15:18 -0500)]
Use C4::Debug to conditionalize warn.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoUse C4::Debug on warn statements.
Joe Atzberger [Fri, 20 Jun 2008 20:18:14 +0000 (15:18 -0500)]
Use C4::Debug on warn statements.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoScript is not an Exporter. Convert to using C4::Debug.
Joe Atzberger [Fri, 20 Jun 2008 19:36:33 +0000 (14:36 -0500)]
Script is not an Exporter. Convert to using C4::Debug.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoThere is no doc-head-calendar.inc. I think it's called calendar.inc and
Joe Atzberger [Fri, 20 Jun 2008 19:36:32 +0000 (14:36 -0500)]
There is no doc-head-calendar.inc. I think it's called calendar.inc and

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
13 years agoReplace EXPR.
Joe Atzberger [Fri, 20 Jun 2008 19:36:31 +0000 (14:36 -0500)]
Replace EXPR.

Prevents log error:
EXPR:at pos 14: non-initialized variable notforloantext

Signed-off-by: Joshua Ferraro <jmf@liblime.com>