Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Julian Maurice	b168f4a2e9	Bug 21395: Make perlcritic happy This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Frédéric Demians	c7ec79b839	Bug 15258: Prevent unused declared variables Add a perlcritic rule to 00-perlcritic.t to prevent unused declared variable. TO TEST: - Apply the 1st patch (unit test) - Run the UT: prove -v t/00-testcritic.t - Note that several Perl script fail - Apply the 2nd patch - Run the UT, and confirm it passes. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All tests pass successful. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>	9 years ago
Galen Charlton	d1ddce95d4	Bug 8798: (follow-up) remove DBIC_DONT_VALIDATE_RELS This corrects a failing test and follows a recommendation by the maintainer of DBIx::Class. This patch also adds a couple new directories for t/00-testcritic.t to check. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Colin Campbell	9929c52a57	Bug 8216: Allow SIP modules to pass critic tests Add C4/SIP to perlcritic tests. Fix those issues that were generating perlcritic errors Signed-off-by: Stacey Walker <stacey@catalyst-eu.net> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Paul Poulain	1acf7a1fad	members now passes perlcritic, but not misc. removing testing of misc	12 years ago
Chris Cormack	7f2ab970da	Bug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests signed-off-by Jonathan Druart <jonathan.druart@biblibre.com>	12 years ago
Colin Campbell	a898a0f3fb	Bug 5549 : Add Koha directory to testcritic	13 years ago
Chris Cormack	dc6e1031f8	Bug 6679 : Adding license statement and stopping declaring variables in a conditional	13 years ago
Chris Cormack	a047dea5e4	Bug 6679 : cataloguing/ now passing critic tests Declare variables outside of conditionals Don't use prototypes http://www.modernperlbooks.com/mt/2009/08/the-problem-with-prototypes.html Use ":encoding(UTF-8)" to get strict validation.	13 years ago
Chris Cormack	4a14e7dbe6	Bug 6679: catalogue/ now passing perl critic tests Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	13 years ago
Chris Cormack	e1bb9e5137	Bug 6679 : Enable Critic tests for authorities and fixed resulting warnings Signed-off-by: Ian <ian.walls@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago
Chris Cormack	7cdea5de35	Bug 6679 Fix scripts in admin & acqui to pass Perl::Critic Scripts in admin & acqui subdirectores weren't passing t/00-testcritic.t. This patch add admin & acqui scripts to test case and fix various errors related to Perl::Critic compliancy. - Fixing a style error to pass Perl::Critic, plus silencing a warn - More style errors, plus fixing a security issue - Explicitly using Carp Contrary to common belief, subroutine prototypes do not enable compile-time checks for proper arguments. Don't use them. Defining a named sub within another sub, does not prevent that subroutine being global Signed-off-by: Frédéric Demians <frederic@tamil.fr> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago
Colin Campbell	5f7b1a58f0	Bug 5485: Add script to run Test::Perl::Critic Tests are run if TEST_QA environment variable is set and Test::Perl::Critic is installed e.g. TEST_QA=1 prove =l t/00-testcritic.t Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago

13 Commits (04a4a34d6e9b7a235ae238b82b991795ca5abb8a)