Commit graph

12842 commits

Author SHA1 Message Date
Katrin Fischer
0f83daddd8 Bug 4506: Traced series
Add separate display of traced series.
Use $w and index rcn for link if $w exists, else show text link.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2010-12-08 12:45:10 +00:00
Katrin Fischer
26fa2de914 Bug 4506: Add links to other editions, some minor corrections
A new label 'Other editions:' is added with links to other editions.
The link starts a search for control number from 775$w in index control number.

A check for existence of $w/001 is added to always provide a fallback to a search for the link text.

Take care of repeated 773 fields.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2010-12-08 12:45:10 +00:00
Katrin Fischer
bfbf10e8e9 Bug 4506: Add volume > set link
A new label 'Set:' is added with a link to the set.
The link starts a search for control number from 773$w in index control number.
A syspref UseControlNumber will be added later, to provide a fallback to a search by 245$a, which is also the title of the set.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2010-12-08 12:45:10 +00:00
Katrin Fischer
43d0860e55 Bug 4506: Add set > volume link
A new label 'Volumes:' is added with a link 'Show volumes'.
The link starts a search fcontrol number from 001 in index rcn = Record control number.
A syspref UseControlNumber will be added later, to provide a fallback to a search by title.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2010-12-08 12:45:09 +00:00
Katrin Fischer
b705902c38 Bug 4506: New icon for sets
Show an own icon for sets - LDR 19 = a

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2010-12-08 12:45:09 +00:00
Katrin Fischer
a1a8acf4e2 BUG 4506: Add 8xx $w subfields to MARC-Frameworks de-DE
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2010-12-08 12:45:09 +00:00
Katrin Fischer
d3605d9ae8 Bug 4506: Some work on article to serial links
- changes search links to use Title index
- show article icon in intranet like in opac

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2010-12-08 12:45:09 +00:00
Katrin Fischer
813325c753 BUG 4506: Add 8xx $w subfields to MARC-Frameworks pl-PL
ru-RU and uk-UA have no files for MARC21

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2010-12-08 12:45:09 +00:00
Katrin Fischer
5d8694b59c BUG 4506: Add 8xx $w subfields to MARC-Frameworks en, fr-FR
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2010-12-08 12:45:08 +00:00
Katrin Fischer
baf3f605ec Bug 4506: Add index Record-control-number = rcn for indexing of $w subfields
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2010-12-08 12:45:08 +00:00
e54169ba0f Incremental fix for Bug 3285 - Location on Add Subscription should be pull down
- Adds location dropdown to subscription edit form
- Pulls authorised value for display on subscription detail page
- Adds function for pulling authorised value description based
  on category and value

This patch does NOT implement automatic preselection of the shelving
location form field on the serial add item screen. This must be
worked out in order for the bug to be closed.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-07 09:29:05 +13:00
Ian Walls
b112ec8ff4 Bug 5460: AutoEmailPrimaryAddress set to invalid value in sysprefs.sql
Fixes de-DE, en, fr-FR, pl-PL, ru-RU and uk-UA default install values for this system preference (changing from '0'
to 'OFF', the preferred value).

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-07 09:07:30 +13:00
Ian Walls
31622bc6b3 Bug 5457: gather_print_notices.pl requires explicit stylesheet
Adds a conditional around the opening and closing of STYLESHEET, testing on whether the $stylesheet variable is set
or not.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-07 08:57:28 +13:00
02524213b3 bug 5397: display renew count consistently
Display the renewal count for loans consistently; in particular,
for loans that have never been renewed, display 0.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-03 12:56:34 +13:00
Chris Cormack
b36befa821 Merge remote branch 'kc/new/enh/bug_4983' into kcmaster 2010-12-03 12:55:25 +13:00
Chris Cormack
836e0d2c03 Merge remote branch 'kc/new/bug_4851' into kcmaster 2010-12-03 12:55:20 +13:00
05dd542ceb Fix for Bug 4983 - Add edit record / edit item links to search results
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-03 12:48:53 +13:00
e6ebf10bba Fix for Bug 4851 - Batch delete shouldn't show delete button if no items were found
- Adding template flag to indicate valid results (hidden or not)
 - Clarifying warning messages based on various outcomes

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-03 12:47:12 +13:00
bb032138e7 bug 4908: rename temlate variable to branchname
Using branchname is more accurate and could avoid
a bug if/when the patron update function is made more
sophisticated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-03 12:40:27 +13:00
d86c4aa894 Fix for Bug 4908 - OPAC patron details page doesn't show patron's home library
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-03 12:40:26 +13:00
Katrin Fischer
eb2c10eff9 Bug 5104: Add control number as search option to acq z39.50 search
Adds control number as search option to z39.50 search in acquisitions.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-03 12:32:32 +13:00
1024eceec7 Fix for Bug 5048, Error in menu/submenu for select language in intranet
Patch for HEAD. This issue was apparently solved quite a while
ago in the OPAC. This patch copies that solution over to the staff client.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 09:24:34 +13:00
Chris Cormack
00408e262f Merge remote branch 'kc/new/bug_5030' into kcmaster 2010-12-02 09:20:14 +13:00
9f0495238d Fix for Bug 5030 - Improve handling of duplicate patrons
- Making duplicate patron warning dialog simpler but more explicit
- Pointing duplicate patron preview window to new brief version
  of moremember.pl to display more patron details than the previous
  version.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 09:16:07 +13:00
Chris Cormack
0287080cdc Merge remote branch 'kc/new/bug_5029' into kcmaster 2010-12-02 09:14:49 +13:00
f7b3b0c75b Fix for Bug 5029 - Update patron deletion error page
- Styling error message with "dialog alert" class
- Adding sidebar patron details to match other patron pages

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 09:13:38 +13:00
9753368626 bug 5405: remove disused script catalogue/suggest.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 09:12:31 +13:00
Chris Cormack
261c8d3aaf Merge remote branch 'kc/new/bug_5142' into kcmaster 2010-12-02 09:04:09 +13:00
470dc1d37c Further fixes for Bug 5142 - Untranslatable strings in tag review template
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 09:02:53 +13:00
be65390d06 Bug 5444 Fix misc/translate script for 'standard' Koha install
[3.2] Should apply

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 08:58:28 +13:00
Chris Cormack
a1aa1eea16 Adding 3.2.1 release to the history
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 08:55:55 +13:00
Chris Cormack
5a71ffa0d3 Fixing formatting and links in the history document
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 08:55:54 +13:00
Colin Campbell
bc3dcdd733 Fix some compile time errors reported in test suite
redeclaration of itemnumber in RotatingCollections
A couple of errors caused by retaining commas in qw()

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 08:53:53 +13:00
Chris Cormack
6aa9e9171c Merge remote branch 'kc/new/bug_5448' into kcmaster 2010-12-02 08:52:49 +13:00
Colin Campbell
f08b33a912 Bug 5448: Refactor Boolean.pm
Remove unnecesssary export
Use Exporter according to best practices
Use Carp not warn so we know where the error string came from
Don't create warnings manipulating undefined input
Replace package variables by lexicals

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 08:51:33 +13:00
Colin Campbell
78be08c73e Bug 5448 Use Test::More in Boolean.t
Use Test::More's structure as more readable
Replaced a test of an used function with a use_ok test
of the module

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 08:51:32 +13:00
Ian Walls
5e8b078651 Bug 4449: AllowHoldPolicyOverride does not override all hold policies
This patch provides a universal override to any hold policy if the AllowHoldPolicyOverride is set.
Amongst other overrides, this patch allows missing, non-checked out items to be placed on hold even with AllowShelfHolds turned off.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 08:35:58 +13:00
Ian Walls
31439fc51a Fixes bug 5232: Shelfname won't display on high-numbered lists
This bugfix adds an explicit GetShelf for the specific shelfnumber when viewing that individual shelfnumber.  This captures the
shelfname, which was originally pulled from shelflist->{$shelfnumber}, which may not have been populated if the List in question was
beyond the 20th private or public list in the system.

Also adds a more explicit sort: the sort from the CGI takes top priority, then it falls back to the default sort for the list, and
ultimate falls to 'title' if neither CGI nor default sort exist.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 08:33:12 +13:00
Colin Campbell
b9ccc51841 Bug 5450 Avoid a name clash in ILSDI modules
C4::ILSDI::Utility exports a subroutine CanBookBeReserved
Both ILSDI were also importing a subroutine of that name from
C4::Reserves Remove conflict by listing subroutines
imported from C4::Reserves explicitly

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-01 10:05:51 +13:00
e7321e1a7f Fix for Bug 5402, "add to cart" shown on checkbox hover
This patch removes the title hint altogether. The checkbox might
be used for the cart, lists, holds, or tags, and expressing this
in a title hint seems overly complicated.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-01 10:02:30 +13:00
d056b2f62a bug 4451 followup - don't need /g for this replace
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-30 14:29:17 +13:00
3f5d9537db Fix for Bug 4451 Batch item tool can't process file with Windows line endings
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-30 14:29:04 +13:00
781b4e5fae Fix for Bug 4981, Tweak style of item listing on MARC display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-30 08:50:06 +13:00
083d3b1a92 Fix for Bug 5051, Renewal due date doesn't always show on patron Checkout tab
Display of the renewal date footer in the template was conditional upon
the existence of checkouts from today.

In order to fix this bug it was necessary to repeat the markup for the
table footer twice in the template, so I created an include file for it.
The same include file can now be used in moremember.tmpl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-30 08:38:43 +13:00
16c891092f Fix for Bug 5269 - link to patron edit form when editing turned off
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-30 08:32:05 +13:00
Chris Cormack
a057f8b7e2 Merge remote branch 'kc/new/bug_5281' into kcmaster 2010-11-30 08:17:40 +13:00
cc57c2688d Fix for Bug 5281, "Check in" then "Renew" checkboxes checked in the same time
This fix corrects the behavior of the checkboxes whether the user clicks the
checkbox itself or the <td> around it. Tested on a PC in Firefox 3.6, Chrome,
Safari 5, and IE 8.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-30 08:15:34 +13:00
Chris Cormack
9c303a4e95 Merge remote branch 'kc/new/enh/bug_5430' into kcmaster 2010-11-30 07:02:18 +13:00
Katrin Fischer
f90f92f80f Bug 5430: Follow-up, fixes error message when no 001 exists
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-30 07:01:17 +13:00
Chris Cormack
110c36bbfc bug 5217 incrementing db version number 2010-11-30 06:57:09 +13:00