Commit graph

12164 commits

Author SHA1 Message Date
Garry Collum
1dfc81a45e Bug 2889: Adds highlighting to serials-collection.tmpl
Also fixes inconsistencies in the capitalization in the headings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-24 07:55:05 -04:00
Garry Collum
db1516269d Bug 3910: Removes an erroneous heading from the serials search results.
Removes the 'Search for Serial Routing' heading from the serials search result screen.

There is no code in the template that performs a routing search, and links to the routing tables are provided in the serials search results.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-24 07:55:03 -04:00
beedb9fc30 bug 4505: updated release notes
Minimum version of Perl required to run Koha is
now 5.8.8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-24 07:51:19 -04:00
Chris Cormack
81cb4e4dbe Bug 4505 - Bumping the perl version to 5.8.8 or greater
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-24 07:47:57 -04:00
Nicole Engard
6698c32ba5 bug 4802 - fix swapped files in acq help
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-21 23:09:33 -04:00
Nicole Engard
eb275234a5 bug 4802 add missing order search help file
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-21 10:29:59 -04:00
0e8b468e1b bug 4801: fix paging in display of staged bibs and import batches
Fixed glitch where the first page of bibs in a batch (or the first
page of import batches) was displaying the entire list instead
of the correct number of records per page.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-21 10:29:55 -04:00
Nicole Engard
a1ee3db962 bug 4802 add new acq help files
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-21 10:29:37 -04:00
Nicole Engard
c4f2ce91ed update main page help file
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-21 10:29:33 -04:00
8c66717a66 fix XHTML error in bib details print page
"&nbsp;" is not subtitutable for a table row

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-19 11:40:28 -04:00
Nahuel ANGELINETTI
8b4d76997f (bug #4519) fix record printing
this add a js that print a record

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-19 11:35:01 -04:00
Garry Collum
b1e8000d18 Bug 4525: Invalid XHTML in currency.tmpl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-19 11:27:16 -04:00
b6fc0d1d21 bug 4151: fix migration_tools typo
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 10:50:07 -04:00
7f700bd461 Bug 4516 (Character shift in MARC21 Field 008)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 10:36:19 -04:00
Chris Nighswonger
a7f56922eb Backing down the required version of Graphics::Magick
This brings the required version into line with the latest version available in the Debian and Ubuntu repos.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 10:29:51 -04:00
Chris Nighswonger
206e1b53b6 Enhancement Bug 4444: Centralize Code Handling Perl Dependencies
Porting about.pl over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 09:01:51 -04:00
Chris Nighswonger
e03d6bc77e Enhancement Bug 4444: Centralize Code Handling Perl Dependencies
Porting install.pl over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 09:01:49 -04:00
Chris Nighswonger
e744cd9fe5 Enhancement Bug 4444: Centralize Code Handling Perl Dependencies
This patch adds a script to allow checking the status of Koha's Perl dependencies from the
command line interface at any time. Run '$ ./koha_perl_deps.pl --help' for available options.
'$ ./koha_perl_deps.pl -c' is recommended if you like color.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 09:01:48 -04:00
Chris Nighswonger
a8e5aa6c01 Enhancement Bug 4444: Centralize Code Handling Perl Dependencies
Porting Makefile.PL over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 09:01:41 -04:00
Chris Nighswonger
1f32ecbc8e Enhancement Bug 4444: Centralize Code Handling Perl Dependencies
This patch adds two modules: C4::Installer::PerlModule and C4::Installer::PerlDependencies. The latter provides a single point
of reference for cataloging Koha Perl dependencies. The former provides an OO style interface to the dependency catalog.

The format of C4::Installer::PerlDependencies is very simply an anonymous hash of hashes. Each second level hash takes this form:

'Foo::Bar' => {
  'usage'    => 'FooBar Feature',
  'required' => '1', # 0 if optional
  'min_ver'  => '0.01',
},

New modules can be appended to C4::Installer::PerlDependencies as needed and will be picked up by every piece of code which needs
this information.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 09:01:37 -04:00
60be9d291f bug 4509: remove references to PINESISBN system preference
This system preference never worked; also, as far as I can tell,
the PINES oISBN service was experimental, not meant for production
use, and is not currently advertised.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 08:59:10 -04:00
Colin Campbell
885d094090 Bug 4507 Don't return null vendor to claims processing
The empty vendor created by the select if any subscriptions
have no associated vendor generates a 'wrong-looking' display
and selecting it gives no options

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 08:57:16 -04:00
Colin Campbell
aec1a31b23 Bug 2505 enable warnings in serials/reorder_members.pl
The only serials routine without warnings enabled was a
script with the least code to generate them
removed the numerous Module use declarations that were not
required
aligned the parameters for a more aesthetically pleasing effect

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 08:48:30 -04:00
f319e850d6 Bug 3768 (Bibliographic Framework Test)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 08:26:21 -04:00
e5c430c63e fix XHTML error in about.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-14 08:41:24 -04:00
4d87724c78 Revert "Bug 4450 Use more consistent error returns in C4/Creators/*"
This reverts commit 1f56a04cad.

[RM note: I confirm Chris Nighswonger's testing that shows that
 the patch causes regressions, including breaking creating new
 label layouts.]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-13 20:20:02 -04:00
Katrin Fischer
cc5b30d799 BUG 4499: Javascript error messages not translatable
- Administration > Patron categories > New Category (category.tmpl)
- Circulation > Checkouts > Toolbar (all tabs except Check out) (members-toolbar.inc)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-13 18:52:07 -04:00
Katrin Fischer
d7e519bd64 BUG 4499: Javascript error messages not translatable
- Cataloging > New Record (addbiblio.tmpl)
- Administration > Currencies > New Currency (currency.tmpl)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-13 14:20:05 -04:00
Chris Nighswonger
72cc96c1eb Bug 4141 Reconcile 3.0.x and HEAD database updates for 3.2.0
This is a partial fix addressing this error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 at /home/koha/koha.prod/installer/data/mysql/updatedatabase.pl line 2916., referer: http://koha-staff.foobar.org/cgi-bin/koha/installer/install.pl

If there are no records in aqbudgets the result is an empty array which causes the sql to attempt to set AUTOINCREMENT to null.

This patch is being submitted on behalf of the Mapua Community Library.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-12 08:05:22 -04:00
J. David Bavousett
dd1ad2d3eb Correct URL for Baker & Taylor ContentCafe
This patch updates the URL for image links in ContentCafe

Sponsored by Plano Independent School District, Plano, TX, USA

[RM note: the previous book cover URL was for a varient of Baker
 and Taylor's service that has to do with 'bookstore integration',
 and if I remember correctly, the main difference is that the
 book jacket image had "buy now" text.  The version supplied
 in this patch should work for normal use of ContentCafe.]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-12 07:40:33 -04:00
Paul Poulain
e7d6dc30f0 (MT3318) RSS OPAC: Adding CDATA term in title and description tags.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-12 07:34:14 -04:00
Colin Campbell
743ad9e827 Housekeeping in errors scripts
Enable warnings - remove Bug 2505 FIXME messages
Correct FSF address in License statement
To aid code analysis tools:
Call new unambiguously with arrow syntax
use noninterpolating quotes on noninterpolating strings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-12 07:29:03 -04:00
bf1d430622 Fix for Bug 4485, System preferences page uses non-standard warning style
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 10:25:39 -04:00
c89133ea51 A couple of CSS and markup corrections
- moving inline style declaration to the default stylesheet
- correcting markup structure on advanced search screen to allow
  consistent custom styling

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 10:13:11 -04:00
Jane Wagner
f4e1363ccd Bug 4300 Display 866z summary holdings public note in OPAC
Added the 866z to the MARC21slim2OPACDetail.xsl file so that it displays
just above the 780 and 785 fields.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 08:58:22 -04:00
Paul Poulain
b83b603e9f stocknumber not saved properly
if you have a marc field, mapped to items.stocknumber, it's not saved properly in items.stocknumber

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 08:44:16 -04:00
Matthias Meusburger
6710641eee MT2582: Fix user deletion without permission
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 08:39:19 -04:00
Chris Cormack
891a0248f7 wr-70205 Rental discount not being respected
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 08:15:32 -04:00
0be1783f2e DB rev 134: DisplayMultiPlaceHold syspref
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 07:45:28 -04:00
Chris Cormack
853bc200b3 Follow up to bug3093 patch
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 07:44:19 -04:00
Jane Wagner
dc0b98eb9e Bug 3093 add syspref to turn off multiholds button
Having the place multiple holds button at the top of the OPAC and staff search results has caused problems for some sites with tight holds policies; this syspref allows those sites to turn off the button.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 07:44:17 -04:00
Colin Campbell
757e1c91cc Bug 3928: Modified date should follow syspref
Changed arriveddate format to follow syspref
Fixed a whitespace error

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 07:34:22 -04:00
J. David Bavousett
f0528664ee Bug 3928: Modification of date for serials.
When a serial status is changed to "Arrived" or "Claimed", the "Expected on"
date is changed to the current date.

A bit of rewriting to get it to apply on master - chris@bigballowax.co.nz

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 07:34:17 -04:00
Matthew Hunt
0139b8769a Display current selected category when editing lists.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 06:22:46 -04:00
f7d3f45c02 Fix for Bug 4475, AmazonLocale not used consistently
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 06:21:00 -04:00
77efd29473 Markup corrections for validity and to eliminate horizontal scrollbar
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 06:15:56 -04:00
f3dd19f2f7 Fix for Bug 4400, BIBTEX export from OPAC results in empty file
opac-export.pl tries to get two variables from marc2bibtex(),
but it only returns one.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 06:14:38 -04:00
257a179c3e Bug 4470 Patron search result pagination bar
Obviously, Koha global pagination function could be improved. This patch
do something which belongs to this function. A CPAN module like
Data::Page could help or be an inspiration... 3.4?

There is also room for improvement in they way resultset are
constructed. The whole set is retrieved and just a subset is displayed.
It impacts performances for libraries with a great number of patrons.
The right solution would be:

  - to find the resultset size with SELECT COUNT(*)
  - to retrieved the exact subset with LIMIT and OFFSET SQL arguments

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 06:09:36 -04:00
Colin Campbell
1d014b4e39 Do not declare variables within (bogus) conditionals
if $index is unnecessary as we have made this true 5 lines above
variables should not be declared in conditionals if used outside of them
set $struct_attr to a sensible default to avoid generating warnings
in this assigment and elsewhere

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 06:07:19 -04:00
Chris Cormack
fcb8469d18 Reserve and onloan were reporting the same cardnumber, due to a little bug in detail.pl fixed by this patch
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 06:04:39 -04:00