The "place hold" button is hidden in detail.pl when there are no items or the
items are not for loan. MARC detail should do the same.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
There is a comma at the beginning that shouldn't be there and then there are
commas in the vol, no combo making it hard to read. it should be something
like this:
Vol 28, No 7; Vol 28, No 8; Vol 28, No 9
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ensure that emails sent from lists and the cart in the
OPAC have the correct quoted-printable encoding. Otherwise,
if there is an equals sign followed by one or two characters
that look like hexadecimal digits in body of the email, the
results can look mangled in some email clients.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch includes an addition to the OPAC's default js (identical to one in the staff client) which lets you add a "focus" class to an element on the page and have javascript move the focus to that element (input or link).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
[RM note: I think there are a few people who wouldn't
call "localisation" a typo - such as our UK, NZ,
Australian, etc. contributors ;-) ]. That said,
I'm pushing this patch to consistent with the
general trend of the English varient used on the
/prog/ templates. There's no implication that en_US
is the "correct" version of the language.]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
A member returns a book : it would be better to see the category of this member
in "information member" near his name.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Delivered version only had Text material type; this patch includes
all 14 material types with appropriate values for each.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
In an list of autorised values (Parameters >autotised values), if you delete an
autorised value after confirm, you go back to the first page of the list, and
you must return manually to the page you left before.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
In authorities, you can create frameworks like for biblio.
But in these it's impossible to delete useless fields, because when you click on
delete button, you go back to the default framework.
SO if you confirm your deletion, it delete your field in the default framework
and so in all the framwork (I think...).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Professional patrons might have Organizations as guarantors, so display the guarantor entry form with a single line labelled appropriately. For Child patrons display the form fields as before.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch modify the way to transfer the different args, don't use the form arrays.
And use a GET form instead of POST(we are getting datas, sending nothing).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
The shortcut to build $query_cgi in C4::Search::buildQuery()
for CCL, CQL, and PQF queries is incorrect, as (for now)
the "q=" prefix is required.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Squashed commit of the following:
commit 143a24041dd1988e025458ccb285a64809640f45
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 19 01:48:35 2009 +1200
Updating indian news
commit 21e518389b99acd038a5f0f5a3819e66bfc32062
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Fri Apr 17 04:43:41 2009 +1200
Adding more dehli public library news
commit a610f13cabf07d4de44e6b841be57e391301d0f3
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Thu Apr 16 02:41:48 2009 +1200
More history work from the devel list
commit 8d7f33c548600177a2b55f46a53f9828238c6e05
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 12 22:24:40 2009 +1200
Added translation information
commit c1d20eb095275904a01090f278356ee6c1b77f71
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 12 21:07:46 2009 +1200
Up to March 2006 on the devel list
commit 45b9ea49220dc350d684e5fe175062dfc95d146c
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 21:39:14 2009 +1200
Up to August 2005 on the devel list
commit 2788b21f1efb9ace2e23cabfbd82bfc27868ab33
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 20:21:01 2009 +1200
Adding tags
commit f3b26c2eccc86a0616c5e98cedeee68ce5662abb
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 20:05:03 2009 +1200
Last little fix
commit f5e778278e9483c9ee4be24fa95692079a5ccbb4
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 19:55:17 2009 +1200
More formatting
commit 83ea369a4e0c5cb6141cf0b2dc104e0e9d0b1761
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 19:32:08 2009 +1200
Formatting tweaks
commit f5c6709268f216b52826a45f427258717e011777
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 19:20:40 2009 +1200
Tab separated text
commit 6a80241a9a77b79b4d3ab8881f0b91217d8238a5
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 17:30:07 2009 +1200
Up to May 2005 on the devel list
commit 6ea5ec539e023d3652ed097467c65f81257a2146
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 16:07:30 2009 +1200
Up to october 2003 on th devel list
commit 8e0d72b86c2da276d1fc5731e69974b135c047f2
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 10:49:59 2009 +1200
Now up to February 2003 on the devel list
commit aedcfd1c66fe2bd61c5bc5cb0aa3ae9e446d356c
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 09:34:32 2009 +1200
Adding history about paul
commit cb728d09ee3024abb3d98cca90f68514e9a6e14e
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 08:41:51 2009 +1200
Typo fix
commit 9f515f9df0450a9a797bb0abb68233eddb2d15ef
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Fri Apr 10 21:43:35 2009 +1200
Done up to October 2002 on the devel list
commit 87382c7d2c2fb05b23eedb0840a94b729f211d16
Author: Chris Cormack <chris@deb-lap.(none)>
Date: Fri Apr 10 20:31:22 2009 +1200
Up to june 2002 on the developer list
commit 75d24ed5f05c45ea7c25e2c8623bec114c35ce81
Author: Chris Cormack <chris@deb-lap.(none)>
Date: Fri Apr 10 18:47:21 2009 +1200
Adding information from the devel list
commit 4ab492672feab94cabc2337f1c8ef01e588c90f6
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Wed Apr 8 08:47:31 2009 +1200
Adding date for biblibre
commit 4a0153d1dbd5abdf289f9e842c8e60908286c66a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Apr 7 22:39:23 2009 +1200
Finished the main mailing list and the announce list, working on the translate list now
commit 4c99f3809ce2539d8c2312ad76bc533ebe2a0fdf
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Apr 7 21:03:07 2009 +1200
Fixing typo
commit ad5f8685529503da0a4a214fc900a9b2fd9a880a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Apr 7 20:47:00 2009 +1200
Adding biblibre, fixing rfp history
commit 0be5d854db10eb2d1710a940c141c1689e3e226a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Apr 7 19:47:59 2009 +1200
More history work
commit 2b423736e5e343fbf5abe84e6e1055541bb2a7c3
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Apr 7 07:04:30 2009 +1200
Fixing dates for OLC
commit 5065f400dc369531725bfe4469b115a168110f52
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Apr 6 22:07:07 2009 +1200
More work on the history
commit d5dd62629bddded528edf5b99e1b316554ff3138
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Apr 6 20:18:03 2009 +1200
Finished committers history
commit d707b19d04f094239d0300b6a0a296b7ac93c799
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Apr 6 19:57:07 2009 +1200
Finishing off committer history
commit b15d07d0c8f299d719365dd087e98066beee19a9
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 5 21:38:39 2009 +1200
VCS history for 2007
commit 47e69aa34409389d8c203e35b70a1480351705ef
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 5 21:30:21 2009 +1200
VCS and main mailing list history for 2006
commit 3e45921c5fee7a122e745d025524970a11ef9b09
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 5 20:07:26 2009 +1200
Continuing on with the History
commit f8719ebb2bde3871c45de9b043f0260b5bd810d7
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 5 19:14:08 2009 +1200
Adding links to computerworld articles
commit 500370aa98b869edb0b0b36ca7af5a8b094f515b
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 5 18:59:30 2009 +1200
2005 vcs and main mailing list history
commit f6fad5cfba85aa4213038ce301cc84436f76df2f
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 5 07:59:18 2009 +1200
Up to June 2005
commit 43d40046e0fb9baf75b58c769632bc99346295cb
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Thu Apr 2 22:05:33 2009 +1300
Working on 2005
commit f15da9231fffecbe2b6d35c53e9e1adf370222c1
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Thu Apr 2 09:33:09 2009 +1300
More history work
commit 93174bbd9bde579c91a3bc49976faf118a83da52
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Mar 31 22:04:56 2009 +1300
More history
commit f2fd3c6d74ef4489100401bbbf936df1efa16d19
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Mar 31 18:55:08 2009 +1300
More 2004
commit a17646986b0abf99b121309e22fce299449a3cc4
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Mar 31 18:27:29 2009 +1300
Working on 2004
commit 5886fae2d293f801ed436a3efa8660966a31ba3e
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Mar 31 13:52:07 2009 +1300
Continuing on with the history updates
commit 1f64c51abf414d8432280023e72d5f191961a8a0
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Mar 31 09:02:25 2009 +1300
More history
commit c20b84d7d42b7774d8c5ab7f20a54f6314e4f30c
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date: Tue Mar 31 13:48:49 2009 +1300
formatting fix
commit 7698ba607429e502126ccf2df1e9e9a4755fa448
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Mar 30 22:02:12 2009 +1300
And even more history
commit cac079f7541e9276710dc778527ea9c84e8d185a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Mar 30 21:45:36 2009 +1300
COntinuing on
commit ce7402c7dbcf01483f9905b4eb75f1d89568e0d8
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Mar 30 21:05:27 2009 +1300
Continuing on
commit 3dcd055d4640160a54e88d8c6519785a390a93a7
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Mar 30 20:44:41 2009 +1300
Continuing on the history
commit cf07159fd8d400750d1878213fab7b01b45c5197
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Mar 30 20:33:28 2009 +1300
More history updates
commit a3c31379e115e9aeab44c752126f6f4878c3bf15
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Mar 29 23:16:52 2009 +1300
More history
commit 831a385489a90f750cc760e18b598339c02aa620
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Mar 29 22:53:25 2009 +1300
Continuing on
commit 26e38756019023dfd928538553fdf95311eee4ed
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Mar 29 22:15:11 2009 +1300
More doc
commit bb13ea869d83f4493dc53041a0894880a5fefd66
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Mar 29 21:54:50 2009 +1300
Continuing work on the history doc
commit 69aff74445eac3c260c081cb63e403c1025b7950
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Mar 29 21:37:37 2009 +1300
History documentation
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
The alternative postal code input on the patron
editing form was only permitted 5 characters of
input. Increase this to 10 to match the
primary zipcode.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This has bearing on bugs 2905, 2665, 2514 and other "wide character" crashes
related to diacritics and Unicode. This should help open the door for reliable
input of diacriticals via acquisitions.
MARC21_utf8_flag_fix.pl diagnoses and fixes existing problems with MARC data
affected by the bug.
Adding SetMarcUnicodeFlag to TransformKohaToMarc prevents the bug from corrupting
further data.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Acquisitions process seems to be adding records with incorrect
representation of the MARC encoding in leader/09. It should be
'a' meaning UTF-8, for all Koha's internalized records, but in
many cases it appears blank (for MARC-8). This script diagnoses
and repairs the value in the leader, depending on runtime options.
The symptom of this problem is that high-value UNICODE characters
in the record will cause Koha to crash whenever it tries to parse
the MARCXML, giving a "Wide character" fatal. While we work on
fixing the input, this script will fix the existing data.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This doesn't insert the large and typically unused <ldapserver> block,
just the switch with a comment pointing to C4::Auth_with_ldap. This otherwise
was undocumented requirement, making LDAP config a bit of a shot in the dark.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
- Moved the following system preferences to the Serials tab:
OPACDisplayExtendedSubInfo
OPACSubscriptionDisplay
RenewSerialAddsSuggestion
SubscriptionHistory
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
* Use of uninitialized value in pattern match (m//) at C4/Biblio.pm line 1305
(displaying MARC21 856s that don't have $3)
* Use of uninitialized value in multiplication (*) at catalogue/detail.pl line 243.
(attemping to calculate average Amazon rating if no Amazon info
is available)
* opac-detail.pl: Use of uninitialized value in length at C4/External/Amazon.pm line 90
(attempting to calculate length of $isbn if it happens to be undef)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Fixes the following problem:
When deleting a patron record via the intranet or the cleanborrowers tool,
patron records are deleted but are not copied to deletedborrowers.
C4::Members::MoveMemberToDeleted() fails with the following error:
deletemem.pl: DBD::mysql::st execute failed: Column count doesn't match value
count at row 1 at C4/Members.pm line 1672.,
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch change the page to use GET instead of post, and use independants "input"
names for searched values. Else the args are not passed to the next page due to
rewrite rules.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
The intranet item display provided by moredetail.pl
would display the original due date of the item, and
would thus be incorrect if the item had been renewed
and got a different due date.
The incorrect date was coming from items.onloan,
which AddIssue() sets to the due date. This patch
fixes the bug in two ways:
[1] AddRenewal() now updates items.onloan with the
correct due date.
[2] Two templates were updated to display the
due date from (indirectly) issues.date_due
instead of items.onloan, thus making it less
likely that the wrong value will be displayed.
This patch does *not* update items.onloan to reflect
the correct due date.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch add the serials deletion in DelBiblio function, so now when a record is deleted all attached serials will be too.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.
Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery. Performance improved.
Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
REFACTOR logic out of conditional branches when the assignment ($nextop) is the same.
Be sure to EXIT after printing a redirect, instead of wasting clock filling in the
template for a process the user will never see. Remove the now inapplicable logic for
differentiation between "/cgi-bin" and "non /cgi-bin" installations. There is no
longer any /cgi-bin in the actual directory file path.
This does not fix the value_builder js errors like "Blurbarcode52251 is not defined",
but it does not cause them either (see Bug 2919).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Auto truncation now works on LTR languages
For RTL languages(Arab, Hebrew), development should be really improved.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
The table row openning and closing tags were outside the template loop.
This moves them inside the loop. Without this search results with more
than one copy will append those copies to the one row.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Since I added more IndependantBranches code to my git repo I need
userenv loaded before SimpleSearch() is called. I think
get_template_and_user() should be called as soon as possible. In this
case it could mean two calls, but it has to be so.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
The re-creation of statement handles for the same queries, repeatedly,
seriously degrades the performance of notices. This introduces new
class-level caching to avoid that problem.
Note: initial provisions
to do the same with caching of COLUMNS information about tables is
also included, but this would probably be most usefully implemented
in C4::Context (or a separate more central module). The benefits of
caching that info would probably be even greater. Note that this
proposed implementation might be obsoleted by ORM integration, where
DB structure info would already be cached.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
GetItemsInfo() returns a count_reserves variable which may be "Waiting" or "Reserved," but opac-detail.pl didn't include a check for these possibilities. This patch has opac-detail.tmpl output "On hold" in either case.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
It looks like a lot of change, but it isn't much:
perltidy, removed unused "toggle" code, and corrected comments.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
