Commit graph

11674 commits

Author SHA1 Message Date
Nahuel ANGELINETTI
96e7c92583 (bug #3651) sending baskets and shelves
this patch restrict the send of baskets and shelves to authenticated users only, and show their surname/firstname in the e-mail, so the receiver will know who sent the list.
(cherry picked from commit f87b755228)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:58:08 -05:00
e0b3d2e235 Some new and altered itemtype images for the NPL set
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:42:57 -05:00
8f965b95e4 Bug 4047 - Add a link to branch URL if available on holdings in OPAC
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:29:15 -05:00
Will Stokes
f27c5ae5a1 Display amount of credit patron has, not just that they have credit.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:18:03 -05:00
Jane Wagner
5b33873c21 Bug 4215 OPAC "Search for title in" can fail with trailing slashes in title
While configuring Search for Title In links, I found that some target sites
can't process an incoming title search if the title being sent has a trailing
slash.  If the same search is sent without the trailing slash, it works fine.  I
modified opac-detail.pl to strip off the trailing slash (and space) for titles
being sent to other sites.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:09:11 -05:00
3d16451ac5 bug 1080 follow-up: make sure 'sound' isn't listed as a language
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:06:59 -05:00
66aaf0726e update RM notes for new translation wrapper script
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:06:50 -05:00
3c3aac0848 Follow up for new translation wrapper
(cherry picked from commit 17bdeb66e041f295214d1406620669c090b4e4de)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 11:43:42 -05:00
c05b7747b9 New wrapper script for handling translation process
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 11:39:24 -05:00
Garry Collum
999e78ac30 Bug 3070: Fixes RSS feed for single result search.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 11:10:33 -05:00
Garry Collum
92bca53408 Bug 2505: Add warnings to opac/maintenance.pl
Added a FIXME for warning generated from C4/Context.pm.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 11:10:30 -05:00
Garry Collum
88a4648b15 Bug 4212: Adds license statement to opac-search.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 11:10:29 -05:00
Colin Campbell
a034d305da bookseller is returned as a scalar hashref not an array
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 10:29:48 -05:00
Colin Campbell
ea7aa11d71 Make GetBooksellerFromId error return consistent
return undef or empty array in error cases
hopefully if we're consistent someone may start checking it
removed unnecessary ()s

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 10:29:47 -05:00
b83474516b bug 4155 followup: fix indication of when checkbox syspref is modified
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 10:27:12 -05:00
b5d8fd8ecb Bug 4155 Can't change the language of the staff client in prefs
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 09:57:19 -05:00
821cfebad6 OAI server fixes
- Add preference OAI-PMH:ConfFile. I just add it in web-services.pref
  and not in DB. It's enough. It's not an end-user preference. Without
  this pref, OAI server operates as previously. And preferences editor
  allow to add a new value to the DB if necessary.
- Fix response to ListMetadataFormats which was empty in extended mode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 09:45:26 -05:00
effad33113 bug 1080: finish work for soundon syspref (DBrev 120)
Tweaked wording of the soundon syspref, added it to the non-English
SQL scripts, and created a DBrev.  Thanks to Nahuel and Eric
for the French translation.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 09:25:25 -05:00
0bdba46f91 bug 1080: XHTML-ify audio tags
This doesn't actually do much, since the <audio> tag is still
not defined in XHTML1, but it makes it consistent with the rest of the
markup.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 09:25:16 -05:00
root
b4c887f2c4 Bugzilla 1080 to add enhancement for sound. Only changed circulation.tmpl/pl and returns.tmpl/pl and added a single syspref (set to off) along with very compressed OGG files for sound which are on the open source "artistic" licence.
Works for HTML5 because it loads smoothly and no plugins required but *at
  this time* this update will only work with staff clients which are Firefox
  version >=3.5 (std for Koha) but other browsers will soon be adding support.

  Additional sounds are included for people to modify and play with, but this
  is such a simple upgrade I doubt at this time Koha needs another complex
  selector so users can add their own sounds. It could be a nice enhancement
  later, of course.

  Suggest we stick with HTML5 <audio tag because it is a standard and no
  plug-ins.

  This simple update has been running live for SMFPL.org for almost 2 weeks

  -Darrell Ulm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 08:12:25 -05:00
J. David Bavousett
bc06a7736a Bug 3775: Accounts::chargelostitem uses title, but title not available to it
This patch fixes the SELECT so that title is available when it is used
later on, which will prevent 'Use of uninitialized value' errors.

It also uses JOIN properly, which the original query and my initial
patches for this did not.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 11:25:25 -05:00
Matthias Meusburger
64b79bf620 MT2116 : CSV Exports : add 'new line' as separator
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 08:00:53 -05:00
Matthias Meusburger
3bbbc15ccf MT 2116: Addons to the CSV export
Fix encoding selection

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 07:54:11 -05:00
Matthias Meusburger
0268a58e16 MT2116: Addons to the CSV export
Adds the ability to customize CSV exports through the use of a YAML file.

The following customizations are available :
  - Preprocessing
  - Postprocessing
  - Field-by-field processing

The YAML field should be stored in the tools/csv-profiles/ directory and
named after the id of the CSV profile you want to customize.
An example file is provided in that directory.
(cherry picked from commit 76655b5b94)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 07:51:33 -05:00
Paul Poulain
452c0ab719 MT2716: fixing finishreceive.pl Software Error
finishreceive.pl was buggy when AcqCreateItem was set to recieve (wrong API)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 07:49:08 -05:00
Paul Poulain
d26687338d MT1203: don't display menus if the user don't has the permission
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 07:46:31 -05:00
Paul Poulain
c26b6957b5 MT 2348 : acqui-home minor improvements
- moving some links to the left part of koha (currencies and suggestions)
- removed currency table
- changing supplier display

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 07:18:44 -05:00
Nahuel ANGELINETTI
39a727a43b (bug #4062) add item index in zebra conf
This add the "item" index.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 07:18:42 -05:00
5577540da7 updated install instructions to include Locale::Currency::Format
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 06:45:19 -05:00
44967351ef set Locale::Currency::Format dep test as DBrev 119
Also fixed bug that prevented updatedatabase.pl
from compiling if Locale::Currency::Format wasn't
already installed.  To test to see if module is present,
do

eval{require Locale::Currency::Format};

not

eval{use Locale::Currency::Format};

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 06:39:22 -05:00
Chris Nighswonger
8724f88bdb Bugfix: Moving sample_notices.sql to mandatory subdir
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 06:36:38 -05:00
Chris Nighswonger
c353d91707 Bugfix: [3/3] [TRANSLATION NEEDED] overdue_notices.pl does not process all advertised fields
Updating mandatory sample notices sql files

NOTE TO TRANSLATORS: Some of these will require new translations

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 06:36:23 -05:00
Chris Nighswonger
6827107ed4 Bugfix: [2/3] overdue_notices.pl does not process all advertised fields
This patch adds a dependency requirement for Locale::Currency::Format

NOTE: It does not adjust kohaversion.pl and sets the dev version to XXX.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 06:36:08 -05:00
Chris Nighswonger
599887a185 Bugfix: [1/3] overdue_notices.pl does not process all advertised fields
Note: overdue_notices.pl really needs to be completely re-written.

The script does not process all fields advertised in tools/letter.pl
This patch adds code to process all fields advertised as well as any
from the items table.

It also adds two additional tags for use in the letter templates:

<item></item> which should enclose all fields from the biblio, biblioitems,
and items tables.

<fine></fine> which should be enclosed by the item tag and should
enclose a currency identifier per ISO 4217. If this tag is present with
a proper identifier, the fine for that item will be displayed in the
proper currency format. Note: ISO 4217 changes from time to time therefore
all currencies may not be supported. If you find one that is not
supported, please file a bug with the Locale::Currency::Format author
Tan D Nguyen <tnguyen at cpan doe org>.

An example of the implimentation of these two tags in a notice template
might be like:

The following item(s) is/are currently overdue:

<item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Fine: <fine>GBP</fine></item>

Which, assuming two items were overdue, would result in a notice like:

The following item(s) is/are currently overdue:

"A Short History of Western Civilization" by Harrison, John B, 909.09821 H2451, Barcode: 08030003 Fine: £3.50
"History of Western Civilization" by Hayes, Carlton Joseph Huntley, 909.09821 H3261 v.1, Barcode: 08030004 Fine: £3.50

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 06:36:01 -05:00
Nicole Engard
8594f3f141 bug 4197 fix opac patron update
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 06:27:47 -05:00
1e09f54a97 bug 3973: make auto-fill button work on budget planning form
Also fixed a variety of XHTML validation errors.

Programming note: it is invalid XHTML and can break Javascript
to use element IDs and class names that start with digits.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 06:20:02 -05:00
d746d80199 bug 4203: add display column to aqbudgets_planning if needed (DBrev 118)
Had not been included in kohastructure.sql

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 05:32:38 -05:00
Henri-Damien LAURENT
9d6df13554 (bug #4135) fix aqplan form
This fix the form to have always the submit button, and fix security issue in aqplan.pl(authnotrequired set to 1)

Conflicts solved:

	koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 05:10:11 -05:00
Colin Campbell
2dc5cb56db Bug 3654 Fix sql syntax error in earlier patch
mysql comments require a space after the --

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 05:08:27 -05:00
419e307f49 bug 4151: replace dep on YAML::XS with YAML::Syck
YAML::Syck is also fast, and dropped YAML::XS means
we don't have to add a formal dependency on it.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 05:04:02 -05:00
Nahuel ANGELINETTI
e905106642 (bug #4195) fix OAI repository
this fix the OAI repository, to don't return resumptionToken if there is no more record.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 04:52:53 -05:00
84b3c05c0d Bug 2959 - Add a timeout parameter to the URL checker
Could improve performances for DB containing URLs which can't be fetched
(good or bad) quickly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:48:01 -05:00
Garry Collum
fad17c9da3 Bug 3652: Fixes XSS vulnerabilities and XTHML errors in opac-search-history.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:42:44 -05:00
959c0cb0d8 bug 2505: fix warnings in opac-MARCdetail.pl
Also indulged in a little code cleanup.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:32:21 -05:00
Garry Collum
79b8a27c0c Bug 3449: Fixes the perpetual error message that pops up when filtering by tag reviewer.
Duplicates the code for searching by reviewer in the form that is used in searching via a link.

It looks like it was the intention of the original writer to filter by borrower number or by name.  Filtering by name was not implemented.  Added a FIXME reference to indicate this.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:12:43 -05:00
Garry Collum
3cdbce6919 Bug 3090: Adds the report ID field to the saved reports page in the guided reports.
Adds an ID field to the save reports table in guided reports to make running runreport.pl easier for users.

Also adds zebra striping to the data table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:12:41 -05:00
Garry Collum
886368370d Bug 2505: Enables warnings in opac-MARCdetail.pl and opac-authoritiesdetail.pl
No resulting warnings after warnings were turned on.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:12:40 -05:00
Garry Collum
90fc2ef1e8 Bug 4192: Fixes warnings generated by opac-account.pl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:12:38 -05:00
4b186cc95b Update fr-FR preferences
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:09:50 -05:00
12370281e6 tweak description of OpacBrowser syspref
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:08:25 -05:00