Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Nick Clemens	fc650b3e87	Bug 31893: Use checkauth and do not fetch about.tt template This patch updates four scripts to use checkauth instead of get_template_and_user reserve/modrequest.pl reserve/modrequest_suspendall.pl course_reserves/mod_course.pl members/members-update-do.pl No behvaiour change is expected To test: 0 - Apply patch 1 - Place some holds for a patron 2 - From patron page, confirm you can suspend all 3 - confirm you can delete marked holds 4 - Edit a course in course-reserves 5 - Make a chaneg to personal details via OPAC 6 - Confirm change can be approved on staff side Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	1 year ago
Jonathan Druart	9d6d641d1f	Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. This patch is a squashed version of: Bug 17600: After export.pl Bug 17600: After perlimport Bug 17600: Manual changes Bug 17600: Other manual changes after second perlimports run Bug 17600: Fix tests And a lot of other manual changes. export.pl is a dirty script that can be found on bug 17600. "perlimport" is: git clone https://github.com/oalders/App-perlimports.git cd App-perlimports/ cpanm --installdeps . export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib" find . $ -name ".pl" -o -name ".pm" $ -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; The ideas of this patch are to: * use EXPORT_OK instead of EXPORT * perltidy the EXPORT_OK list * remove '&' before the subroutine names * remove some uneeded use statements * explicitely import the subroutines we need within the controllers or modules Note that the private subroutines (starting with _) should not be exported (and not used from outside of the module except from tests). EXPORT vs EXPORT_OK (from https://www.thegeekstuff.com/2010/06/perl-exporter-examples/) """ Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members. @EXPORT and @EXPORT_OK are the two main variables used during export operation. @EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace. @EXPORT_OK does export of symbols on demand basis. """ If this patch caused a conflict with a patch you wrote prior to its push: * Make sure you are not reintroducing a "use" statement that has been removed * "$subroutine" is not exported by the C4::$MODULE module means that you need to add the subroutine to the @EXPORT_OK list * Bareword "$subroutine" not allowed while "strict subs" means that you didn't imported the subroutine from the module: - use $MODULE qw( $subroutine list ); You can also use the fully qualified namespace: C4::$MODULE::$subroutine Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	8 years ago
Julian Maurice	96cc447045	Bug 25898: Prohibit indirect object notation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	638786e719	Bug 24663: Remove authnotrequired if set to 0 It defaults to 0 in get_template_and_user Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Mark Tompsett	2ca766f392	Bug 21349: Instructors with special characters in cardnumber cannot be removed from course reserves The cardnumber can contain strange non-javascript-friendly characters. This patch converts all the internal references to borrowernumber, but displays the cardnumber when showing list of matching users. TEST PLAN --------- 1) Make sure Course Reserves is being used. Check system preferences. 2) Make sure there is a Course entered. 3) Make sure there is a patron with an cardnumber which breaks the existing javascript (eg. Ka-boom:Ka-boom!KABOOM@#$!) 4) Go into the course list. 5) Click the course name link 6) In the "Instructor Search" box enter the patron name. 7) Select the patron which has the ugly cardnumber. 8) Click Save -- The course listing should have the new teacher listed. 9) Click the course name link again. 10) Click 'Remove' beside the instructor's name. -- nothing happens, and inspecting the error console gives you the ugly error described in comment #0 11) apply this patch 12) restart_all 13) sudo service apache2 restart 14) refresh the page. 15) click 'Remove' beside the instructor's name. -- name is removed. 16) Click Save -- the course listing no longer lists the new teacher. 17) Actually confirm that adding and removing others normally works as expected. 18) run koha qa test tools. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Aleisha Amohia	f05da6ada7	Bug 19230: Preventing warn when deleting course To test: 1) Ensure UseCourseReserves is enabled 2) Go to Course Reserves, create a course 3) When you are taken to the course page, you should notice the 'Argument "" isn't numeric in numeric gt' warn 4) Delete course 5) Notice warn, and that no confirm message popped up 6) Apply patch 7) Create a course again. Confirm the 'Argument "" isn't numeric in numeric gt' warn did not show 8) Delete the course 9) Notice no warn and the confirm message pops up Sponsored-by: Catalyst IT Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	66aacace08	Bug 16154: CGI->multi_param - Declare a list This patch replaces the occurrences of my @foo = $cgi->param('foo'); with my @foo = $cgi->multi_param('foo'); perl -p -i -e 's/^(\smy\s@\w+\s=\s)\$(cgi\|input\|query)\->param\(/$1\$$2\->multi_param\(/xms' */.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>	8 years ago
Jonathan Druart	a6c9bd0eb5	Bug 9978: Replace license header with the correct license (GPLv3+) Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> http://bugs.koha-community.org/show_bug.cgi?id=9987 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	e20270fec4	Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	afd2418d73	Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Galen Charlton	281448f84e	bug 8215: (followup) avoid spurious warning in Apache log Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	65b874bb47	bug 8215: (followup) make sure C4::CourseReserves doesn't export anything New modules should not export any symbols by default without a very good reason. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	11 years ago
Galen Charlton	4db08281c5	bug 8215: (followup) run new files through perltidy Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	11 years ago
Kyle Hall	be869ab279	Bug 8215 - Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Test Plan: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Corinne Bulac <corinne.hayet@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> http://bugs.koha-community.org/show_bug.cgi?id=8125	12 years ago

14 Commits (cf06f05ec0a3bc5f965ba09168e3dc8c82e0dbb3)