Koha/koha-tmpl/intranet-tmpl/prog/en/includes
David Gustafsson ddc2906b77
Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines
To test:

1) Run the following test and make sure all pass:
  t/db_dependent/api/v1/biblios.t
  t/db_dependent/api/v1/checkouts.t
  t/db_dependent/api/v1/return_claims.t
  t/db_dependent/Circulation/CalcDateDue.t
  t/db_dependent/Circulation/CheckIfIssuedToPatron.t
  t/db_dependent/Circulation/dateexpiry.t
  t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
  t/db_dependent/Circulation/GetTopIssues.t
  t/db_dependent/Circulation_holdsqueue.t
  t/db_dependent/Circulation/IsItemIssued.t
  t/db_dependent/Circulation/issue.t
  t/db_dependent/Circulation/MarkIssueReturned.t
  t/db_dependent/Circulation/maxsuspensiondays.t
  t/db_dependent/Circulation/ReturnClaims.t
  t/db_dependent/Circulation/Returns.t
  t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
  t/db_dependent/Circulation.t
  t/db_dependent/Circulation/TooMany.t
  t/db_dependent/Circulation/transferbook.t
  t/db_dependent/DecreaseLoanHighHolds.t
  t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
  t/db_dependent/HoldsQueue.t
  t/db_dependent/Holds/RevertWaitingStatus.t
  t/db_dependent/Illrequests.t
  t/db_dependent/ILSDI_Services.t
  t/db_dependent/Items.t
  t/db_dependent/Koha/Account/Line.t
  t/db_dependent/Koha/Acquisition/Order.t
  t/db_dependent/Koha/Biblio.t
  t/db_dependent/Koha/Holds.t
  t/db_dependent/Koha/Items.t
  t/db_dependent/Koha/Item.t
  t/db_dependent/Koha/Object.t
  t/db_dependent/Koha/Patrons.t
  t/db_dependent/Koha/Plugins/Circulation_hooks.t
  t/db_dependent/Koha/Pseudonymization.t
  t/db_dependent/Koha/Recalls.t
  t/db_dependent/Koha/Recall.t
  t/db_dependent/Koha/Template/Plugin/CirculationRules.t
  t/db_dependent/Letters/TemplateToolkit.t
  t/db_dependent/Members/GetAllIssues.t
  t/db_dependent/Members/IssueSlip.t
  t/db_dependent/Patron/Borrower_Discharge.t
  t/db_dependent/Patron/Borrower_PrevCheckout.t
  t/db_dependent/Reserves/GetReserveFee.t
  t/db_dependent/Reserves.t
  t/db_dependent/rollingloans.t
  t/db_dependent/selenium/regressions.t
  t/db_dependent/SIP/ILS.t
  t/db_dependent/Holds.t
  t/db_dependent/Holds/LocalHoldsPriority.t
  t/db_dependent/Holds/HoldFulfillmentPolicy.t
  t/db_dependent/Holds/HoldItemtypeLimit.t
  t/db_dependent/Circulation/transferbook.t
2) Performe one or more checkouts for a patron, making sure
  that the circulation rules allows for renewals (for example by
  setting an earlier due-date).
3) Log in as this patron in OPAC and make sure the list of
  checkouts is displayed correctly, and that renewing an issue
  still works.

Sponsored-by: Gothenburg University Library
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-05-12 12:40:21 -03:00
..
background_jobs Bug 33316: (QA follow-up) Add link to record, fix typo and heading 2023-04-13 11:47:53 -03:00
catalogue Bug 33070: Remove use of can_edit_items 2023-03-17 09:59:02 -03:00
csv_headers Bug 28327: Unify CSV delimiter special behavior for tabulation 2022-08-19 15:53:12 -03:00
mana Bug 30952: Undo change to Home breadcrumb for remaining templates 2022-10-12 16:00:50 -03:00
modals Bug 31028: (follow-up) Consistently style help-block 2023-03-06 11:23:17 -03:00
str Bug 30642: (follow-up) Change sql and adapt for translations 2023-02-10 11:07:58 -03:00
virtualshelves/merge Bug 32097: Consistent classes for primary buttons: Lists 2022-11-10 10:27:17 -03:00
about-team.inc Bug 29602: Surround strings with span tag 2022-04-19 21:25:51 -10:00
accounts.inc Bug 26403: (QA follow-up) Add missing debit and credit types to includes 2023-05-10 15:26:15 -03:00
acquisitions-add-to-basket.inc Bug 28079: Set focus to search box field when adding an order to basket 2021-10-21 10:21:50 +02:00
acquisitions-menu.inc Bug 31115: (QA follow-up) Use more specific permission for sidebar link 2022-10-24 14:11:08 -03:00
acquisitions-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
acquisitions-toolbar.inc Bug 28082: Add acquisitions toolbar to vendors on vendor search page 2022-05-10 15:17:17 -10:00
additional-fields-display.inc
additional-fields-entry.inc Bug 31254: Add additional fields for accountlines 2022-09-21 18:58:28 -03:00
admin-items-search-field-form.inc Bug 32213: Reindent item search fields templates 2022-11-29 09:05:15 -03:00
admin-menu.inc Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests 2022-11-08 14:39:51 -03:00
adv-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
auth-finder-search.inc Bug 29434: add UNIMARC relationship codes for authorities 2022-08-09 07:42:21 -03:00
auth-two-factor.inc Bug 30588: Add missing include file 2022-10-21 11:36:58 -03:00
authorities-search-results.inc Bug 29602: Surround strings with span tag 2022-04-19 21:25:51 -10:00
authorities-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
authorities-toolbar.inc Bug 28542: Move new authority from Z39.50/SRU to a button 2021-06-21 10:10:01 +02:00
authorities.inc
authorities_js.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
authority-detail-modal.inc Bug 29965: Preview MARC in authority search results 2022-02-23 22:05:33 -10:00
av-build-dropbox.inc Bug 30603: Display Sort1 and Sort2 as free text if no AV exists 2022-05-10 23:09:09 -10:00
biblio-title-head.inc
biblio-title.inc Bug 31028: Update patron and biblio includes to remove whitespace 2023-03-06 11:23:17 -03:00
biblio-view-menu.inc Bug 32005: Cleanup indenting 2022-11-10 09:21:50 -03:00
blocked-fines.inc Bug 30487: Convert checkout and patron details page tabs to Bootstrap 2022-10-17 08:06:34 -03:00
blocking_errors.inc Bug 10921: Prevent an order from a closed basket to be edited 2020-09-18 11:49:29 +02:00
branch-selector.inc
budget_planning.inc Bug 30629: fix <span> in title of some pages 2022-06-01 16:28:28 -03:00
budgets-active-currency.inc Bug 25744: replace <b> with <strong> in the staff interface 2020-09-18 11:08:35 +02:00
budgets-admin-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
budgets-admin-toolbar.inc
calendar.inc Bug 19249: Fix date inputs on patron quick add form 2023-05-05 09:13:25 -03:00
cat-menu.inc Bug 31028: Add ability to report concerns from the staff interface 2023-03-06 11:23:17 -03:00
cat-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
cat-toolbar.inc Bug 31028: Add ability to report concerns from the staff interface 2023-03-06 11:23:17 -03:00
catalog-strings.inc Bug 9565: (follow-up) Deleting a biblio should alert/fail if there are existent subscriptions 2021-12-10 21:15:30 -10:00
cataloging-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
catalogue-search-box.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
cateditor-ui.inc Bug 32253: Load all CodeMirror lines initially when using advanced editor 2023-05-05 09:13:38 -03:00
cateditor-widgets-marc21.inc Bug 32321: Pre-populate material type for 006 in advanced cataloging editor 2023-01-27 15:14:47 -03:00
category-out-of-age-limit.inc
chart.inc
checkin-search-box.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
checkin-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
checkouts-table-footer.inc Bug 30718: Fix time display 2022-08-19 08:26:38 -03:00
checkouts-table.inc Bug 25503: Add option to export items bundle contents in checkouts table 2023-05-10 15:26:20 -03:00
circ-menu.inc Bug 33038: Add classes to patroncategorycode for easier customization 2023-04-17 09:39:44 -03:00
circ-nav.inc Bug 30624: Add loggedinlibrary permission and DB update 2023-03-13 15:22:59 -03:00
circ-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
cities-admin-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
clubs-table.inc Bug 29602: (follow-up) Surround strings with span tag 2022-04-19 21:25:51 -10:00
columns_settings.inc Bug 31994: DataTable next button does not work when using data in the HTML 2023-04-06 10:03:15 -03:00
contracts-admin-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
country-list.inc
currencies-admin-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
datatables.inc
date-format.inc
delimiter_text.inc Bug 27486: Rename system preference delimiter to CSVDelimiter 2021-01-29 09:03:45 +01:00
desks-admin-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
doc-head-close-receipt.inc
doc-head-close.inc Bug 29723: Add a "Configure table" button for KohaTable tables 2022-08-16 10:12:26 -03:00
doc-head-open.inc Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences 2022-08-09 08:44:14 -03:00
empty_line.inc
erm-search.inc Bug 33064: Add a licenses option to the searchbar 2023-05-10 15:26:21 -03:00
facets.inc Bug 17170: (follow-up) Use x instead of X 2022-10-21 11:15:24 -03:00
filter-orders.inc Bug 31991: Restore style of sidebar forms 2022-10-27 09:41:39 -03:00
form-blocks.inc
format_price.inc
greybox.inc
guided-reports-view.inc Bug 28454: Add Koha version number to database schema link in reports 2021-09-29 12:47:33 +02:00
header.inc Bug 30624: Add loggedinlibrary permission and DB update 2023-03-13 15:22:59 -03:00
holds_table.inc Bug 25856: Add suspend class to tr's of suspended holds 2023-03-17 09:59:03 -03:00
home-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
html_helpers.inc Bug 33154: Tab WRAPPER follow-up: label text must be translatable 2023-04-13 11:47:54 -03:00
i18n.inc Bug 26816: Chomp whitespace around i18n strings 2020-11-02 11:03:09 +01:00
ill-availability-table.inc
ill-list-table-strings.inc Bug 22440: New ILL requests table 2023-05-05 09:13:41 -03:00
ill-list-table.inc Bug 22440: New ILL requests table 2023-05-05 09:13:41 -03:00
ill-toolbar.inc
installer-doc-head-close.inc Bug 30011: Update links to jQueryUI assets, remove datepicker references, etc. 2022-04-08 15:49:16 +02:00
installer-intranet-bottom.inc Bug 29155: Update links to jQuery and jQuery Migrate files 2022-04-25 10:00:22 -10:00
installer-strings.inc
intranet-bottom.inc Bug 24201: (follow-up) add desk choice with library choice 2020-08-07 16:54:40 +02:00
intranetstylesheet.inc
job_progress.inc Bug 31666: (QA follow-up) Add filters 2022-10-05 16:08:16 -03:00
js-biblio-format.inc Bug 22440: New ILL requests table 2023-05-05 09:13:41 -03:00
js-date-format.inc Bug 30310: Fix date_to_rfc3339 2023-01-31 10:19:46 -03:00
js-patron-format-address.inc Bug 26967: Correctly format patron address in autocomplete 2023-04-21 10:36:26 -03:00
js-patron-format.inc Bug 33504: Update patron_to_html to deal with null 2023-05-05 09:13:20 -03:00
js-patron-get-age.inc Bug 30059: Deal with timezones 2022-03-24 14:22:10 -10:00
js_includes.inc Bug 26967: Correctly format patron address in autocomplete 2023-04-21 10:36:26 -03:00
keyboard_shortcuts.inc
labels-toolbar.inc
langmenu-staff-top.inc Bug 20168: Update of the OPAC bootstrap template to bootstrap v4 2020-09-09 14:13:03 +02:00
last-borrower.inc Bug 30952: Staff interface redesign (header) 2022-10-12 15:58:16 -03:00
letters-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
member-alt-address-style.inc Bug 30603: Fix other occurrences 2022-05-10 23:09:09 -10:00
member-alt-contact-style.inc Bug 29213: Fix typo ol in member-alt-contact-style.inc 2021-10-15 11:34:26 +02:00
member-display-address-style.inc Bug 21794: (QA follow-up) Separate city and country with a comma 2021-09-09 10:59:38 +02:00
member-display-alt-address-style.inc Bug 21794: (QA follow-up) Separate city and country with a comma 2021-09-09 10:59:38 +02:00
member-main-address-style.inc Bug 30603: Fix other occurrences 2022-05-10 23:09:09 -10:00
member-search-box.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
members-toolbar.inc Bug 31713: (follow-up) Display print option for any outstanding 2022-11-03 10:05:10 -03:00
merge-record.inc Bug 33181: Use template wrapper for tabs on record merge pages 2023-04-14 15:39:40 -03:00
messaging-preference-form.inc Bug 32492: (follow-up) Add missing HTML filters 2023-03-06 14:45:23 -03:00
modal-claims.inc Bug 33613: Use prop() to evaluate checkbox 2023-05-09 10:58:05 -03:00
noadd-warnings.inc
onboarding_messages.inc
page-numbers.inc
password_check.inc Bug 23816: Fix patron edition 2020-09-10 09:57:53 +02:00
patron-age.inc Bug 27717: Display date of birth even if the patron is under 1 2021-03-05 13:38:58 +01:00
patron-article-requests.inc Bug 32679: Use different CSS classes for titles of article requests in staff interface 2023-03-06 14:45:24 -03:00
patron-restrictions-tab.inc Bug 33574: Correct pointer for restrict_type.code 2023-04-20 15:48:33 -03:00
patron-return-claims.inc Bug 30487: Convert checkout and patron details page tabs to Bootstrap 2022-10-17 08:06:34 -03:00
patron-search-box.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
patron-search-header.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
patron-search.inc Bug 26967: Correctly format patron address in autocomplete 2023-04-21 10:36:26 -03:00
patron-title.inc Bug 33266: Fix missing space in patron title 2023-03-20 09:39:52 -03:00
patron-toolbar.inc Bug 31421: Add a limited option to template plugin 2022-10-27 09:42:57 -03:00
patron_messages.inc Bug 21699: Allow circulation messages to be editable 2023-05-05 10:18:55 -03:00
patroncards-errors.inc Bug 28576: Update the maximum size of an image. 2022-02-14 21:41:38 -10:00
patroncards-toolbar.inc
patronfields.inc Bug 32770: Restore phone 2023-02-22 15:05:24 -03:00
patrons-admin-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
permissions.inc Bug 33673: Change "global system preferences" to "system preferences" 2023-05-09 10:58:01 -03:00
popup-bottom.inc
pos-menu.inc Bug 27583: Proposed terminology changes 2021-07-26 12:46:32 +02:00
prefs-admin-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
prefs-menu.inc Bug 33634: Correct anchors in system preference submenu 2023-05-05 09:13:26 -03:00
recalls.inc Bug 30733: Simplify translatable strings 2022-06-17 10:16:34 -03:00
relatives-issues-table.inc Bug 30487: Convert checkout and patron details page tabs to Bootstrap 2022-10-17 08:06:34 -03:00
renew-search-box.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
renew_results.inc
renew_strings.inc Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines 2023-05-12 12:40:21 -03:00
reports-menu.inc Bug 31401: (QA follow-up) Remove Koha.ArePluginsEnabled, it is no longer needed 2022-09-07 13:55:37 -07:00
reports-toolbar.inc Bug 26486: Group edit buttons in reports toolbar 2022-06-27 12:32:24 -03:00
resort_form.inc
restriction-types.inc Bug 33551: (QA follow-up) Fix TT filters 2023-05-05 10:18:41 -03:00
rotating-collections-toolbar.inc
search_indexes.inc Bug 31841: Use location,wrdl when searching Shelving location 2023-04-06 09:47:22 -03:00
select2.inc Bug 25727: (follow-up) Some style updates, JS i18n 2020-08-24 11:19:03 +02:00
serials-advsearch.inc Bug 32771: Standardize structure around action fieldsets in serials 2023-03-31 12:30:37 +02:00
serials-menu.inc Bug 28719: Change somes links in the serials page to avoid them leading to nothing 2021-08-16 09:56:37 +02:00
serials-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
serials-toolbar.inc
shortcut.inc Bug 30952: Staff interface redesign (header) 2022-10-12 15:58:16 -03:00
slip-print.inc Bug 27282: fix all occurrences 2021-04-21 10:51:29 +02:00
stockrotation-toolbar.inc
sub-header.inc Bug 30952: Staff interface redesign (header) 2022-10-12 15:58:16 -03:00
subscriptions-search.inc Bug 32771: Standardize structure around action fieldsets in serials 2023-03-31 12:30:37 +02:00
subtype_limits.inc Bug 22605: (QA follow-up) Make Braille search option stick 2022-03-24 14:22:10 -10:00
subtypes_unimarc.inc
suggestions-add-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
tools-item-action.inc Bug 28290: Don't send subfields to 'as_string' if none to send 2022-09-07 13:50:21 -07:00
tools-menu.inc Bug 31417: Update and reference cat-menu.inc 2022-10-18 10:28:34 -03:00
tools-nomatch-action.inc
tools-overlay-action.inc
transaction_types.inc Bug 30733: Move all semicolons inside the translatable strings 2022-06-17 10:16:40 -03:00
transfer_reasons.inc Bug 29602: Surround strings with span tag 2022-04-19 21:25:51 -10:00
validator-strings.inc
vendor-menu.inc
virtualshelves-toolbar.inc
waiting_holds.inc Bug 32503: Use first cancellation for date ordering 2023-02-27 11:37:12 -03:00
wysiwyg-systempreferences.inc Bug 26949: Upgrade TinyMCE in the staff interface from 5.0.16 to 5.9.2 2021-10-05 10:58:13 +02:00
xslt-handler.inc Bug 29602: Surround strings with span tag 2022-04-19 21:25:51 -10:00
z3950-admin-search.inc Bug 32683: Convert header search tabs to Bootstrap 2023-03-10 12:04:08 -03:00
z3950_search.inc Bug 26291: Move translatable strings out of z3950_search.inc into z3950_search.js 2020-09-29 14:28:19 +02:00