Main Koha release repository https://koha-community.org
Find a file
Kyle Hall 0411bf0573
Bug 33216: Catch and handle RegisterRequired exceptions for SIP fee paid messages
If registers are being used in Koha, they are required. If a SIP account has no register and a fee paid message is sent, the SIP server crashes and the client never gets a response. It would be much better if Koha would response with 38 response where "payment accepted" is N, and an AF field stating that the SIP account needs to be associated with a register.

Test Plan:
1) Enable UseCashRegisters, set RequireCashRegister to "always require a
   cash register". Do *not* set a cash register for the SIP account you
   will be testing with.
2) Using the SIP cli tester, send a fee paid message for a patron owing
   fees.
3) Note the lack of a SIP response
4) Apply this patch
5) Restart the SIP server
6) Repeat step 2, you should now get a SIP response with the error
   message in it!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-04-19 09:20:48 -03:00
acqui Bug 32437: Honor overlay setting in staged batch when adding to a basket 2023-03-31 13:13:27 +02:00
admin Bug 31695: Type standard number is missing field ci_raw in field_config.yaml 2023-04-14 11:35:35 -03:00
api Bug 33066: Use KohaTable for LicensesList 2023-04-10 07:38:43 -03:00
authorities Bug 30930: (QA follow-up) Tidy code block 2023-04-06 10:03:19 -03:00
basket Bug 33160: Use hostinfo to display title information when 773$w is empty 2023-04-06 09:47:23 -03:00
bin
C4 Bug 33216: Catch and handle RegisterRequired exceptions for SIP fee paid messages 2023-04-19 09:20:48 -03:00
catalogue Bug 18829: (QA follow-up) Replace forbidden indirect syntax 2023-04-17 09:39:42 -03:00
cataloguing Bug 33375: Quote reserved keyword 'rank' in advanced editor 2023-04-14 11:35:26 -03:00
circ Bug 33345: On-site checkout checkbox does not work since issue date using flatpickr 2023-04-14 11:35:22 -03:00
clubs
course_reserves Bug 20256: Use new methods 2023-02-02 11:59:26 -03:00
debian Bug 33360: Update koha-conf.xml 2023-04-14 11:35:33 -03:00
docs 22.11.00: Update history.txt 2022-11-25 15:20:02 -03:00
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors
etc Bug 33360: Update koha-conf.xml 2023-04-14 11:35:33 -03:00
ill
installer Bug 33192: DBRev 22.12.00.020 2023-04-14 11:35:42 -03:00
Koha Bug 33238: Fix bad suggestions query (Bug 29886 follow-up) 2023-04-17 09:39:43 -03:00
koha-tmpl Bug 33483: Prevent 400 when more than 1 agreement is linked 2023-04-19 09:20:48 -03:00
labels Bug 31633: (follow-up) Group template params 2022-10-03 14:09:59 -03:00
lib/CGI/Session/Serialize
members Bug 26598: Display guarantee's fines on guarantor's details page 2023-04-06 10:03:16 -03:00
misc Bug 32334: Fix spelling 2023-04-12 11:22:04 -03:00
offline_circ
opac Bug 33192: Update all occurrences of AutoEmailPrimaryAddress 2023-04-14 11:35:39 -03:00
patron_lists
patroncards
plugins
pos Bug 30619: Add email receipt to POS 2022-09-07 15:59:34 -07:00
recalls
reports Bug 23824: Add a "Save and run" button to reports 2023-04-17 09:39:45 -03:00
reserve Bug 33198: Don't calculate pickup locations per bib unless placing multiple holds 2023-03-27 11:50:18 +02:00
reviews
rotating_collections
serials
services
skel
suggestion Bug 32531: Restore behaviour of 'include archived' filter 2023-01-05 09:22:58 -03:00
svc Bug 33408: Fetch sysprefs from svc/config/systempreferences 2023-04-13 11:47:58 -03:00
t Bug 33229: (follow-up) Adjust tests to set anonymous patron before setting patron privacy to 2 2023-04-17 09:55:48 -03:00
tags
tools Bug 33341: Address some perlcritic errors in 5.36 2023-03-28 14:50:33 +02:00
virtualshelves Bug 3150: (QA follow-up) Tidy scripts 2023-03-27 12:49:47 +02:00
xt Bug 33227: Unit tests 2023-03-20 09:39:49 -03:00
.editorconfig
.eslintrc.json
.gitignore Bug 32609: Add compiled css files to gitignore 2023-02-10 11:07:52 -03:00
.htaccess
.mailmap Bug 32582: Fix error in .mailmap 2023-01-17 09:27:15 +00:00
.perlcriticrc
.proverc.dist
.stylelintrc.json Bug 31528: (follow-up) A few additional rules 2022-10-03 08:23:15 -03:00
about.pl Bug 30403: (QA follow-up) Add new YAML syspref to about.pl 2023-04-06 11:28:19 -03:00
app.psgi
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl
cpanfile Bug 32558: (QA follow-up) Move ForkManager to required 2023-03-07 11:03:32 -03:00
cypress.json Bug 33408: Extend defaultCommandTimeout for cypress 2023-04-13 11:48:00 -03:00
fix-perl-path.PL
gulpfile.js Bug 32978: Replace node-sass with dart-sass 2023-02-22 10:03:39 -03:00
help.pl
INSTALL
Koha.pm Bug 33192: DBRev 22.12.00.020 2023-04-14 11:35:42 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 33133: Add fast cataloging to 'Cataloging' page 2023-03-27 12:50:07 +02:00
Makefile.PL Bug 32806: (follow-up) Rename main.js to erm.js 2023-02-27 11:12:01 -03:00
MANIFEST.SKIP
package.json Bug 33066: Introduce a KohaTable Vue component 2023-04-10 07:38:28 -03:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 32806: Move main-erm.ts to modules/erm.ts 2023-02-27 11:12:01 -03:00
yarn.lock Bug 33066: Introduce a KohaTable Vue component 2023-04-10 07:38:28 -03:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo