Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
53814 commits 35 branches 612 tags 1.8 GiB
Perl 45.4%
JavaScript 39.3%
HTML 7.2%
XSLT 3.9%
Vue 1.4%
Other 2.3%
Find a file
Janusz Kaczmarek 18843cabdb
Bug 36791: Koha explodes when trying to edit an authority rec. with an invalid authid 
When trying to open the authority editor with authid=<invalid_authid>
(e.g. a deleted authid) Koha explodes with a message:
Can't call method "authtypecode" on an undefined value at
/kohadevbox/koha/authorities/authorities.pl line 556

This this because authtypecode method is called on the result of
->find without verifying that it was succesful.

Test plan:
==========
1. Try to edit an auth rec. giving as a authid (in URL) a non-existing
   authid, e.g. in ktd, with standard ktd test data:
   http://your_ktd:8081/cgi-bin/koha/authorities/authorities.pl?authid=100000
   Koha should explode with the message:
   Can't call method "authtypecode" on an undefined value at
   /kohadevbox/koha/authorities/authorities.pl line 556
2. Apply the patch; restart_all.
3. Repeat p. 1.  You should get the 404 error page.

Sponsored-by: Ignatianum University in Cracow
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-05-10 14:11:46 +02:00
acqui Bug 36246: Add JS function/include for submitting forms from link data 2024-05-03 18:02:12 +02:00
admin Bug 36757: Sync concerns tables 2024-05-08 18:23:46 +02:00
api Bug 36618: Make biblio creation optional for ERM local titles 2024-05-08 20:04:07 +02:00
authorities Bug 36791: Koha explodes when trying to edit an authority rec. with an invalid authid 2024-05-10 14:11:46 +02:00
basket Bug 34478: Add 'op' to sendbasketform 2024-03-01 10:58:53 +01:00
bin
bookings Bug 35574: Bookings tab from biblio details should only require manage_bookings permission 2023-12-18 15:21:04 +01:00
C4 Bug 36750: Use the same label for Zebra 2024-05-07 17:41:19 +02:00
catalogue Bug 35558: Do not retrieve the local image if none exists 2024-04-26 18:06:07 +02:00
cataloguing Bug 36786: (Bug 31791 follow-up) Koha explodes when trying to edit a biblio with invalid biblionumber 2024-05-08 18:23:43 +02:00
circ Bug 34972: (QA follow-up) Remove some ModReserveCancelAll imports 2024-05-07 15:53:43 +02:00
clubs Bug 34478: Manual fix - add op clubs/templates-add-modify 2024-03-01 10:57:55 +01:00
course_reserves Bug 34478: Manual fix - Course reserves 2024-03-01 10:56:56 +01:00
debian Bug 36788: Update debian/control file 2024-05-06 15:04:29 +02:00
docs Update docs/contributors.yaml 2024-05-02 16:47:37 +02:00
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors Bug 36148: Improve error handling and restore programming errors 2024-03-01 11:01:06 +01:00
etc Bug 30897: (QA follow-up) Enable graceful restart by default 2024-04-11 16:53:43 +02:00
ill Bug 35106: CSRF fix 2024-04-29 18:53:09 +02:00
installer Bug 19768: DBRev 23.12.00.054 2024-05-08 20:04:10 +02:00
Koha Bug 34360: Get distinct biblionumber 2024-05-10 14:11:42 +02:00
koha-tmpl Bug 27363: Restore temporary selection of Z39.50 targets throughout multiple searches 2024-05-10 14:11:45 +02:00
labels Bug 36511: Some scripts missing a dependency following Bug 24879 2024-04-10 09:09:50 +02:00
lib Bug 35681: Use ::Bootstrap version of FromANSI 2024-05-02 16:47:39 +02:00
members Bug 32610: Add date extended patron attributes to patron module 2024-04-30 17:09:48 +02:00
misc Bug 36787: staticfines.pl add use Koha::DateUtils::output_pref 2024-05-07 17:41:20 +02:00
offline_circ Bug 34478: Changes for offline_circ 2024-03-01 10:58:34 +01:00
opac Bug 19768: Add "Title notes" tab to OpacSerialDefaultTab preference 2024-05-08 20:04:09 +02:00
patron_lists Bug 34478: Changes for patron_lists/add-modify 2024-03-01 10:57:41 +01:00
patroncards Bug 34478: (follow-up) patroncards: FIXMEs for op and missing script 2024-03-01 11:00:00 +01:00
plugins Bug 30897: Add option to disable automated restart 2024-04-11 16:53:42 +02:00
pos Bug 33478: Apply formatting to RECEIPT 2024-04-26 20:15:44 +02:00
preservation Bug 34030: Add a "print slips" action links to print in batch 2023-10-23 11:33:55 -03:00
recalls Bug 33478: Apply formatting to RECALL_REQUESTER_DET 2024-04-26 20:15:45 +02:00
reports Bug 36555: (QA follow-up) Tidy 2024-05-02 13:19:17 +02:00
reserve Bug 30579: Disentangle multi-hold and single bib forms 2024-05-07 15:53:57 +02:00
reviews Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
rotating_collections Bug 34478: Manual fix - add op - rotating_collections/addItems 2024-03-01 10:57:33 +01:00
serials Bug 32392: Fix QA issues 2024-04-29 15:19:31 +02:00
services Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
skel
suggestion Bug 34963: Restore the ability to blank fields when editing a suggestion 2024-04-19 18:06:36 +02:00
svc Bug 36700: Update svc to use CSRF-TOKEN 2024-05-01 13:40:19 +01:00
t Bug 36774: Add cypress tests 2024-05-10 14:11:43 +02:00
tags Bug 34478: Add 'op' to tags/review 2024-03-01 10:58:25 +01:00
tools Bug 36526: Remove circular dependency from Koha::Objects 2024-05-03 16:02:44 +02:00
virtualshelves Bug 34478: Correct op name for list edit confirmation 2024-03-01 11:00:09 +01:00
xt Bug 36374: flag JS files to keep tidy 2024-04-29 15:19:33 +02:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js 2024-04-22 08:57:39 +02:00
.gitignore Bug 36546: (QA follow-up) Add bundle spec to .gitignore 2024-04-30 15:55:37 -03:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap 23.11.00: Update mailmap 2023-11-30 14:58:47 -03:00
.perlcriticrc
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.prettierrc.js Bug 36400: (follow-up) remove option editorconfig from .prettierrc.js 2024-04-22 08:57:40 +02:00
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.stylelintrc.json Bug 31528: (follow-up) A few additional rules 2022-10-03 08:23:15 -03:00
about.pl Bug 32693: About script: Process only the tab being queried 2024-04-22 12:39:24 +02:00
app.psgi
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl
cpanfile Bug 25159: Add ability to specify a pre-modified version of action log data and store as diff 2024-05-02 16:47:42 +02:00
cypress.config.ts Bug 36012: Extend cypress's requestTimeout value 2024-03-22 15:07:36 +01:00
fix-perl-path.PL
gulpfile.js Bug 36730: (Bug 35428 follow-up) po files (sometimes) fail to update 2024-05-07 15:53:44 +02:00
help.pl
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 19768: DBRev 23.12.00.054 2024-05-08 20:04:10 +02:00
kohaversion.pl
LICENSE
mainpage.pl Bug 34478: Remove generate_csrf from pl 2024-03-01 10:55:56 +01:00
Makefile.PL Bug 36546: Deploy swagger_bundle.json via make 2024-04-30 14:32:10 +02:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
package.json Bug 36546: Deploy swagger_bundle.json via make 2024-04-30 14:32:10 +02:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 35919: Add record sources admin page 2024-04-26 17:06:04 +02:00
yarn.lock Bug 36546: Fix js-yaml dependency in package.json 2024-04-30 14:32:09 +02:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo