Main Koha release repository https://koha-community.org
Find a file
Fridolin Somers 3a3ffbc54b Bug 21975: Avoid unnecessary substitutions in automatic item modification by age
Automatic item modification by age cronjob is based on rules with conditions and substitutions.
When substitution value is equal to actual item value, the code should not call C4::Items::ModItem. It adds unnecessary action log and entry in zebraqueue.
With a rule than can impact all catalogue you can explode your database with action logs.

Test plan :
1) Run prove t/db_dependent/Items/AutomaticItemModificationByAge.t
2) Define a item modification by age with no condition
3) Run several times misc/cronjobs/automatic_item_modification_by_age.pl
4) Check it creates only one entry in action_logs and zebraqueue

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-04-16 13:17:33 +00:00
acqui Bug 22541: Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl 2019-04-11 11:45:24 +00:00
admin Bug 10796: Handle can_change_password on the staff interface 2019-04-12 02:32:07 +00:00
api/v1 Bug 13895: (QA follow-up) Make the class plural 2019-03-28 19:38:41 +00:00
authorities Bug 19994: Used Modern::Perl in Authorities perl scripts 2019-01-28 14:58:23 +00:00
basket Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
C4 Bug 21975: Avoid unnecessary substitutions in automatic item modification by age 2019-04-16 13:17:33 +00:00
catalogue Bug 21891: Remove non-XSLT detail view in the staff client 2019-04-12 01:41:17 +00:00
cataloguing Bug 10345: Increment copy number when adding multiple copies. 2019-03-23 09:11:38 +00:00
circ Bug 21346: Streamline logic in holds and transfers 2019-04-16 11:28:54 +00:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-03-23 09:51:36 +00:00
debian Bug 17746: (QA follow-up) Make set_password.pl generate a password if required 2019-03-28 11:58:20 +00:00
docs Bug 7143: (follow-up) Update about page for new devs (Academy) 2019-02-19 13:52:14 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 22043: (QA follow-up) Add parameter to control behavior 2019-03-15 12:10:46 +00:00
ill Bug 18589: Show ILLs as part of patron profile 2019-03-22 20:21:46 +00:00
installer Bug 22695: DBRev 18.12.00.046 2019-04-16 13:17:33 +00:00
Koha Bug 22474: Clone field config before adding fields to it 2019-04-16 13:17:32 +00:00
koha-tmpl Bug 22695: Remove non-XSLT search results view from the staff client 2019-04-16 13:17:32 +00:00
labels Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
members Bug 21013: Missing itemtype for checkut makes patron summary print explode 2019-04-10 20:09:50 +00:00
misc Bug 20937: Truncate items for print notices when user has an email 2019-04-11 11:47:59 +00:00
offline_circ Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
opac Bug 10796: Use $category->effective_change_password in the OPAC 2019-04-12 02:32:07 +00:00
OpenILS
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 22090: Add missing information to cash register CSV file 2019-04-16 13:17:32 +00:00
reserve Bug 17978: Check if hold can be placed before placing on placerequest.pl 2019-04-10 19:59:28 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 15774: (follow-up) fix rebase issues 2019-03-07 20:37:06 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-08 20:58:23 +00:00
svc Bug 22250: Clean up Mana KB integration with serials and reports 2019-04-11 11:34:14 +00:00
t Bug 21975: add Unit Test 2019-04-16 13:17:33 +00:00
tags Bug 22036: Indented code where '^I' was written rather than an indent. 2019-01-17 02:23:28 +00:00
test
tmp/modified_authorities
tools Bug 22069: (follow-up) fix patorns type for patrons 2019-04-16 13:17:32 +00:00
virtualshelves Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL
gulpfile.js Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display 2019-02-04 14:13:35 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 22695: DBRev 18.12.00.046 2019-04-16 13:17:33 +00:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-04 14:50:40 +00:00
Makefile.PL Bug 20174: Remove xml_sax.pl target from Makefile.pl 2019-02-15 18:42:48 +00:00
MANIFEST.SKIP
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo