Main Koha release repository https://koha-community.org
Find a file
Marc Véron 3b3f82de37 Bug 11929: patron modification error shows borrowernumber
If an error occurs in patron batch modification, a message similar to the following is displayed:
Can not update patron with borrowernumber 7055

It would be useful to have the cardnumber as well.

This patch adds the card number to the lists of errors.

It is not easy to trigger an error (see comments).
For testing, I tweaked the sub ModMember in C4/Members.pm to always return false.

TEST PLAN
---------
1) Log in as a superlibrarian and create a test user
2) Change the cardnumber to a number differing from the
   borrower number.
3) Home -> Tools -> Batch patron modification
4) Type in the cardnumber of that test user
5) Check the Library checkbox.
6) Click Save
   -- nice error, but it is borrower number instead of
      the card number which was entered.
7) Apply the patch
8) Repeat steps 3-6
   -- nice error, but it is now more informative.
9) run koha qa test tools.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2015-06-01 14:28:04 -03:00
acqui Bug 14172: Acq: Orders without items missing from 'spent' list 2015-05-18 10:28:17 -03:00
admin Bug 14145: Noisy warns in admin/preferences.pl 2015-05-22 09:37:24 -03:00
authorities
basket
C4 Bug 14115: Silence warnings in t/Label* 2015-06-01 14:11:15 -03:00
catalogue Bug 13773: add stock number to details and items display 2015-05-04 12:29:25 -03:00
cataloguing
circ Bug 12066: New renew page in staff client doesn't record branch in statistics 2015-06-01 10:56:53 -03:00
course_reserves
debian Bug 14203: Message for non-existent lang removal 2015-05-26 10:42:05 -03:00
docs Bug 14255: minor edits to history.txt to facilitate automatic updates to the website 2015-05-26 10:42:05 -03:00
errors
etc Bug 8992: Add 7..$3 to the Indentifier-standard index 2015-04-28 15:47:40 -03:00
install_misc Bug 14066: Removing more Readonly 2015-05-06 11:05:22 -03:00
installer Bug 12160: DBRev 3.21.00.002 2015-05-26 10:59:54 -03:00
Koha Bug 7380: Refactor the patron search box header 2015-05-19 10:10:31 -03:00
koha-tmpl Bug 11929: patron modification error shows borrowernumber 2015-06-01 14:28:04 -03:00
labels Bug 12911: batch_id for new labels batches can be asssigned to several batches 2015-05-14 11:11:03 -03:00
members Bug 11925: Check ages limits when creating/updating patrons 2015-05-20 11:19:07 -03:00
misc Bug 11603: Change the output filenames 2015-06-01 14:25:24 -03:00
offline_circ Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac
OpenILS
patron_lists
patroncards Bug 14122: Patron card: Software error when creating using borrower_number as parameter from URL 2015-05-06 10:40:00 -03:00
plugins
reports Bug 14279: Remove CGI::scrolling_list from issues_avg_stats.pl 2015-06-01 14:21:58 -03:00
reserve Bug 13687: Move hold policy check into CanItemBeReserved 2015-05-19 12:05:50 -03:00
reviews Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
rotating_collections Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Bug 13423: Remove unused serials-recieve 2015-05-14 11:48:17 -03:00
services Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
suggestion Bug 10752: Alert the librarian if the suggestion has not been added 2015-04-28 15:11:42 -03:00
svc
t Bug 14113: Silence t/Dates.t warnings and cleanup output. 2015-06-01 14:13:54 -03:00
tags
test Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
tmp/modified_authorities
tools Bug 11929: patron modification error shows borrowernumber 2015-06-01 14:28:04 -03:00
virtualshelves Bug 13986: Printing a list only prints the results of the page you are viewing 2015-05-15 16:01:33 -03:00
xt Bug 13941: [1/2] Test <body> tag with id/class attributes 2015-04-24 09:47:28 -03:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap (RM followup) .mailmap updates 2015-05-22 17:02:21 -03:00
about.pl Bug 13486: Apache version empty in about page if Apache 2.4 2015-05-22 09:33:02 -03:00
changelanguage.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
edithelp.pl
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
INSTALL
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.opensuse Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
Koha.pm Bug 12160: DBRev 3.21.00.002 2015-05-26 10:59:54 -03:00
koha_perl_deps.pl
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
LICENSE
mainpage.pl Bug 8007: Discharge - Glue 2015-04-30 12:33:53 -03:00
Makefile.PL
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/