Main Koha release repository https://koha-community.org
Find a file
Jonathan Druart 3b552ac937 Bug 28622: (bug 15758 follow-up) Remove incorrect branch selection in adv search
From
  commit df97814f30
  Bug 15758: Koha::Libraries - Remove GetBranches

+    selected_branchcode => ( C4::Context->IsSuperLibrarian ? C4::Context->userenv : '' ),

And

-        [% PROCESS options_for_libraries libraries => Branches.all() %]
+        [%# FIXME Should not we filter the libraries displayed? %]
+        [% PROCESS options_for_libraries libraries => Branches.all( selected => selected_branchcode, unfiltered => 1 ) %]

The change in the pl is wrong as it should pass C4::Context->userenv->{branch},
but prior to this commit it seems that we didn't select the logged in
library anyway.

Looks like we should remove this code but preserve the current behavior and select "All libraries".

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-07-30 09:48:54 -04:00
acqui Bug 23971: Rename pref with AcquisitionLog 2021-04-23 11:58:49 +02:00
admin Bug 28418: Show template_id of MARC modification templates 2021-07-09 07:56:50 -04:00
api Bug 28480: Add q parameters for GET /patrons 2021-07-09 09:09:31 -04:00
authorities Bug 28160: Values from 150$a aren't prefilled in z39.50 search form from an existing authority record 2021-05-10 15:52:53 +02:00
basket Bug 27268: (QA follow-up) Add Koha::Biblios to basket scripts 2021-03-09 17:20:47 +01:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
C4 Bug 28660: (bug 21325 follow-up) Fix auto self check 2021-07-23 07:44:31 -04:00
catalogue Bug 28622: (bug 15758 follow-up) Remove incorrect branch selection in adv search 2021-07-30 09:48:54 -04:00
cataloguing Bug 27739: Advanced editor should use DefaultCountryField008 preference 2021-04-16 12:28:17 +02:00
circ Bug 28581: Use 'from_email_address' where appropriate 2021-07-09 09:05:48 -04:00
clubs
course_reserves
debian Bug 27348: Fix test on ALTERNATE_INDEXER_DAEMON in koha-indexer 2021-07-02 09:36:58 -04:00
docs Bug 28476: Update info in docs/teams.yaml file 2021-07-02 09:26:43 -04:00
errors
etc Bug 21286: Add Corporate-name as phrase to zebra indexes 2021-07-02 07:15:39 -04:00
ill Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
installer Increment version for 21.05.02 release 2021-07-30 08:14:21 -04:00
Koha Bug 22801: (follow-up) Use date-of-publication directly 2021-07-30 09:39:33 -04:00
koha-tmpl Bug 28622: (bug 15758 follow-up) Remove incorrect branch selection in adv search 2021-07-30 09:48:54 -04:00
labels
lib/CGI/Session/Serialize Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-18 11:23:42 -04:00
members Bug 26760: Escape URI parameters in redirect URI to paycollect.pl 2021-07-16 08:40:17 -04:00
misc Update release notes for 21.05.02 release 2021-07-30 08:14:21 -04:00
offline_circ Bug 24083: Add support for unseen_renewals 2020-11-11 16:09:58 +01:00
opac Bug 28561: Remove DBIC warning in opac-shelves 2021-07-16 08:16:16 -04:00
patron_lists Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
patroncards Bug 23271: Replace search_limited with search_with_library_limits 2021-04-21 15:25:07 +02:00
plugins
pos Bug 28368: Add fallback language for anonymous payment receipts 2021-05-27 14:12:24 +02:00
reports Bug 28524: Escape 'rank' in cat_issues_top.pl 2021-07-09 13:44:43 -04:00
reserve Bug 28338: Default to holding branch to save clicks 2021-06-18 09:41:34 -04:00
reviews
rotating_collections
serials Bug 23243: Adjust previous patch 2021-04-21 15:25:07 +02:00
services
skel
suggestion Bug 28581: Use 'from_email_address' where appropriate 2021-07-09 09:05:48 -04:00
svc Bug 27061: Remove duplicate permission check in svc/mana/search 2021-04-30 17:07:32 +02:00
t Bug 22801: (follow-up) Use date-of-publication directly 2021-07-30 09:39:33 -04:00
tags
tmp/modified_authorities
tools Bug 28745: (bug 28158 follow-up) Restore the items table once the job is done 2021-07-30 08:14:21 -04:00
virtualshelves
xt Bug 28370: Rewrite tests 2021-05-25 09:28:18 +02:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Bug 28386: Disambiguate Tomas and Blou 2021-05-26 12:30:59 +02:00
.perlcriticrc
.scss-lint.yml
about.pl Bug 28490: Revert "Bug 26995: Remove references to relationship column" 2021-06-18 07:47:34 -04:00
app.psgi
changelanguage.pl
cpanfile Bug 28317: Use the default CGI::Session serializer 2021-05-19 14:45:32 +02:00
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Increment version for 21.05.02 release 2021-07-30 08:14:21 -04:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-18 11:23:42 -04:00
MANIFEST.SKIP
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md
README.robots
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-18 11:23:42 -04:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo