Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
19666 commits 35 branches 612 tags 1.8 GiB
Perl 45.3%
JavaScript 39.4%
HTML 7.2%
XSLT 3.9%
Vue 1.4%
Other 2.3%
Find a file
Kenza Zaki 3b56392a6f Bug 10682: remove inappropriate uses of finish() from C4::Reserves 
This patch gets rid of finish.

From the man page

finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Similar to other patches from the same author
I run prove t/db_dependent/Reserves.t without errors
don't know if more tests are needed.
No koha-qa errors

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-10-09 03:37:15 +00:00
acqui Bug 10096 - Add a Z39.50 interface for authority searching 2013-10-04 14:26:29 +00:00
admin Bug 10096 - Add a Z39.50 interface for authority searching 2013-10-04 14:26:29 +00:00
authorities Bug 10096 - Add a Z39.50 interface for authority searching 2013-10-04 14:26:29 +00:00
basket Bug 9073 - Download option from the cart should match the menu button in lists 2012-11-25 18:08:46 -05:00
C4 Bug 10682: remove inappropriate uses of finish() from C4::Reserves 2013-10-09 03:37:15 +00:00
catalogue Bug 5645: improve converting simple search to Z39.50 search 2013-10-02 14:58:54 +00:00
cataloguing Bug 10096 - (follow-up) various QA improvements 2013-10-04 14:29:18 +00:00
circ Bug 9761: Make it possible to confirm future hold requests at checkin time 2013-09-25 00:26:34 +00:00
course_reserves bug 8215: (followup) avoid spurious warning in Apache log 2013-05-21 16:01:08 -07:00
debian Bug 9611: (follow-up) add libcrypt-eksblowfish-perl to debian/control 2013-10-03 23:41:17 +00:00
docs Bug 10550: Fix database typo wthdrawn 2013-09-08 01:58:41 +00:00
errors Housekeeping in errors scripts 2010-05-12 07:29:03 -04:00
etc Bug 9252 - Add option to send patron's home branch in AF field 2013-09-08 06:07:38 +00:00
install_misc Bug 8840 - [SIGNED-OFF] Patch to solve false "All dependencies installed!" 2013-05-12 21:15:19 -04:00
installer Bug 10096: (follow-up) add LC authority Z39.50 targets to 'en' sample data 2013-10-04 14:59:29 +00:00
Koha Bug 9611: (follow-up) move new password hashing routines to separate module 2013-10-09 03:29:22 +00:00
koha-tmpl Bug 10917: allow staff to update hold pickup location without modify_holds_priority 2013-10-08 14:23:07 +00:00
labels Bug 10527: remove disused routine C4::Branch::get_branch_code_from_name 2013-07-12 20:20:20 +00:00
members Bug 9611: (follow-up) move new password hashing routines to separate module 2013-10-09 03:29:22 +00:00
misc bug 10419: (follow-up) improvements to the usage text 2013-10-03 22:13:40 +00:00
offline_circ Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly. 2013-03-21 20:35:37 -04:00
opac Bug 9611: (follow-up) move new password hashing routines to separate module 2013-10-09 03:29:22 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patroncards Bug 9924: (follow-up) ensure that correct error message is displayed 2013-09-08 19:19:50 +00:00
plugins Bug 7804 - Add Koha Plugin System - QA Followup 2 2013-03-20 14:50:19 -04:00
reports Bug 10718: fix items with no checkouts report 2013-09-08 20:04:43 +00:00
reserve Bug 10663: QA Followup: Typo in comment in renewscript 2013-08-16 01:39:16 +00:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections Bug 9605: rotating collections permissions are wrong 2013-03-30 22:11:05 -04:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials bug 10728: fix additional log noise generated by subscription-renew.pl 2013-08-19 14:10:38 +00:00
services Bug 7178: Acquisition item creation improvement 2012-03-26 11:07:23 +02:00
skel Bug 7804 - Add Koha Plugin System 2013-03-20 14:49:47 -04:00
sms Bug 2505 - Add commented use warnings where missing in the sms/ directory 2010-04-21 20:25:08 +12:00
suggestion Bug 9307: QA Followup 2013-06-19 07:19:39 -07:00
svc Bug 7813: (follow-up) improvements for deleting local cover images 2013-09-21 18:11:13 +00:00
t Bug 9611: (follow-up) move new password hashing routines to separate module 2013-10-09 03:29:22 +00:00
tags Bug 10730: Use DataTables on the tag review page 2013-09-25 16:47:59 +00:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities
tools Bug 10601: Add a counter on batch items modifications 2013-09-18 17:10:00 +00:00
virtualshelves Bug 7788: [SIGNED-OFF] Followup: GetShelf call in addbybiblio script corrected 2012-05-22 12:06:26 +02:00
xt Bug 9802 - add test case to ensure man pages have correct XML 2013-03-20 15:11:10 -04:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap 7439 Mailmap for master 2012-01-27 12:27:58 +01:00
about.pl Bug 10915: (QA followup) warn if cannot read history.txt 2013-09-20 17:25:57 +00:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl 7368 Typo in edithelp.pl warning 2013-04-18 09:47:58 -04:00
fix-perl-path.PL
help.pl Bug 10052: QA Followup 2013-05-23 08:55:12 -07:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 7440 - Remove NoZebra vestiges 2013-03-19 21:17:04 -04:00
INSTALL.opensuse Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl Bug 10096: DBRev 3.13.00.024 2013-10-04 14:37:37 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 10080 - Change system pref IndependantBranches to IndependentBranches 2013-05-22 07:58:23 -07:00
Makefile.PL Bug 10539: Followup for removing KohaTest unit tests 2013-09-05 15:06:05 +00:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 10712: Save missing config variables to install log 2013-08-13 14:14:30 +00:00

README 

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/