Main Koha release repository https://koha-community.org
Find a file
Owen Leonard 3bcde5d91f Bug 22657: Remove JavaScript from OPAC suggestion validation of required fields
This patch modifies the OPAC suggestion form so that it doesn't require
JavaScript for form validation. This change doesn't alter the behavior
of the form for users but does fit with the general goal of progressive
enhancement for the OPAC.

The patch adds "required" labels to required fields to better identify
required fields.

To test, apply the patch and make sure there are required fields
specified in the OPACSuggestionMandatoryFields system preference.

 - Log in to the OPAC and go to Your purchase suggestions -> New
   purchase suggestion.
 - Verify that the fields specified in OPACSuggestionMandatoryFields are
   highlighted and marked "required."
 - Verify that you can't submit the form without filling out these
   fields.

Signed-off-by: Bin Wen <bin.wen@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-05-15 16:58:50 +00:00
acqui Bug 4833: (QA follow-up) Add budgetname to SearchSuggestion 2019-05-15 16:46:47 +00:00
admin Bug 21411: Address QA concerns 2019-05-10 18:59:39 +00:00
api/v1 Bug 15496: (QA follow-up) Change success status on api 2019-04-26 12:06:58 +00:00
authorities Bug 19994: Used Modern::Perl in Authorities perl scripts 2019-01-28 14:58:23 +00:00
basket Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
C4 Bug 4833: (QA follow-up) Add budgetname to SearchSuggestion 2019-05-15 16:46:47 +00:00
catalogue Bug 22424: Add search by all lost statuses to item search 2019-04-30 13:39:44 +00:00
cataloguing Bug 21411: Advanced cataloging editor - rancor - Allow configuration of Keyboard 2019-05-10 18:59:39 +00:00
circ Bug 7088: Allow renew on hold items with due date 2019-05-09 14:40:49 +00:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-03-23 09:51:36 +00:00
debian Bug 22893: Embed contributors.yaml for debian packages 2019-05-14 18:16:37 +00:00
docs Bug 21662: (QA follow-up) Be consistent between history and contributors 2019-05-10 17:19:44 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 22787: Add mapping of letters "ů" and "Ů" to zebra definitions 2019-05-07 11:00:13 +00:00
ill Bug 21460: (follow-up) Fix bugs found in QA 2019-04-25 10:46:56 +00:00
installer Bug 21651: (QA follow-up) Remove remaining obsolete file from German web installer 2019-05-15 15:47:15 +00:00
Koha Bug 11853: Allow to clear the date of birth at the OPAC 2019-05-14 18:20:31 +00:00
koha-tmpl Bug 22657: Remove JavaScript from OPAC suggestion validation of required fields 2019-05-15 16:58:50 +00:00
labels Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
members Bug 21312: Show lockout on Patrons form 2019-05-10 18:01:36 +00:00
misc Bug 22875: Document verbose option in import_patrons 2019-05-15 12:10:53 +00:00
offline_circ Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
opac Bug 22657: Remove JavaScript from OPAC suggestion validation of required fields 2019-05-15 16:58:50 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 22053: ability to enable/disable some plugins 2019-05-09 18:54:44 +00:00
reports Bug 22090: Add missing information to cash register CSV file 2019-04-16 13:17:32 +00:00
reserve Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest 2019-05-10 18:57:20 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 22849: Do not share data (Mana) without agreement 2019-05-14 18:06:17 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-08 20:58:23 +00:00
svc Bug 7862: Preventing warns when creating a notice 2019-05-15 12:10:52 +00:00
t Bug 4833: (QA follow-up) Add budgetname to SearchSuggestion 2019-05-15 16:46:47 +00:00
tags Bug 22036: Indented code where '^I' was written rather than an indent. 2019-01-17 02:23:28 +00:00
tmp/modified_authorities
tools Bug 7862: Preventing warns when creating a notice 2019-05-15 12:10:52 +00:00
virtualshelves Revert "Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean" 2019-05-15 10:56:48 +00:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 22893: Do not crash if contributors.yaml does not exist 2019-05-14 18:16:37 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display 2019-02-04 14:13:35 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 22899: DBRev 18.12.00.075 2019-05-14 18:15:54 +00:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-04 14:50:40 +00:00
Makefile.PL Bug 22893: Embed contributors.yaml for debian packages 2019-05-14 18:16:37 +00:00
MANIFEST.SKIP
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo