Main Koha release repository https://koha-community.org
Find a file
Jonathan Druart 3c034dcc3a Bug 21086: Fix wrong mock of DateTime->now
prove t/db_dependent/DecreaseLoanHighHolds.t
t/db_dependent/DecreaseLoanHighHolds.t .. 1/17 Can't locate object method
 "truncate" via package "80" (perhaps you forgot to load "80"?) at /home/vagrant/kohaclone/C4/Circulation.pm line 3497.

What is happening:
We mock DateTime->now in the script to avoid the date comparaisons to fail on
slow servers (see bug 19705).

  my $now_value       = DateTime->now();
  my $mocked_datetime = Test::MockModule->new('DateTime');
  $mocked_datetime->mock( 'now', sub { return $now_value; } );

Since bug 20287, we have the following calls:
Koha::Patron->store => Koha::Patron::Category->get_expiry_date

which does:
221         return $date->add( months => $self->enrolmentperiod, end_of_month => 'limit' );

as enrolmentperiod is generated by t::lib::TestBuilder, it can be quite big, and so
the date change from one call to the others.

The failure is actually coming from the date becoming > 9999, which is not handled correctly,
on purpose, by Koha::DateUtils (infinite)

On the way this patch fixes the other occurrence, in Sitemapper.t (just in case)

Test plan:
Make sure the tests pass now.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-07-19 16:24:57 +00:00
acqui Bug 12395: (QA follow-up) Change wording for consistency and fix use CGI; 2018-07-06 14:01:50 +00:00
admin Bug 7651: Add a new permission for managing currencies and exchange rates 2018-07-18 17:45:21 +00:00
api/v1 Bug 20942: Split debit and credit lines 2018-07-18 16:49:27 +00:00
authorities Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button 2018-07-02 11:29:20 +00:00
basket Bug 16575: Irregular behaviour using window.print() followed by window.location.href 2018-07-19 16:12:56 +00:00
C4 Bug 18322: (follow-up) Use authorized value labels 2018-07-18 17:42:50 +00:00
catalogue Bug 20919: Remove unecessary search calls on the biblio detail page 2018-07-13 10:34:29 +00:00
cataloguing Bug 21053: Encode URI characters in plugin 008 2018-07-19 16:23:16 +00:00
circ Bug 20851: Add module to circ/article-request-slip.pl 2018-06-08 09:48:12 -04:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 20467: (QA follow-up) Display error if no or invalid course id is passed 2018-07-02 12:55:38 +00:00
debian Bug 20079: Display stack trace for development installations 2018-07-18 17:00:20 +00:00
docs Bug 20906: Prevent test failures due to stricter perl 2018-06-22 12:59:09 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 18322: Update xslt for NORMARC and UNIMARC 2018-07-18 17:42:49 +00:00
ill Bug 20556: Marking ILL request as complete.. 2018-04-20 11:42:00 -03:00
installer Bug 7651: DBRev 18.06.00.007 2018-07-18 19:11:27 +00:00
Koha Bug 18072: Only accept Koha::Library in parameters 2018-07-18 17:42:47 +00:00
koha-tmpl Bug 21064: Use undefined instead of undef 2018-07-19 16:24:30 +00:00
labels Bug 12020: Allow translating label-edit-batch hardcoded strings 2018-03-26 17:31:15 -03:00
members Bug 21085: Fix add/edit of patrons when HouseboundModule is set 2018-07-19 15:44:03 +00:00
misc Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files 2018-07-18 17:44:47 +00:00
offline_circ Bug 19752: offline_circ/service.pl - Return HTTP status 401 when authentication failed and add option nocookie 2018-05-03 13:26:48 -03:00
opac Bug 20287: Move ModMember to Koha::Patron 2018-07-18 15:49:50 +00:00
OpenILS
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 20010: use Modern::Perl in Patroncards perl scripts 2018-02-05 09:46:44 -03:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 20495: Remove get_saved_report 2018-07-02 12:06:54 +00:00
reserve Bug 20724: Move the ReservesNeedReturns logic to AddReserve 2018-05-16 10:53:13 -03:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections
serials Bug 20730: Move the authentication block before doing anything 2018-05-23 11:44:10 -03:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel
suggestion Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
svc Bug 20495: (follow-up) Correct search for report by name 2018-07-02 12:06:54 +00:00
t Bug 21086: Fix wrong mock of DateTime->now 2018-07-19 16:24:57 +00:00
tags Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
test
tmp/modified_authorities
tools Bug 20287: Move ModMember to Koha::Patron 2018-07-18 15:49:50 +00:00
virtualshelves Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
xt Bug 20906: Fix translatable-templates.t 2018-06-22 12:59:09 +00:00
.editorconfig
.gitignore Bug 20267: Add basic .gitignore 2018-03-26 17:31:16 -03:00
.htaccess
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
about.pl Bug 20727: (QA follow-up) Remove a few use statements again 2018-06-22 16:10:10 +00:00
changelanguage.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
edithelp.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
fix-perl-path.PL
help.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
INSTALL
install-CPAN.pl
Koha.pm Bug 7651: DBRev 18.06.00.007 2018-07-18 19:11:27 +00:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl
LICENSE
mainpage.pl Bug 20489: Remove warnings from the interface 2018-04-20 12:24:00 -03:00
Makefile.PL Bug 18342: Enable memcached by default for new installs 2018-05-03 12:47:07 -03:00
MANIFEST.SKIP
README
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
rewrite-config.PL Bug 18342: Enable memcached by default for new installs 2018-05-03 12:47:07 -03:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo