Main Koha release repository https://koha-community.org
Find a file
Kenza Zaki 4287fd9d1c Bug 10629: remove inappropriate uses of $sth->finish() in C4::Branch
Test plan :
Check if the regression tests still works
prove t/db_dependent/Branch.t
t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207.
t/db_dependent/Branch.t .. ok
All tests successful.
Files=1, Tests=36,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.12 cusr  0.00 csys =  0.16 CPU)
Result: PASS

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

From the man page

finsh()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-08-28 14:25:52 +00:00
acqui Bug 10573: (follow-up) update license and copyright statement 2013-08-17 16:06:06 +00:00
admin Bug 8887: only display desired result when doing exact syspref search 2013-08-16 16:17:41 +00:00
authorities Bug 5262: make authority plugin copy indicators to bib record 2013-08-14 17:17:22 +00:00
basket
C4 Bug 10629: remove inappropriate uses of $sth->finish() in C4::Branch 2013-08-28 14:25:52 +00:00
catalogue Bug 10404: add previous/next browsing to staff client 2013-08-09 15:07:39 +00:00
cataloguing Bug 10766: unbreak reservoir search when UseQueryParser is OFF 2013-08-25 17:16:23 +00:00
circ Bug 5652: display subtitles on patron checkout and holds summary 2013-08-06 14:30:52 +00:00
course_reserves bug 8215: (followup) avoid spurious warning in Apache log 2013-05-21 16:01:08 -07:00
debian Bug 9247 - Add two more usage examples to the manpage for koha-mysql 2013-08-28 13:43:00 +00:00
docs bug 7143: add latest batch of committers 2013-07-22 14:40:58 +00:00
errors
etc Bug 8911: make sure history.txt gets installed where history.txt can see it 2013-07-22 14:11:48 +00:00
install_misc Bug 8840 - [SIGNED-OFF] Patch to solve false "All dependencies installed!" 2013-05-12 21:15:19 -04:00
installer Bug 10593: make AuthoritiesLog default to yes 2013-08-28 13:44:57 +00:00
Koha Bug 9755: (follow-up) tweak test for tag visibility in merge hash 2013-07-23 23:11:04 +00:00
koha-tmpl Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL 2013-08-28 14:15:03 +00:00
labels Bug 10527: remove disused routine C4::Branch::get_branch_code_from_name 2013-07-12 20:20:20 +00:00
members Bug 5652: display subtitles on patron checkout and holds summary 2013-08-06 14:30:52 +00:00
misc Bug 10664 [QA Followup] - fix error in overdue_notices.pl if there is no active currency 2013-08-16 14:39:02 +00:00
offline_circ
opac Bug 9916 - Use DataTables in the OPAC 2013-08-19 14:19:02 +00:00
OpenILS
patroncards Bug 10527: remove disused routine C4::Branch::get_branch_code_from_name 2013-07-12 20:20:20 +00:00
plugins
reports Bug 3134: add ability to selelct multiple reports to delete at once 2013-08-21 14:24:33 +00:00
reserve Bug 10663: QA Followup: Typo in comment in renewscript 2013-08-16 01:39:16 +00:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections
selenium
serials bug 10728: fix additional log noise generated by subscription-renew.pl 2013-08-19 14:10:38 +00:00
services
skel
sms
suggestion Bug 9307: QA Followup 2013-06-19 07:19:39 -07:00
svc
t Bug 10508: (follow-up) remove Perl 5.14 construct 2013-08-28 14:24:34 +00:00
tags Merge remote branch 'origin/new/bug6554_reverts' 2013-05-01 11:22:30 -07:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities
tools Bug 7785: (follow-up) standardize POD 2013-08-13 16:15:30 +00:00
virtualshelves
xt
.htaccess
.mailmap
about.pl Bug 8911: make sure history.txt gets installed where history.txt can see it 2013-07-22 14:11:48 +00:00
changelanguage.pl
edithelp.pl
fix-perl-path.PL
help.pl Bug 10052: QA Followup 2013-05-23 08:55:12 -07:00
INSTALL
install-CPAN.pl
INSTALL.debian
INSTALL.fedora7
INSTALL.opensuse
INSTALL.ubuntu
INSTALL.ubuntu.12.04
INSTALL.ubuntu.lucid
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl bug 7494: DBRev 3.13.00.015' 2013-07-24 15:12:52 +00:00
LICENSE
mainpage.pl Bug 10080 - Change system pref IndependantBranches to IndependentBranches 2013-05-22 07:58:23 -07:00
Makefile.PL Bug 8911: make sure history.txt gets installed where history.txt can see it 2013-07-22 14:11:48 +00:00
MANIFEST.SKIP
README
README.robots
rewrite-config.PL Bug 10712: Save missing config variables to install log 2013-08-13 14:14:30 +00:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/