Jonathan Druart 546379cc92 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls ... C4::Circulation::GetItemIssue returned all the issue and item informations for a given issue. Moveover it also did some date manipulations. Most of the time this subroutine was called, there additional information were useless as the caller usually just needed the basic issue's infos 'from the issue table). This first patch updates the simple calls, ie. the ones that just need the issue's infomations. Test plan: The following operations should success: - transfer a book - create a rule for on-site checkouts and confirm that a patron cannot check more items out that it's defined in the rule. - Renew an issue using ILSDI - Using SIP confirm that you are able to see your issues Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>		2017-07-10 12:06:37 -03:00
..
Acquisition	Bug 8612: [QA Follow-up] Remove two newlines from template output	2017-06-05 12:02:08 -03:00
api/v1	Bug 17932: (followup) Fix /patrons endpoint	2017-02-17 15:33:00 +00:00
Auth
Authorities	Bug 9988: Refactor the cron script	2017-04-13 08:53:47 -04:00
Biblio
Circulation	Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls	2017-07-10 12:06:37 -03:00
Creators	Bug 18044: Add a test	2017-02-07 17:46:00 +00:00
data
Exporter	Bug 17196: [QA Follow-up] Wrong module in Record.t	2017-01-13 13:49:29 +00:00
Holds	Bug 12063: [QA Follow-up] Small change of two test scripts	2017-05-09 08:59:40 -04:00
Items	Bug 18761: Fix tests for AutomaticItemModificationByAge.t - clear cache	2017-06-14 14:36:11 -03:00
Koha	Bug 18361: [QA Follow-up] Resolve warning on undef values supplied	2017-06-16 11:52:18 -03:00
Labels
LDAP
Letters	Bug 17975: TT syntax for notices - Prove that HOLD_SLIP is compatible	2017-06-15 15:56:00 -03:00
Members	Bug 18664: Make IssueSlip returns if params are not valid	2017-05-28 22:26:23 -04:00
OAI	Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios	2017-06-13 16:18:59 -03:00
Patron	Bug 18420: Do not use 'S' as patron category code in other tests	2017-04-21 10:49:25 -04:00
Record
Reports	Bug 17898: Automagically convert SQL reports	2017-05-19 18:48:26 +00:00
Reserves	Bug 17560: Hold fee placement at point of checkout	2017-03-31 12:06:04 +00:00
Search	Bug 18762: Remove a warning from History.t	2017-06-14 14:36:28 -03:00
selenium	Bug 18804: Add additional information to execute successfuly selenium tests	2017-06-16 17:04:08 -03:00
Serials	Bug 18697: Final polishing	2017-06-19 15:35:51 -03:00
SIP	Bug 18104: [QA Follow-up] Add a test for customized name in AE	2017-07-06 14:52:55 -03:00
Template/Plugin	Bug 18512: Add tests	2017-05-08 08:38:11 -04:00
Utils	Bug 18094: Add tests to highlight the problem	2017-03-22 21:12:43 +00:00
www	Bug 18807: t/db_dependent/www/batch.t fails	2017-06-19 15:34:39 -03:00
XSLT_Handler
00-strict.t	Bug 18233 - t/db_dependent/00-strict.t has non-existant resetversion.pl	2017-05-08 09:22:27 -04:00
01-test_dbic.t	Bug 18226: Perltidy + license	2017-06-05 17:52:48 -03:00
Accounts.t	Bug 18448: Fix a few db_dependent tests	2017-04-21 00:09:43 +00:00
Acquisition.t	Bug 18554: Adjust a few typos including responsability	2017-05-09 21:03:22 +00:00
AdditionalField.t	Bug 13726: Make Koha::Acq::Bookseller using Koha::Object	2016-12-30 11:54:32 +00:00
Amazon.t
ArticleRequests.t	Bug 18766: Remove itemtype-related warnings from ArticleRequests.t	2017-06-09 10:50:53 -03:00
AudioAlerts.t
Auth.t	Bug 18442: Add a test	2017-05-08 08:29:13 -04:00
Auth_with_cas.t
Auth_with_ldap.t	Bug 6979 - Fix Already in a transaction error	2017-03-31 12:21:28 +00:00
AuthorisedValues.t	Bug 18448: Fix a few db_dependent tests	2017-04-21 00:09:43 +00:00
AuthoritiesMarc.t	Bug 18448: Fix a few db_dependent tests	2017-04-21 00:09:43 +00:00
BackgroundJob.t
Barcodes.t
Barcodes_ValueBuilder.t
Biblio.t	Bug 18554: Adjust a few typos including responsability	2017-05-09 21:03:22 +00:00
Bookseller.t	Bug 18448: Fix a few db_dependent tests	2017-04-21 00:09:43 +00:00
Breeding.t
Budgets.t	Bug 18420: Fix Budgets.t when no patron category 'S' exists	2017-04-21 10:49:24 -04:00
Calendar.t	Bug 12063 - Fix QA failures	2017-05-09 08:59:39 -04:00
Charset.t	Bug 18269: Move field mappings related code to Koha::FieldMapping[s]	2017-03-31 10:20:00 +00:00
check_sysprefs.t	Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t	2017-01-20 13:39:37 +00:00
Circulation.t	Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls	2017-07-10 12:06:37 -03:00
ClassSource.t
Clubs.t	Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable	2017-05-12 08:53:21 -04:00
ColumnsSettings.t
Context.t	Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 1	2017-06-05 17:52:47 -03:00
Contract.t	Bug 13726: Make Koha::Acq::Bookseller using Koha::Object	2016-12-30 11:54:32 +00:00
CourseReserves.t
db_structure.t
DecreaseLoanHighHolds.t	Bug 16387: Fix default shortened loan period time	2017-02-07 17:54:21 +00:00
default_search_class.pl
Filter_MARC_ViewPolicy.t
Fines.t
FrameworkPlugin.t
Heading_MARC21.t
Hold.t	Bug 12063 - Remove Koha::Hold::waiting_expires_on since dateexpiration is set on database	2017-05-09 08:59:39 -04:00
Holds.t	Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds	2017-07-05 13:42:52 -03:00
HoldsQueue.t	Bug 18001 - Unit Test	2017-04-21 07:16:25 -04:00
Holidays.t
ILSDI_Services.t	Bug 17836: (ILSDI) Regression test	2017-01-20 13:44:57 +00:00
ImportBatch.t	Bug 18611: [QA Follow-up] Add unit test for GetItemNumbersFromImportBatch	2017-05-28 22:23:34 -04:00
Installer.t	Bug 17234: Need to separate KEY and FOREIGN KEY checks	2017-01-12 12:43:10 +00:00
Items.t	Bug 17512: Improve handling dates in C4::Items	2017-02-14 13:57:49 +00:00
Items_DelItemCheck.t
KitchenSinkPlugin.kpz
Koha.t	Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes	2017-07-05 13:42:21 -03:00
Koha_Authority.t
Koha_Database.t
Koha_Elasticsearch.t	Bug 18434 - Followup fix tests for sorting and factes	2017-07-06 14:29:02 -03:00
Koha_Elasticsearch_Indexer.t	Bug 18434: (QA followup) Move _convert_marc_to_json tests into Indexer.t	2017-07-06 14:29:02 -03:00
Koha_Misc_Files.t
Koha_SearchEngine_Elasticsearch_Search.t	Bug 18068: ES - Fix location and (home|holding)branch facets	2017-02-17 11:34:41 +00:00
Languages.t
Letters.t	Bug 18478 - Unit tests	2017-05-28 22:17:13 -04:00
Linker_FirstMatch.t
Log.t
MarcModificationTemplates.t
Members.t	Bug 15702: Add test cases for modified code	2017-04-24 13:21:27 -04:00
MungeMarcPrice.t
NewsChannels.t	Bug 17960: Rename opac_news.new with opac_news.content	2017-02-06 17:42:12 +00:00
Overdues.t
Passwordrecovery.t	Bug 18420: Fix HoldFulfillmentPolicy.t and Passwordrecovery.t	2017-04-21 10:49:25 -04:00
PatronLists.t	Bug 17486: [QA Follow-up] Changes as to set_userenv	2017-01-13 12:32:20 +00:00
Patrons.t	Bug 17742: Use TestBuilder to create the library and patron category	2016-12-28 13:34:21 +00:00
Plugins.t	Bug 15879: Add Tests	2017-01-11 14:03:00 +00:00
QueryParser.t
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t
Reports.t
Reserves.t	Bug 18620: [QA Follow-up] Move the final rollback to the very end	2017-05-28 22:17:13 -04:00
rollingloans.t
RotatingCollections.t
Search.t	Bug 18762: Remove some warnings from Search.t	2017-06-14 14:36:28 -03:00
Serials.t	Bug 18782: Remove unused C4::Serials::getsupplierbyserialid	2017-07-05 13:41:47 -03:00
Serials_2.t	Bug 18420: Do not use 'S' as patron category code in other tests	2017-04-21 10:49:25 -04:00
Service.t
ShelfBrowser.t
Sitemapper.t	Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication	2017-06-05 17:52:48 -03:00
Stats.t
SuggestionEngine_ExplodedTerms.t
Suggestions.t	Bug 18420: Use TestBuilder to create a patron category in Suggestions.t	2017-04-21 10:49:25 -04:00
sysprefs.t
Tags.t
Templates.t	Bug 18010: Unit test for gettemplate	2017-03-23 00:36:12 +00:00
TestBuilder.t	Bug 18182: Tests all Koha::Objects-based modules	2017-04-21 00:10:50 +00:00
Upload.t	Bug 18300: [QA Follow-up] Fix return value inconsistency	2017-04-21 00:11:40 +00:00
UsageStats.t	Bug 18448: Fix a few db_dependent tests	2017-04-21 00:09:43 +00:00
Virtualshelves.t	Bug 18228: QA Followup - use gender neutral language in new tests	2017-07-05 13:35:49 -03:00
XISBN.t
XSLT_Handler.t
zebra_config.pl